From 5d3586f707d9c787fa5ab0c1b34ac46ec77ce6f7 Mon Sep 17 00:00:00 2001
From: Matt Corallo <git@bluematt.me>
Date: Mon, 6 Feb 2017 11:44:38 -0500
Subject: [PATCH] Avoid copying CNodeStats to make helgrind OK with buggy
 std::string

zcash: cherry picked from commit ae683c1b1960b32134f5a5a29504691c91f39cf3
zcash: https://github.com/bitcoin/bitcoin/pull/9708
---
 src/rpc/net.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/rpc/net.cpp b/src/rpc/net.cpp
index da2154e6a..00832acfa 100644
--- a/src/rpc/net.cpp
+++ b/src/rpc/net.cpp
@@ -68,9 +68,8 @@ static void CopyNodeStats(std::vector<CNodeStats>& vstats)
     LOCK(cs_vNodes);
     vstats.reserve(vNodes.size());
     for (CNode* pnode : vNodes) {
-        CNodeStats stats;
-        pnode->copyStats(stats);
-        vstats.push_back(stats);
+        vstats.emplace_back();
+        pnode->copyStats(vstats.back());
     }
 }