Add a test for Orchard note detection.

We can't actually test rollback via RPC tests until
wallet persistence is implemented. This implements
a rollback scenario that will should pass after wallet
persistence is implemented.

qa/pull-tester/rpc-tests.py

@@ -73,6 +73,7 @@ BASE_SCRIPTS= [
     'wallet_changeindicator.py',
     'wallet_import_export.py',
     'wallet_isfromme.py',
+    'wallet_orchard.py',
     'wallet_nullifiers.py',
     'wallet_sapling.py',
     'wallet_sendmany_any_taddr.py',

qa/rpc-tests/wallet_orchard.py

@@ -0,0 +1,145 @@
+#!/usr/bin/env python3
+# Copyright (c) 2022 The Zcash developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or https://www.opensource.org/licenses/mit-license.php .
+
+from test_framework.test_framework import BitcoinTestFramework
+from test_framework.util import (
+    NU5_BRANCH_ID,
+    assert_equal,
+    get_coinbase_address,
+    nuparams,
+    start_nodes,
+    wait_and_assert_operationid_status
+)
+
+from decimal import Decimal
+
+# Test wallet behaviour with the Orchard protocol
+class WalletOrchardTest(BitcoinTestFramework):
+    def __init__(self):
+        super().__init__()
+        self.num_nodes = 4
+
+    def setup_nodes(self):
+        return start_nodes(self.num_nodes, self.options.tmpdir, [[
+            '-experimentalfeatures',
+            '-orchardwallet',
+            nuparams(NU5_BRANCH_ID, 210),
+        ]] * self.num_nodes)
+
+    def run_test(self):
+        # Sanity-check the test harness
+        assert_equal(self.nodes[0].getblockcount(), 200)
+
+        # Get a new orchard-only unified address
+        acct1 = self.nodes[1].z_getnewaccount()['account']
+        addrRes1 = self.nodes[1].z_getaddressforaccount(acct1, ['orchard'])
+        assert_equal(acct1, addrRes1['account'])
+        assert_equal(addrRes1['pools'], ['orchard'])
+        ua1 = addrRes1['unifiedaddress']
+
+        # Verify that we have only an Orchard component
+        receiver_types = self.nodes[0].z_listunifiedreceivers(ua1)
+        assert_equal(set(['orchard']), set(receiver_types))
+
+        # Verify balance
+        assert_equal({'pools': {}, 'minimum_confirmations': 1}, self.nodes[1].z_getbalanceforaccount(acct1))
+
+        # Send some sapling funds to node 2 for later spending after we split the network
+        acct2 = self.nodes[2].z_getnewaccount()['account']
+        addrRes2 = self.nodes[2].z_getaddressforaccount(acct2, ['sapling', 'orchard'])
+        assert_equal(acct2, addrRes2['account'])
+        ua2 = addrRes2['unifiedaddress']
+        saplingAddr2 = self.nodes[2].z_listunifiedreceivers(ua2)['sapling']
+
+        recipients = [{"address": saplingAddr2, "amount": Decimal('10')}]
+        myopid = self.nodes[0].z_sendmany(get_coinbase_address(self.nodes[0]), recipients, 1, 0)
+        wait_and_assert_operationid_status(self.nodes[0], myopid)
+
+        # Mine the tx & activate Orchard
+        self.sync_all()
+        self.nodes[0].generate(10)
+        self.sync_all()
+
+        # Check the value on saplingAddr2
+        assert_equal(
+                {'pools': {'sapling': {'valueZat': Decimal('1000000000')}}, 'minimum_confirmations': 1}, 
+                self.nodes[2].z_getbalanceforaccount(acct2))
+
+        # Node 0 shields some funds
+        # t-coinbase -> Orchard
+        recipients = [{"address": ua1, "amount": Decimal('10')}]
+        myopid = self.nodes[0].z_sendmany(get_coinbase_address(self.nodes[0]), recipients, 1, 0)
+        wait_and_assert_operationid_status(self.nodes[0], myopid)
+
+        self.sync_all()
+        self.nodes[0].generate(1)
+        self.sync_all()
+
+        assert_equal(
+                {'pools': {'orchard': {'valueZat': Decimal('1000000000')}}, 'minimum_confirmations': 1}, 
+                self.nodes[1].z_getbalanceforaccount(acct1))
+
+        # Split the network
+        # TODO: Enable after wallet persistence.
+        # self.split_network()
+
+        # Send another tx to ua1
+        recipients = [{"address": ua1, "amount": Decimal('10')}]
+        myopid = self.nodes[0].z_sendmany(get_coinbase_address(self.nodes[0]), recipients, 1, 0)
+        wait_and_assert_operationid_status(self.nodes[0], myopid)
+
+        # Mine the tx & generate a majority chain on the 0/1 side of the split
+        self.sync_all()
+        self.nodes[0].generate(10)
+        self.sync_all()
+
+        assert_equal(
+                {'pools': {'orchard': {'valueZat': Decimal('2000000000')}}, 'minimum_confirmations': 1}, 
+                self.nodes[1].z_getbalanceforaccount(acct1))
+
+        # On the other side of the split, send some funds to node 3
+        acct3 = self.nodes[3].z_getnewaccount()['account']
+        addrRes3 = self.nodes[3].z_getaddressforaccount(acct3, ['sapling', 'orchard'])
+        assert_equal(acct3, addrRes3['account'])
+        ua3 = addrRes3['unifiedaddress']
+
+        recipients = [{"address": ua3, "amount": Decimal('1')}]
+        myopid = self.nodes[2].z_sendmany(ua2, recipients, 1, 0, True)
+        wait_and_assert_operationid_status(self.nodes[2], myopid)
+
+        self.sync_all()
+        self.nodes[2].generate(1)
+        self.sync_all()
+
+        assert_equal(
+                {'pools': {'sapling': {'valueZat': Decimal('900000000')}}, 'minimum_confirmations': 1}, 
+                self.nodes[2].z_getbalanceforaccount(acct2))
+
+        assert_equal(
+                {'pools': {'orchard': {'valueZat': Decimal('100000000')}}, 'minimum_confirmations': 1}, 
+                self.nodes[3].z_getbalanceforaccount(acct3))
+
+        # TODO: enable after wallet persistence
+        # # Rejoin the network. 
+        # self.join_network()
+
+        # split 0/1's chain should have won, so their wallet balance should be consistent
+        assert_equal(
+                {'pools': {'orchard': {'valueZat': Decimal('2000000000')}}, 'minimum_confirmations': 1}, 
+                self.nodes[1].z_getbalanceforaccount(acct1))
+
+        # TODO: enable after wallet persistence
+        # # split 2/3's chain should have been rolled back, so their txn should have been
+        # # un-mined
+        # assert_equal(
+        #         {'pools': {'sapling': {'valueZat': Decimal('1000000000')}}, 'minimum_confirmations': 1}, 
+        #         self.nodes[2].z_getbalanceforaccount(acct2))
+
+        # assert_equal(
+        #         {'pools': {}, 'minimum_confirmations': 1}, 
+        #         self.nodes[3].z_getbalanceforaccount(acct3))
+
+if __name__ == '__main__':
+    WalletOrchardTest().main()