zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
Kris Nuttycombe 2022-04-26 11:19:17 -06:00 committed by Kris Nuttycombe
parent 91ef609c1b
commit 6b80f3ba1f
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
doc/release-process.md
View File

@ -65,7 +65,7 @@ progress bar displayed during the build process.
## Release process ## Release process
Identify the commit from which the release will be made. This is frequently the current Identify the commit from which the release will be made. This could be the current
`HEAD` of `master`, but it's also often useful to instead use a release stabilization `HEAD` of `master`, but it's also often useful to instead use a release stabilization
branch based upon a previous release candidate when producing a release, so that branch based upon a previous release candidate when producing a release, so that
development can proceed unblocked on the `master` branch during the release candidate development can proceed unblocked on the `master` branch during the release candidate
@ -160,20 +160,16 @@ Notify the Zcash DevOps engineer/sysadmin that the release has been tagged. They
some variables in the company's automation code and then run an Ansible playbook, which: some variables in the company's automation code and then run an Ansible playbook, which:
* builds Zcash based on the specified branch * builds Zcash based on the specified branch
* deploys it as a public service (e.g. betatestnet.z.cash, mainnet.z.cash) * deploys it as a public service (e.g. testnet.z.cash, mainnet.z.cash)
* often the same server can be re-used, and the role idempotently handles upgrades, but if * often the same server can be re-used, and the role idempotently handles upgrades, but if
not then they also need to update DNS records not then they also need to update DNS records
* possible manual steps: blowing away the `testnet3` dir, deleting old parameters, * possible manual steps: blowing away the `testnet3` dir, deleting old parameters,
restarting DNS seeder restarting DNS seeder.
Then, verify that nodes can connect to the testnet server, and update the guide on the Verify that nodes can connect to the mainnet and testnet servers.
wiki to ensure the correct hostname is listed in the recommended zcash.conf.
### Update the 1.0 User Guide Update the [Zcashd Full Node and CLI](https://zcash.readthedocs.io/en/latest/rtd_pages/zcashd.html)
documentation on ReadTheDocs to give the new version number.
This also means updating [the translations](https://github.com/zcash/zcash-docs).
Coordinate with the translation team for now. Suggestions for improving this
part of the process should be added to #2596.
### Publish the release announcement (blog, github, zcash-dev, slack) ### Publish the release announcement (blog, github, zcash-dev, slack)

2
zcutil/make-release.py
View File

@ -137,7 +137,7 @@ def verify_dependency_updates():
try: try:
sh_log('./qa/zcash/updatecheck.py') sh_log('./qa/zcash/updatecheck.py')
except SystemExit: except SystemExit:
raise SystemExit("Dependency update check failed. Either some updates not been correctly postponed, or the .updatecheck-token file is missing.") raise SystemExit("Dependency update check failed. Either some updates have not been correctly postponed, or the .updatecheck-token file is missing.")
@phase('Checking tags.') @phase('Checking tags.')
def verify_tags(revision, releaseprev, releasefrom): def verify_tags(revision, releaseprev, releasefrom):