From a510b4752d1c380d6a446e876491d5e249a76724 Mon Sep 17 00:00:00 2001 From: Simon Date: Fri, 16 Mar 2018 11:45:45 -0700 Subject: [PATCH 1/2] Enable mempool logging in tx expiry QA test. --- qa/rpc-tests/mempool_tx_expiry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa/rpc-tests/mempool_tx_expiry.py b/qa/rpc-tests/mempool_tx_expiry.py index d0f8073a4..9edf156d2 100755 --- a/qa/rpc-tests/mempool_tx_expiry.py +++ b/qa/rpc-tests/mempool_tx_expiry.py @@ -17,7 +17,7 @@ from decimal import Decimal class MempoolTxExpiryTest(BitcoinTestFramework): def setup_nodes(self): - return start_nodes(4, self.options.tmpdir, [["-nuparams=5ba81b19:205", "-txexpirydelta=4"]] * 4) + return start_nodes(4, self.options.tmpdir, [["-nuparams=5ba81b19:205", "-txexpirydelta=4", "-debug=mempool"]] * 4) # Test before, at, and after expiry block # TODO: Test case of dependent txs in reorgs From eb138626676880602e262291770f70f8cdc770ce Mon Sep 17 00:00:00 2001 From: Simon Date: Fri, 16 Mar 2018 11:46:39 -0700 Subject: [PATCH 2/2] Closes #3084. Log txid when removing expired txs from mempool. --- src/txmempool.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/txmempool.cpp b/src/txmempool.cpp index acb671ec2..650239e89 100644 --- a/src/txmempool.cpp +++ b/src/txmempool.cpp @@ -271,6 +271,7 @@ void CTxMemPool::removeExpired(unsigned int nBlockHeight) for (const CTransaction& tx : transactionsToRemove) { list removed; remove(tx, removed, true); + LogPrint("mempool", "Removing expired txid: %s\n", tx.GetHash().ToString()); } }