From 83e018b160943c6bab53122077995d1275c91107 Mon Sep 17 00:00:00 2001 From: Sean Bowe Date: Tue, 31 May 2016 21:07:20 -0600 Subject: [PATCH] Remove redundant constraints. --- src/zcash/circuit/commitment.tcc | 4 ---- src/zcash/circuit/note.tcc | 9 --------- 2 files changed, 13 deletions(-) diff --git a/src/zcash/circuit/commitment.tcc b/src/zcash/circuit/commitment.tcc index 769749a68..d1b0b10fa 100644 --- a/src/zcash/circuit/commitment.tcc +++ b/src/zcash/circuit/commitment.tcc @@ -89,10 +89,6 @@ public: } void generate_r1cs_constraints() { - // TODO: This may not be necessary if SHA256 constrains - // its output digests to be boolean anyway. - intermediate_hash->generate_r1cs_constraints(); - hasher1->generate_r1cs_constraints(); hasher2->generate_r1cs_constraints(); } diff --git a/src/zcash/circuit/note.tcc b/src/zcash/circuit/note.tcc index 87912b348..f472cb151 100644 --- a/src/zcash/circuit/note.tcc +++ b/src/zcash/circuit/note.tcc @@ -96,11 +96,6 @@ public: a_sk->generate_r1cs_constraints(); rho->generate_r1cs_constraints(); - // TODO: These constraints may not be necessary if SHA256 - // already boolean constrains its outputs. - a_pk->generate_r1cs_constraints(); - commitment->generate_r1cs_constraints(); - spend_authority->generate_r1cs_constraints(); expose_nullifiers->generate_r1cs_constraints(); @@ -222,10 +217,6 @@ public: a_pk->generate_r1cs_constraints(); - // TODO: This constraint may not be necessary if SHA256 - // already boolean constrains its outputs. - rho->generate_r1cs_constraints(); - prevent_faerie_gold->generate_r1cs_constraints(); commit_to_outputs->generate_r1cs_constraints();