From 9161071b0234310e33c5662031b6db956b17978c Mon Sep 17 00:00:00 2001 From: Daira Hopwood Date: Fri, 10 Jul 2020 01:55:05 +0100 Subject: [PATCH] Use ValueFromAmount instead of double arithmetic, and improve variable names. Signed-off-by: Daira Hopwood --- src/rpc/mining.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp index 51bf83a41..d9a73b785 100644 --- a/src/rpc/mining.cpp +++ b/src/rpc/mining.cpp @@ -902,11 +902,11 @@ UniValue getblocksubsidy(const UniValue& params, bool fHelp) UniValue result(UniValue::VOBJ); if (canopyActive) { UniValue fundingstreams(UniValue::VOBJ); - auto elems = Consensus::GetActiveFundingStreams(nHeight, consensus); - for (auto elem : elems) { - CAmount value = elem.Value(nBlockSubsidy); - fundingstreams.pushKV(elem.recipient, (double) value / COIN); - nMinerReward -= value; + auto fsinfos = Consensus::GetActiveFundingStreams(nHeight, consensus); + for (auto fsinfo : fsinfos) { + CAmount nStreamAmount = fsinfo.Value(nBlockSubsidy); + fundingstreams.pushKV(fsinfo.recipient, ValueFromAmount(nStreamAmount)); + nMinerReward -= nStreamAmount; } result.pushKV("fundingstreams", fundingstreams); } else if (nHeight > 0 && nHeight <= consensus.GetLastFoundersRewardBlockHeight(nHeight)) {