[rpc] Remove estimatepriority.

The RPC call was already deprecated.

(cherry picked from commit bitcoin/bitcoin@12839cdd56)

Zcash: we do not have `estimatesmartpriority`.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>

doc/release-notes.md

@@ -29,7 +29,7 @@ RPC Changes
   is unable to construct the transaction without selecting funds from the transparent 
   pool, so the impact of this change is that for such transactions, the user must specify
   `AllowFullyTransparent`.
-- The `estimatepriority` RPC call now always returns -1.
+- The `estimatepriority` RPC call has been removed.
 
 Changes to Transaction Fee Selection
 ------------------------------------
@@ -43,8 +43,8 @@ Removal of Priority Estimation
 ------------------------------
 
 - Estimation of "priority" needed for a transaction to be included within a target
-  number of blocks has been removed. The `estimatepriority` RPC call now always
-  returns -1. The format for `fee_estimates.dat` has also changed to no longer save
+  number of blocks, and the associated `estimatepriority` RPC call, have been
+  removed. The format for `fee_estimates.dat` has also changed to no longer save
   these priority estimates. It will automatically be converted to the new format
   which is not readable by prior versions of the software.
 

src/rpc/client.cpp

@@ -58,7 +58,6 @@ static const CRPCConvertTable rpcCvtTable =
     //     preserve that here.
     { "submitblock",                 {{s}, {s}} },
     { "estimatefee",                 {{o}, {}} },
-    { "estimatepriority",            {{o}, {}} },
     { "getblocksubsidy",             {{o}, {}} },
     // misc
     { "getinfo",                     {{}, {}} },

src/rpc/mining.cpp

@@ -940,33 +940,6 @@ UniValue estimatefee(const UniValue& params, bool fHelp)
     return ValueFromAmount(feeRate.GetFeePerK());
 }
 
-UniValue estimatepriority(const UniValue& params, bool fHelp)
-{
-    if (fHelp || params.size() != 1)
-        throw runtime_error(
-            "estimatepriority nblocks\n"
-            "\nDEPRECATED. Estimates the approximate priority a zero-fee transaction needs to begin\n"
-            "confirmation within nblocks blocks.\n"
-            "\nArguments:\n"
-            "1. nblocks     (numeric)\n"
-            "\nResult:\n"
-            "n :    (numeric) estimated priority\n"
-            "\n"
-            "-1.0 is returned if not enough transactions and\n"
-            "blocks have been observed to make an estimate.\n"
-            "\nExample:\n"
-            + HelpExampleCli("estimatepriority", "6")
-            );
-
-    RPCTypeCheck(params, boost::assign::list_of(UniValue::VNUM));
-
-    int nBlocks = params[0].get_int();
-    if (nBlocks < 1)
-        nBlocks = 1;
-
-    return mempool.estimatePriority(nBlocks);
-}
-
 UniValue getblocksubsidy(const UniValue& params, bool fHelp)
 {
     if (fHelp || params.size() > 1)
@@ -1073,7 +1046,6 @@ static const CRPCCommand commands[] =
 #endif
 
     { "util",               "estimatefee",            &estimatefee,            true  },
-    { "util",               "estimatepriority",       &estimatepriority,       true  },
 };
 
 void RegisterMiningRPCCommands(CRPCTable &tableRPC)