zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #5761 from ebfull/duplicate-orchard-nullifier 

Check that duplicate Orchard nullifiers within transactions are rejected
This commit is contained in:
Kris Nuttycombe 2022-03-28 21:27:57 -06:00 committed by GitHub
parent a63a4601ea 0a59f8c789
commit a04bf958ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gtest/data/tx-orchard-duplicate-nullifiers.h Normal file
View File

File diff suppressed because one or more lines are too long

23
src/gtest/test_transaction_builder.cpp
View File

@ -201,6 +201,29 @@ TEST(TransactionBuilder, SproutToSproutAndSapling) {
RegtestDeactivateSapling();
}
TEST(TransactionBuilder, DuplicateOrchardNullifier)
{
#include "data/tx-orchard-duplicate-nullifiers.h"
RegtestActivateNU5();
CDataStream ssin(
ParseHex(txdataOrchardDuplicateNullifiersTestVector),
SER_NETWORK,
PROTOCOL_VERSION
);
CTransaction tx;
ssin >> tx;
CValidationState state;
EXPECT_FALSE(CheckTransactionWithoutProofVerification(tx, state));
EXPECT_EQ(state.GetRejectReason(), "bad-orchard-nullifiers-duplicate");
// Revert to default
RegtestDeactivateNU5();
}
TEST(TransactionBuilder, TransparentToOrchard)
{
auto consensusParams = RegtestActivateNU5();