From bf450b26072568fa4387225edd98b8a2f44b2ccd Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Wed, 14 Oct 2020 21:52:32 +0100 Subject: [PATCH] qa: Disable FORTIFY_SOURCE checks FORTIFY_SOURCE does mostly nothing for Clang before 10, which we don't pin yet (and won't before we next upgrade Rust). --- qa/zcash/full_test_suite.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/qa/zcash/full_test_suite.py b/qa/zcash/full_test_suite.py index 621197654..3fe2df08a 100755 --- a/qa/zcash/full_test_suite.py +++ b/qa/zcash/full_test_suite.py @@ -78,11 +78,13 @@ def check_security_hardening(): # NOTE: checksec.sh does not reliably determine whether FORTIFY_SOURCE # is enabled for the entire binary. See issue #915. - ret &= test_fortify_source('src/zcashd') - ret &= test_fortify_source('src/zcash-cli') - ret &= test_fortify_source('src/zcash-gtest') - ret &= test_fortify_source('src/zcash-tx') - ret &= test_fortify_source('src/test/test_bitcoin') + # FORTIFY_SOURCE does mostly nothing for Clang before 10, which we don't + # pin yet, so we disable these tests. + # ret &= test_fortify_source('src/zcashd') + # ret &= test_fortify_source('src/zcash-cli') + # ret &= test_fortify_source('src/zcash-gtest') + # ret &= test_fortify_source('src/zcash-tx') + # ret &= test_fortify_source('src/test/test_bitcoin') return ret