From c3b3e071604ed0c2d5e6891d17fd901e10483032 Mon Sep 17 00:00:00 2001 From: Sean Bowe Date: Fri, 3 Jul 2020 09:37:34 -0600 Subject: [PATCH] Change LIBSODIUM_ERROR to -1. We only relied on success being 0 and our code was otherwise agnostic to the actual return code in the event of failed signature verification, but this change keeps the API consistent. --- src/gtest/test_consensus.cpp | 2 +- src/rust/src/rustzcash.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gtest/test_consensus.cpp b/src/gtest/test_consensus.cpp index 68624f50d..5f9780f55 100644 --- a/src/gtest/test_consensus.cpp +++ b/src/gtest/test_consensus.cpp @@ -48,7 +48,7 @@ void ZIP215Check( } if (!valid_zip215) { - expected_zip215 = 1; + expected_zip215 = -1; } EXPECT_EQ( diff --git a/src/rust/src/rustzcash.rs b/src/rust/src/rustzcash.rs index 0c57e7721..42933a983 100644 --- a/src/rust/src/rustzcash.rs +++ b/src/rust/src/rustzcash.rs @@ -1345,7 +1345,7 @@ pub extern "system" fn librustzcash_mmr_hash_node( // mimic the `crypto_sign_verify_detached` API in libsodium, but uses // the ed25519-zebra crate internally instead. const LIBSODIUM_OK: isize = 0; -const LIBSODIUM_ERROR: isize = 1; +const LIBSODIUM_ERROR: isize = -1; #[no_mangle] pub extern "system" fn librustzcash_zebra_crypto_sign_verify_detached(