Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
parent
05ecc47197
commit
d02a863c28
|
@ -84,7 +84,8 @@ void CTransaction::UpdateHash() const
|
||||||
*const_cast<uint256*>(&hash) = SerializeHash(*this);
|
*const_cast<uint256*>(&hash) = SerializeHash(*this);
|
||||||
}
|
}
|
||||||
|
|
||||||
CTransaction::CTransaction() : nVersion(CTransaction::SPROUT_MIN_CURRENT_VERSION), fOverwintered(false), nVersionGroupId(0), nExpiryHeight(0),
|
CTransaction::CTransaction() : nVersion(CTransaction::SPROUT_MIN_CURRENT_VERSION),
|
||||||
|
fOverwintered(false), nVersionGroupId(0), nExpiryHeight(0),
|
||||||
vin(), vout(), nLockTime(0),
|
vin(), vout(), nLockTime(0),
|
||||||
valueBalance(0), vShieldedSpend(), vShieldedOutput(),
|
valueBalance(0), vShieldedSpend(), vShieldedOutput(),
|
||||||
vJoinSplit(), joinSplitPubKey(), joinSplitSig(),
|
vJoinSplit(), joinSplitPubKey(), joinSplitSig(),
|
||||||
|
@ -112,7 +113,8 @@ CTransaction::CTransaction(
|
||||||
assert(evilDeveloperFlag);
|
assert(evilDeveloperFlag);
|
||||||
}
|
}
|
||||||
|
|
||||||
CTransaction::CTransaction(CMutableTransaction &&tx) : nVersion(tx.nVersion), fOverwintered(tx.fOverwintered), nVersionGroupId(tx.nVersionGroupId),
|
CTransaction::CTransaction(CMutableTransaction &&tx) : nVersion(tx.nVersion),
|
||||||
|
fOverwintered(tx.fOverwintered), nVersionGroupId(tx.nVersionGroupId),
|
||||||
vin(std::move(tx.vin)), vout(std::move(tx.vout)),
|
vin(std::move(tx.vin)), vout(std::move(tx.vout)),
|
||||||
nLockTime(tx.nLockTime), nExpiryHeight(tx.nExpiryHeight),
|
nLockTime(tx.nLockTime), nExpiryHeight(tx.nExpiryHeight),
|
||||||
valueBalance(tx.valueBalance),
|
valueBalance(tx.valueBalance),
|
||||||
|
|
Loading…
Reference in New Issue