zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix test_wallet_zkeys failures by increasing diversifier search offset 

1 chance in 2^-128 is unobservable, whereas 1 chance in 1024 happens
often.
This commit is contained in:
sasha 2022-03-31 11:12:57 -07:00
parent 9befdb2c45
commit d711a7c529
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/wallet/gtest/test_wallet_zkeys.cpp
View File

@ -67,9 +67,9 @@ TEST(WalletZkeysTest, StoreAndLoadSaplingZkeys) {
EXPECT_EQ(1, addrs.count(address));
// Find a diversified address that does not use the same diversifier as the default address.
// By starting our search at `10` we ensure there's no more than a 2^-10 chance that we
// By starting our search at `128` we ensure there's no more than a 2^-128 chance that we
// collide with the default diversifier.
libzcash::diversifier_index_t j(10);
libzcash::diversifier_index_t j(128);
auto dpa = sk.ToXFVK().FindAddress(j).first;
// add the default address
@ -461,11 +461,12 @@ TEST(WalletZkeysTest, WriteCryptedSaplingZkeyDirectToDb) {
wallet.GetSaplingPaymentAddresses(addrs);
ASSERT_EQ(1, addrs.size());
// Generate a diversified address different to the default
// If we can't get an early diversified address, we are very unlucky
// Find a diversified address that does not use the same diversifier as the default address.
// By starting our search at `128` we ensure there's no more than a 2^-128 chance that we
// collide with the default diversifier.
libzcash::SaplingExtendedSpendingKey extsk;
EXPECT_TRUE(wallet.GetSaplingExtendedSpendingKey(address, extsk));
libzcash::diversifier_index_t j(10);
libzcash::diversifier_index_t j(128);
auto dpa = extsk.ToXFVK().FindAddress(j).first;
// Add diversified address to the wallet