diff --git a/src/Makefile.gtest.include b/src/Makefile.gtest.include index d3f28d159..99df48515 100644 --- a/src/Makefile.gtest.include +++ b/src/Makefile.gtest.include @@ -9,6 +9,8 @@ noinst_PROGRAMS += zcash-gtest # test_checktransaction.cpp MUST be before # any test that calls SelectParams(). zcash_gtest_SOURCES = \ + test/testutil.cpp \ + test/testutil.h \ gtest/main.cpp \ gtest/utils.cpp \ gtest/utils.h \ diff --git a/src/Makefile.test.include b/src/Makefile.test.include index 3db8cbf12..91b13cfde 100644 --- a/src/Makefile.test.include +++ b/src/Makefile.test.include @@ -102,6 +102,8 @@ BITCOIN_TESTS =\ test/test_random.h \ test/test_util.cpp \ test/test_util.h \ + test/testutil.cpp \ + test/testutil.h \ test/torcontrol_tests.cpp \ test/transaction_tests.cpp \ test/txvalidationcache_tests.cpp \ diff --git a/src/gtest/test_deprecation.cpp b/src/gtest/test_deprecation.cpp index badd29956..74c0034da 100644 --- a/src/gtest/test_deprecation.cpp +++ b/src/gtest/test_deprecation.cpp @@ -9,6 +9,8 @@ #include "util.h" #include "utilstrencodings.h" +#include "test/testutil.h" + #include #include diff --git a/src/test/alert_tests.cpp b/src/test/alert_tests.cpp index f215eccd0..e28591465 100644 --- a/src/test/alert_tests.cpp +++ b/src/test/alert_tests.cpp @@ -17,11 +17,11 @@ #include "rpc/server.h" #include "serialize.h" #include "streams.h" -#include "util.h" #include "utilstrencodings.h" #include "utiltest.h" #include "warnings.h" +#include "test/testutil.h" #include "test/test_bitcoin.h" #include diff --git a/src/test/test_bitcoin.cpp b/src/test/test_bitcoin.cpp index 362b6e035..c7db48b0b 100644 --- a/src/test/test_bitcoin.cpp +++ b/src/test/test_bitcoin.cpp @@ -25,6 +25,8 @@ #include "rpc/server.h" #include "rpc/register.h" +#include "test/testutil.h" + #include #include #include diff --git a/src/test/testutil.cpp b/src/test/testutil.cpp index de01228f0..304cffb79 100644 --- a/src/test/testutil.cpp +++ b/src/test/testutil.cpp @@ -1,3 +1,33 @@ // Copyright (c) 2009-2016 The Bitcoin Core developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. + +#include "testutil.h" + +#ifdef WIN32 +#include +#endif + +#include + +boost::filesystem::path GetTempPath() { +#if BOOST_FILESYSTEM_VERSION == 3 + return boost::filesystem::temp_directory_path(); +#else + // TODO: remove when we don't support filesystem v2 anymore + boost::filesystem::path path; +#ifdef WIN32 + char pszPath[MAX_PATH] = ""; + + if (GetTempPathA(MAX_PATH, pszPath)) + path = boost::filesystem::path(pszPath); +#else + path = boost::filesystem::path("/tmp"); +#endif + if (path.empty() || !boost::filesystem::is_directory(path)) { + LogPrintf("GetTempPath(): failed to find temp path\n"); + return boost::filesystem::path(""); + } + return path; +#endif +} diff --git a/src/test/testutil.h b/src/test/testutil.h index 2e83115e5..5875dc50e 100644 --- a/src/test/testutil.h +++ b/src/test/testutil.h @@ -8,4 +8,8 @@ #ifndef BITCOIN_TEST_TESTUTIL_H #define BITCOIN_TEST_TESTUTIL_H +#include + +boost::filesystem::path GetTempPath(); + #endif // BITCOIN_TEST_TESTUTIL_H diff --git a/src/util.cpp b/src/util.cpp index 8c6f54aae..74df35a65 100644 --- a/src/util.cpp +++ b/src/util.cpp @@ -605,28 +605,6 @@ boost::filesystem::path GetSpecialFolderPath(int nFolder, bool fCreate) } #endif -boost::filesystem::path GetTempPath() { -#if BOOST_FILESYSTEM_VERSION == 3 - return boost::filesystem::temp_directory_path(); -#else - // TODO: remove when we don't support filesystem v2 anymore - boost::filesystem::path path; -#ifdef WIN32 - char pszPath[MAX_PATH] = ""; - - if (GetTempPathA(MAX_PATH, pszPath)) - path = boost::filesystem::path(pszPath); -#else - path = boost::filesystem::path("/tmp"); -#endif - if (path.empty() || !boost::filesystem::is_directory(path)) { - LogPrintf("GetTempPath(): failed to find temp path\n"); - return boost::filesystem::path(""); - } - return path; -#endif -} - void runCommand(const std::string& strCommand) { int nErr = ::system(strCommand.c_str()); diff --git a/src/util.h b/src/util.h index 77b9a5142..dbb3e6d1c 100644 --- a/src/util.h +++ b/src/util.h @@ -95,7 +95,6 @@ void ReadConfigFile(const std::string& confPath, std::map