Update comments
This commit is contained in:
parent
1a62587e9a
commit
ddea44a27e
|
@ -119,7 +119,7 @@ class WalletNullifiersTest (BitcoinTestFramework):
|
||||||
# Parallel encrypted wallet can't cache nullifiers for received notes,
|
# Parallel encrypted wallet can't cache nullifiers for received notes,
|
||||||
# and therefore can't detect spends. So it sees a balance corresponding
|
# and therefore can't detect spends. So it sees a balance corresponding
|
||||||
# to the sum of both notes it received (one as change).
|
# to the sum of both notes it received (one as change).
|
||||||
# TODO: Devise a way to avoid this issue (#)
|
# TODO: Devise a way to avoid this issue (#1528)
|
||||||
assert_equal(self.nodes[1].z_getbalance(myzaddr), zsendmanynotevalue + zaddrremaining)
|
assert_equal(self.nodes[1].z_getbalance(myzaddr), zsendmanynotevalue + zaddrremaining)
|
||||||
|
|
||||||
# send node 2 zaddr on node 1 to taddr
|
# send node 2 zaddr on node 1 to taddr
|
||||||
|
|
|
@ -208,9 +208,10 @@ public:
|
||||||
*
|
*
|
||||||
* It's okay to cache the nullifier in the wallet, because we are storing
|
* It's okay to cache the nullifier in the wallet, because we are storing
|
||||||
* the spending key there too, which could be used to derive this.
|
* the spending key there too, which could be used to derive this.
|
||||||
* If PR #1210 is merged, we need to revisit the threat model and decide
|
* If the wallet is encrypted, this means that someone with access to the
|
||||||
* whether it is okay to store this unencrypted while the spending key is
|
* locked wallet cannot spend notes, but can connect received notes to the
|
||||||
* encrypted.
|
* transactions they are spent in. This is the same security semantics as
|
||||||
|
* for transparent addresses.
|
||||||
*/
|
*/
|
||||||
boost::optional<uint256> nullifier;
|
boost::optional<uint256> nullifier;
|
||||||
|
|
||||||
|
@ -758,9 +759,6 @@ public:
|
||||||
*
|
*
|
||||||
* - Restarting the node with -reindex (which operates on a locked wallet
|
* - Restarting the node with -reindex (which operates on a locked wallet
|
||||||
* but with the now-cached nullifiers).
|
* but with the now-cached nullifiers).
|
||||||
*
|
|
||||||
* Several rounds of this may be required to incrementally fill the
|
|
||||||
* nullifier caches of discovered notes.
|
|
||||||
*/
|
*/
|
||||||
std::map<uint256, JSOutPoint> mapNullifiersToNotes;
|
std::map<uint256, JSOutPoint> mapNullifiersToNotes;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue