From 67d2b19caaeff95ac9a910587b000e840d48419a Mon Sep 17 00:00:00 2001 From: Charlie O'Keefe Date: Wed, 28 Nov 2018 22:44:52 -0700 Subject: [PATCH] initialize pCurrentParams in TransactionBuilder tests These three tests were failing when run in isolation, or sporadically when test order is randomized, since Params() includes an assertion that pCurrentParams is not null. --- src/gtest/test_transaction_builder.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gtest/test_transaction_builder.cpp b/src/gtest/test_transaction_builder.cpp index 380b410bb..4d31adee2 100644 --- a/src/gtest/test_transaction_builder.cpp +++ b/src/gtest/test_transaction_builder.cpp @@ -95,6 +95,7 @@ TEST(TransactionBuilder, Invoke) TEST(TransactionBuilder, ThrowsOnTransparentInputWithoutKeyStore) { + SelectParams(CBaseChainParams::REGTEST); auto consensusParams = Params().GetConsensus(); auto builder = TransactionBuilder(consensusParams, 1); @@ -103,6 +104,7 @@ TEST(TransactionBuilder, ThrowsOnTransparentInputWithoutKeyStore) TEST(TransactionBuilder, RejectsInvalidTransparentOutput) { + SelectParams(CBaseChainParams::REGTEST); auto consensusParams = Params().GetConsensus(); // Default CTxDestination type is an invalid address @@ -113,6 +115,7 @@ TEST(TransactionBuilder, RejectsInvalidTransparentOutput) TEST(TransactionBuilder, RejectsInvalidTransparentChangeAddress) { + SelectParams(CBaseChainParams::REGTEST); auto consensusParams = Params().GetConsensus(); // Default CTxDestination type is an invalid address