zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enforce length constraints on allPrevOutputs

This commit is contained in:
Jack Grigg 2022-02-17 18:24:19 +00:00
parent c0736d3ef6
commit e9625d2483
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/rust/src/transaction_ffi.rs
View File

@ -206,6 +206,24 @@ pub extern "C" fn zcash_transaction_precomputed_init(
error!("all_prev_outputs had trailing data");
return ptr::null_mut();
}
Ok(all_prev_outputs)
if !tx
.transparent_bundle()
.map(|t| {
if t.is_coinbase() {
// Coinbase txs have one fake input.
all_prev_outputs.is_empty()
} else {
// For non-coinbase txs, every input is real.
t.vin.len() == all_prev_outputs.len()
}
})
// If we have no transparent part, we should have no prev outputs.
.unwrap_or_else(|| all_prev_outputs.is_empty()) =>
{
error!("all_prev_outputs is incorrect length");
return ptr::null_mut();
}
Ok(all_prev_outputs) => MapTransparent {
auth: TransparentAuth { all_prev_outputs },
},