Apply doc suggestions from code review

This commit is contained in:
Daira Hopwood 2022-07-22 19:33:27 +01:00
parent 1caf6f70df
commit ee4a427519
3 changed files with 5 additions and 3 deletions

View File

@ -453,7 +453,8 @@ impl BatchScanner {
height: u32,
) -> Result<(), io::Error> {
let block_tag = BlockHash(block_tag);
// The consensusBranchId parameter is ignored; it is not used in trial decryption.
// The consensusBranchId parameter is ignored; it is not used in trial decryption
// and does not affect transaction parsing.
let tx = Transaction::read(tx_bytes, consensus::BranchId::Sprout)?;
let txid = tx.txid();
let height = consensus::BlockHeight::from_u32(height);

View File

@ -139,7 +139,8 @@ struct CMainSignals {
BatchScanner* (),
aggregate_non_null_values<std::vector<BatchScanner*>>> GetBatchScanner;
/**
* Notifies listeners of updated transaction data (transaction, and optionally the block it is found in.
* Notifies listeners of updated transaction data (the transaction, and
* optionally the block it is found in).
*
* Listeners of this signal should not listen to `GetBatchScanner` or they
* will be notified about transactions twice.

View File

@ -3554,7 +3554,7 @@ bool WalletBatchScanner::AddToWalletIfInvolvingMe(
auto decryptedNotesForTx = decryptedNotes.find(tx.GetHash());
if (decryptedNotesForTx == decryptedNotes.end()) {
throw std::logic_error("Called SyncTransaction with a tx that wasn't passed to AddTransaction");
throw std::logic_error("Called WalletBatchScanner::AddToWalletIfInvolvingMe with a tx that wasn't passed to AddTransaction");
}
auto decryptedNotes = decryptedNotesForTx->second;