zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #5555 from steven-ecc/deprecate_rpcs 

Mark z_gettotalbalance and dumpwallet as deprecated
This commit is contained in:
Steven 2022-02-16 15:58:46 -08:00 committed by GitHub
parent d0d6d47aa7 816649db2a
commit ffdc11c378
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/wallet/rpcdump.cpp
View File

@ -547,6 +547,7 @@ UniValue dumpwallet(const UniValue& params, bool fHelp)
if (fHelp || params.size() != 1) if (fHelp || params.size() != 1)
throw runtime_error( throw runtime_error(
"dumpwallet \"filename\"\n" "dumpwallet \"filename\"\n"
"\nDEPRECATED. Please use the z_exportwallet RPC instead.\n"
"\nDumps taddr wallet keys in a human-readable format. Overwriting an existing file is not permitted.\n" "\nDumps taddr wallet keys in a human-readable format. Overwriting an existing file is not permitted.\n"
"\nArguments:\n" "\nArguments:\n"
"1. \"filename\" (string, required) The filename, saved in folder set by zcashd -exportdir option\n" "1. \"filename\" (string, required) The filename, saved in folder set by zcashd -exportdir option\n"

1
src/wallet/rpcwallet.cpp
View File

@ -3916,6 +3916,7 @@ UniValue z_gettotalbalance(const UniValue& params, bool fHelp)
if (fHelp || params.size() > 2) if (fHelp || params.size() > 2)
throw runtime_error( throw runtime_error(
"z_gettotalbalance ( minconf includeWatchonly )\n" "z_gettotalbalance ( minconf includeWatchonly )\n"
"\nDEPRECATED. Please use the z_getbalanceforaccount RPC instead.\n"
"\nReturn the total value of funds stored in the node's wallet.\n" "\nReturn the total value of funds stored in the node's wallet.\n"
"\nCAUTION: If the wallet contains any addresses for which it only has incoming viewing keys," "\nCAUTION: If the wallet contains any addresses for which it only has incoming viewing keys,"
"\nthe returned private balance may be larger than the actual balance, because spends cannot" "\nthe returned private balance may be larger than the actual balance, because spends cannot"