zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
13,026 Commits 27 Branches 108 Tags 109 MiB
Commit Graph

13026 Commits

Author SHA1 Message Date
Jack Grigg 1088866455
pyflakes fixes 2019-12-04 19:16:20 +00:00
Jack Grigg 6278085c23
Match alerts both with and without comments 
We always locally check alerts against our subversion string without comments.
This change ensures that we will also propagate alerts to peers based on their
subversion strings without comments. Note that if an alert specifically targets
a commented subversion string, we will only relay it to peers with the exact
same comments.
 2019-12-04 17:21:56 +00:00
Jack Grigg 5fd97dcdf9
Wrap long line 2019-12-04 17:21:55 +00:00
Jack Grigg 784a481070
cleanup: Comments 2019-12-04 17:21:54 +00:00
Jack Grigg dfeb5bfc6c
Parameterize zcash.conf in init error message 2019-12-04 17:21:53 +00:00
Jack Grigg 00d1efde32
Add tests covering the current interaction of alerts with subver comments 2019-12-04 17:21:52 +00:00
Jack Grigg c1ed8080f2
Handle Equihash and optional miner code in TestChain100Setup 2019-12-04 17:21:51 +00:00
Jack Grigg 26a84cc1f9
Fix benchmarks after removal of SelectParamsFromCommandLine() 2019-12-04 17:18:46 +00:00
Gregory Maxwell 9fee2baebf
Make connect=0 disable automatic outbound connections. 
Otherwise it just responds to this obvious bit of configuration by
 trying to connect to "0" in a loop.
 2019-12-04 17:18:45 +00:00
Jorge Timón 71068892d2
Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs 2019-12-04 17:18:44 +00:00
Gregory Sanders f4d9e06a90
Added additional config option for multiple RPC users. 2019-12-04 17:18:43 +00:00
MarcoFalke e763ce7b20
[qt] Move GUI related HelpMessage() part downstream 
Zcash: Non-QT parts only
 2019-12-04 17:18:42 +00:00
MarcoFalke e11e1ea58e
[trivial] Reuse translation and cleanup DEFAULT_* values 
* DEFAULT_DISABLE_SAFEMODE = false
* Use DEFAULT_* constants for extern bools
 2019-12-04 17:18:41 +00:00
Luke Dashjr 9bc915b02a
Bugfix: Omit wallet-related options from -help when wallet is not supported 2019-12-04 17:18:40 +00:00
Luke Dashjr 2e02bb21f7
Constrain constant values to a single location in code 2019-12-04 17:18:39 +00:00
Jack Grigg 363c945325
Initialize experimental mode in a separate function 2019-12-04 17:18:38 +00:00
Jonas Schnelli a425ac9706
Initialize logging before we do parameter interaction 2019-12-04 17:18:37 +00:00
Jonas Schnelli ef6b9b0fb2
Refactor parameter interaction, call it before AppInit2() 2019-12-04 17:18:36 +00:00
Luke Dashjr 5bedad9580
Bugfix: Omit wallet-related options from -help when wallet is disabled 2019-12-04 17:18:35 +00:00
Luke Dashjr a624c49219
Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo 2019-12-04 17:18:34 +00:00
Luke Dashjr 3779bea091
Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool) 2019-12-04 17:18:33 +00:00
Luke Dashjr b90ea483dd
Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method 2019-12-04 17:18:32 +00:00
Jorge Timón bd87de60ed
Chainparams: Translations: DRY: options and error strings 
Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine
 2019-12-04 17:18:31 +00:00
Jorge Timón af9b9652fa
Chainparams: Replace CBaseChainParams::Network enum with string constants (suggested by Wladimir) 2019-12-04 17:18:30 +00:00
Casey Rodarmor aa1d014b40
Give a better error message if system clock is bad 
Fixes #2007

This checks to see if the system clock appears to be bad and gives a
helpful error message. If the user's clock is set incorrectly, hopefully
they'll abort, fix it, and then save themselves a fruitless resync.
 2019-12-04 17:18:29 +00:00
Wladimir J. van der Laan 921e9a2e53
doc: mention change to option parsing behavior in release notes 2019-12-04 17:18:28 +00:00
Wladimir J. van der Laan 5514316892
Fix argument parsing oddity with -noX 
`bitcoind -X -noX` ends up, unintuitively, with `X` set.
(for all boolean options X)

This result is due to the odd two-pass processing of arguments. This
patch fixes this oddity and simplifies the code at the same time.
 2019-12-04 17:18:27 +00:00
Gavin Andresen b346588c13
Unit test doublespends in new blocks 
As suggested by Greg Maxwell-- unit test to make sure a block
with a double-spend in it doesn't pass validation if half of
the double-spend is already in the memory pool (so full-blown
transaction validation is skipped) when the block is received.
 2019-12-04 17:13:57 +00:00
Homu 9a06ea5ab8 Auto merge of #4221 - rex4539:typo, r=mdr0id 
Fix typo
 2019-12-03 22:12:39 +00:00
Homu 2383d1b1de Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id 
Remove option mempooltxinputlimit

This option is no longer used after Overwinter. Fixes #4209.
 2019-12-03 20:07:20 +00:00
Homu 46f44c6a38 Auto merge of #4180 - oxarbitrage:issue3198, r=mdr0id 
Add node version to metrics screen

Closes #3198.

Example output:

```
Thank you for running a mainnet zcashd v2.1.0-rc1 node!
```
 2019-12-03 18:02:57 +00:00
Homu 08c92b6e93 Auto merge of #4168 - oxarbitrage:issue3571, r=mdr0id 
change LoadKeyMetadata, LoadZKeyMetadata and LoadSaplingZKeyMetadata to void

Fixes #3571
 2019-12-03 16:59:15 +00:00
Homu 173d6a7c18 Auto merge of #4165 - oxarbitrage:issue4029, r=mdr0id 
Remove CheckProofOfWork errors from logs

To fix https://github.com/zcash/zcash/issues/4029 bitcoin patch(https://github.com/bitcoin/bitcoin/pull/7459) was ported.
 2019-12-03 14:56:52 +00:00
Homu 5e26d48a39 Auto merge of #4226 - str4d:2074-wallet-1, r=mdr0id 
Bitcoin 0.12 wallet PRs 1

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6057
- bitcoin/bitcoin#6415

Part of #2074. Closes #3700.
 2019-12-03 06:53:27 +00:00
Homu cc807987c9 Auto merge of #4244 - charlieok:add_check_depends_build_step, r=mdr0id 
Add check-depends step to STAGE_COMMANDS list

Added to the beginning of the list of stage commands
 2019-12-03 03:11:32 +00:00
Homu 2d4b6f9cc2 Auto merge of #4243 - mdr0id:ipv6_rpc_patch, r=mdr0id 
IPv6 RPC patch

Cherry-picked from bitcoin/bitcoin#7489.

To support CI updates via GKE, this patch ensures hosts using only IPv4 can function gracefully on `proxy_test.py`.
 2019-12-03 01:42:47 +00:00
Marshall Gaucher 017682f993
Update to stop random race error from assert 2019-12-02 17:39:00 -08:00
Marshall Gaucher acea0f7715
Update z_sendmany calls passing int 0, instead of Decimal('0') 2019-12-02 15:37:10 -08:00
str4d 6d57fcff13
Apply suggestions from code review 
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
 2019-12-02 21:10:35 +00:00
Marshall Gaucher 62f5bdfbdc
Update `import *` to unblock pyflakes from failing 2019-12-02 11:38:33 -08:00
Dimitris Apostolou cec2bd93cf
Remove stale comment 2019-11-29 16:37:38 +02:00
Alfredo Garcia afbf1a7082 remove dead code in init 2019-11-28 14:55:32 -03:00
Charlie O'Keefe d4f70e5536 Add check-depends step to STAGE_COMMANDS list 2019-11-27 14:12:18 -08:00
Wladimir J. van der Laan e427f70a8c make proxy_test work on servers without ipv6 2019-11-27 10:38:14 -08:00
Jack Grigg 9c93079e28
Add Heartwood to upgrade list 2019-11-25 14:15:19 +00:00
Dagur Valberg Johannsson fe1ff82a7d Remove option mempooltxinputlimit 
This option is no longer used after Overwinter. Fixes #4209.
 2019-11-19 10:35:39 +01:00
Eirik Ogilvie-Wigley ecce2c9672 Account for malloc overhead 2019-11-14 16:21:37 -07:00
Matt Corallo 4f3f8899b3
SQUASH "Implement watchonly support in fundrawtransaction" 2019-11-14 15:52:26 +00:00
Matt Corallo f70fdf4efe
SQUASH "Add have-pubkey distinction to ISMINE flags" 2019-11-14 15:52:23 +00:00
Matt Corallo 60dc0a9e8e
Implement watchonly support in fundrawtransaction 
Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524).
 2019-11-14 15:46:07 +00:00