a9496b08b6
rpc: Register calls where they are defined
...
Split out methods to every module, apart from 'help' and 'stop' which
are implemented in rpcserver.cpp itself.
- This makes it easier to add or remove RPC commands - no longer everything that includes
rpcserver.h has to be rebuilt when there's a change there.
- Cleans up `rpc/server.h` by getting rid of the huge cluttered list of function definitions.
- Removes most of the bitcoin-specific code from rpcserver.cpp and .h.
Continues #7307 for the non-wallet.
2018-07-18 11:07:18 -06:00
4b184205e3
rpc: update inline comments to refer to new file paths
2018-07-18 11:07:17 -06:00
4519a766b6
move rpc* to rpc/
2018-07-18 11:07:16 -06:00
34aca1b03c
[RPC, Wallet] Move RPC dispatch table registration to wallet/ code
...
Allow extending the rpc dispatch table by appending commands when server is not running.
2018-07-18 11:07:15 -06:00
aad4b86e95
Auto merge of #3376 - LarryRuane:2728-help-message-experimental, r=bitcartel
...
add extra help how to enable experimental features
Closes #2728 . When the user attempts to execute a disabled experimental RPC, print some nice text explaining how to enable the RPC (either command-line or adding lines to zcash.conf).
2018-07-18 07:45:46 -07:00
cc9cddbf49
Auto merge of #3371 - kozyilmaz:clang, r=str4d
...
Add -Wl,-pie linker option for macOS and use it instead of -pie
fixes linker error (see below) due to "-pie" usage, replaced it with "-Wl,-pie" for macOS platform
```
clang: error: argument unused during compilation: '-pie' [-Werror,-Wunused-command-line-argument]
```
2018-07-17 21:41:36 -07:00
efa7b914fb
Auto merge of #3243 - pejvan:patch-1, r=bitcartel
...
Update README.md
Added default options to build zcash with as many parallel compilation units as there are cpu cores.
This makes compiling zcash multiple times faster.
2018-07-17 19:57:32 -07:00
b9bd5ab42c
Auto merge of #3354 - leto:absurd_fee_bug, r=bitcartel
...
Fix absurd fee bug reported in #3281 , with tests
This was ported from the Hush `absurd_fee_bug` PR: https://github.com/MyHush/hush/pull/136
Tests executed with `./qa/pull-tester/rpc-tests.sh wallet` and pass on Ubuntu 16.04. Some tests were added for previously untested behavior as well.
Closes #3281 .
2018-07-17 15:03:08 -07:00
687bd96cbd
Minor update to address nits in review.
2018-07-17 14:26:38 -07:00
3835cbb57f
Auto merge of #3263 - str4d:ibd-upstream-changes, r=bitcartel
...
InitialBlockDownload upstream changes
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7208
- bitcoin/bitcoin#8007
- bitcoin/bitcoin#9053
- Excluding second commit (requires bitcoin/bitcoin#8865 )
- bitcoin/bitcoin#10388
2018-07-17 13:17:27 -07:00
0b6eeac330
Update and fix per review comments, the test for absurd fee.
2018-07-17 13:00:42 -07:00
13b41a6760
Auto merge of #3156 - Eirik0:2935-change-indicator, r=bitcartel
...
Add change indicator
This adds to the json returned when calling z_listreceivedbyaddress and z_listuspent an additional field entitiled 'change' which will be either true or false depending on whether or not the note was change from another transaction.
2018-07-17 11:41:03 -07:00
642f3681ca
Update README.md
...
updated to use parenthesis as suggested by @bitcartel
2018-07-17 13:08:54 +02:00
66dfcc1369
add extra help how to enable experimental features
2018-07-16 21:31:55 -06:00
f23e783600
Decryption and tests of note/outgoing encryption.
2018-07-16 18:34:14 -06:00
ea0bd9d3b8
Auto merge of #3345 - str4d:sapling-z_validateaddress, r=bitcartel
...
Add Sapling support to z_validateaddress
Part of #3217 .
2018-07-16 15:04:54 -07:00
62d707d1fd
Fix test broken by change indicator
2018-07-16 14:50:06 -06:00
0646f749f9
Add change indicator for notes
2018-07-16 14:49:29 -06:00
b7d058cef3
Auto merge of #3334 - arielgabizon:add_groth_tests, r=bitcartel
...
Extend JoinSplit tests to Groth
As we now have both PGHR and Groth proofs for Sprout - make the joinsplit tests check the Groth proofs as well.
See https://github.com/zcash/zcash/issues/3266
2018-07-16 12:11:12 -07:00
4b8c52c65c
Improve error message
2018-07-14 05:16:28 +00:00
75bb5f94f4
Update comment as per @arielgabizon
2018-07-13 19:19:16 +00:00
589479fd33
Extend Joinsplit tests to Groth
2018-07-13 13:01:34 +02:00
eea0e2c924
Auto merge of #3390 - arcalinea:3319_discard_sk_if_invalid_ivk, r=str4d
...
Discard sk if ivk == 0
Addresses #3319
2018-07-13 03:16:21 -07:00
db9f669c15
Discard sk if ivk == 0
2018-07-12 15:05:19 -07:00
f55bcd1c10
Auto merge of #3374 - rex4539:fix-typos, r=str4d
...
Fix typos
2018-07-12 14:25:15 -07:00
26948eb24b
Update payment-api.md with type field of z_validateaddress
2018-07-12 22:14:14 +01:00
34bf166e5f
Add encryption of SaplingNotePlaintext and SaplingOutgoingPlaintext classes.
...
This is part of #3061 to add Sapling note functionality.
2018-07-11 22:03:04 -07:00
d86f60f382
Auto merge of #3324 - ebfull:sapling-note-encryption, r=ebfull
...
Sapling note encryption implementation
Closes #3055
Implemented along with @gtank and @Eirik0
DH key exchange was implemented in https://github.com/zcash/librustzcash/pull/18
2018-07-11 14:51:57 -07:00
7478876271
Minor edits
2018-07-11 15:48:41 -06:00
bea879157c
Add Sapling support to z_validateaddress
2018-07-09 15:38:07 +01:00
579ad3b13e
Auto merge of #3273 - arcalinea:sapling_keys, r=str4d
...
Sapling keys in keystore, wallet
- Add/Have/Get SaplingSpendingKey
- Add/Remove/Have/Get SaplingFullViewingKey
- Have/Get SaplingIncomingViewingKey
- SaplingSpendingKeyMap, SaplingFullViewingKeyMap, SaplingIncomingViewingKeyMap
- GenerateNewSaplingZKey()
Not included: note decryptors, crypted keystore
2018-07-06 15:18:39 -07:00
16b617aca6
Auto merge of #3370 - LarryRuane:2984-libsnark-debug-logging, r=str4d
...
Disable libsnark debug logging in Boost tests
Initialize `src/snark/libsnark/common/profiling.cpp: inhibit_profiling_info` to false.
2018-07-06 09:28:44 -07:00
ccf9106501
Fix typos
2018-07-06 14:33:24 +03:00
2173767365
Add crypted keystore sapling add key
2018-07-05 15:00:00 -07:00
8e91ebf76c
Change default_address to return SaplingPaymentAddr and not boost::optional
2018-07-05 14:52:51 -07:00
f82a864dc1
Add StoreAndRetrieveSaplingSpendingKey test
2018-07-05 14:52:51 -07:00
f4207d0c0e
Add SaplingIncomingViewingKeys map, SaplingFullViewingKey methods
2018-07-05 14:52:46 -07:00
efb7662d4a
Add Sapling Add/Have/Get to keystore
2018-07-05 14:37:33 -07:00
c872c1d2df
Disable libsnark debug logging in Boost tests
2018-07-05 10:16:13 -06:00
eda9f87809
Add -Wl,-pie linker option for macOS and use it instead of -pie
2018-07-04 12:27:01 +03:00
cea065e3d4
Auto merge of #3360 - RichardLitt:feat/license, r=str4d
...
docs(LICENSE): update license year to 2018
Part of #2887 .
2018-07-03 13:54:24 -07:00
bbee5e2525
Auto merge of #3363 - bitcartel:release-v1.1.2, r=str4d
...
Release v1.1.2
2018-07-02 02:19:08 -07:00
720b8ac8ad
make-release.py: Updated release notes and changelog for 1.1.2.
2018-07-01 20:12:33 -07:00
7163f00303
make-release.py: Updated manpages for 1.1.2.
2018-07-01 20:12:33 -07:00
8fc73722e8
make-release.py: Versioning changes for 1.1.2.
2018-07-01 20:07:24 -07:00
5ffb24613f
docs(LICENSE): update license year to 2018
...
Should be the right thing to do, but I am not a lawyer, so I do not know.
2018-06-26 10:06:23 -04:00
0f091f228c
Auto merge of #3356 - bitcartel:release-v1.1.2-rc1, r=bitcartel
...
Release v1.1.2 rc1
2018-06-22 21:53:15 -07:00
3ef8f7abb3
make-release.py: Updated release notes and changelog for 1.1.2-rc1.
2018-06-22 17:03:41 -07:00
5121fad00c
make-release.py: Updated manpages for 1.1.2-rc1.
2018-06-22 17:03:41 -07:00
5cbbb7e375
make-release.py: Versioning changes for 1.1.2-rc1.
2018-06-22 16:55:20 -07:00
Wladimir J. van der Laan
Daniel Cousens
Jonas Schnelli
Homu
Simon
Pejvan
Larry Ruane
Sean Bowe
Eirik Ogilvie-Wigley
Duke Leto
Ariel Gabizon
Jay Graber
Jack Grigg
Dimitris Apostolou
kozyilmaz
Richard Littauer