Commit Graph

799 Commits

Author SHA1 Message Date
MarcoFalke c2848070b4 test: Move linters to test/lint, add readme
Zcash: Only the lint-* scripts we have backported.
2020-10-27 23:05:02 +00:00
John Newbery 2788e33710 [contrib] convert test-security-check to python3 2020-10-27 23:05:02 +00:00
practicalswift 5d0affeafb add lint tool to check python3 shebang 2020-10-27 23:05:02 +00:00
practicalswift eab2490ea4 Add shell script linting: Check for shellcheck warnings in shell scripts 2020-10-27 23:05:02 +00:00
MarcoFalke 5747638ecf Refine travis check for duplicate includes
This partially reverts commit c36b720d009f1ab1c3900750e05c1f17412e564d.
2020-10-27 23:05:02 +00:00
practicalswift a3afa2a17e Add Travis check for duplicate includes
This enforces parts of the project header include guidelines (added by @sipa in #10575).
2020-10-27 23:05:02 +00:00
practicalswift 87bc7fc83e Add lint-include-guards.sh which checks include guard consistency 2020-10-27 23:05:02 +00:00
Akio Nakamura b2d56059fa [script] lint-whitespace: improve print linenumber
Before this PR, the linenumber infomaition is output if trailing-space
or tab code was found, but the output occurence is only per a file.
This PR separates the output timing of file name and line number.
As a result, users will find where they need to fix more easily.
2020-10-27 23:05:02 +00:00
MarcoFalke 87f4e1c488 devtools: Exclude patches from lint-whitespace 2020-10-27 23:05:02 +00:00
Sjors Provoost c1683a142b [scripts] lint-whitespace: check last N commits or unstaged changes
Get usage instructions:
.lint-whitespace.sh -?
2020-10-27 23:05:02 +00:00
Sjors Provoost 034fe80a79 [scripts] lint-whitespace: use perl instead of grep -P
MacOS does not support 'grep -P' out of the box. This change makes
it easier for developers to check for whitespace problems locally.
2020-10-27 23:05:02 +00:00
Wladimir J. van der Laan b77da1fd0c contrib: Ignore historical release notes for whitespace check
Lint checks should not test these, they are historical documents,
and we don't want to encourage silly changes to them to satisfy
a checker.

Hopefully makes travis pass again on master.

Tree-SHA512: 37e6716c4fd5e8a4e579f9b84042e6b0ac224836b6c851cd1ca3f7d46611ffd3003bed0ae08dd0457f69d6eaa485a0d21c631e7ef16b14bdb0f2f78ea700332d
2020-10-27 23:05:02 +00:00
MeshCollider 378d6d04aa Add tab char lint check and exclude imported dependencies 2020-10-27 23:05:02 +00:00
Evan Klitzke 5da5d54216 Add a lint check for trailing whitespace.
This adds a new CHECK_DOC check that looks for newly introduced trailing
whitespace. Existing trailing whitespace (of which there is plenty!)
will not trigger an error.

This is written in a generic way so that new lint-*.sh scripts can be
added to contrib/devtools/, as I'd like to contribute additional lint
checks in the future.
2020-10-27 23:05:02 +00:00
therealyingtong 3cdef42bcc make-release.py: Updated release notes and changelog for 4.1.0-rc1. 2020-10-28 02:51:45 +08:00
therealyingtong f10cf663bc make-release.py: Versioning changes for 4.1.0-rc1. 2020-10-28 02:32:03 +08:00
practicalswift ab5fdb7c7d Use bash instead of POSIX sh. POSIX sh does not support arrays. 2020-10-27 15:09:43 +00:00
practicalswift 8cd66cf690 Add error handling: exit if cd fails 2020-10-27 15:08:36 +00:00
str4d 8aadc745c2
Use HTTPS in script license headers
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-10-26 18:04:19 +00:00
Hennadii Stepanov 1d3af17140 Enable ShellCheck rules
Enabled ShellCheck rules:
  SC1087
  SC2001
  SC2004
  SC2005
  SC2006
  SC2016
  SC2028
  SC2048
  SC2066 (note that IFS already contains only a line feed)
  SC2116
  SC2166
  SC2181
  SC2206
  SC2207
  SC2230
  SC2236

Zcash: Only the changes that applied to the versions of the scripts we have.
2020-10-26 17:36:26 +00:00
practicalswift 3b1bf4b4af Add "export LC_ALL=C" to all shell scripts
Zcash: Only for shell scripts we have from upstream.
2020-10-26 17:36:26 +00:00
MarcoFalke 6506fbacf1 test: Move linters to test/lint, add readme 2020-10-26 17:36:26 +00:00
Pieter Wuille 6b6f3b5649 Fail on commit with VERIFY SCRIPT but no scripted-diff 2020-10-26 17:20:55 +00:00
Cory Fields 553c9e6850 devtools: add script to verify scriptable changes 2020-10-26 15:54:33 +00:00
Daira Hopwood c656ae1303 Add new copyright entries for build-aux/m4/ax_cxx_compile_stdcxx.m4
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-20 13:55:14 +01:00
Homu de5c28b4b7 Auto merge of #4613 - str4d:claaaaaang, r=daira
Pin Clang for all compilation

fixes #2513, fixes #4697, fixes #4698, fixes #4699. refs #4607, #4292
2020-10-20 11:15:47 +00:00
Daira Hopwood f2d7fd6323 contrib/devtools/symbol-check.py: add info about Fedora-based distributions.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 14:47:29 +01:00
Daira Hopwood d54d4d083e Update contrib/devtools/symbol-check.py
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 14:47:29 +01:00
Ben Wilson 172b26991e Build python for debian9 and ubuntu16.04 2020-10-15 19:50:29 -04:00
Ben Wilson c6f9215c04 Fixed Centos and Arch python requirements 2020-10-15 17:24:21 -04:00
Ben Wilson 1271afa354 Added Arch and Centos to script, added libtinfo5 for arch 2020-10-15 12:19:28 -04:00
Ben Wilson b598691668 Added libtinfo5 to ci builder containers 2020-10-14 10:55:08 -04:00
Jack Grigg ab35a260d5 Remove remaining OpenSSL references 2020-09-30 00:40:12 +01:00
Jack Grigg f43e3833f3 gitian: Switch from x86_64-unknown-linux-gnu to x86_64-linux-gnu
This will work regardless of how config.sub behaves, and matches what
upstream currently uses.
2020-09-28 21:36:46 +01:00
Sean Bowe 505495a73d
make-release.py: Updated release notes and changelog for 4.0.0. 2020-09-01 13:31:19 -06:00
Sean Bowe 01d1ea5f0f
make-release.py: Versioning changes for 4.0.0. 2020-09-01 13:28:51 -06:00
Sean Bowe 95d159c0e7
make-release.py: Updated release notes and changelog for 4.0.0-rc1. 2020-08-26 10:17:07 -06:00
Sean Bowe a5d6dbde1e
make-release.py: Versioning changes for 4.0.0-rc1. 2020-08-26 10:09:33 -06:00
Charlie O'Keefe 2605fc29dd Remove 'jessie' (debian 8) from suites list in linux gitian descriptors
Debian 8 "jessie" support reached its end-of-life on June 30, 2020
https://www.debian.org/News/2020/20200709
2020-08-18 13:33:40 -06:00
Homu 940fe0b3be Auto merge of #4657 - str4d:tracing-fields, r=str4d
Add support for logging fields in spans and events

Field values must be pointers to C strings, which in practice means that they
cannot be formatted inline (as the pointer must remain valid across the FFI).
This might be improved by future iterations of the macros.

`LogPrint()` is also moved to the DEBUG level, leaving `LogPrintf()` at INFO.
2020-08-17 16:23:58 +00:00
str4d 5ca852ba41
debian: Rename X11 to Expat-with-advertising-clause in copyright
The X11 license specifically mentions the X Consortium as the party that the no-advertising clause applies to.

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-08-18 02:00:24 +12:00
Daira Hopwood eea06658f4 Newer version of checksec.sh from a6df608ac0
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-08-14 17:49:16 +01:00
Jack Grigg 4591a4f832 tracing: Add MAP macro
Source: https://github.com/swansontec/map-macro
License: X11

Also updates contrib/debian/copyright for recent license additions.
2020-08-11 00:51:12 +01:00
Dimitris Apostolou b0b8c63a54
Remove deprecated contrib utilities 2020-08-08 10:57:12 +03:00
Jack Grigg bf4730dd64 contrib: Update macdeploy README 2020-08-08 00:12:10 +01:00
Jack Grigg 927a03465f Merge branch 'master' into modernise-macos-toolchain 2020-08-08 00:07:31 +01:00
Kris Nuttycombe 4dd0647c1c Remove Proton license from contrib/debian/copyright 2020-07-31 13:08:19 -06:00
Kris Nuttycombe 0391809da1 Remove amqp code and Proton library depenencies & flags. 2020-07-31 13:08:18 -06:00
Homu 2589b2fcc5 Auto merge of #4614 - str4d:ctaes, r=str4d
Replace OpenSSL AES with ctaes-based version

Backported from upstream PR https://github.com/bitcoin/bitcoin/pull/7689.

This is backported primarily to remove merge conflicts for a subsequent
backport, and also helps us towards removing OpenSSL. Its actual usage
in wallet encryption would be replaced by a more modern construction
before we make wallet encryption a supported feature, but for now this
does not affect anyone using the experimental feature.
2020-07-31 00:14:40 +00:00
Jack Grigg fb2edcc352 Debian: Add copyright entries for ctaes and secp256k1 2020-07-30 05:57:00 +01:00