practicalswift
68393a4b73
Fix warnings introduced in shellcheck v0.6.0
...
Zcash: Only for shell scripts we have backported.
2020-10-27 23:05:19 +00:00
practicalswift
8ed37f5f40
Remove repeated suppression. Fix indentation.
2020-10-27 23:05:19 +00:00
Vidar Holen
37604a1990
refactor/lint: Add ignored suggestions to an array
...
This avoids duplicating the codes between command and comments.
2020-10-27 23:05:19 +00:00
João Barbosa
653f6dc7e7
qa: Ignore shellcheck warning SC2236
...
With shellcheck 0.6.0 the warning `SC2236 - Use -n instead of ! -z` is raised.
This change adds that warning to the ignored list.
2020-10-27 23:05:19 +00:00
vim88
27f924108c
Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes.
2020-10-27 23:05:19 +00:00
practicalswift
5b11b94d27
macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew
2020-10-27 23:05:19 +00:00
practicalswift
73a6c29bcd
macOS fix: Work around empty (sub)expression error when using BSD grep
2020-10-27 23:05:19 +00:00
Julian Fleischer
52f45ad9a4
use export LC_ALL=C.UTF-8
2020-10-27 23:05:19 +00:00
Julian Fleischer
b90433afd3
fix locale for lint-shell
2020-10-27 23:05:19 +00:00
DesWurstes
be186b8112
Obsolete #!/bin/bash shebang
2020-10-27 23:05:18 +00:00
practicalswift
f98ced2aba
Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python
2020-10-27 23:05:02 +00:00
practicalswift
0eef155a4a
Explicitly specify encoding when opening text files in Python code
2020-10-27 23:05:02 +00:00
practicalswift
1b32acdd52
Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
2020-10-27 23:05:02 +00:00
practicalswift
745ac0ae6d
Add "export LC_ALL=C" to all shell scripts
...
Zcash: Only for lint-* scripts we have backported from upstream.
2020-10-27 23:05:02 +00:00
practicalswift
aade01b184
docs: Mention lint-locale-dependence.sh in developer-notes.md
2020-10-27 23:05:02 +00:00
practicalswift
40316e9359
build: Add linter for checking accidental locale dependence
2020-10-27 23:05:02 +00:00
practicalswift
9174ccaf0d
build: Guard against accidental introduction of new Boost dependencies
2020-10-27 23:05:02 +00:00
MarcoFalke
c2848070b4
test: Move linters to test/lint, add readme
...
Zcash: Only the lint-* scripts we have backported.
2020-10-27 23:05:02 +00:00
John Newbery
2788e33710
[contrib] convert test-security-check to python3
2020-10-27 23:05:02 +00:00
practicalswift
5d0affeafb
add lint tool to check python3 shebang
2020-10-27 23:05:02 +00:00
practicalswift
eab2490ea4
Add shell script linting: Check for shellcheck warnings in shell scripts
2020-10-27 23:05:02 +00:00
MarcoFalke
5747638ecf
Refine travis check for duplicate includes
...
This partially reverts commit c36b720d009f1ab1c3900750e05c1f17412e564d.
2020-10-27 23:05:02 +00:00
practicalswift
a3afa2a17e
Add Travis check for duplicate includes
...
This enforces parts of the project header include guidelines (added by @sipa in #10575 ).
2020-10-27 23:05:02 +00:00
practicalswift
87bc7fc83e
Add lint-include-guards.sh which checks include guard consistency
2020-10-27 23:05:02 +00:00
practicalswift
4ddfb216ee
Fix missing or inconsistent include guards
2020-10-27 23:05:02 +00:00
practicalswift
653846b0a4
Document include guard convention
2020-10-27 23:05:02 +00:00
Akio Nakamura
b2d56059fa
[script] lint-whitespace: improve print linenumber
...
Before this PR, the linenumber infomaition is output if trailing-space
or tab code was found, but the output occurence is only per a file.
This PR separates the output timing of file name and line number.
As a result, users will find where they need to fix more easily.
2020-10-27 23:05:02 +00:00
MarcoFalke
87f4e1c488
devtools: Exclude patches from lint-whitespace
2020-10-27 23:05:02 +00:00
Sjors Provoost
c1683a142b
[scripts] lint-whitespace: check last N commits or unstaged changes
...
Get usage instructions:
.lint-whitespace.sh -?
2020-10-27 23:05:02 +00:00
Sjors Provoost
034fe80a79
[scripts] lint-whitespace: use perl instead of grep -P
...
MacOS does not support 'grep -P' out of the box. This change makes
it easier for developers to check for whitespace problems locally.
2020-10-27 23:05:02 +00:00
Wladimir J. van der Laan
b77da1fd0c
contrib: Ignore historical release notes for whitespace check
...
Lint checks should not test these, they are historical documents,
and we don't want to encourage silly changes to them to satisfy
a checker.
Hopefully makes travis pass again on master.
Tree-SHA512: 37e6716c4fd5e8a4e579f9b84042e6b0ac224836b6c851cd1ca3f7d46611ffd3003bed0ae08dd0457f69d6eaa485a0d21c631e7ef16b14bdb0f2f78ea700332d
2020-10-27 23:05:02 +00:00
MeshCollider
378d6d04aa
Add tab char lint check and exclude imported dependencies
2020-10-27 23:05:02 +00:00
Evan Klitzke
5da5d54216
Add a lint check for trailing whitespace.
...
This adds a new CHECK_DOC check that looks for newly introduced trailing
whitespace. Existing trailing whitespace (of which there is plenty!)
will not trigger an error.
This is written in a generic way so that new lint-*.sh scripts can be
added to contrib/devtools/, as I'd like to contribute additional lint
checks in the future.
2020-10-27 23:05:02 +00:00
Dan Raviv
36463d42c0
Fix header guards using reserved identifiers
...
Identifiers beginning with an underscore followed immediately by an uppercase letter are reserved.
2020-10-27 23:05:02 +00:00
Philip Kaufmann
70e1e116af
[Trivial] ensure minimal header conventions
...
- ensure header namespaces and end comments are correct
- add missing header end comments
- ensure minimal formatting (add newlines etc.)
2020-10-27 23:05:02 +00:00
Homu
75f1a46023
Auto merge of #4832 - therealyingtong:release-v4.1.0-rc1, r=daira
...
Release candidate v4.1.0-rc1
2020-10-27 20:21:35 +00:00
therealyingtong
d66cabf8c9
Update release-notes-4.1.0-rc1.md
2020-10-28 02:54:01 +08:00
therealyingtong
3cdef42bcc
make-release.py: Updated release notes and changelog for 4.1.0-rc1.
2020-10-28 02:51:45 +08:00
therealyingtong
1f731e8355
make-release.py: Updated manpages for 4.1.0-rc1.
2020-10-28 02:51:44 +08:00
therealyingtong
f10cf663bc
make-release.py: Versioning changes for 4.1.0-rc1.
2020-10-28 02:32:03 +08:00
Homu
b61a7e2e89
Auto merge of #4831 - str4d:shell-cleanups, r=daira
...
Shell script cleanups
Cherry-picked from https://github.com/bitcoin/bitcoin/pull/10773 .
Fixes a bug with `./contrib/devtools/gen-manpages.sh` backported in zcash/zcash#4827 .
2020-10-27 16:33:16 +00:00
practicalswift
ab5fdb7c7d
Use bash instead of POSIX sh. POSIX sh does not support arrays.
2020-10-27 15:09:43 +00:00
practicalswift
8cd66cf690
Add error handling: exit if cd fails
2020-10-27 15:08:36 +00:00
Homu
5009f219e6
Auto merge of #4830 - daira:rename-bp-funding-stream, r=daira
...
Rename the FS_ZIP214_ECC funding stream to FS_ZIP214_BP
See also https://github.com/zcash/zips/pull/412 .
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-27 15:06:57 +00:00
Daira Hopwood
d54dda736d
Rename the FS_ZIP214_ECC funding stream to FS_ZIP214_BP.
...
See also https://github.com/zcash/zips/pull/412 .
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-27 13:27:19 +00:00
Homu
d6012677ea
Auto merge of #4826 - str4d:4823-static-assert, r=daira
...
Replace BOOST_STATIC_ASSERT with static_assert
Closes zcash/zcash#4823 .
2020-10-27 11:46:00 +00:00
Jack Grigg
d476537d86
scripted-diff: Remove BOOST_STATIC_ASSERT
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_STATIC_ASSERT(/static_assert(/' ./src/*.h ./src/*.cpp ./src/*/*.h* ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
sed -i ':a;N;$!ba;s/#include <boost\/static_assert.hpp>\n//' ./src/*.h ./src/*.cpp ./src/*/*.h* ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2020-10-27 10:44:58 +00:00
Homu
1d5ed8fa2f
Auto merge of #4744 - LarryRuane:4721-treestate, r=daira
...
add z_gettreestate RPC
Closes #4721 .
2020-10-27 09:46:56 +00:00
Larry Ruane
a91a7d37cf
add z_gettreestate rpc
2020-10-26 23:08:47 -06:00
Homu
b9a4f291ea
Auto merge of #4812 - str4d:shielded-reqs-reject-reasons, r=str4d
...
Improve reject reasons for unmet shielded requirements
These reject messages end up bubbling up to users via the RPC interface.
Distinguishing between the various failure cases will help users figure
out why their transaction is being rejected.
Closes zcash/zcash#3114 .
2020-10-27 01:35:14 +00:00