4ca2b20496
test: Use ed25519_verify in ConsensusTests
2020-12-08 14:23:37 +00:00
5ab69760c5
Auto merge of #4891 - zquestz:add_hex_to_getblock, r=daira
...
[Feature] Include transaction hex in verbose getblock output
This fixes https://github.com/zcash/zcash/issues/4888 and actually makes it so the existing documentation is correct!
I also added a small test to make sure the transaction hex is returned correctly in verbose (2) `getblock` calls, and matches the value in `getrawtransaction`.
Let me know if there is anything else I need to update, as this is my first PR for zcash.
-------------------------------------------------------------------------------------------
Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR.
* [ ] Relevant documentation for this PR has to be completed and reviewed by @mdr0id before the PR can be merged
* [ ] A test plan for the PR must be documented in the PR notes and included in the test plan for the next regular release
As a note, all buildbot tests need to be passing and all appropriate code reviews need to be done before this PR can be merged.
2020-12-08 14:16:34 +00:00
2e9bdc6789
Write down the folklore about nSequence
2020-12-08 07:14:42 -07:00
7dbd969b14
Auto merge of #4882 - rex4539:fix-readelf, r=daira
...
readelf is Linux only
Fixes https://github.com/zcash/zcash/issues/4875 .
2020-12-05 14:31:11 +00:00
307dd8837f
Fix readelf configuration
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-12-04 20:48:26 +02:00
36838ef60f
Auto merge of #4889 - LarryRuane:getinfo-add-build-version, r=LarryRuane
...
add more version information to getinfo rpc
Needed for https://github.com/zcash/lightwalletd/issues/319 , lightwalletd's `GetLightdInfo` grpc would like to return the zcashd version and commit hash.
2020-12-04 16:59:21 +00:00
c3a91be479
Switch to ed25519-zebra for consensus signature checks
...
ed25519-zebra can validate all signatures pre-Canopy, and now that Canopy
is active on mainnet, we don't need to worry about consensus divergence.
2020-12-04 03:42:16 +00:00
77c2a5f810
Auto merge of #4877 - str4d:boost-backports, r=str4d
...
Backport Boost removal PRs
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7613
- bitcoin/bitcoin#10502
- bitcoin/bitcoin#10193
- bitcoin/bitcoin#13961
- bitcoin/bitcoin#13734
- Only the second commit (we don't need the first).
- bitcoin/bitcoin#14480
Part of #4819 .
2020-12-04 01:34:19 +00:00
4cb31e5a19
Fix Hungarian notation nit from Daira
2020-12-04 01:32:07 +00:00
efb603557a
Include transaction hex in verbose getblock output
2020-12-03 14:18:17 -10:00
18775308fa
add more version information to getinfo rpc
2020-12-02 09:42:28 -07:00
c8896f9907
Auto merge of #4874 - str4d:rpc-tests-py, r=str4d
...
Backport migration from rpc-tests.sh to rpc-tests.py
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6567
- bitcoin/bitcoin#6523
- bitcoin/bitcoin#6616
- bitcoin/bitcoin#6788
- Only the commit fixing `rpc-tests.py`
- bitcoin/bitcoin#6791
- Only the fix to `qa/rpc-tests/README.md`
- bitcoin/bitcoin#6827
- bitcoin/bitcoin#6930
- bitcoin/bitcoin#6804
- bitcoin/bitcoin#7029
- bitcoin/bitcoin#7028
- bitcoin/bitcoin#7027
- bitcoin/bitcoin#7135
- bitcoin/bitcoin#7209
- bitcoin/bitcoin#7635
- bitcoin/bitcoin#7778
- bitcoin/bitcoin#7851
- bitcoin/bitcoin#7814
- Only the changes to the new .py files in this PR.
- bitcoin/bitcoin#7971
- bitcoin/bitcoin#7972
- bitcoin/bitcoin#8056
- Only the first commit.
- bitcoin/bitcoin#8098
- bitcoin/bitcoin#8104
- bitcoin/bitcoin#8133
- Only the `rpc-tests.py` commit.
- bitcoin/bitcoin#8066
- bitcoin/bitcoin#8216
- Only the last two commits.
- bitcoin/bitcoin#8254
- bitcoin/bitcoin#8400
- bitcoin/bitcoin#8482
- Excluding the first commit (only affects RPC tests we don't have).
- bitcoin/bitcoin#8551
- bitcoin/bitcoin#8607
- Only the pull-tester commit, for conflict removal.
- bitcoin/bitcoin#8625
- bitcoin/bitcoin#8713
- bitcoin/bitcoin#8750
- bitcoin/bitcoin#8789
- bitcoin/bitcoin#9098
- bitcoin/bitcoin#9276
- Excluding the second commit (we don't have the changes it requires).
- bitcoin/bitcoin#9657
- bitcoin/bitcoin#9807
- bitcoin/bitcoin#9766
- bitcoin/bitcoin#9823
2020-12-02 13:53:52 +00:00
a7370b112e
test: Run shielding-heavy RPC tests in serial
2020-12-02 13:52:08 +00:00
3a91bcfac5
test: Silence pyflakes unused import warning
...
rpc-tests.py trial-imports zmq to determine whether it is available.
2020-12-02 01:01:50 +00:00
21bfa3a0e1
readelf is Linux only
2020-11-25 12:44:58 +02:00
e03667b608
lint: Remove boost/foreach.hpp from allowed includes
2020-11-23 23:24:05 +00:00
ed5c647b45
refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread
2020-11-23 23:07:15 +00:00
8e2d9a78fe
gui: get special folder in unicode
2020-11-23 23:07:15 +00:00
1ffd2d5fad
util: Replace boost::signals2 with std::function
...
Zcash: Added missing imports that were being implicitly included.
2020-11-23 23:07:15 +00:00
df3b6684f2
clang-format: Delete ForEachMacros
2020-11-23 23:07:15 +00:00
c3983ccb1c
scripted-diff: Remove #include <boost/foreach.hpp>
...
-BEGIN VERIFY SCRIPT-
sed -i ':a;N;$!ba;s/#include <boost\/foreach.hpp>\n//' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp
-END VERIFY SCRIPT-
2020-11-23 23:07:15 +00:00
62114cff9e
scripted-diff: Remove BOOST_REVERSE_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_REVERSE_FOREACH(\(.*\), \(.*\))/for (\1 : reverse_iterate(\2))/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ;
-END VERIFY SCRIPT-
2020-11-23 23:07:15 +00:00
e8b5d36eea
Fix const_reverse_iterator constructor (pass const ptr)
2020-11-23 23:07:15 +00:00
46509b99f4
Introduce src/reverse_iterator.hpp and include it...
...
...where it will be needed
Taken from https://gist.github.com/arvidsson/7231973 with small
modifications to fit the bitcoin core project
2020-11-23 23:07:15 +00:00
f5e98e0fb1
scripted-diff: Remove PAIRTYPE
...
Zcash: Added an extra command to handle cases where the pair were not
separated by a space.
-BEGIN VERIFY SCRIPT-
sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
sed -i 's/PAIRTYPE(\([^,]*\),\([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ;
-END VERIFY SCRIPT-
2020-11-23 23:07:15 +00:00
92a867febc
scripted-diff: Fully remove BOOST_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2020-11-23 23:07:15 +00:00
32433c2baf
Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal
2020-11-23 23:06:32 +00:00
5a82dd0817
Add autocomplete to bitcoin-qt's console window.
...
Removed externs
Added listCommands() to CRPCTable
Move autocomplete init to RPCConsole::setClientModel()
Zcash: Only the CRPCTable::listCommands() function.
2020-11-23 23:06:32 +00:00
21a7ec8bfb
test: Run rpc-tests.py in full_test_suite.py
2020-11-21 03:03:58 +00:00
891fbff5b9
test: Adjust some Zcash RPC tests to work with parallel runner
2020-11-21 03:03:58 +00:00
01449d8a3d
qa: Set correct path for binaries in rpc tests
2020-11-21 03:03:58 +00:00
bc644280bf
Add exclude option to rpc-tests.py
2020-11-21 03:03:58 +00:00
32249fb5b2
[qa][doc] Correct rpc test options in readme
2020-11-21 03:03:55 +00:00
b18c437464
[trivial] Add tests_config.ini to .gitignore
2020-11-21 03:03:15 +00:00
4f4f8d5ad7
Various review markups for rpc-tests.py improvements
2020-11-21 03:03:15 +00:00
6aad43b63f
Refactor rpc-tests.py
...
- add main()
- remove global variables
2020-11-21 03:03:15 +00:00
cc099b3b7b
Improve rpc-tests.py arguments
...
A few miscellaneous improvements to rpc-tests.py command line arguments:
- make all arguments start with double dash for consistency
- improve help text and output
- add nozmq argument to explicitly exclude the ZMQ tests
- change 'parallel' to 'jobs'
2020-11-21 03:03:15 +00:00
389b70cafe
Use argparse in rpc_tests.py
...
This commit replaces the roll-your-own argument parsing in rpc_tests.py
with Python's standard library argparse.
2020-11-21 03:03:15 +00:00
41c2bc1e05
Use configparser in rpc-tests.py
...
Remove the use of wildcard imports in rpc-tests.py and replace with
configparser.
2020-11-21 03:03:15 +00:00
2eab4f7503
remove obsolete run-bitcoind-for-test.sh
2020-11-21 03:03:15 +00:00
3accdb2fc7
Reorder RPC tests for running time
2020-11-21 03:03:15 +00:00
8b3c39ea80
[qa] rpc-tests: Apply random offset to portseed
...
This helps to skip over resources, which are blocked by regtest bitcoind
zombie nodes
2020-11-21 03:03:15 +00:00
0a73a0fbd9
[qa] test_framework: Exit when tmpdir exists
2020-11-21 03:03:15 +00:00
d014a30566
[qa] pull-tester: Only print output when failed
2020-11-21 03:03:15 +00:00
bcbf03ebe9
[qa] Refactor RPCTestHandler to prevent TimeoutExpired
2020-11-21 03:03:15 +00:00
352f2dc54b
[qa] create_cache: Delete temp dir when done
2020-11-21 03:03:15 +00:00
2d90c8f0d8
[doc] - clarify statement about parallel jobs in rpc-tests.py
2020-11-21 03:03:12 +00:00
4500a75346
[qa] pull-tester: Don't mute zmq ImportError
...
Zcash: We didn't backport the mute, so this is just conflict removal.
2020-11-21 03:02:41 +00:00
e4d1dcc753
[qa] Remove unused code
2020-11-21 03:02:41 +00:00
b25a63593e
[qa] Use single cache dir for chains
2020-11-21 03:02:41 +00:00
Jack Grigg
Homu
Kris Nuttycombe
Dimitris Apostolou
Josh Ellithorpe
Larry Ruane
Chun Kuan Lee
MarcoFalke
Jorge Timón
Luv Khemani
John Newbery
fanquake
Alex Morcos
isle2983