Kris Nuttycombe
721e5d85ab
Deprecate `getrawchangeaddress` and `z_listaddresses`
2022-05-10 16:23:15 -06:00
Kris Nuttycombe
1b8a9af946
Add tests to check auth data commitments committing to Orchard actions.
...
In the process of adding these tests, I also found and fixed a number
of type errors in Orchard auth data root computation.
Fixes #5223
2022-05-09 21:01:11 -06:00
Kris Nuttycombe
c6ceeb1646
Merge pull request #5934 from nuttycom/fix/release-notes-typos
...
Fix typos in release notes & Orchard wallet internal API doc.
2022-05-09 12:52:35 -06:00
Kris Nuttycombe
7defcb8341
Merge pull request #5926 from nuttycom/deprecation/z_getbalance
...
Add z_get(total)balance to deprecation flags.
2022-05-09 12:52:16 -06:00
Kris Nuttycombe
ac1f6799c2
Merge pull request #5935 from str4d/release-v5.0.0-rc1
...
Release v5.0.0-rc1
2022-05-09 11:00:20 -06:00
Kris Nuttycombe
8f2c15cf6f
Include getbalance in recommendations for z_getbalance and z_gettotalbalance replacements.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-05-09 10:32:56 -06:00
Kris Nuttycombe
75055882d4
Add missing parenthesis to -reindex help.
2022-05-09 10:13:39 -06:00
Jack Grigg
64ccad1a89
make-release.py: Updated release notes and changelog for 5.0.0-rc1.
2022-05-09 15:35:33 +00:00
Jack Grigg
e7f04c1741
make-release.py: Updated manpages for 5.0.0-rc1.
2022-05-09 15:35:33 +00:00
Kris Nuttycombe
f41ccaf244
Fix typos in release notes & Orchard wallet internal API doc.
2022-05-09 09:30:02 -06:00
Jack Grigg
a51cbfc78c
make-release.py: Versioning changes for 5.0.0-rc1.
2022-05-09 15:29:29 +00:00
Kris Nuttycombe
731df21da7
Fix a typo in the release script.
2022-05-09 09:12:46 -06:00
Kris Nuttycombe
9fe516576f
Set RELEASE_TO_DEPRECATION_WEEKS to 2 weeks to provide RC EOS halt.
2022-05-09 09:11:05 -06:00
Kris Nuttycombe
580bbc0b35
Postpone dependency updates prior to v5.0.0-rc1
2022-05-09 08:52:59 -06:00
Kris Nuttycombe
cdcf1ee88b
Merge pull request #5927 from nuttycom/fix/transaction_field_init
...
Ensure boolean & integer-typed transaction fields are zero-initialized.
2022-05-09 08:40:52 -06:00
Kris Nuttycombe
8ca33e06f7
Merge pull request #5919 from nuttycom/feature/z_sendmany_tx_limit
...
Add -orchardactionlimit parameter to guard against memory exhaustion.
2022-05-09 08:39:09 -06:00
Kris Nuttycombe
5c1a99a288
Merge pull request #5917 from nuttycom/feature/wallet_orchard-checkpoint_depth
...
Select anchors at `-anchorconfirmations` depth.
2022-05-09 08:29:55 -06:00
Kris Nuttycombe
20614fdaf8
Add -orchardactionlimit help text.
2022-05-07 20:48:41 -06:00
Kris Nuttycombe
a71db41d38
Add -orchardactionlimit parameter to guard against memory exhaustion.
...
Orchard proving can require large amounts of memory, so by default
`z_sendmany` will not attempt to create transactions containing more
than 50 Orchard inputs or outputs to reduce the risk of memory
exhaustion. The `-orchardactionlimit` parameter allows users with
larger amounts of memory at their disposal to override this limit.
Fixes #5889
2022-05-06 22:16:13 -06:00
Kris Nuttycombe
c920077a46
Use default anchor confirmations for minconf in z_mergetoaddress.
...
z_mergetoaddress doesn't currently have any mechanism for specifying
the minconf value. We don't want to default back to a minconf of 1,
as before, because we'll be selecting anchors with at least 3
confirmations by default, so the simplest change here is to make
the minconf value default to the number of anchor confirmations, and
add a configurable minconf at some point in the future. It's likely
that `z_mergetoaddress` will end up being deprecated in any case,
so this works for now.
Also, ensure that anywhere that we're attempting to obtain the Orchard
anchor that we don't attempt to get an anchor from a height below NU5
activation.
2022-05-06 22:15:20 -06:00
Kris Nuttycombe
295f7d9f7b
Change default anchor depth from 10 confirmations to 3
2022-05-06 18:05:39 -06:00
Charlie O'Keefe
c9eb25c9ee
Merge pull request #5930 from defuse/2022-05-rpc-assertion-failure
...
Test an assertion failure in the listaddresses RPC
2022-05-06 16:06:58 -06:00
Kris Nuttycombe
66fad22873
Fix missing handling for imported transparent multisig addresses.
2022-05-06 13:29:05 -06:00
Taylor Hornby
b900c4827b
Reproduce an assertion failure in the listaddresses RPC
2022-05-06 11:59:28 -06:00
Charlie O'Keefe
9227cfb5cb
Merge pull request #5883 from nuttycom/util/release_from_commit_hash
...
Build releases from a commit hash, rather than a named branch.
2022-05-06 09:37:29 -06:00
Kris Nuttycombe
a5f6af12b8
Update release process documentation to clarify the use of release stabilization branches.
2022-05-06 07:30:32 -06:00
Kris Nuttycombe
6b80f3ba1f
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-05-06 07:30:29 -06:00
Kris Nuttycombe
91ef609c1b
Build releases from a commit hash, rather than a named branch.
...
This modifies the release script to take as its first argument
the hash of the git commit to be released. It also improves the
verification of the previous commit tag by ensuring that the tag
exists in the history of the specified commit.
2022-05-06 07:29:46 -06:00
Kris Nuttycombe
038decbc08
Ensure transaction integer fields are zero-initialized.
2022-05-05 13:24:42 -06:00
Kris Nuttycombe
954e2b4aa6
Add parity-scale-codec licenses to contrib/debian/copyright
2022-05-05 13:06:56 -06:00
Kris Nuttycombe
99e41f36c1
Gracefully handle Get(Sprout/Sapling)NoteWitnesses failure.
2022-05-05 12:29:40 -06:00
Kris Nuttycombe
7f29c53c33
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-05-05 12:29:40 -06:00
Kris Nuttycombe
0c59fd9a20
Add z_get(total)balance to deprecation flags.
2022-05-05 07:53:29 -06:00
Kris Nuttycombe
fefea8fe29
Fix RPC tests that depend upon -anchorconfirmations=1
2022-05-04 18:00:34 -06:00
Kris Nuttycombe
f285a39063
Merge pull request #5410 from LarryRuane/2021-12-06-test-python-standalone
...
Allow rpc python tests to be run standalone
2022-05-04 17:41:42 -06:00
Kris Nuttycombe
af18ee1aba
Add -anchorconfirmations to the release notes
2022-05-04 16:07:40 -06:00
Kris Nuttycombe
1b387b7459
Disallow -anchorconfirmations values > 100
2022-05-04 16:07:40 -06:00
Charlie O'Keefe
92d2a87053
Merge pull request #5905 from nuttycom/feature/disable_legacy_privacy_strategy
...
Allow deprecated wallet features to be preemptively disabled.
2022-05-04 16:05:45 -06:00
Kris Nuttycombe
90fc0eaa43
Add anchor depth parameter to Get*NoteWitnesses
2022-05-04 16:04:21 -06:00
Daira Hopwood
50a8a8745a
Fix WalletTests.CachedWitnessesEmptyChain for new anchor selection.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-05-04 16:04:21 -06:00
Daira Hopwood
c2dedb641e
Select an anchor and notes that have 10 confirmations.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-05-04 16:04:21 -06:00
Daira Hopwood
f20be2cff7
Rename nOrchardAnchorConfirmations -> nAnchorConfirmations
2022-05-04 16:04:21 -06:00
Kris Nuttycombe
63e4addd9a
Select Orchard anchors at `-orchardanchorconfirmations` depth.
...
This changes anchor selection and Orchard authentication path generation
to default to select anchors at a the depth specified by the
`-orchardanchorconfirmations` CLI argument, with a default anchor
selection depth of 10 blocks.
If the value of `minconf` used for a particular call to `z_sendmany` is
less than the the set number of Orchard anchor confirmations, `minconf`
will be used instead for the Orchard anchor confirmations depth,
so that the selected anchor will be certain to contain any notes
selected to be spent.
Fixes #5644
2022-05-04 14:16:43 -06:00
Kris Nuttycombe
37bbb9f239
Clarify documentation of the deprecation process.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-05-04 11:53:54 -06:00
Kris Nuttycombe
b7d6120b20
Merge pull request #5924 from steven-ecc/5893-enforce-recovery-phrase-backup
...
Require wallet recovery phrase to be backed up for z_getnewaccount an…
2022-05-03 21:13:35 -06:00
Kris Nuttycombe
717b253a01
Remove `-allowdeprecated=all`
...
We've decided to remove the option to allow all deprecated features,
because this has the effect that, if a user enables this flag, they
won't get the warning (and hence may forget to take action) at the time
that a feature is moved from the default-allowed set to the
default-denied set.
Co-authored-by: str4d <thestr4d@gmail.com>
2022-05-03 20:32:10 -06:00
Kris Nuttycombe
c5493c168b
Merge pull request #5923 from nuttycom/logging/error_log_anchor_mismatch
...
Use ERROR level logging for fatal errors in main/init
2022-05-03 19:25:05 -06:00
Steven Smith
3965eb77f4
Require wallet recovery phrase to be backed up for z_getnewaccount and z_getaddressforaccount
2022-05-03 18:21:16 -07:00
Kris Nuttycombe
d80935a8fd
Use ERROR level logging for fatal errors in main/init
...
Fixes #5922
2022-05-03 16:12:19 -06:00
Kris Nuttycombe
ef547b03a1
Merge pull request #5920 from steven-ecc/5880-add-missing-orchard-pool-metrics
...
Add orchard pool metrics
2022-05-02 20:03:04 -06:00