13351ff31d
Merge pull request #5609 from str4d/bump-deps-4.7.0-rc1
...
Bump dependencies ahead of 4.7.0-rc1
2022-03-05 13:37:28 +00:00
cedf2b5ecb
wallet_sendmany_any_taddr.py: Expect expired tx to be ignored.
2022-03-03 01:31:32 +08:00
98cd4bab0b
wallet_sendmany_any_taddr.py: Test sending output from expired tx.
2022-03-03 01:31:32 +08:00
4a8bdabb2f
wallet_sendmany_any_taddr.py: Test sending from a change taddr.
2022-03-01 11:33:54 +08:00
21430b13ac
depends: Update Rust to 1.59.0
2022-03-01 00:09:18 +00:00
adb7d074d5
qa: Postpone recent CCache release
2022-03-01 00:05:01 +00:00
4c49af7750
qa: Bump all postponed dependencies
...
We have a pending PR to address the `native_ccache` and `googletest`
dependencies, and we aren't going to touch `bdb`.
2022-03-01 00:03:42 +00:00
ba9e020fcd
add functional test
2022-02-17 16:47:59 -07:00
698f7ba770
z_listreceivedbyaddress: reject UA component addr ( #5537 )
2022-02-15 09:19:09 -07:00
e568a190f3
Merge pull request #5419 from zcash/feature/wallet_unified_addresses
2022-02-14 08:17:36 -08:00
b1ab30c8d9
Rename sapling-specific zip32 FFI methods.
...
Also addresses a couple of other minor comments from code review.
2022-02-12 15:24:48 -07:00
326dafeebe
fix wallet_listreceived.py, add blockdata to taddr output
2022-02-12 13:01:58 -07:00
007f05493a
Add change field to z_listreceivedbyaddress for transparent addrs.
...
This updates the `IsChange` method to check the HD keypath associated
with the key for whether the address was generated as internal
or external.
2022-02-11 12:48:35 +00:00
c48e35bb66
Update z_listreceivedbyaddress to support unified addresses (5467)
2022-02-11 12:48:23 +00:00
89b9bbaf33
wallet: Separate counters for external and internal transparent keys
...
This fixes a potential bug with importing the mnemonic into a third
party transparent wallet. Previously, if a user called `getnewaddress`,
made a bunch of transactions that generated at least 20 change
addresses, and then called `getnewaddress` again, the two external
addresses would be separated by a gap of more than 20. If this mnemonic
were imported into a third party transparent wallet, the wallet would
not detect any funds in the second (or subsequent) transparent addresses
because it would detect 20 unused addresses in a row (via the BIP 44
default gap limit).
Now, we track external and internal keys separately; repeated calls to
`getnewaddress` will return addresses for sequential keys. This has the
added benefit that the sequence of `getnewaddress` outputs will be the
same after restoring from a backup.
2022-02-10 21:26:29 +00:00
11e62fa997
wallet: Remove `CWallet::GetKeyFromPool`
...
Legacy transparent addresses for external use are now obtained directly
via `GenerateNewKey(true)`.
2022-02-10 21:26:29 +00:00
2aad87e147
Merge pull request #5526 from str4d/wallet-unified-addrs-in-rpcs
...
Handle wallet Unified Addresses in RPCs
2022-02-09 21:11:41 -07:00
88dde127f4
wallet: Show UAs instead of Sapling receivers in `z_listunspent`
...
We also add a `type` field to the output objects (matching the field in
`z_viewtransaction`), now that the output type can't be distinguished
solely from the address encoding.
2022-02-10 02:32:56 +00:00
bf79be2b57
Replace z_getbalanceforaddress with z_getbalanceforviewingkey
2022-02-09 16:58:55 -07:00
9439c79bab
Merge pull request #5469 from nuttycom/feature/wallet_unified_addresses-z_sendmany
...
Add support for unified addresses to z_sendmany
2022-02-08 23:42:59 +00:00
3f84067658
Fix nondeterministic test failure in wallet_listreceivedby.py
2022-02-08 14:18:18 -07:00
1890758b27
Apply suggestions from code review.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-02-08 10:59:15 -07:00
cf271473eb
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <thestr4d@gmail.com>
2022-02-07 16:52:31 -07:00
13ee447a42
Merge branch 'test_wallet_listreceived' into feature/wallet_unified_addresses-z_sendmany
2022-02-07 15:08:35 -07:00
fa0d4eb473
Use z_shieldcoinbase for Sprout funds in wallet_listreceived tests.
...
After release 4.7.0, z_sendmany will no longer support sending
funds to Sprout. By using z_shieldcoinbase, we can avoid this
limitation.
2022-02-07 15:06:19 -07:00
1e165b8396
allow UA as z_shieldcoinbase destination
2022-02-03 08:31:26 -07:00
ca04cb0a58
All implementations of ComparisonTestFramework were overriding num_nodes
...
Moreover, they were all overriding it to the same value (1).
Set the default to 1 and remove redundant subclass constructor code.
2022-02-01 10:27:16 -07:00
4dce020678
enforce usage of the get_tests comptool interface as ComparisonTestFramework method
...
In practice all-and-only subclasses of ComparisonTestFramework implement get_tests.
This commit enforces this relation.
2022-02-01 10:27:10 -07:00
214567be2c
Add a few additional cases to z_sendmany RPC tests.
2022-02-01 08:24:31 -07:00
a0c27bf254
Address TODOs in rpc-tests/wallet-accounts.py
2022-02-01 08:24:31 -07:00
9afea4f10b
Add failing tests for z_sendmany ANY_TADDR -> UA and UA -> <legacy_taddr>
2022-01-30 11:07:00 -07:00
71f17fa05c
Add a check for internal vs. external outputs to wallet_listreceived test.
2022-01-27 21:29:40 -07:00
992a47103d
Merge pull request #5500 from str4d/ua-wallet-balance-rpcs
...
Implement balance RPC methods that support Unified Addresses
2022-01-27 20:11:38 +00:00
d17a0bb9de
Merge remote-tracking branch 'upstream/master' into feature/wallet_unified_addresses
2022-01-25 20:27:33 -07:00
756f4fc840
wallet: Implement `z_getbalanceforaddress`
...
Closes zcash/zcash#5182 .
2022-01-26 00:34:45 +00:00
ca0dad0a8c
wallet: Implement `z_getbalanceforaccount`
...
Closes zcash/zcash#5183 .
2022-01-25 23:54:30 +00:00
28eddb7c21
Merge pull request #5474 from LarryRuane/2022-01-disable-sprout-addr-gen
...
rpc: Disable Sprout address generation at Canopy #5368
2022-01-25 10:05:44 -07:00
19bfc2f3b8
Merge pull request #5463 from zingolabs/drop_pyblake2_dep
...
Drop pyblake2 dependency
2022-01-25 09:32:08 -07:00
c4a74087b7
Modify CWallet::FindSpendableInputs to use ZTXOSelector
2022-01-24 13:10:31 -07:00
a6f9c9c0bc
Merge pull request #5458 from nuttycom/cleanup/sendmany_txbuilder
...
Use the transaction builder to implement z_sendmany.
2022-01-21 20:14:58 -07:00
f850e89449
Replace the badly-named `PaymentSource` with `ZTXOSelector`
...
The ZTXOSelector type allows selection of previous Zcash
transaction outputs (both transparent outputs and shielded notes)
on the basis of either a (legacy) bare address, or for a
BIP-44 account.
2022-01-19 13:35:38 -07:00
96c9333b74
wallet: Reverse order of arguments to z_getaddressforaccount
...
We now use the empty array of pools to indicate that the default pools
should be used when providing a diversifier index parameter, instead of
needing a default sentinel value for the diversifier index parameter
(which was previously suggested as '*' which would have caused issues
for defining a consistent type for that parameter).
2022-01-18 20:02:13 +00:00
ff0e9f6b95
wallet: Show UAs owned by the wallet in `z_viewtransaction`
...
Part of zcash/zcash#5186 .
2022-01-18 19:44:33 +00:00
baaa3c4ac0
wallet: Implement `z_listunifiedreceivers`
...
Closes zcash/zcash#5181 .
2022-01-18 19:44:33 +00:00
8617622e0d
wallet: Implement `z_getaddressforaccount`
...
Closes zcash/zcash#5180 .
2022-01-18 19:43:27 +00:00
fe384eeb1f
wallet: Implement `z_getnewaccount`
...
Closes zcash/zcash#5178 .
2022-01-13 22:35:08 +00:00
cc392c70a6
Merge branch 'master' into feature/wallet_unified_addresses
2022-01-12 16:54:12 -07:00
423489c5e8
Merge pull request #5458 from nuttycom/cleanup/sendmany_txbuilder
...
Use the transaction builder to implement z_sendmany.
2022-01-12 23:50:09 +00:00
0ca7d49626
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <jack@electriccoin.co>
2022-01-12 10:45:46 -07:00
9554ed2dc4
Require an explicit flag to allow cross-pool transfers in z_sendmany.
...
This adds an `allowRevealedAmounts` argument to z_sendmany. This
flag must be present to allow an amount-revealing cross-pool transfer
to be constructed.
2022-01-11 19:40:02 -07:00
str4d
therealyingtong
Jack Grigg
Larry Ruane
sasha
Kris Nuttycombe
Kris Nuttycombe
zancas
Charlie O'Keefe