Delete spare mainnet Founders' Reward addresses that will never be used
These addresses were originally intended as fallbacks if an FR address was compromised.
There is no need to retain them in the code given that the FR has ended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
native_rust: don't install Rust docs
This speeds up builds, especially native builds on macOS. fixes#5042
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
When -blocksonly is set to 1, it interacts with the -walletbroadcast
parameter and sets it to 0 if it has not been set already.This behavior
is not captured by the current documentation, which claims that -blocksonly
does not impact any wallet transactions.
(cherry picked from commit 621e86ee8d0102e2bf41f7656a368083b89b2f83)
Zcash: Excludes max-peer doc changes, since we don't have
block-relay-only peers yet.
Add metrics collection and a Prometheus exporter
This adds an FFI wrapper around the `metrics` crate, and exposes CPP macros for collecting metrics in the C++ codebase. With this, we can collect metrics from both C++ and Rust.
The following metrics are included in this PR:
- Chain metrics:
- (counter) `zcash.chain.verified.block.total`
- (gauge) `zcash.chain.verified.block.height`
- (histogram) `zcash.chain.verified.block.seconds`
- Value pool metrics:
- (gauge) `zcash.pool.notes.created[name]`
- (gauge) `zcash.pool.notes.spent[name]` (currently not measured)
- (gauge) `zcash.pool.notes.unspent[name]` (currently not measured)
- (gauge) `zcash.pool.value.zatoshis[name]`
- P2P network metrics:
- (gauge) `zcash.net.peers`
- (counter) `zcash.net.in.bytes.total`
- (counter) `zcash.net.in.bytes[command]`
- (counter) `zcash.net.in.messages[command]`
- (counter) `zcash.net.out.bytes.total`
- (counter) `zcash.net.out.bytes[command]`
- (counter) `zcash.net.out.messages[command]`
- Node metrics:
- (gauge) `zcash.mempool.size.transactions`
- (gauge) `zcash.mempool.size.bytes`
- (gauge) `zcash.mempool.usage.bytes`
- (informational) `zcashd.build.info`
Collection of metrics is conditional on enabling an exporter. This PR adds a Prometheus exporter that can be enabled with `-prometheusport=<port>`. Metrics names have `.` replaced by `_` for compatibility with Prometheus.
By default, metrics are only exposed to localhost. This can be expanded with `-metricsallowip=<ip>`.
RewindBlockIndex calls DisconnectTip in a way that can potentially cause
a Sprout tree to not exist (the rewind_index RPC test reliably triggers
this). We only need to access the tree during disconnection for metrics
purposes, and we will never encounter this rewind situation on either
mainnet or testnet, so if we can't access the Sprout tree we default to
zero.
notes.created and notes.spent can be collected for the transparent pool
as well as the shielded pools. notes.unspent can only be collected for
the transparent pool, by design.
- zcash.sync.block.downloaded.total is redundant, and can be replaced by
zcash.net.in.messages[command=block].
- zcash.sync.block.verified.total and zcash.chain.verified.block.total
are identical for us, because we verify blocks synchronously.
- Add zcash. prefix to common metrics.
- Use .total suffix for accumulating counters instead of .count.
- Group names where possible.
- Shorten names where possible (and still clear).
hyper 0.14.3 added an unstable C API, but the changes to enable it
require us to configure cargo with a linker for cross-compilation.
We'll need to figure this out eventually, but for now let's just
pin hyper to a version that doesn't require it.
- Sprout and Sapling pool metrics (commitments, values)
- Block verification time histogram (as a summary, not bucketed)
- Mempool stats (same as getmempoolinfo returns)
- Inbound and outbound bytes labelled by command
- Added command labels to message counters
Given that label values may be dynamic, any metrics callsite with labels
can't be stored statically. Instead, we contruct a fresh metrics Key each
time we hit a metric with labels (if a metrics recorder is installed).
Leverages the VA_OPT macro library, which is a polyfill for __VA_OPT__
on non-C++20 platforms, to enable TracingSpan to support optional fields.
Source: https://github.com/willwray/VA_OPT
License: Boost Software License, Version 1.0
Pavel Janík
Homu
Daira Hopwood
Jack Grigg
Kris Nuttycombe
glowang
Sjors Provoost
MarcoFalke
plutoforever
str4d
Kris Nuttycombe