0b9f76c36c
Merge pull request #6430 from zcash/hotfix-v5.4.1
...
Back-merge of hotfix-v5.4.1
2023-02-13 16:24:30 -07:00
1ceb4c19cc
qa: Extend `wallet_deprecation` to test `allowdeprecated` in config file
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-02-10 23:57:05 +00:00
8dd3e6135d
qa: Refactor `wallet_deprecation` test to extract common logic
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-02-10 23:57:05 +00:00
251432966f
Merge pull request #6401 from nuttycom/version-5.4.0-back_merge
...
Back-merge version-5.4.0 changes to `master`.
2023-02-02 15:36:12 -07:00
141d7c29d3
Merge pull request #6236 from zcash/fix_tar_extractall
...
Adding tarfile member sanitization to extractall()
2023-02-01 16:33:34 -07:00
51d62c652d
qa: Add RPC test reproducing the Orchard reindex issue
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2023-01-31 00:28:30 +00:00
95e3447b96
Fix potential path or symlink traversal
...
Use `realpath` instead of `abspath` and remove unused `safe_extract` arguments & defaults.
Reviewed with @daira @str4d @sellout
2023-01-27 14:08:02 -07:00
543df3797a
Adding tarfile member sanitization to extractall()
2023-01-27 14:08:01 -07:00
214c3007f5
Enable tests of chain supply & transparent pool balance.
2023-01-24 02:13:05 +00:00
0e931a9397
Merge pull request #4470 from oxarbitrage/issue4294
...
Add transparent value pool to RPC calls
2023-01-23 21:55:00 +00:00
0f886c32fe
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-01-23 13:23:20 -07:00
193b22b754
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 11:33:23 -07:00
2fd52ada51
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
486817498f
Add chain supply and transparent value to block index.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
9e1efad2d1
Merge pull request #6312 from str4d/6308-backport-6898
...
Backport `CreateNewBlock` rewrite
2023-01-19 21:47:20 +00:00
e490b7ff4f
qa: Update show_help RPC test
2023-01-13 02:57:39 +00:00
86c019fdfb
Update overwinter test to not shield to Sprout
2023-01-10 15:22:50 -07:00
1c2a406f32
Use cached sprout addresses rather than funding
2023-01-10 15:22:50 -07:00
1951a1fc46
No longer test_received_sprout
2023-01-10 15:22:49 -07:00
8f3083c7f6
Update `mergetoaddress_mixednotes.py` to no longer send to Sprout.
2023-01-10 15:22:49 -07:00
f31370a15b
Remove wallet_shieldcoinbase_sprout test.
...
Shielding coinbase outputs to Sprout is no longer supported.
2023-01-10 15:22:49 -07:00
819db74cea
Remove mergetoaddress_sprout test as sending to Sprout is no longer supported.
2023-01-10 15:22:49 -07:00
73a43638b1
qa: Update mempool_packages RPC test after deprecation ratcheting
2023-01-09 10:30:33 +00:00
a33b8529ff
Merge branch 'master' into 6307-backport-mempool-packages
2023-01-06 23:55:37 +00:00
5cc15a881a
qa: Change show_help RPC test to print out differences
2023-01-05 22:32:19 +00:00
0ff86213ce
Deprecate old hash fields of `getblocktemplate`
2023-01-05 22:32:19 +00:00
09cd65327b
Disable previously-deprecated features by default
...
These features were deprecated at least 3 minor releases ago. I found
one mistake which was that `z_validateaddress` had not been placed
behind the `addrtype` deprecated feature; this has been fixed.
2023-01-05 22:32:19 +00:00
37921677e9
Remove `zcraw*` RPC methods
2023-01-03 12:35:53 +00:00
ad8bd0d254
qa: Refactor `wallet_deprecation` test to simplify deprecation changes
2023-01-03 12:35:53 +00:00
2651451454
Remove `dumpwallet` RPC method
...
The RPC method handler is left in as a tombstone, to redirect callers to
the replacement method (as this is an upstream Bitcoin Core RPC method
that users may expect to be present).
2023-01-03 12:35:52 +00:00
38e319a88f
Prevent block.nTime from decreasing
...
Under some circumstances it is possible for there to be a significant,
discontinuous jump in a node's clock value. On mining nodes, this can
result in block templates which are no longer valid due to time-based
nLockTime constraints. UpdateTime() is modified so that it will never
decrease a block's nLockTime, thereby preventing such invalidations.
(cherry picked from commit bitcoin/bitcoin@ef8dfe41d1 )
Zcash: Updated CreateNewBlock_validity test and wallet_1941 RPC test to
ensure we satisfy the future timestamp soft fork rule.
2022-12-20 08:56:15 +00:00
ef14b8ba60
Add test showing bug in mempool packages
...
(cherry picked from commit bitcoin/bitcoin@598b25d5ee )
2022-12-19 05:38:49 +00:00
b63c58500a
Track transaction packages in CTxMemPoolEntry
...
Associate with each CTxMemPoolEntry all the size/fees of descendant
mempool transactions. Sort mempool by max(feerate of entry, feerate
of descendants). Update statistics on-the-fly as transactions enter
or leave the mempool.
Also add ancestor and descendant limiting, so that transactions can
be rejected if the number or size of unconfirmed ancestors exceeds
a target, or if adding a transaction would cause some other mempool
entry to have too many (or too large) a set of unconfirmed in-
mempool descendants.
(cherry picked from commit bitcoin/bitcoin@5add7a74a6 )
Zcash:
- Mempool methods were adapted to our mempool changes.
- Default ancestor and descendant size limits were double to account for
our larger block size.
- The mempool_packages RPC test fee was adapted to account for our
emissions curve (which results in a smaller per-block reward that
needs to be split into smaller shards for sequential transactions.
- Includes some modifications to account for us backporting
bitcoin/bitcoin@f3fe83673e early in
zcash/zcash#5269 .
2022-12-19 05:38:43 +00:00
80a1366a05
Merge pull request #6265 from sellout/any_taddr-sans-coinbase
...
Don’t select transparent coinbase with ANY_TADDR
2022-12-12 09:18:32 -07:00
cf720fcf0f
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-12-07 12:31:07 -07:00
5f0681a601
Update failing tests after fixing ANY_TADDR behavior
2022-12-02 22:30:45 -07:00
0994282019
Fix typos
2022-11-25 23:09:48 +02:00
f6a4f68115
Merge pull request #6122 from nuttycom/wallet/listunspent_as_of
...
Add `asOfHeight` argument across the RPC API
2022-11-23 21:20:20 -07:00
368d04245d
Change asOfHeight to preserve Bitcoin compat
2022-11-22 22:06:51 -07:00
7792228bab
Revert change to getbalance minconf
...
It was the docs that were wrong. In this case, the default `minconf` _should_ be
0 (to match upstream).
2022-11-22 16:47:40 -07:00
d444f8b586
Fix small error in code review suggestions
2022-11-22 16:47:40 -07:00
f290b9a7b4
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-22 15:59:07 -07:00
4f85307186
Add FIXMEs to repair comments after #6262 is fixed
2022-11-22 10:36:34 -07:00
0a87047186
Merge pull request #6245 from sellout/wallet_accounts-formatting
...
Small formatting change
2022-11-22 07:55:40 -07:00
b9158fe377
Merge pull request #6259 from str4d/debugmetrics
...
Place zcashd.debug.* metrics behind a -debugmetrics config option
2022-11-22 06:05:47 +00:00
b27fdf54fd
Add matured_at_height test helper
2022-11-21 22:36:12 -07:00
3b3f8f4cac
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 21:15:07 -07:00
71b5f99ede
Work around #6262 in wallet_listunspent
2022-11-21 20:44:21 -07:00
952a1ac433
Ignore mempool when asOfHeight is set
...
This also catches a case where the default minconf was 0 (which disagreed with
the docs), and a case where asOfHeight checked the wrong param entry.
2022-11-21 20:44:21 -07:00
c267c3ee26
Merge pull request #6192 from daira/reduce-equihash-solution-memory
...
Reduce memory usage of CBlockIndex
2022-11-21 22:25:30 +00:00
Kris Nuttycombe
Jack Grigg
Charlie O'Keefe
Kris Nuttycombe
TrellixVulnTeam
str4d
Alfredo Garcia
Greg Pfeil
Mark Friedenbach
Suhas Daftuar
Suhas Daftuar
Greg Pfeil
Dimitris Apostolou