Homu
0ad52ca9b1
Auto merge of #4249 - oxarbitrage:issue_3724, r=str4d
...
Add confirmations, blockheight, blockindex and blocktime to z_listreceivedbyaddress
Fixes https://github.com/zcash/zcash/issues/3724
1- There was a PR to add confirmations to this call at https://github.com/zcash/zcash/pull/3836
I ported the commit from there and fixed test case by incrementing the confirmations as suggested at: https://github.com/zcash/zcash/pull/3836#issuecomment-499927807
2- Then added `blockheight`, `blockindex` and `blocktime`. To avoid some duplicated code (Sprout/Sapling) created a structure `trxblock`.
3- Original issue requests only time and blockindex however i think height is also important; if `blockindex` is the position of the transaction in the block then you are going to need also `height` to find it.
2020-04-25 05:28:16 +00:00
Alfredo Garcia
a1c37b7b79
Fix typo
...
Co-Authored-By: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2020-04-15 15:46:49 -03:00
Alfredo Garcia
8a40b8518a
fix wallet nullifiers test
2020-04-14 17:11:20 -03:00
Alfredo Garcia
0a6ab8a5ab
return address info in z_importviewingkey
2020-04-07 08:38:12 -03:00
mdr0id
65a02f0984
Standard py2 to py3 updates
2020-02-09 08:14:21 -08:00
Daira Hopwood
bc909a7a7f
Replace http with https: in links to the MIT license.
...
Also change MIT/X11 to just MIT, since no distinction was intended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
Jack Grigg
3cb20f26a1
test: Make expected_utxos optional in get_coinbase_address()
2019-03-06 09:03:55 +13:00
Jack Grigg
b0f1d643aa
test: Fetch coinbase address from coinbase UTXOs
...
After upstream PR bitcoin/bitcoin#5994 , the first call to getnewaddress after
startup does not return the address being used by the miner.
2019-03-06 09:03:51 +13:00
mdr0id
4ca5def62f
Make pythonisms consistent
2018-12-18 12:16:23 -08:00
Simon
12a1267a4a
Update qa tests for new "sapling" default for z_getnewaddress.
2018-11-16 14:22:23 -08:00
Eirik Ogilvie-Wigley
5602e1f1a6
Allow passing timeout parameter to wait_and_assert_operationid_status
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
e39f0e16c2
Remove unused imports
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
4d89d020a6
Remove unneeded semicolons
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
f081d9cb02
Use utility method to wait for async operations
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
4e1e91512d
Fix assertion and comment
2018-08-06 09:58:40 -06:00
Eirik Ogilvie-Wigley
62d707d1fd
Fix test broken by change indicator
2018-07-16 14:50:06 -06:00
Jack Grigg
28915c30ca
Fix z_importviewingkey startHeight parameter
...
Closes #2937 .
2018-04-03 02:43:52 +01:00
Jack Grigg
44e37656bf
Add watch-only support to Zcash RPC methods
...
Balance totals do not include spends linked to viewing key addresses, as
nullifiers cannot be calculated and therefore spends cannot be detected.
2017-12-20 00:46:37 +00:00
Daira Hopwood
811b36ba80
For unused variables reported by pyflakes, either remove the variable,
...
suppress the warning, or fix a bug (if the wrong variable was used).
refs #2450
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
aff0bf7fa1
Clean up imports to be pyflakes-checkable. fixes #2450
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:04 +01:00
Jack Grigg
b8eb37757b
Require -experimentalmode for wallet encryption
2017-02-09 22:10:58 +00:00
Simon
db026807b8
Add z_sendmany rule that when sending coinbase utxos to a zaddr
...
they must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
2016-10-24 21:34:16 -07:00
Daira Hopwood
deba66ca55
Fix other potential race conditions similar to ref #1597 in RPC tests.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 00:37:14 +01:00
Jack Grigg
2b499f4386
Fix RPC tests that require wallet encryption
2016-10-20 14:35:41 -05:00
Jack Grigg
ddea44a27e
Update comments
2016-10-14 17:16:09 -05:00
Jack Grigg
1a62587e9a
Delay caching of nullifiers when wallet is locked
...
Closes #1502
2016-10-14 17:16:09 -05:00
Jack Grigg
8f445ee774
Break the RPC test by encrypting the mirroring wallet
2016-10-14 17:14:13 -05:00
Jack Grigg
52fdce985f
Add RPC test showing correct handling of JS txns from blockchain
...
For unencrypted wallets, the wallet correctly tracks JoinSplits made for their
zkey in a different wallet.
2016-10-14 17:14:13 -05:00