Kris Nuttycombe
149ffb9582
Merge pull request #6374 from nuttycom/bug/wallet_rescan_escape
...
Allow rescan to exit in the case that Ctrl-C is pressed.
2023-01-27 13:54:57 -07:00
Kris Nuttycombe
a4e6efa3ce
Merge pull request #6376 from sellout/fetch-params-macos
...
Support Bash 3.2 in fetch-params.sh
2023-01-27 11:32:20 -07:00
Kris Nuttycombe
29e65bf536
Tolerate missing cached conflict data in ThreadNotifyWallets
2023-01-26 16:51:23 -07:00
Greg Pfeil
81cc5b98e1
Support Bash 3.2 in fetch-params.sh
...
MacOS still ships with a 15-year-old version of Bash so this removes some usage of features that
require newer (only 10 years old) versions.
Fixes #6367 .
Co-authored-by: Mohamed AlFalasi <2569171+edubai@users.noreply.github.com>
2023-01-26 15:33:57 -07:00
Kris Nuttycombe
887b2688df
Remove unused DEFAULT_BATCHSCANNERMEMLIMIT constant.
2023-01-26 12:33:55 -07:00
Kris Nuttycombe
aab58d308f
Bound wallet batch scanner size to 1000 blocks instead of 100 MiB
...
1000 blocks was selected as a balance between limiting the likely
maximum memory usage of the batch scanner, and avoiding
artificially restricting scanning throughput of small/fast blocks
due to the second-boundary lock synchronization point.
This also removes the `zcashd.wallet.batchscanner.usage.bytes` gague
value that was previously made available when `-prometheusport` was
specified.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 12:26:31 -07:00
Kris Nuttycombe
ce694802d9
Fetch recently conflicted transactions incrementally in ThreadNotifyWallet.
...
We no longer fetch updates from the mempool unless we have fetched all
updates from the chain, as we would otherwise notify the wallet of
mempool changes for which they have not observed parent transactions
in the chain.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 12:26:31 -07:00
Kris Nuttycombe
3b17b77f3d
Allow rescan to exit in the case that Ctrl-C is pressed.
...
Wallet rescanning that happens on node startup was previously not
respecting Ctrl-C. We use an explicit check of `ShutdownRequested()`
instead of a `boost::interruption_point` because wallet startup does
not run in a separate thread.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 11:43:54 -07:00
Kris Nuttycombe
069159b8c1
Merge commit '267ddf8efe36cc799c4c31772a8883ea332ef55b' into version-5.4.0
2023-01-26 09:30:33 -07:00
str4d
cc068329d5
Merge pull request #6370 from nuttycom/bug/dumpwallet_help
...
Fixes an error in `zcash-cli help` following the removal of `dumpwallet`.
2023-01-26 00:48:52 +00:00
Kris Nuttycombe
25c62d804a
Fixes an error in `zcash-cli help` following the removal of `dumpwallet`.
2023-01-25 16:57:29 -07:00
Kris Nuttycombe
c9b63cc3e5
Merge pull request #6358 from str4d/rpc-tests-python-driver
2023-01-25 15:06:06 -07:00
Jack Grigg
817276c02f
rust: Migrate `OrchardMerkleFrontier` to `cxx`
...
Closes zcash/zcash#6333 .
2023-01-24 21:04:48 +00:00
Kris Nuttycombe
a1589ac994
Merge pull request #6364 from str4d/release-v5.4.0-rc2
...
Release v5.4.0-rc2
2023-01-23 21:22:09 -07:00
Jack Grigg
908675b5b9
rust: Add `cxx` version of `RustStream`
2023-01-24 04:15:09 +00:00
Kris Nuttycombe
6d182d7ae7
Update doc/release-notes.md
...
Minor wording correction.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-23 19:15:35 -07:00
Kris Nuttycombe
214c3007f5
Enable tests of chain supply & transparent pool balance.
2023-01-24 02:13:05 +00:00
Jack Grigg
f5b123e494
make-release.py: Updated release notes and changelog for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
Jack Grigg
ad24667c1a
make-release.py: Updated manpages for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
Jack Grigg
ae7c2c742d
make-release.py: Versioning changes for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
Jack Grigg
8f4fff4529
Update release notes with notable changes for v5.4.0
2023-01-24 02:13:05 +00:00
Jack Grigg
5b74dbfddd
metrics: Update `zcash.pool.value.zatoshis` gauge for transparent pool
2023-01-24 02:13:05 +00:00
Jack Grigg
0ff03e9693
depends: Postpone cxx update
2023-01-24 02:12:55 +00:00
str4d
d6e2fada84
Merge pull request #6362 from nuttycom/issue2921-fix-copyright-headers
...
Replace fix-copyright-headers.py with a script that creates a scripted-diff git commit.
2023-01-23 22:13:05 +00:00
str4d
0e931a9397
Merge pull request #4470 from oxarbitrage/issue4294
...
Add transparent value pool to RPC calls
2023-01-23 21:55:00 +00:00
Kris Nuttycombe
0f886c32fe
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-01-23 13:23:20 -07:00
Kris Nuttycombe
3cec519ce4
scripted-diff: Update Zcash copyrights to 2023
...
-BEGIN VERIFY SCRIPT-
for party in "The Zcash developers" "The Bitcoin Core developers" "Bitcoin Developers"; do
sed -i"" -e "s#Copyright (c) \([0-9]\{4\}\)\(-[0-9]\{4\}\)\? $party#Copyright (c) \1-2023 $party#" COPYING
sed -i"" -e "s#\(.*\)\([0-9]\{4\}\)\(-[0-9]\{4\}\)\, $party#\1\2-2023, $party#" contrib/debian/copyright
done
sed -i"" -e "s/define(_COPYRIGHT_YEAR, [0-9]\{4\})/define(_COPYRIGHT_YEAR, 2023)/" configure.ac
sed -i"" -e "s/#define COPYRIGHT_YEAR [0-9]\{4\}/#define COPYRIGHT_YEAR 2023/" src/clientversion.h
git grep "^// Copyright (c) .* The Zcash developers" \
| awk -F ':' '{print $1}' \
| xargs -I {} sed -i"" -e "s#// Copyright (c) \([0-9]\{4\}\)\(-[0-9]\{4\}\)\? The Zcash developers#// Copyright (c) \1-2023 The Zcash developers#" {}
-END VERIFY SCRIPT-
2023-01-23 11:31:54 -07:00
Kris Nuttycombe
b8fe1d2b78
Replace fix-copyright-headers.py with a script that creates a scripted-diff git commit.
...
Fixes #2921
Supersedes #4926
2023-01-23 11:31:41 -07:00
Kris Nuttycombe
57ca26867b
Remove unnecessary delta_count variable.
2023-01-22 22:21:02 -07:00
Kris Nuttycombe
193b22b754
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 11:33:23 -07:00
Kris Nuttycombe
810c191216
Add script for verifying block rewards and fees not claimed by miners.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
Kris Nuttycombe
2fd52ada51
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
Kris Nuttycombe
aa78fc0878
Verify sum of pool balances against chain total supply.
...
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-22 09:10:03 -07:00
Alfredo Garcia
486817498f
Add chain supply and transparent value to block index.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
Jack Grigg
267ddf8efe
qa: Enable RPC test execution to be overridden from Python
...
`run_tests` now takes a (subclass of) `RPCTestHandler` as its first
argument, and returns `True` if all tests passed instead of calling
`sys.exit`. This enables RPC tests to be run from Python and the
execution of individual tests to be customised:
```python
import importlib
import sys
sys.path.append('qa/pull-tester')
rpc_tests = importlib.import_module('rpc-tests')
src_dir = '.'
build_dir = '.'
exeext = ''
class MyTestHandler(rpc_tests.RPCTestHandler):
def start_test(self, args, stdout, stderr):
print('Starting test!')
return subprocess.Popen(
args,
universal_newlines=True,
stdout=stdout,
stderr=stderr)
test_list = ['test_to_run.py']
all_passed = rpc_tests.run_tests(MyTestHandler, test_list, src_dir, build_dir, exeext)
```
2023-01-20 13:50:41 +00:00
str4d
1b72c1177d
Merge pull request #6357 from str4d/release-v5.4.0-rc1
...
Release v5.4.0-rc1
2023-01-20 04:02:54 +00:00
Jack Grigg
227887490b
make-release.py: Updated release notes and changelog for 5.4.0-rc1.
2023-01-19 22:57:59 +00:00
Jack Grigg
c426545081
make-release.py: Updated manpages for 5.4.0-rc1.
2023-01-19 22:57:58 +00:00
Jack Grigg
072fc26e3e
make-release.py: Versioning changes for 5.4.0-rc1.
2023-01-19 22:50:16 +00:00
Jack Grigg
95c6ff635d
depends: CMake 3.25.2
2023-01-19 22:48:36 +00:00
Jack Grigg
c94b3f40d1
doc: Fix arguments to make-release.py in hotfix process
...
Closes zcash/zcash#6280 .
2023-01-19 22:33:05 +00:00
instagibbs
4bb399a8f5
Corrected values
...
(cherry picked from commit bitcoin/bitcoin@f8536a62c3 )
2023-01-19 21:49:14 +00:00
instagibbs
bbf4f8b6e9
Gave miner test values constants for less error-prone values.
...
(cherry picked from commit bitcoin/bitcoin@617deeb06e )
Zcash: Adapted to mining slow start.
2023-01-19 21:49:13 +00:00
Suhas Daftuar
9d04148414
Add tags to mempool's mapTx indices
...
(cherry picked from commit bitcoin/bitcoin@086da92ea7 )
2023-01-19 21:49:13 +00:00
str4d
9e1efad2d1
Merge pull request #6312 from str4d/6308-backport-6898
...
Backport `CreateNewBlock` rewrite
2023-01-19 21:47:20 +00:00
str4d
6ec042dd51
Merge pull request #6343 from rex4539/typos
...
Fix typos
2023-01-18 23:22:44 +00:00
str4d
8bc5740003
Merge pull request #6348 from str4d/update-deps-5.4.0
...
Update dependencies for 5.4.0 and fix some help messages
2023-01-13 16:18:10 +00:00
Jack Grigg
e490b7ff4f
qa: Update show_help RPC test
2023-01-13 02:57:39 +00:00
str4d
579e7d1e75
Merge pull request #6347 from daira/increase-wallet-timeout
...
Increase the time that the wallet will wait for the block index to load
2023-01-13 01:02:57 +00:00
Jack Grigg
7e42041772
Document -clockoffset option
2023-01-13 00:43:46 +00:00