7167dc9b2c
Test setting an expiry height of 0.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-26 20:43:52 +01:00
961c0d58ec
Auto merge of #4060 - str4d:remove-libsnark, r=daira
...
Remove libsnark
Closes #167 . Closes #416 . Closes #418 . Closes #437 .
Closes #521 . Closes #743 . Closes #750 . Closes #894 .
Closes #903 . Closes #1125 . Closes #1136 . Closes #1240 .
Closes #1264 . Closes #1516 . Closes #1517 . Closes #1651 .
Closes #2064 . Closes #2158 . Closes #3478 . Closes #3652 .
Closes #3744 .
2019-09-26 11:21:40 -07:00
62dc5f0821
Auto merge of #4144 - zcash:hotfix-v2.0.7-3, r=str4d
...
Release v2.0.7-3
2019-09-24 16:02:35 -07:00
9d8322a341
Enable RPC tests to wait on mempool notifications
2019-09-20 21:41:49 +01:00
982e924e98
tests: Clean up use of repr() in mininode
2019-09-16 12:23:46 +01:00
06507722ac
Auto merge of #4088 - LarryRuane:3708-insightexplorer-formatting, r=Eirik0
...
insightexplorer: formatting, pyflakes cleanups
These changes were too late (post-review) for the Insight Explorer PRs, see #3708 . No functional differences.
2019-09-04 10:57:56 -07:00
8669cb692d
test: Update RPC tests to use a minimum of Sapling
...
The p2p_nu_peer_management and rewind_index RPC tests still start from
Sprout, because they are explicitly (and only) testing network behaviour
across network upgrades.
The mempool_tx_input_limit test is removed because the flag has been
ignored since Sapling activation, and will be removed at some point in
the near future.
2019-08-22 17:26:54 +01:00
d7d4dd8a0f
test: Add hashFinalSaplingProxy to create_block
2019-08-22 15:44:18 +01:00
0097df5c7a
test: Add Sapling v4 transactions to mininode framework
2019-08-22 15:44:16 +01:00
3019c0be14
test: Require minimum of Sapling for all RPC tests
2019-08-22 15:42:54 +01:00
1f38ad2536
Remove libsnark unit tests from full test suite
2019-08-22 15:42:54 +01:00
b54725fbed
Remove constant
...
Co-Authored-By: str4d <thestr4d@gmail.com>
2019-08-19 12:30:24 -06:00
5ac48d8ebc
Updated location to new download server, fixing #4100
2019-08-18 14:38:49 +01:00
94f642c80a
Enable shorter block times rpc test
2019-08-16 13:21:33 -06:00
f58bc7b638
Add RPC test and test framework constants for Sapling->Blossom activation.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-16 20:19:18 +01:00
cfdf040332
test: Fix AuthServiceProxy closed conn detection
2019-08-16 20:19:18 +01:00
929b302e40
Updated location to new download server
2019-08-14 11:42:31 -07:00
7c5a791b73
insightexplorer: formatting, pyflakes cleanups
2019-08-09 15:27:52 -06:00
5fd1f5afc0
Auto merge of #3972 - LarryRuane:3708-getblockhashesrpc, r=str4d
...
3708 getblockhashesrpc
Part of #3708
2019-08-09 08:00:17 -07:00
2528af69ff
Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
...
Implement ZIP 208: Shorter Block Target Spacing
Closes #3690 .
2019-08-09 02:35:30 -07:00
2e505df351
add timestampindex related RPC getblockhashes
2019-08-08 14:35:07 -06:00
86b23f37ad
add spentindex RPC for bitcore block explorer
2019-08-07 14:23:42 -06:00
2f00729061
Add copyright info
2019-08-05 19:05:11 -06:00
42a21ef004
Test clean up and fixes
2019-08-05 14:52:34 -06:00
65df6225a6
Do not create transactions that will expire after the next epoch
2019-08-02 16:01:20 -06:00
c68511b876
Auto merge of #3926 - LarryRuane:3708-getaddressrpcs, r=str4d
...
add addressindex RPC for bitcore block explorer
Addresses #3708
2019-08-01 05:43:29 -07:00
2300b911f8
Auto merge of #4035 - Eirik0:use-committransaction, r=str4d
...
Use CommitTransaction
This enables `-walletbroadcast` to correctly control transactions created with `z_*` APIs. It also addresses some TODOs in the code and consolidates some repeated logic.
Closes #4077 (because `CommitTransaction` calls `KeepKey` on the transparent change address).
2019-08-01 03:04:06 -07:00
907554be3a
test: Fix pyflakes warnings
2019-08-01 10:43:03 +01:00
8e48ca1fb2
test: Fix permissions on wallet_changeaddresses RPC test
2019-08-01 10:21:27 +01:00
68e174e22b
add addressindex related RPCs
2019-07-31 10:31:16 -06:00
6bc69c39cb
test: Check for change t-addr reuse in z_sendmany
2019-07-31 12:11:14 +01:00
07851670b4
Temporarily disable test
2019-07-29 15:04:34 -06:00
102dafdf89
Update block subsidy halving for zip208
2019-07-29 13:44:53 -06:00
5306121e5c
Auto merge of #4075 - Eirik0:4059-fix-migration-test, r=Eirik0
...
Fix nondeterministic failure in sapling migration test
Fixes #4059
2019-07-26 01:06:55 -07:00
a63ec6e717
Shorter block times rpc test
2019-07-25 12:49:15 -06:00
5fc227c7dd
Apply suggestions from code review
...
Show migration status in assertion failures
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-07-25 12:35:10 -06:00
6a3f9d8260
Clean up and fix typo
2019-07-24 15:43:08 -06:00
6da42887f1
Auto merge of #3944 - daira:update-license-info, r=daira
...
Update license info
Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes.
Fixes #2827 .
2019-07-24 04:07:03 -07:00
ded45b90d7
Fix nondeterministic failure in sapling migration test
2019-07-20 14:36:08 -06:00
2fe59a5681
qa/zcash/checksec.sh is under a BSD license, with a specialized non-endorsement clause.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:31:39 +01:00
bc909a7a7f
Replace http with https: in links to the MIT license.
...
Also change MIT/X11 to just MIT, since no distinction was intended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
1c899f5a83
Auto merge of #4044 - Eirik0:fix-mergetoaddress-test-comment, r=Eirik0
...
Fix comment in mergetoaddress RPC test
2019-07-18 06:12:22 -07:00
f57f76d789
Rename vjoinsplit to vJoinSplit
2019-06-16 19:13:49 +03:00
c9d14272af
Fix comment in mergetoaddress RPC test
2019-06-11 14:32:57 -06:00
f381d4e085
add spentindex to getrawtransaction RPC results
2019-06-11 10:29:51 -06:00
a8055cfe10
Fix z_mergetoaddress sending from ANY_SPROUT/ANY_SAPLING when the wallet contains both note types
2019-06-10 13:21:25 -06:00
bb0a3e1cb5
Remove old mergetoaddress RPC test
2019-05-22 16:01:50 -06:00
23d9826ef9
Fix LogPrint statements
2019-05-10 17:25:30 -06:00
7470ae8885
Do not automatically remove async migration operations and return txids
2019-05-10 17:19:56 -06:00
e7529049fb
Test the expiry height of migration transactions.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
7cf4749d0d
Correctly account for migration transactions in the mempool
...
Co-authored-by: LarryRuane <larry@z.cash>
2019-05-05 12:59:43 -06:00
345177cfc1
Do not look at vin/vout when determining migration txs and other cleanup
2019-04-30 09:52:53 -06:00
e9530f40f2
use -valueBalance rather than vpub_new to calculate migrated amount
2019-04-29 17:00:26 -06:00
108e587c14
Fix typos and update documentation
2019-04-29 15:29:29 -06:00
2276133bb3
Test migration using both the parameter and the default Sapling address
2019-04-29 15:29:29 -06:00
6e82d72852
Add rpc to get Sprout to Sapling migration status
2019-04-29 15:28:35 -06:00
6acb37bcee
Check for full failure message in test case
2019-04-26 19:01:23 -06:00
5519d16997
Set min depth when selecting notes to migrate
2019-04-25 13:43:23 -06:00
d2a584e35a
Refactor wait_and_assert_operationid_status to allow returning the result
2019-04-24 11:31:14 -06:00
699288b4b4
Documentation cleanup
2019-04-24 11:31:14 -06:00
81a45d6984
Add rpc to enable and disable Sprout to Sapling migration
2019-04-24 11:31:14 -06:00
d6b47948bf
Add qa test for experimental feature: -developersetpoolsizezero
2019-04-23 15:05:15 -07:00
3cb20f26a1
test: Make expected_utxos optional in get_coinbase_address()
2019-03-06 09:03:55 +13:00
b0f1d643aa
test: Fetch coinbase address from coinbase UTXOs
...
After upstream PR bitcoin/bitcoin#5994 , the first call to getnewaddress after
startup does not return the address being used by the miner.
2019-03-06 09:03:51 +13:00
48b7dea5a8
Auto merge of #3639 - leto:size_on_disk, r=bitcartel
...
Port getblockchaininfo.size_on_disk from BTC master
Closes #3630 .
2019-02-25 10:08:44 -08:00
ecde950bac
Add Sapling benchmarks to benchmark runner
2019-02-16 18:44:16 +00:00
a482e4c9fa
Strategically sync to prevent intermittent failures
2019-01-17 15:00:57 -07:00
32212cbad7
Extract helper methods
2019-01-17 15:00:57 -07:00
5e654035a6
fail test if pong is not received
2019-01-17 15:00:57 -07:00
3dab742638
Check entire contents of mempool
2019-01-17 15:00:52 -07:00
57dcc9e6bf
Make variables local
2019-01-17 14:58:50 -07:00
73859fd218
Move common code to helper
2019-01-17 14:58:46 -07:00
23b329d912
flake8 cleanup
2019-01-14 14:00:24 -07:00
4ca5def62f
Make pythonisms consistent
2018-12-18 12:16:23 -08:00
067b6f9373
For ZEC-013. Update qa tests broken by expiring soon threshold.
2018-11-17 09:02:10 -08:00
4484c76202
For ZEC-013. RPC createrawtransaction returns error if tx expiring soon.
2018-11-17 09:02:10 -08:00
cc1ab2db55
For ZEC-013. Don't propagate txs which are expiring soon in p2p messages.
...
When responding to "mempool" message, do not include the txid of an
expiring soon transaction in the "inv" message reply.
When responding to "getdata" message, do not reply with a "tx" message
for a transaction which is expiring soon.
2018-11-17 09:02:00 -08:00
f8cd79c2de
For ZEC-013. Mitigate potential tx expiry height related DoS vector.
...
Don't accept transactions which are about to expire (next 3 blocks).
Don't set a ban score if a peer does propragate these transactions.
See ZEC-013 for more detail.
2018-11-17 09:01:49 -08:00
43040e9384
Add support for "notfound" message to mininode.
2018-11-17 08:27:41 -08:00
a47e1fda73
Auto merge of #3684 - str4d:load-sapling-chain-value, r=bitcartel
...
Load sapling chain value into memory
`CBlockIndex::nSaplingValue` has been correctly set and written to disk since before Sapling activated, meaning that all nodes now are correctly tracking the Sapling shielded pool value on-disk. However, on restart the per-block values are not being read into memory, and so the in-memory pool value appears to be zero on every restart. Setting `nSaplingValue` in-memory during block index loading fixes the problem.
2018-11-16 21:07:46 -08:00
e0b89f59f9
Adjust z_mergetoaddress assertions in Sapling rpc test
2018-11-16 18:14:58 -07:00
0adb77d32e
Add locking for Sapling notes
2018-11-16 18:14:58 -07:00
487c9020bd
Add Sapling support to z_mergetoaddress
2018-11-16 18:14:58 -07:00
e0c491c073
Extend Sprout mergetoaddress rpc test to also work for Sapling
2018-11-16 18:14:57 -07:00
fe393e8a2f
Add fail method to rpc test utils
2018-11-16 18:00:05 -07:00
12a1267a4a
Update qa tests for new "sapling" default for z_getnewaddress.
2018-11-16 14:22:23 -08:00
4e117579c5
Test Sapling value pool accounting
2018-11-16 16:14:52 +00:00
6c1bf4e7ed
Add size_on_disk test
...
Co-authored-by: Simon <simon@bitcartel.com>
2018-11-14 15:04:05 -08:00
97fccdbac5
Auto merge of #3605 - LarryRuane:3604-memo-zeros, r=daira
...
3604 fix sapling default memo - 0xF6 plus zeros
Closes #3604 . For Sapling outputs, set the default memo to `no_memo` instead of all zeros. (See section 5.5 of the Sapling protocol specification.)
2018-10-28 03:15:07 -07:00
882a4f577f
Fix potentially misleading test failures
2018-10-24 13:53:25 -06:00
245db9c8a6
update bug in wallet_listreceived.py, now it highlights the fix
2018-10-24 08:13:56 -06:00
d810703431
Auto merge of #3588 - bitcartel:hash_final_sapling_root_verification, r=bitcartel
...
Add test to verify final sapling root in block header is updated.
2018-10-18 17:52:11 -07:00
61caa46619
For #3359 . Return error if Sapling addresses passed to RPC z_mergetoaddress.
...
RPC z_mergetoaddress does not support Sapling yet but the existing error
reporting was not clear to users.
2018-10-13 08:10:10 -07:00
de1b86a429
For #3359 . RPCs transferring funds return error if Sapling addresses are used before Sapling activation.
2018-10-12 23:14:06 -07:00
527b7feef5
Auto merge of #3592 - Eirik0:z-sendmany-better-error, r=bitcartel
...
Better error message when sending to both sprout and sapling
When trying to send to both Sprout and Sapling (not currently supported with z_sendmany) we were getting the following error in our operation result: `general exception: boost::bad_get: failed value get using boost::get`.
This PR changes this to fail with a better error message before the async operation begins:
```
error code: -8
error message:
Cannot send to both Sprout and Sapling addresses using z_sendmany
```
2018-10-12 15:30:34 -07:00
0917c84d9a
Better error message when sending to both sprout and sapling
...
Co-authored-by mdr0id <marshall@z.cash>
2018-10-12 14:12:21 -06:00
01918e8742
Update test to verify Sapling nullifiers and witnesses persist correctly.
2018-10-11 21:52:56 -07:00
eb0bf23751
add test for sapling spend with transparent recipient
2018-10-11 15:22:20 +02:00
56765e24cb
Add test to verify final sapling root in block header is updated.
2018-10-10 17:30:58 -07:00
3f824a908b
Fix HDSeed comment
2018-10-10 16:00:59 -06:00
732e167043
Auto merge of #3450 - leto:rpctest-readme, r=str4d
...
Fix some typos in rpc-tests readme
2018-10-09 13:18:07 -07:00
c2bb0ec67f
Auto merge of #3517 - mdr0id:3388_persist_wallet, r=str4d
...
Sapling support for persisting wallet to disk
Closes #3388 . Closes #3061 .
2018-10-08 09:53:34 -07:00
01282e4fa6
Update wallet_persistence test to verify spending notes after restart.
2018-10-07 16:22:33 -07:00
08f1baaaca
Update wallet_persistence test to verify wallet txs are persisted across restarts.
2018-10-06 22:53:24 -07:00
5537bf5cdb
Fix file permissions of QA test wallet_persistence.py
2018-10-06 21:05:30 -07:00
2fcf06077f
Persist Sapling key material in the wallet to disk
2018-10-06 00:01:14 +01:00
87ae893d75
Revert "wallet: Comment out HDSeed and CHDChain persistence to disk"
...
This reverts commit b7f9a7ae02
2018-10-05 17:46:43 +01:00
625797a037
Auto merge of #3518 - str4d:3216-z_shieldcoinbase, r=str4d
...
Add Sapling support to z_shieldcoinbase
Part of #3216 .
2018-10-05 03:33:16 -07:00
089ec92e7b
Fix pyflakes warnings
2018-10-05 11:32:22 +01:00
967bbbc486
Auto merge of #3561 - bitcartel:3560_update_sapling_note_data, r=bitcartel
...
Closes #3560 . Update Sapling note data correctly when importing a key.
2018-10-04 15:37:34 -07:00
f09aae037c
Update wallet_listreceived test for now-correct empty Sapling memos
2018-10-04 22:46:15 +01:00
4ba35551d4
Auto merge of #3510 - arcalinea:3378_z_listunspent, r=bitcartel
...
Sapling support for z_listunspent
Closes #3378 .
2018-10-04 11:39:14 -07:00
f0dcfceb81
Closes #3560 . Update Sapling note data correctly when importing a key.
2018-10-03 15:40:50 -07:00
5f91a95641
Add Sapling support to z_shieldcoinbase
...
Part of #3216 .
2018-10-03 12:16:18 +01:00
bcdb4344f0
Auto merge of #3548 - Eirik0:3546-sapling-coin-priority, r=bitcartel
...
Use max priority for all shielded transactions
Addresses https://github.com/zcash/zcash/issues/3546#issuecomment-425184034
2018-10-01 10:13:15 -07:00
b7549f2aec
Add test that Sapling shielded transactions have MAX_PRIORITY
2018-09-30 17:23:53 -07:00
5f57babd08
Cleanup to address review comments.
2018-09-28 22:11:05 -07:00
d7d6480ce3
z_listunspent rpc unit test: add testing for Sapling
2018-09-28 15:23:24 -07:00
011f9a02ef
Add rpc test for sprout txs z_listunspent
2018-09-28 15:19:10 -07:00
e4f0d6a8de
Sapling support for z_listreceivedbyaddress
2018-09-27 16:59:29 -06:00
4c4e1718b1
Update qa test as offline regtest nodes need branch id passed in.
2018-09-21 17:16:44 -07:00
18f8abb62d
Closes #3534 . Do not use APPROX_RELEASE_HEIGHT to get consensus branch
...
id when in regtest mode.
Co-authored-by: Larry Ruane <larryruane@gmail.com>
2018-09-21 11:10:15 -07:00
36243f41f1
Auto merge of #3520 - Eirik0:3327-sign-offline, r=bitcartel
...
Fix signing raw transactions with unsynced offline nodes
This PR address the issue in two different ways:
- In `signrawtransaction` we determine the consensus branch ID (which we then later use to construct the transaction) using the chain height. We now also consider the `APPROX_RELEASE_HEIGHT` as this is a better estimation than 0 for the height of the chain if we are unsynced. (This in and of itself solves the Overwinter signing issue).
- We have added an additional parameter to `signrawtransaction` to allow manually overriding the consensus branch ID that zcashd determines we are on. This allows users to work around corner cases where the first strategy is still insufficient.
Closes #3327 .
2018-09-19 15:02:52 -07:00
c10249f3de
Remove unused import
2018-09-19 14:41:02 -06:00
25c3f903c1
Auto merge of #3491 - Eirik0:3218-sapling-import-export-wallet, r=str4d
...
Add Sapling support to z_importwallet and z_exportwallet
Includes code adapted from upstream PR https://github.com/bitcoin/bitcoin/pull/8323
Closes #3218 .
2018-09-19 12:15:48 -07:00
379c7439a0
Auto merge of #3479 - Eirik0:rpc-test-cleanup, r=bitcartel
...
Rpc test cleanup
The main purpose of this PR was to inline the method 'wait_for_async_operation_id' from util.py in tests where we were doing this manually. To make it work in all cases, I had to change the method to return the result in the case where the call failed. I also did a bit of general clean up (removing semicolons) in the files which I changed.
2018-09-18 20:05:39 -07:00
e95bdeabbf
Auto merge of #3521 - bitcartel:sapling_json_data, r=str4d
...
Add Sapling fields to JSON RPC output using TxToJSON.
Related to #3063 to add Sapling support to wallet RPCs.
2018-09-18 12:13:14 -07:00
3501519bc8
Update qa test to check for Sapling related JSON fields.
2018-09-17 10:01:50 -07:00
40b9527301
Incorporate APPROX_RELEASE_HEIGHT when determining what consensus branch to sign with
2018-09-17 10:27:39 -06:00
19697025c6
Add test for signing raw transactions offline
2018-09-17 10:27:37 -06:00
5602e1f1a6
Allow passing timeout parameter to wait_and_assert_operationid_status
2018-09-14 18:41:14 -06:00
e39f0e16c2
Remove unused imports
2018-09-14 18:41:14 -06:00
4d89d020a6
Remove unneeded semicolons
2018-09-14 18:41:14 -06:00
f081d9cb02
Use utility method to wait for async operations
2018-09-14 18:41:14 -06:00
611f93244b
Allow more information to be returned when an async rpc fails
2018-09-14 18:41:14 -06:00
b37dc4e22f
Don't export empty zip32 metadata
2018-09-14 18:36:24 -06:00
2fe39561ec
Export zip32 metadata with sapling keys
2018-09-14 17:27:20 -06:00
ae807af413
Export comment on HDSeed and fingerprint with wallet
2018-09-14 17:26:02 -06:00
9bcf90e2de
Add sapling support to z_importwallet
2018-09-14 16:16:03 -06:00
5e360fb29f
Add sapling spending keys to z_exportwallet
2018-09-14 15:07:15 -06:00
8e057ad9ee
qa: Test both Overwinter and Sapling peer management
2018-09-12 12:15:37 +01:00
b7f9a7ae02
wallet: Comment out HDSeed and CHDChain persistence to disk
...
Sapling keys generated from the seed are not yet persisted, so we don't
want to persist the seed or chain state either, otherwise the wallet
could end up in an inconsistent state.
Some tests are temporarily disabled because commenting out HDSeed
persistence breaks invariants inside CCryptoKeyStore.
Revert this commit during the PR for #3388 .
2018-09-03 10:45:37 +01:00
af04224522
Fix file permissions of wallet_sapling RPC test
2018-09-03 08:27:33 +01:00
0f436a0a26
Fix RPC test that checks exact wording of cleaned-up error message
2018-09-03 08:23:09 +01:00
e54c4d2ca1
rpcwallet: Add Sapling support to z_sendmany
2018-08-27 11:36:14 +01:00
622751da12
Auto merge of #3444 - LarryRuane:2982-mininode-version, r=str4d
...
generalize mininode.py protocol versioning
Fixes #2982 -- replace `overwintered` boolean argument to NodeConn constructor with a protocol version integer, so that adding Sapling (and beyond) will be easier.
2018-08-20 09:48:51 -07:00
4e1e91512d
Fix assertion and comment
2018-08-06 09:58:40 -06:00
7929851626
Only include the change field if we have a spending key
2018-08-06 09:58:40 -06:00
41ecade012
Fix some typos in rpc-tests readme
2018-08-05 21:51:35 -07:00
c0aa34a4b2
generalize mininode.py protocol versioning
2018-08-02 20:30:20 -06:00
066cc9c6c7
Auto merge of #3429 - str4d:3217-sapling-address-creation, r=str4d
...
Add Sapling support to z_getnewaddress and z_listaddresses
Closes #3217 .
2018-08-01 12:01:39 -07:00
4aabeebc1f
test: Fix permissions of wallet_addresses
2018-08-01 19:56:01 +01:00
d75e69da5a
test: Deduplicate logic in wallet_addresses RPC test
2018-08-01 09:44:31 +01:00
f01c11bd0f
Add tests for expiryheight parameter of RPC createrawtransaction.
2018-07-30 10:24:10 -07:00
eec85c4388
Add Sapling support to z_getnewaddress and z_listaddresses
2018-07-30 16:24:20 +01:00
cb3a815b29
Add call to sync_all() after (z_sendmany, wait)
2018-07-20 12:00:41 -06:00
4b184205e3
rpc: update inline comments to refer to new file paths
2018-07-18 11:07:17 -06:00
b9bd5ab42c
Auto merge of #3354 - leto:absurd_fee_bug, r=bitcartel
...
Fix absurd fee bug reported in #3281 , with tests
This was ported from the Hush `absurd_fee_bug` PR: https://github.com/MyHush/hush/pull/136
Tests executed with `./qa/pull-tester/rpc-tests.sh wallet` and pass on Ubuntu 16.04. Some tests were added for previously untested behavior as well.
Closes #3281 .
2018-07-17 15:03:08 -07:00
0b6eeac330
Update and fix per review comments, the test for absurd fee.
2018-07-17 13:00:42 -07:00
13b41a6760
Auto merge of #3156 - Eirik0:2935-change-indicator, r=bitcartel
...
Add change indicator
This adds to the json returned when calling z_listreceivedbyaddress and z_listuspent an additional field entitiled 'change' which will be either true or false depending on whether or not the note was change from another transaction.
2018-07-17 11:41:03 -07:00
62d707d1fd
Fix test broken by change indicator
2018-07-16 14:50:06 -06:00
0646f749f9
Add change indicator for notes
2018-07-16 14:49:29 -06:00
f649bb36c5
Auto merge of #3303 - LarryRuane:2807-rpc-test-round-fees, r=bitcartel
...
(rpc-test) accurately account for fee without rounding error
Fix for #2807 , this test compares balances after doing key exports and imports, and expects these balances to be equal. But they are not exactly equal due to transaction fees, so the test makes them "equal" by rounding a value that has had fees taken out up to the nearest hundredth of a unit (which is much more than the default fee). This obviously is somewhat sloppy. It also converts a balance to float, which really should never be used due to loss of precision (use Decimal instead).
This change makes the test accurately account for the fee using precise comparisons, and removes the use of float. This test doesn't depend on the default fee (0.0001) but instead sets the fee (to that value). This way, if the default fee changes in the future, this test will continue to run. While testing these changes, I set the fee to various values (up to the max, 0.0190), and the test still passes.
2018-06-22 14:01:48 -07:00
a4ff089b2a
Fix pyflakes error in test zkey_import_export.
2018-06-22 11:34:21 -07:00
e5aa9f617b
Fix absurd fee bug reported in #3281 , with tests
2018-06-22 05:20:45 +00:00
4e3ff06507
Auto merge of #3320 - str4d:macos-tests, r=bitcartel
...
Fix MacOS tests
Includes code cherry-picked from upstream PR bitcoin/bitcoin#8270 .
2018-06-18 19:00:56 -07:00
341a22ad90
Skip ELF-only sec-hard checks on non-ELF binaries
2018-06-07 18:49:15 +12:00
c7e64754dc
Add MacOS support to no-dot-so test
2018-06-05 22:32:13 +12:00
25c13ef702
Add hashFinalSaplingRoot to getblocktemplate
2018-06-01 15:47:30 -06:00
fff031688e
(rpc-test) accurately account for fee without rounding error
2018-05-24 11:29:14 -04:00
386a9b35c0
Auto merge of #3238 - str4d:3199-mempool-sapling-activation, r=str4d
...
Update mempool_nu_activation RPC test to exercise both Overwinter and Sapling
Closes #3199 .
2018-05-16 13:52:40 -07:00
a81b36d267
Add more options when asserting in RPC tests
2018-05-04 09:38:36 -06:00
11aa594440
Remove obsolete CreateJoinSplit and GenerateParams binaries
2018-05-03 13:18:03 +01:00
2c34c1cbff
Update mempool_nu_activation RPC test to exercise both Overwinter and Sapling
...
Closes #3199 .
2018-05-03 01:07:41 +01:00
9bd8f092c6
Closes #3178 by adding verbosity level improvements to getblock RPC.
...
This is a follow-up commit for d0a1d833520d120bb5a2ac4cf4192047af6afe24
found in PR #3095 in order to fix nits and add a test.
2018-04-30 11:51:59 -07:00
68cf6f3c2d
Auto merge of #3074 - arcalinea:2983_tx_expiry_test_dependent, r=str4d
...
Add test for dependent txs to mempool_tx_expiry.py
Closes #2983
Also replaced absolute blockheight check with a relative height check.
2018-04-23 15:50:16 -07:00
7dc0f84788
Add test for dependent txs to mempool_tx_expiry.py
2018-04-18 06:34:09 -07:00
690d38f0f8
Resolve issue bitcoin/bitcoin#3166 .
...
These changes decode valid SIGHASH types on signatures in assembly (asm) representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from jtimon, laanwj, and sipa.
2018-04-16 07:38:36 -06:00
216e94fb24
[RPC] createrawtransaction: add option to set the sequence number per input
2018-04-12 18:10:04 -06:00
3fe2f3d143
Update -enforcenodebloom RPC test with filterclear vs filteradd
2018-04-05 01:30:38 +01:00
b77e46fe01
Add RPC test for -enforcenodebloom
2018-04-05 01:30:38 +01:00
10e97b8f00
test: Add missing Overwinter fields to mininode's CTransaction
2018-04-04 22:49:49 +01:00
473a113241
Don't increase banscore if the transaction only just expired.
...
Author: Jack Grigg <str4d@z.cash>
2018-04-04 01:29:47 +01:00
a0ea82301a
Test that receiving an expired transaction does not increase the peer's ban score.
2018-04-04 00:01:49 +01:00
697140ede5
Add support for Overwinter v3 transactions to mininode framework.
2018-04-04 00:01:23 +01:00
26cdb83add
Update blockchain.py RPC test for Zcash
2018-04-03 20:40:54 +01:00
f95bf4c417
Fix chainstate serialized_size computation
2018-04-03 20:40:54 +01:00
79272bfaf9
Add tests for gettxoutsetinfo, CLevelDBBatch, CLevelDBIterator
...
Thanks @dexX7.
2018-04-03 20:40:54 +01:00
3055fd5508
Auto merge of #3136 - str4d:2937-z_importviewingkey-startheight, r=daira
...
Fix z_importviewingkey startHeight parameter
Closes #2937 .
Co-authored-by: Tomas M <tomas@slax.org>
2018-04-03 09:41:09 -07:00
3a47b9bcfd
Auto merge of #3132 - str4d:2898-rewind-block-index, r=daira
...
When rewinding, remove insufficiently-validated blocks
If a block is insufficiently-validated against a particular branch ID, then we
cannot guarantee that even the block header will be valid under the actual
consensus rules the node will want to apply. Instead require that the blocks are
completely re-validated, by removing them from the block index (which is
equivalent to reducing their validity to BLOCK_VALID_UNKNOWN).
Closes #3100 .
2018-04-03 04:37:21 -07:00
fe87fd2b36
Add RPC test of RewindBlockIndex
2018-04-03 10:58:27 +01:00
ca981fd442
Auto merge of #3080 - leto:jsindex, r=bitcartel
...
Return JoinSplit and JoinSplitOutput indexes in z_listreceivedbyaddress
This implements a feature request by @nathan-at-least in https://github.com/zcash/zcash/issues/2932 and I wanted to ask for feedback about the exact form of the data returned before updating tests and docs.
2018-04-03 00:30:11 -07:00
28915c30ca
Fix z_importviewingkey startHeight parameter
...
Closes #2937 .
2018-04-03 02:43:52 +01:00
afdd64c6ae
Add tests for new JoinSplit keys returned by z_listreceivedbyaddress
2018-04-02 13:23:00 -07:00
347804fe73
Auto merge of #3106 - braddmiller:3046-mergetoaddress-concurrent, r=str4d
...
Add Note Locking to z_mergetoaddress
Adds note locking to `z_mergetoaddress` allowing it to be invoked multiple times before previous `z_mergetoaddress` operations have finished.
Reference issue [#3046 ](https://github.com/zcash/zcash/issues/3046 )
Co-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash>
2018-03-30 14:29:17 -07:00
72f14060bc
Auto merge of #3098 - str4d:2343-overwinter-disable-mempooltxinputlimit, r=str4d
...
Ignore -mempooltxinputlimit once Overwinter activates
Overwinter changes the SignatureHash function to solve the quadratic hashing problem, so this option will no longer be needed.
2018-03-30 08:33:58 -07:00
4e6400bc00
Implement note locking for z_mergetoaddress
...
Co-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash>
2018-03-29 15:48:34 -06:00
9666cc912a
Test calling z_mergetoaddress to merge notes while a note merge is ongoing
2018-03-29 15:38:26 -06:00
5bdce01848
Auto merge of #2913 - bitcartel:2910_z_listunspent, r=bitcartel
...
Closes #2910 . Add z_listunspent RPC call.
Have tested on network. Opening up for review.
2018-03-28 10:40:49 -07:00
d72c19a662
Closes #2910 . Add z_listunspent RPC call.
2018-03-28 10:38:57 -07:00
31afbcc5c9
Ignore -mempooltxinputlimit once Overwinter activates
2018-03-28 14:25:42 +02:00
99b6f76355
Auto merge of #3111 - bitcartel:3110_high_fee_error_reporting, r=bitcartel
...
Closes #3110 . Ensure user can see error message about absurdly high fees.
2018-03-27 10:33:52 -07:00
8b15afd315
Closes #3110 . Ensure user can see error message about absurdly high fees.
2018-03-27 10:23:24 -07:00
b466c1c90c
cleanup: Ensure code is pyflakes-clean for CI
2018-03-27 02:47:57 +02:00
64de921747
Auto merge of #3091 - bitcartel:cache_invalidation_qa, r=str4d
...
Closes #1988 . Add qa test for cache invalidation bug found in v1.0.0 to v1.0.3.
2018-03-20 11:28:08 -07:00
70e2522306
Auto merge of #3090 - bitcartel:3084_log_expired_txid, r=bitcartel
...
Closes #3084 . Log txid when removing expired transactions from mempool.
2018-03-19 14:59:30 -07:00
b7caaf954b
test: Move wait_and_assert_operationid_status debug output before asserts
...
Otherwise we don't see them for failed tests :)
2018-03-19 14:00:18 +01:00
b740a99079
Remove local function wait_and_assert_operationid_status which is
...
now defined in the test framework for shared usage.
2018-03-16 17:16:22 -07:00
2f761371d2
Add qa test for cache invalidation bug found in v1.0.0 to v1.0.3.
2018-03-16 15:18:34 -07:00
a510b4752d
Enable mempool logging in tx expiry QA test.
2018-03-16 11:45:45 -07:00
b4353db5d6
pyflakes cleanups to RPC tests after Overwinter PRs.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-03-12 14:15:25 +00:00
4db8717431
Fix outdated comment about starting balance of nodes
2018-02-28 14:29:05 -08:00
48cecf2ad9
Regtest mining does have a founders reward, a single address t2FwcEhFdNXuFMv1tcYwaBJtYVtMj8b1uTg
2018-02-28 14:28:22 -08:00
62fee1296f
Update awkward wording about blocks as per @daira
2018-02-28 14:17:28 -08:00
d8399efc03
This library seems to not be used at all and all comments mentioning it are ghosts
2018-02-28 14:13:07 -08:00
427e5fae3f
Fix references to Bitcoin in RPC tests readme
2018-02-26 10:47:59 -08:00
a418756ef4
Auto merge of #2874 - arcalinea:tx_block_expiry, r=arcalinea
...
Transaction expiry height
Implements ZIP 203.
- Only applies after Overwinter blockheight.
Closes #754 .
2018-02-23 18:37:48 -08:00
b6e5cc7d27
Add python qa test overwinter_peer_management.
2018-02-23 14:22:43 -08:00
5943f227da
Add mempool_tx_expiry.py test
2018-02-23 00:12:10 -08:00
c5904fb2a4
Auto merge of #2797 - str4d:2493-active-merging, r=bitcartel
...
Implement z_mergetoaddress for combining UTXOs and notes
Closes #2493 .
2018-02-22 20:59:51 -08:00
15ced9b153
wallet_mergetoaddress: Add additional syncs to prevent race conditions
2018-02-23 04:28:04 +00:00
e6cd2a8356
Closes #2964 . z_sendmany once again makes v1 tx for taddr to taddr.
...
In accordance with the Zcash protocol spec.
2018-02-22 15:43:42 +00:00
4c3d2b3bbe
Check upgrade status in wallet_overwintertx RPC test
2018-02-22 13:44:40 +00:00
553a5c1ab2
Gate z_mergetoaddress as an experimental feature
2018-02-22 13:23:25 +00:00
6e9c7629af
Implement z_mergetoaddress for combining UTXOs and notes
...
Closes #2493 .
2018-02-22 13:23:18 +00:00
ed9aa2b62a
Add branch IDs for current and next block to getblockchaininfo
...
Closes #2974 .
2018-02-21 21:18:03 +00:00
d4d2844829
Auto merge of #2463 - str4d:713-rollback-limit, r=str4d
...
Implement roll-back limit for reorganisation
Part of #2905 . Closes #713 .
2018-02-20 15:17:22 -08:00
818b94f94f
Make number of inputs configurable in validatelargetx test
2018-02-20 04:22:22 +00:00
49274558c6
Auto merge of #2940 - str4d:nu-activation-mempool-expiry, r=str4d
...
Mempool improvements, branch ID awareness
Whenever the local chain tip is updated, transactions in the mempool which commit to an
unmineable branch ID (for example, just before a network upgrade activates, where the
next block will have a different branch ID) will be removed.
Includes commits cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6654
- Only the mempool index change.
- bitcoin/bitcoin#6776
- bitcoin/bitcoin#7020
- bitcoin/bitcoin#6915
Part of #2074 .
2018-02-19 19:00:30 -08:00
34a64fe0a2
Remove mempool transactions which commit to an unmineable branch ID
2018-02-20 02:57:44 +00:00
b0f8c83f95
Add failing test checking timelocked-txn removal during reorg
2018-02-20 02:57:40 +00:00
57e6ecda5a
Implement roll-back limit for reorganisation
...
Closes #713 .
2018-02-19 16:32:42 +00:00
072099d788
Implementation of Overwinter transaction format ZIP 202.
2018-02-16 10:10:15 -08:00
9e8f1d09ca
zkey_import_export: Synchronize mempools before mining
...
Resolves a race condition that caused the RPC test to intermittently fail.
Closes #2892 .
2018-01-22 21:10:57 +00:00
44e5b42751
Check chainValueZat when checking value pool monitoring
2018-01-03 23:41:53 +01:00
5d9cf8ae23
Fix pyflakes warnings in zkey_import_export RPC test
2017-12-21 18:19:42 +00:00
1683c2d5bf
Auto merge of #2143 - str4d:1997-viewing-keys, r=str4d
...
Implement incoming viewing keys
Closes #1997 .
2017-12-20 14:11:05 -08:00
44e37656bf
Add watch-only support to Zcash RPC methods
...
Balance totals do not include spends linked to viewing key addresses, as
nullifiers cannot be calculated and therefore spends cannot be detected.
2017-12-20 00:46:37 +00:00
c1b0db70e5
Auto merge of #2779 - arcalinea:2515_test_zimportkey, r=str4d
...
Add RPC test that exercises z_importkey
Part of #2515 .
2017-12-18 08:32:28 -08:00
efda4bafef
Auto merge of #2796 - per-gron:less-verbose-tests, r=daira
...
Less verbose tests
Fixes #2453 and deduplicates some related code.
2017-12-17 00:22:38 -08:00
d4ab94a6d9
Print result of RPC call in test only when PYTHON_DEBUG is set
2017-12-16 19:24:25 +01:00
8993edfb77
Deduplicate test utility method wait_and_assert_operationid_status
...
Strictly speaking this is not a true deduplication; the test output will be
slightly different (due to inconsistent print statements) but I think this is
close enough.
2017-12-16 19:24:25 +01:00
7888624f74
Auto merge of #2795 - str4d:2351-sprout-circuit-value, r=str4d
...
Track net value entering and exiting the Sprout circuit
Delta values will be stored for new blocks; old blocks can be filled in by
re-indexing. The net value currently in the Sprout circuit is only calculated
when delta values for all previous blocks are present.
Part of #2351 .
2017-12-16 02:09:40 -08:00
f44a4cea42
Auto merge of #2790 - bitcartel:2746_payment_disclosure_prefix, r=str4d
...
Closes #2746 . Payment disclosure blobs now use 'zpd:' prefix.
2017-12-15 10:31:58 -08:00
73b220cb0f
Add rpc test that exercises z_importkey
2017-12-15 10:15:50 -08:00
e319633435
Add Sprout value pool to getblock and getblockchaininfo
2017-12-14 22:06:15 +00:00
61345ae703
Closes #2746 . Payment disclosure blobs now use 'zpd:' prefix.
2017-12-07 10:11:43 -08:00
019c4bddc8
Auto merge of #2741 - bitcartel:stop_dumpwallet_overwriting, r=str4d
...
Prevent RPC calls dumpwallet and z_exportwallet from overwriting an existing file
Closes #2740
2017-12-04 09:41:52 -08:00
159aa37fc0
Closes #2759 . Fixes broken pipe error with QA test wallet.py.
2017-11-22 00:02:52 -08:00
ba1dbb3040
RPC dumpwallet and z_exportwallet updated to no longer allow
...
overwriting an existing file.
2017-11-16 22:29:37 -08:00
45232b1961
Add payment disclosure as experimental feature.
2017-11-14 13:29:05 -08:00
337bca8125
Fix an issue where qa test wallet_shieldcoinbase could hang.
...
The mempool was not synced so a block could be generated and not
clear out the mempool. This would then cause subsequent code
which expected the mempool of all nodes to be empty to hang.
2017-11-03 00:39:23 -07:00
3775ac5250
Auto merge of #2692 - bitcartel:2639_enable_z_shieldcoinbase, r=str4d
...
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
This reverts commit 5023af7bd5
2017-11-02 00:18:40 -07:00
c5dabd2b66
Closes #2639 . Adds optional limit parameter with a default value of 50.
...
The new parameter is to satisfy the principle of least astonishment
by providing a sensible default for the maximum number of transparent
inputs to shield. If users do not configure -mempooltxinputlimit
it is possible for them to create transactions with hundreds of
inputs which suffer from mining delay, due to the current state of
the network where some miners have configured -mempooltxinputlimit
as a way to deal with the problem of quadratic hashing.
2017-11-01 10:40:24 -07:00
cf72e8e06e
Closes #2263 fixing broken pipe error.
2017-10-30 11:58:37 -07:00
c2d3bafeaa
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
...
This reverts commit 5023af7bd5
2017-10-26 11:29:36 -07:00
a20b975a52
Update performance-measurements.sh
...
Fix error message, as per @daira
2017-10-24 14:50:26 -07:00
6b58fd2c99
Auto merge of #2665 - leto:perf_fix, r=str4d
...
Fix bug where performance-measurements.sh fails hards when given no args
Better than "$1: unbound variable", we ran into this when testing this script in the Hush repo, so we are pushing this fix upstream.
2017-10-23 18:37:05 -07:00
692bf7a6df
Add --list-stages argument to full_test_suite.py
2017-10-18 00:56:32 -07:00
91dd425b4a
Add libsnark tests to full_test_suite.py
2017-10-18 00:55:52 -07:00
4c9b77d8fb
Auto merge of #2654 - str4d:429-test-driver-script, r=str4d
...
[Test] New merge test suite driver script
Running the script with no arguments will run all test stages in succession.
Passing one or more stages as arguments will run just those stages.
Closes #429 .
2017-10-16 21:51:21 -07:00
6e98511cf1
Add stdout notice if any stage fails
2017-10-16 16:16:14 -04:00
88fbdc4868
Add bitcoin-util-test.py to full_test_suite.py
...
Not moved, because upstream makes improvements to this script, and the need to
set environment variables makes it simpler to just use the given script.
2017-10-16 16:15:10 -04:00
a2dc9be5c5
Auto merge of #2533 - str4d:2530-mininode, r=str4d
...
Migrate MiniNode to Zcash
This enables various RPC tests that use it (most of them in the extended test suite) to properly test Zcash code.
The PR also fixes bugs in the BIP65 and BIP66 tests that were both masking and masked by the un-migrated MiniNode.
The Python module `pyblake2` is now a requirement for the RPC tests.
Part of #2530 .
2017-10-16 08:43:58 -07:00
147fffb7ec
Fix bug where performance-measurements.sh fails hards when given no args
...
Better than "$1: unbound variable", we ran into this when testing this
script in the Hush repo, so we are pushing this fix upstream.
2017-10-16 08:39:59 -07:00
af549fe6ed
Auto merge of #2650 - str4d:2645-listunspent-benchmark, r=str4d
...
Add benchmark for listunspent
Closes #2645 .
2017-10-12 15:24:53 -07:00
94790c5d8f
Add memory benchmark for validatelargetx
2017-10-09 22:18:28 +01:00
c6af0aa453
Move check-security-hardening.sh into full_test_suite.py
2017-10-06 11:17:45 +01:00
105b2b6248
Move ensure-no-dot-so-in-depends.py into full_test_suite.py
2017-10-06 11:17:45 +01:00
aadf3aa159
Replace full-test-suite.sh with a new test suite driver script
...
This will be the canonical location for the entire Zcash merge test suite.
2017-10-06 11:17:11 +01:00
f8ef223ce3
Un-indent RPC test output in test runner
...
The indentation caused the test stdout to be buffered and only printed at the
end of the test, which makes it harder to diagnose hanging tests.
2017-10-05 15:18:58 +01:00
5455ca0d0e
Fix BIP65 and BIP66 tests
...
Blocks were being created that didn't satisfy the regtest consensus rules.
2017-10-05 15:18:54 +01:00
c10c40779d
[Test] MiniNode: Implement Zcash coinbase
2017-10-05 15:18:53 +01:00
7596a4922d
[Test] MiniNode: Coerce OP_PUSHDATA bytearrays to bytes
...
If a bytearray is passed in as part of an iterable, the CScript constructor
fails because b''.join() cannot be used to join a bytearray to a bytes or str in
Python 2.
2017-10-05 15:18:31 +01:00
643235859a
[Test] MiniNode: Fix coinbase creation
...
CScriptNum is only used for heights > 16.
2017-10-05 15:18:27 +01:00
e68c3ec188
[Test] MiniNode: Use Zcash PoW
...
Equihash solver code extracted from https://github.com/str4d/zcash-pow
RPC tests now require pyblake2 to be installed
2017-10-05 15:15:10 +01:00
0de9a481ab
[Test] MiniNode: Update protocol version and network magics
2017-10-05 15:15:10 +01:00
31bc3d2581
[Test] MiniNode: Implement Zcash block parsing
2017-10-05 15:15:10 +01:00
c47dc872a7
[Test] MiniNode: Implement v2 CTransaction parsing
2017-10-05 15:15:10 +01:00
13ca1e8011
[Test] MiniNode: Implement JSDescription parsing
2017-10-05 15:15:06 +01:00
99dd50c30c
Add benchmark for listunspent
...
Closes #2645 .
2017-10-04 12:48:50 +01:00
243b6a9d4b
Add connections in BIP65 and BIP66 tests to the test manager
...
Fixes a bug in the tests causing them to silently pass instead of correctly
reporting other errors. Introduced in 4a785b0a5b
2017-10-03 17:41:37 +01:00
e806f9c603
Auto merge of #2638 - bitcartel:2637_experimental_feature_z_shieldcoinbase, r=str4d
...
Closes #2637 . Make z_shieldcoinbase an experimental feature.
Can be enabled with: `zcashd -experimentalfeatures -zshieldcoinbase`
2017-09-27 16:09:54 -07:00
091c089d03
Fix incorrect failure in memory benchmark
2017-09-27 19:42:39 +01:00
72b4f0b3e6
Individualise performance-measurements.sh errors for debugging
2017-09-27 19:41:54 +01:00
5023af7bd5
Closes #2637 . Make z_shieldcoinbase an experimental feature where it
...
can be enabled with: zcashd -experimentalfeatures -zshieldcoinbase.
2017-09-27 10:43:54 -07:00
f897e075c2
Fix pyflakes warnings in RPC tests
2017-09-27 17:24:19 +01:00
f34c60de37
Auto merge of #2615 - bitcartel:2448_shield_coinbase, r=bitcartel
...
Add RPC command shield_coinbase #2448 .
Shield transparent coinbase funds by sending to a shielded z address. Closes #2448 .
2017-09-22 12:04:31 -07:00
06c19063bb
Implement RPC shield_coinbase #2448 .
2017-09-21 15:04:12 -07:00
8f16b27304
Auto merge of #2616 - nathan-at-least:importprivkey-shows-address.4, r=str4d
...
Importprivkey shows address
Scratching an itch: make `importprivkey` output the corresponding address.
Without this PR, `importprivkey` shows no output. Because we're moving towards an "address-based" RPC interface, rather than "account-based", there's a gap when using `importprivkey` because there's no way to assign it to a specific account, but also no easy way to determine the address. This change fixes that wart.
2017-09-21 14:29:03 -07:00
109fed51ff
Additional test cases for importprivkey RPC test
2017-09-21 22:21:44 +01:00
60b4a79000
Auto merge of #2620 - bitcartel:2583_watch_only_fspendable, r=str4d
...
Closes #2583 . Exclude watch-only utxos from coin selection.
2017-09-20 04:49:48 -07:00
5a0721f0fe
Set up a clean chain.
...
Delete redundant method wait_until_miner_sees() via use of sync_all().
2017-09-19 20:42:53 -07:00
b17e1b4080
Closes #2583 . Exclude watch-only utxos from z_sendmany coin selection.
2017-09-19 19:42:48 -07:00
2e8aefdce1
add load-wallet benchmark
2017-09-18 21:54:53 +02:00
3e92c028ce
Add a new requirement that `importprivkey` API is idempotent.
2017-09-18 15:30:42 +09:00
63cdea4233
Add a new rpc-test-specified requirement: `importprivkey` outputs the associated address. (Test fails.)
2017-09-18 15:30:42 +09:00
d29b6b042f
key_import_export rpc-test: verify that UTXO view co-evolves for nodes sharing a key.
2017-09-18 15:30:42 +09:00
e719bf75d4
Adjust instructions for UTXO dataset creation
...
--nocleanup is sufficient to leave the data directories behind. --noshutdown is
only useful if you want to inspect the nodes afterwards, and you'd need to
manually shut down both nodes before copying the data directories.
2017-09-11 21:53:35 +01:00
d669871e8b
Fix bug in benchmark data generation script
2017-09-06 19:52:35 +01:00
Daira Hopwood
Homu
Jack Grigg
Eirik Ogilvie-Wigley
zebambam
Eirik Ogilvie-Wigley
Larry Ruane
Dimitris Apostolou
Simon
mdr0id
Jonathan "Duke" Leto
arielgabizon
Jay Graber
Larry Ruane
Daniel Cousens
Duke Leto
mruddy
Jonas Schnelli
Pieter Wuille
James O'Beirne
Brad Miller
Matt Corallo
Per Grön
Ariel Gabizon
Nathan Wilcox