Kris Nuttycombe
fccf37844b
Fix pyflakes.
2020-07-02 16:54:49 -06:00
Homu
602e88ddb9
Auto merge of #4489 - therealyingtong:4479-remove-sprout-shielding, r=str4d
...
[ZIP 211] Disabling Addition of New Value to the Sprout Value Pool
Disables Sprout outputs after NU4 by checking for nonzero `vpub_old` in transactions after NU4 activation height.
Adds gtests to check expected behaviour before and after NU4 activation height.
edit:
Also modifies `z_` methods in `rpcwallet`, and adds a matching RPC test.
Implements [ZIP 211](https://zips.z.cash/zip-0211 ), closes #4479
2020-07-02 21:53:51 +00:00
Larry Ruane
bf568273a7
fix pyflakes CI errors
2020-07-02 14:32:48 -06:00
Kris Nuttycombe
4d223f9797
Merge remote-tracking branch 'upstream/master' into zip-207
2020-07-02 13:24:45 -06:00
Sean Bowe
14a09a5fd6
Remove unused imports from remove_sprout_shielding RPC test.
2020-07-02 11:09:22 -06:00
therealyingtong
f24e706079
Replace leadByte in SaplingNote with is_zip_212
2020-07-02 15:37:32 +08:00
Larry Ruane
5b7fed5bbf
self.sync_all(), not time.sleep(4)
2020-07-01 10:28:15 -06:00
Kris Nuttycombe
7dd1889944
Trivial copyright fix.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-07-02 00:27:18 +08:00
therealyingtong
5e4d13b49d
Add RPC tests
...
Test that Sprout shielding is accepted before Canopy and rejected after Canopy activation
2020-07-02 00:27:14 +08:00
Rod Vagg
a106c15a19
Add joinSplitPubKey and joinSplitSig to RPC
...
These two properties are required to fully reconstruct a Zcash
transaction's binary form from the RPC data.
Co-authored-by: str4d <thestr4d@gmail.com>
2020-06-30 21:47:51 +10:00
Kris Nuttycombe
92cec200ee
Minor fixes for ZIP-207 review comments.
2020-06-29 16:13:08 -06:00
Jack Grigg
efd04b920b
Implement zip-207 and zip-214.
...
Add funding streams to consensus parameters.
Add funding stream payments to coinbase txns generated by the miner.
* Reduce valueBalance for shielded outputs to funding streams.
* Ensure we produce binding signatures in any case where shielded
outputs go to either a funding stream or the miner.
2020-06-25 16:15:50 -06:00
Taylor Hornby
75876f477b
Implement system for postponing dependency updates.
2020-06-24 18:14:47 -06:00
Larry Ruane
6335944784
add python test to reproduce bug 4301
2020-06-24 09:27:11 -06:00
Homu
552482a404
Auto merge of #3913 - str4d:smoke-tests, r=str4d
...
Automated smoke tests
Usage:
```
ZCASHD=./src/zcashd ZCASHCLI=./src/zcash-cli ./qa/zcash/smoke_tests.py --wallet=wallet.smoketest.dat "$HOME/.zcash"
```
Includes code cherry-picked from bitcoin/bitcoin#7751 .
2020-06-04 22:17:48 +00:00
Homu
4ffccda774
Auto merge of #4322 - oxarbitrage:issue3740, r=str4d
...
Add -debuglogfile option
Cherry-picked from https://github.com/bitcoin/bitcoin/pull/11781 .
Closes https://github.com/zcash/zcash/issues/3740 .
2020-06-04 00:40:45 +00:00
Homu
e9a6d7926b
Auto merge of #4282 - oxarbitrage:issue2375, r=daira
...
Add a flag to get amount results as integer
Closes https://github.com/zcash/zcash/issues/2375
2020-06-03 11:26:00 +00:00
Daira Hopwood
270a724c87
Remove unused import in qa/rpc-tests/listtransactions.py
...
Co-authored-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2020-06-03 12:25:31 +01:00
Alfredo Garcia
93afebeef4
add new parameters to rpc client and fix some bugs
2020-05-30 12:18:43 -03:00
Alfredo Garcia
e7c829aa0e
update docs
2020-05-30 10:34:03 -03:00
Alfredo Garcia
76cb4e8d04
remove not needed comments from wallet.py
2020-05-29 11:24:39 -03:00
Daira Hopwood
1527e5b3ca
Missing NU4->Canopy renames.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-05-29 10:02:50 +01:00
Daira Hopwood
22b8574d9e
Rename golden/nu4.tar.gz to canopy.tar.gz.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-05-29 01:30:30 +01:00
Alfredo Garcia
7c84f4e98a
fix test cases
2020-05-28 10:58:04 -03:00
Anthony Towns
83087be393
test: Add tests for `-debuglogfile` with subdirs
2020-05-28 10:58:04 -03:00
Wladimir J. van der Laan
4de0ac3351
test: Add test for `-debuglogfile`
2020-05-28 10:58:04 -03:00
Daira Hopwood
c1227ae67c
Rename NU4 to Canopy in constant and function names.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-05-28 13:11:48 +01:00
Jack Grigg
5a577c7630
qa: Add --automate flag to smoke tests
2020-05-28 23:04:58 +12:00
Jack Grigg
4498eb26db
qa: Remove unused timeout configuration from wait_for_balance
2020-05-28 23:04:58 +12:00
Jack Grigg
c2144f7af7
qa: Add --use-faucet flag to smoke tests
2020-05-28 23:04:58 +12:00
mdr0id
a63c1d6279
Add helpers for tapping and donating to the testnet faucet
2020-05-28 19:10:32 +12:00
Eirik Ogilvie-Wigley
b21fcf37cb
Various improvements
...
- Print time since start for each operation
- Print traceback for any raised exceptions
- Improve messages to user
- Warning cleanups
2020-05-28 19:01:52 +12:00
Eirik Ogilvie-Wigley
aa4b98a7c3
Resolve decimal vs float issues
2020-05-28 18:59:20 +12:00
Homu
9bf8443c16
Auto merge of #4504 - str4d:disconnectblock-fixes, r=str4d
...
Use the cached consensusBranchId in DisconnectBlock
If a node is started with a set of network upgrades that don't match the
serialized chain (such as when we implement NU rollbacks on testnet),
RewindBlockIndex will disconnect each block in the chain until it
reaches the most recent block that agrees with the node's set of network
upgrades. However, the blocks themselves should be disconnected using
the consensus branch ID that they were connected with, which is
persisted alongside the chain and reconstructed in LoadBlockIndex.
2020-05-28 02:51:34 +00:00
Jack Grigg
a2db35137b
qa: Improve reliability of smoke test cleanup
2020-05-28 13:15:55 +12:00
Jack Grigg
a2ba414d69
qa: Improve reliability of smoke tests
2020-05-28 13:15:55 +12:00
Jack Grigg
0261ccbbe8
qa: Don't allow smoke tests with mainnet wallet.dat
2020-05-28 13:15:55 +12:00
Jack Grigg
a6ff0a0794
qa: Use slick-bitcoinrpc for smoke tests
2020-05-28 13:15:55 +12:00
Jack Grigg
eeecb3bf8c
qa: Transaction chain smoke test
2020-05-28 13:15:55 +12:00
Jack Grigg
01757cff23
qa: Simple smoke tests
2020-05-28 13:15:55 +12:00
Jack Grigg
6d1563d7a3
qa: Run Zcash node for smoke tests
2020-05-28 13:15:55 +12:00
Jack Grigg
6470237c09
qa: Smoke test driver
2020-05-28 13:15:55 +12:00
Homu
4907a31302
Auto merge of #4242 - oxarbitrage:issue3726, r=str4d
...
Add estimatedheight to rpc getblockchaininfo response
Fixes https://github.com/zcash/zcash/issues/3726
Ported from https://github.com/zcash/zcash/pull/3727 with comments addressed.
2020-05-28 00:49:49 +00:00
therealyingtong
06ddf659a7
Add RPC tests for post-Heartwood rollback
2020-05-28 09:54:42 +12:00
Alfredo Garcia
d42e0a433c
remove additional not needed casts from py tests
2020-05-18 18:09:07 -03:00
Alfredo Garcia
26e4889f87
Fix casting in listtransactions.py
2020-05-18 16:53:01 -03:00
Alfredo Garcia
24d3516e35
Fix casting in wallet.py
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-05-18 16:53:01 -03:00
Alfredo Garcia
25bccb4814
replace with AssertionError assert_equal in receivedby.py
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-05-18 16:53:01 -03:00
Alfredo Garcia
25f48c21dd
add amountZat field to z_listreceivedbyaddress
2020-05-18 16:53:01 -03:00
Alfredo Garcia
76e7f21d4a
add amountZat field to listunspent
2020-05-18 16:52:04 -03:00
Alfredo Garcia
9a55c8b238
add amountZat field to listtransactions, gettransaction and listsinceblock
2020-05-18 16:51:24 -03:00
Alfredo Garcia
2ec9ac3c81
add amountZat field to listreceivedbyaddress and listreceivedbyaccount
2020-05-18 16:49:39 -03:00
Alfredo Garcia
306270911e
add boolean inZat to z_getbalance
2020-05-18 16:47:17 -03:00
Alfredo Garcia
50372cab62
add boolean inZat to getbalance
2020-05-18 16:47:17 -03:00
Alfredo Garcia
d2c26b33e0
add boolean inZat to getreceivedbyaccount
2020-05-18 16:47:17 -03:00
Alfredo Garcia
4b61aede28
add bool argument to get balance in satoshis to rpc getreceivedbyaddress
2020-05-18 16:47:17 -03:00
Kris Nuttycombe
6a0d464f41
Merge remote-tracking branch 'upstream/master' into hotfix-v2.1.2-2-golden
2020-05-18 11:22:22 -06:00
Kris Nuttycombe
04d82fa30f
Remove unused imports.
2020-05-18 10:38:37 -06:00
Taylor Hornby
e0ab57ee36
Add univalue to updatecheck.py and update univalue, removing calls to deprecated methods
2020-05-14 12:42:19 -06:00
Sean Bowe
43ffa3bf43
Add NU4 activation to golden test.
2020-05-14 12:24:56 -06:00
Kris Nuttycombe
9061f8251e
Merge remote-tracking branch 'upstream/master' into hotfix-v2.1.2-2-golden
2020-05-14 12:24:44 -06:00
Kris Nuttycombe
a2898a84f4
Fully remove the regtest tree from restored nodes.
2020-05-08 10:36:04 -06:00
Kris Nuttycombe
76a88dab52
Update golden test for heartwood network upgrade.
2020-05-07 19:12:24 -06:00
Kris Nuttycombe
8542522732
Merge branch 'release/v2.1.1-1' into release/v2.1.2
2020-05-07 19:02:45 -06:00
Kris Nuttycombe
a546caffc9
Add baseline for golden testing across network upgrade boundaries.
2020-05-07 16:34:44 -06:00
Kris Nuttycombe
35ff8d9bf2
Remove unused imports.
2020-05-05 11:41:06 -06:00
Kris Nuttycombe
45dab9adc0
Revert "Update qa/rpc-tests/sapling_rewind_check.py"
...
This reverts commit e09f052570
.
2020-05-04 16:57:48 -06:00
Kris Nuttycombe
ae86386648
Update test description and clarify internal comments.
2020-05-04 10:55:32 -06:00
Kris Nuttycombe
6742ba021f
Add Zcash copyright to sapling_rewind_check.py
2020-05-02 18:33:58 -06:00
Kris Nuttycombe
e09f052570
Update qa/rpc-tests/sapling_rewind_check.py
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-05-02 18:33:01 -06:00
Kris Nuttycombe
e7eff424c1
Update qa/rpc-tests/test_framework/mininode.py
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-05-02 18:31:26 -06:00
Kris Nuttycombe
2de5a2cb2d
Use `%x` formatter for branch id hex string in test_framework/util.py
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-05-02 18:31:13 -06:00
Kris Nuttycombe
c2e3454e0a
Clean up imports in sapling_rewind_check.py
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-05-02 18:30:09 -06:00
Kris Nuttycombe
1508345a20
Merge remote-tracking branch 'upstream/master' into bug/4119-rewind_detection
2020-05-01 17:33:53 -06:00
Jack Grigg
7e684120d3
Add NU4 test helpers
2020-05-01 11:38:32 +12:00
Alfredo Garcia
4c40f9f514
implement z_getnotescount api call
2020-04-25 11:17:20 -03:00
Homu
0ad52ca9b1
Auto merge of #4249 - oxarbitrage:issue_3724, r=str4d
...
Add confirmations, blockheight, blockindex and blocktime to z_listreceivedbyaddress
Fixes https://github.com/zcash/zcash/issues/3724
1- There was a PR to add confirmations to this call at https://github.com/zcash/zcash/pull/3836
I ported the commit from there and fixed test case by incrementing the confirmations as suggested at: https://github.com/zcash/zcash/pull/3836#issuecomment-499927807
2- Then added `blockheight`, `blockindex` and `blocktime`. To avoid some duplicated code (Sprout/Sapling) created a structure `trxblock`.
3- Original issue requests only time and blockindex however i think height is also important; if `blockindex` is the position of the transaction in the block then you are going to need also `height` to find it.
2020-04-25 05:28:16 +00:00
Kris Nuttycombe
5a8f6f8058
Merge remote-tracking branch 'upstream/master' into bug/4119-rewind_detection
2020-04-22 14:58:11 -06:00
Kris Nuttycombe
7629560a26
Trivial comment.
2020-04-15 16:09:19 -06:00
Kris Nuttycombe
a4e80ae1ab
Restart node in a chain split state to allow the test to complete.
2020-04-15 15:58:48 -06:00
Kris Nuttycombe
5030e73afc
Make the test reproduce the actual off-by-one error in rewind length.
2020-04-15 14:19:05 -06:00
Alfredo Garcia
a1c37b7b79
Fix typo
...
Co-Authored-By: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2020-04-15 15:46:49 -03:00
Dimitris Apostolou
5f2e015aa3
Fix typos
2020-04-15 13:24:00 +03:00
Kris Nuttycombe
59d2a6458d
Narrow down the test case.
2020-04-14 17:47:29 -06:00
Alfredo Garcia
8a40b8518a
fix wallet nullifiers test
2020-04-14 17:11:20 -03:00
Homu
084303d8c2
Auto merge of #4264 - NikVolf:mmr, r=str4d
...
[ZIP 221] FlyClient - Consensus-Layer Changes
Implements https://zips.z.cash/zip-0221
2020-04-14 20:09:34 +00:00
Kris Nuttycombe
a4e8945cfa
Check network reunification.
2020-04-14 13:52:50 -06:00
Kris Nuttycombe
f432ceff31
Add a test reproducing the off-by-one error.
2020-04-14 13:37:40 -06:00
Jack Grigg
e85fac5167
test: Ignore timestamps in addressindex checks
...
The mempool timestamps are local to each node, and if the testing
machine is under load, they can potentially differ by a second.
Closes zcash/zcash#4439 .
Co-authored-by: Ying Tong <yingtong@ethereum.org>
2020-04-14 20:56:37 +12:00
Jack Grigg
21d8e5be15
Comment clarifications and fixes
2020-04-11 11:39:00 +12:00
Jack Grigg
9cfd574eac
test: Add an extra assertion to feature_zip221.py
2020-04-10 19:47:45 +12:00
Homu
3033b8a0ec
Auto merge of #4402 - oxarbitrage:issue4326, r=str4d
...
Add -lightwalletd experimental option
Similar to `-insightexplorer` but loading less indexes.
After testing and code review this should be able to close https://github.com/zcash/zcash/issues/4326
2020-04-10 03:42:54 +00:00
Homu
780554e53a
Auto merge of #4426 - oxarbitrage:issue4372, r=str4d
...
Return address info in z_importviewingkey
Closes https://github.com/zcash/zcash/issues/4372
2020-04-10 00:20:40 +00:00
Jack Grigg
2ad84e8564
Comment tweaks and cleanups
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-04-10 09:53:30 +12:00
Alfredo Garcia
a43f5daff8
add -lightwalletd experimental option
2020-04-09 11:05:21 -03:00
Jack Grigg
eca5009825
test: Build Rust tests as part of qa/zcash/full_test_suite.py
...
The previous version of full_test_suite.py directly called the test
binary, which was being compiled at the same time as the static library.
However, by passing the --tests argument to cargo, rustc was ignoring
several important release-profile configurations, and was also
attempting to link the test binary, which was breaking cross-compilation
builds.
This commit alters src/Makefile.am to only build the static library, and
leaves test compilation to the test runner itself. This ensures that the
tests are only compiled for native builds, when the tests will be run on
the same platform.
2020-04-08 18:17:19 +12:00
Jack Grigg
cb57c17eb6
test: Verify ZIP 221 logic against reference implementation
2020-04-08 08:49:01 +12:00
Alfredo Garcia
de5b69f160
add expected address check to tests
2020-04-07 10:39:33 -03:00
Alfredo Garcia
0a6ab8a5ab
return address info in z_importviewingkey
2020-04-07 08:38:12 -03:00
Homu
1be7250db9
Auto merge of #4411 - str4d:2074-rpc-test-harness-1, r=mdr0id
...
Backport RPC test harness PRs
Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6548
- https://github.com/bitcoin/bitcoin/pull/6804
- Just the coverage backend, not the flag to enable it for all RPC tests.
- https://github.com/bitcoin/bitcoin/pull/7744
- https://github.com/bitcoin/bitcoin/pull/9832
- Excludes `wallet-hd.py` change (missing bitcoin/bitcoin#8309).
Part of #2074 .
2020-04-03 03:14:04 +00:00