zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
9,764 Commits 27 Branches 108 Tags 109 MiB
Commit Graph

9764 Commits

Author SHA1 Message Date
Jack Grigg 8c54e34a68
Use tromp's solver to regenerate miner tests 
When using, comment out tromp's solver in miner.cpp to avoid linker errors.
 2016-10-22 00:52:56 -05:00
Jack Grigg 6be6762237
Regenerate genesis blocks with nVersion = 4 
Includes parts of #1554
 2016-10-22 00:52:45 -05:00
Jack Grigg 80f4cdcf8f
Reject block versions lower than 4 
Closes #1556
 2016-10-22 00:43:26 -05:00
Jack Grigg 7ac924cdb7
Disallow v0 transactions as a consensus rule 
Closes #1557
 2016-10-22 00:40:50 -05:00
zkbot a12eaa2bf2 Auto merge of #1581 - bitcartel:1464_ncc_2016_008, r=str4d 
Fixes for NCC-2016-008

To close #1464 NCC-2016-088

- This PR
- https://github.com/zcash/libsnark/pull/8

Of the 101 issues in NCC-2016-088, 62 are in dependencies, and many of the remainder are duplicates of the CIDs fixed in this PR.

Commit log message is: CID Type (Type is from scan.coverity Type column)
 2016-10-22 00:56:08 -04:00
Simon e11e61ddb1 Workaround g++ 5.x bug with brace enclosed initializer. 
http://stackoverflow.com/questions/32912921/whats-wrong-with-this-inline-initialization-of-stdarray/32912976#32912976
 2016-10-21 21:50:25 -07:00
Jack Grigg 07064ea2d1
GBT: Add RPC tests 2016-10-21 23:38:37 -05:00
Jack Grigg 1628efedaf
GBT: Correct block header in proposals RPC test 2016-10-21 23:36:35 -05:00
Jack Grigg 89aa746ca1
GBT: Add informational founders' reward value to coinbasetxn 2016-10-21 23:36:04 -05:00
Jack Grigg 53ddbaed16
GBT: Support coinbasetxn instead of coinbasevalue 
Once a Zcash GBT spec has been written, we can re-enable coinbasevalue.
 2016-10-21 23:32:24 -05:00
zkbot 48888b67c9 Auto merge of #1599 - daira:1597.fix-other-potential-race-conditions, r=daira 
Fix other potential race conditions similar to ref #1597 in RPC tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-22 00:15:32 -04:00
Jack Grigg 09864abc55
Revert "Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459"" 
This reverts commit f19cb7b7ee.
 2016-10-21 23:14:00 -05:00
zkbot 7ccbcca62c Auto merge of #1591 - bitcartel:upstream_7933_fix_out_of_memory_deserializing_utxo, r=daira 
Upstream: fix out of memory problem when deserializing utxo

bitcoin/bitcoin#7933
 2016-10-21 23:32:51 -04:00
zkbot f808be7546 Auto merge of #1589 - bitcartel:upstream_7856_one_getaddr_per_connection, r=daira 
Upstream: Only send one GetAddr response per connection.

bitcoin/bitcoin#8427
 2016-10-21 22:53:19 -04:00
zkbot 71043784dd Auto merge of #1586 - bitcartel:z_sendmany_amount_too_strict, r=daira 
Fix issue where z_sendmany amount parameter is too strict

Upstream treats an amount parameter of `1` the same as `1.0`.  Third-party would like this fixed.
 2016-10-21 22:10:41 -04:00
zkbot fd7ef7b632 Auto merge of #1584 - bitcartel:1504_zca_011_logging, r=daira 
More granular control over logging of z_* calls

Closes #1504
 2016-10-21 21:32:46 -04:00
zkbot 10ad093bbb Auto merge of #1567 - str4d:rename-binaries, r=daira 
Rename binaries

This ensures that our installs don't clash with existing Bitcoin binaries and libraries.

Closes #1563 and #1565
 2016-10-21 20:48:11 -04:00
Daira Hopwood deba66ca55 Fix other potential race conditions similar to ref #1597 in RPC tests. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-22 00:37:14 +01:00
zkbot dc21a8a39f Auto merge of #1578 - daira:1570.tromp-equihash-with-libsodium-blake.2, r=daira 
1570.tromp equihash with libsodium blake.2

Remove BLAKE2b implementation from Tromp Equihash solver, and address almost all of @str4d's review comments on #1570. Supercedes #1576.

Signed-off-by: Daira Hopwood daira@jacaranda.org
 2016-10-21 19:07:26 -04:00
Daira Hopwood f0f838f081 Fix race condition in rpc-tests/wallet_protectcoinbase.py. closes #1597 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-21 17:20:36 +01:00
zkbot cd8e856df7 Auto merge of #1585 - bitcartel:1583_stop_test_writing_to_testnet3, r=daira 
Closes #1583 by setting up the datadir for the wallet gtest.

Stops test writing to ~/.zcash/testnet3.
Also related to #1506
 2016-10-21 03:15:00 -04:00
Simon 43f0769cf6 Fix build problem with coins_tests 2016-10-20 23:50:19 -07:00
Pieter Wuille abd22bb674 Add tests for CCoins deserialization 2016-10-20 22:59:50 -07:00
Patrick Strateman e9d221e764 CDataStream::ignore Throw exception instead of assert on negative nSize. 
Previously disk corruption would cause an assert instead of an exception.
 2016-10-20 22:59:50 -07:00
Pieter Wuille f588c5edd6 Fix OOM bug: UTXO entries with invalid script length 2016-10-20 22:59:50 -07:00
Pieter Wuille 6fc5764eda Treat overly long scriptPubKeys as unspendable 2016-10-20 22:59:50 -07:00
Pieter Wuille 4c6ea562bd Introduce constant for maximum CScript length 2016-10-20 22:59:50 -07:00
zkbot c99a1c7e4f Auto merge of #1566 - daira:1557.make-v2-txns-standard, r=ageis 
1557.make v2 txns standard

Make v2 transactions standard. This also corrects a rule about admitting large orphan transactions into the mempool, to account for v2-specific fields. ref #1557
 2016-10-21 01:10:37 -04:00
zkbot 323b8214c2 Auto merge of #1580 - str4d:1378-repair-witness-cache, r=daira 
Clear witness cache when re-witnessing notes

Closes #1378
 2016-10-21 00:24:39 -04:00
Gregory Maxwell a514cb2968 Only send one GetAddr response per connection. 
This conserves resources from abusive peers that just send
 getaddr in a loop. Also makes correlating addr messages
 against INVs less effective.
 2016-10-20 20:30:53 -07:00
Wladimir J. van der Laan e496b2e391 net: Ignore `notfound` P2P messages 2016-10-20 20:22:34 -07:00
Daira Hopwood f19cb7b7ee Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459" 
This reverts commit a652e4183e.
 2016-10-21 03:14:40 +01:00
Daira Hopwood 5d985da5c1 Repair check-security-hardening.sh. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-21 02:34:13 +01:00
Simon 5eed758493 Update test to use integer amount as well as decimal amount when calling z_sendmany 2016-10-20 17:10:25 -07:00
Simon 75407c6872 Fix issue where z_sendmany is too strict and does not allow integer based amount e.g. 1 which is the same as 1.0 2016-10-20 17:03:57 -07:00
zkbot 78293a9989 Auto merge of #1575 - arcalinea:document-rpc-security, r=daira 
Document RPC security assumptions

Document RPC security assumptions in security-warnings.md #965
 2016-10-20 19:50:47 -04:00
Simon ffd2cb3437 Closes #1583 by setting up the datadir for the wallet gtest. 2016-10-20 16:45:02 -07:00
Simon 446f867b4c Add debug option "zrpcunsafe" to be used when logging more sensitive information such as the memo field of a note. 2016-10-20 15:24:31 -07:00
Simon e7b1f312f5 Add security warning about logging of z_* calls. 2016-10-20 15:24:31 -07:00
zkbot 90031e1d61 Auto merge of #1577 - radix42:v1.0.0-rc1-gitian, r=daira 
V1.0.0 rc1 gitian

Removes indeterminism from gitian builds: underlying processor instruction set variant of x86_64 was being detected by the libgmp autoconf process, which caused differences in libgmp and libsnark
 2016-10-20 17:40:27 -04:00
zkbot f90526579b Auto merge of #1569 - str4d:1552-disable-wallet-encryption, r=daira 
Disable wallet encryption

Closes #1552
 2016-10-20 17:01:51 -04:00
Daira Hopwood 5f0009b2d2 Assert that the Equihash solver is a supported option. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-20 21:17:34 +01:00
Daira Hopwood f91bbeedb7 Add help for -equihashsolver= option. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-20 21:17:02 +01:00
Jack Grigg d8e06e3f58
Add test that encryptwallet is disabled 2016-10-20 14:45:44 -05:00
zkbot bb891cb4a2 Auto merge of #1571 - daira:1459.avoid-boost-posix-time, r=daira 
Avoid boost::posix_time functions that have potential out-of-bounds read bugs

ref #1459

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-20 15:42:23 -04:00
Jack Grigg 2b499f4386
Fix RPC tests that require wallet encryption 2016-10-20 14:35:41 -05:00
Simon ccc0f9af42 Fixes CID 1352714 uninitialized scalar variable. 2016-10-20 11:41:28 -07:00
Jack Grigg 8ecf6ccfef
Improve security documentation 2016-10-20 13:41:00 -05:00
Simon fed6c83ccf Fixes CID 1352727 uninitialized scalar variable. 2016-10-20 11:40:22 -07:00
Simon 351b38fd5b Fixes CID 1352599 unitialized scalar variable 2016-10-20 11:35:51 -07:00