Kris Nuttycombe
7cd4462b20
Merge pull request #5695 from str4d/5694-gitian-fix
...
build: Fix `zcash/address/orchard.hpp` filename in `src/Makefile.am`
2022-03-17 16:30:33 -06:00
Jack Grigg
22c6bf88a3
build: Fix `zcash/address/orchard.hpp` filename in `src/Makefile.am`
...
The incorrect extension caused `make distdir-am` to fail due to a
missing rule for the header file.
Closes zcash/zcash#5694 .
2022-03-17 19:38:10 +00:00
sasha
2dcaac5fcb
Merge pull request #5574 from daira/zcashd-wallet-tool
...
Make a zcashd-wallet-tool executable
2022-03-15 13:41:55 -07:00
sasha
3a957618b6
Merge pull request #5662 from nuttycom/legacy_seed_to_mnemonic
...
Derive the mnemonic seed from the legacy HD seed, if one is available.
2022-03-14 20:32:09 -07:00
sasha
7071b41c55
Merge pull request #5578 from superbaud/powlimit-document
...
comment explaining the 0x0f0f[..]0f0f powLimit constant for regtest
2022-03-14 18:47:04 -07:00
sasha
f37d186e7e
Merge pull request #5600 from superbaud/use-debian-libtinfo
...
remove superfluous space at end of native_packages that i introduced in #5576
2022-03-14 17:06:53 -07:00
Kris Nuttycombe
e335ff2325
Fix indentation.
2022-03-14 17:40:10 -06:00
Kris Nuttycombe
d420e2efab
Derive the new mnemonic seed from the legacy HD seed, if one is available.
...
Fixes #5572
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-14 17:40:04 -06:00
Daira Hopwood
4611493c9d
Merge pull request #5663 from nuttycom/check_master_key_validity
...
Return std::optional<CExtKey> from CExtKey::Master
2022-03-14 17:10:24 +00:00
Daira Hopwood
340840894a
Tweaks to message text.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-14 08:24:25 +00:00
Daira Hopwood
6ee6692c83
qa/zcash/full_test_suite.py: enable `test_rpath_runpath` for Rust binaries, and
...
reenable `test_fortify_source` for C++ binaries.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-14 08:05:59 +00:00
Daira Hopwood
1d31d4bc7c
Include $(bin_SCRIPTS) in `check-symbols`, `check-security`, and `clean` targets.
...
Checking for stack canaries in `check-security` is disabled for Rust executables
(Rust does support `-Z stack-protector=all` but only for the nightly compiler).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-13 22:53:29 +00:00
Daira Hopwood
55d14faebf
Correct the fallback instruction for how to clear the terminal on macOS: pressing Command + K
...
also clears scrollback.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-13 18:25:40 +00:00
Daira Hopwood
ccada66324
Simplify debug tracing.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-12 12:56:32 +00:00
Kris Nuttycombe
0c38ad9200
Return std::optional<CExtKey> from CExtKey::Master
...
Master key generation is fallible, but the type of master
key generation did not previously reflect that the generated
key might be invalid.
2022-03-11 18:47:01 -07:00
Daira Hopwood
577f695af5
Set `meta` for `-datadir` option.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 19:02:31 +00:00
Daira Hopwood
3e36252d9a
Document that '~' cannot be used in `-datadir` (see #5661 ).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 18:35:52 +00:00
Daira Hopwood
d5b6e226f0
Ensure the buffer used in `prompt` is zeroized even on error.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 18:21:11 +00:00
Daira Hopwood
7a98644ff2
Improve error message when the config file cannot be found, taking into account -conf and -datadir.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 18:16:40 +00:00
Daira Hopwood
cb2c89eedf
Use the tracing crate for debugging.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 17:17:56 +00:00
Daira Hopwood
f6a8461047
Merge pull request #5636 from superbaud/lazy-load-parameters
...
only load the proof parameters in gtests for tests that need them
2022-03-10 18:11:09 +00:00
Daira Hopwood
799b46b90a
Cleanups to error handling for the first invocation of zcash-cli.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-10 17:18:26 +00:00
Daira Hopwood
999b395360
Improve memory hygiene, and use -stdin to pass the recovery phrase to the child zcash-cli process.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-10 17:17:06 +00:00
Daira Hopwood
d4405feddf
Simplify extraction of recovery phrase.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-09 18:04:27 +00:00
Charlie O'Keefe
4f04c96f7b
Merge pull request #5632 from steven-ecc/z_sendmany_uniqueness_check
...
Extend uniqueness check in z_sendmany to UA receivers
2022-03-07 21:56:49 -07:00
Kris Nuttycombe
f7006e9a33
Merge pull request #5592 from superbaud/gtest-ordering-fixes
...
fix ordering issues with gtests: WalletZkeysTest, ContextualCheckBlockTest, CheckBlock, Metrics.GetLocalSolPS
2022-03-07 18:54:16 -07:00
Daira Hopwood
9b20105413
Tweak the wording of the fallback messages when the terminal cannot be automatically cleared.
...
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 19:34:31 +00:00
Daira Hopwood
6fb943d0f6
Refactor use of `export_path` as suggested.
...
Co-authored-by: Sean Bowe <sean@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 19:33:27 +00:00
Daira Hopwood
e940829313
The recovery phrase confirmation and `zcashd-wallet-tool` are being introduced in zcashd v4.7.0.
...
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 19:32:51 +00:00
Daira Hopwood
6f5efcbb0f
Improved error handling.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
25792cba93
Move `wallet_tool.rs` from `src/rust/src` into `src/rust/bin`.
...
Also add a brief description of `zcashd-wallet-tool` to `src/rust/README.md`.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
8ec0d854b9
Add some text about choosing location of the physical backup.
...
Add TODO for better handling of file not found and permission errors.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
de933c1cb5
Attempt to fix linking problem on ARM.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
a36fceca70
Make a zcashd-wallet-tool executable.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Steven Smith
7f7d9e6e1f
Extend uniqueness check in z_sendmany to UA receivers
2022-03-06 21:24:14 -08:00
sasha
f1d652fc78
Call LoadProofParameters() in gtests that need proofs
2022-03-05 21:51:27 -08:00
sasha
8f68166c24
move proof parameter loading out of gtest/main.cpp and into utiltest.cpp
2022-03-05 21:51:27 -08:00
sasha
0e6b004a64
make librustzcash_init_zksnark_params idempotent
2022-03-05 21:51:27 -08:00
str4d
13351ff31d
Merge pull request #5609 from str4d/bump-deps-4.7.0-rc1
...
Bump dependencies ahead of 4.7.0-rc1
2022-03-05 13:37:28 +00:00
Jack Grigg
fdb5709e7e
depends: Revert to `libc++ 13.0.0-3` for Windows cross-compile
...
The 13.0.1-1 MSYS2 binaries cause linker errors due to missing `new` and
`delete` symbols. This commit partially reverts the LLVM 13.0.1 upgrade:
Windows cross-compilation still uses `clang 13.0.1`, but is compiled
against `libc++ 13.0.0`.
2022-03-05 03:53:13 +00:00
Charlie O'Keefe
e33178615c
Merge pull request #5581 from LarryRuane/2022-02-log-getblocktemplate
...
Log calls to getblocktemplate
2022-03-03 15:56:34 -07:00
Charlie O'Keefe
c2b5bf0c42
Merge pull request #5622 from nuttycom/logging/sapling_note_witnesses
...
Log outpoint for failed Sapling witness lookup.
2022-03-03 15:21:10 -07:00
str4d
d4a019e89b
Merge pull request #5621 from nuttycom/test/orchard_tree_ser_roundtrip
...
Add a roundtrip test for Orchard merkle frontier serialization from the C++ side.
2022-03-03 21:56:41 +00:00
Kris Nuttycombe
8b44cc7072
Add a roundtrip test for Orchard merkle frontier serialization from the C++ side.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-03-03 11:04:40 -07:00
Kris Nuttycombe
ceff068e20
Merge pull request #5625 from therealyingtong/orchard-remove-with-anchor
...
Orchard: invalidate mempool transactions that use orphaned anchors.
2022-03-03 10:58:08 -07:00
Daira Hopwood
5990853de3
Merge pull request #5623 from str4d/nu5-fix-orchard-commitment-tree-bugs
...
Fix for chain forks on NU5 testnet
2022-03-03 15:21:58 +00:00
Kris Nuttycombe
fd2f5bdc28
Merge pull request #5610 from therealyingtong/debug-any-taddr
...
Ignore expired transactions in `CWallet::FindSpendableInputs`.
2022-03-03 08:08:06 -07:00
Jack Grigg
ae3d2a3525
Add missing `view.PopAnchor(_, ORCHARD)` in `DisconnectBlock`
...
By forgetting to pop the tree, we were leaving the view in an
inconsistent state, where it believed the best Orchard anchor was for a
tree that didn't correspond to the rest of the view. This would then
propagate in subsequent block connections, and the chain history
commitments to Orchard tree roots eventually result in inconsistent
`blockcommitments` values in subsequent blocks.
2022-03-03 13:26:48 +00:00
Jack Grigg
2230ba912f
Ensure the view's best Orchard anchor matches the previous block
...
`ConnectBlock` was already checking that the given view's "best block"
was the previous block. However, it then assumed the view was correct on
its claimed best anchors.
For Orchard, we know that `hashFinalOrchardRoot` field of `CBlockIndex`
will only ever be set when a block is (attempted to be) connected to the
main chain, and so we can instead add assertions around its value and
ensure the view is consistent with the previous block.
2022-03-03 13:26:48 +00:00
therealyingtong
dbb7e027c8
Orchard: invalidate mempool transactions that use orphaned anchors.
2022-03-03 17:37:07 +08:00