Commit Graph

10083 Commits

Author SHA1 Message Date
Sean Bowe 226a6b3248 Initialize after profiling messages are suppressed. 2016-11-14 10:19:46 -07:00
Sean Bowe d92bea9888 Add tests for witness `element` and tree `last` methods. Strengthen testing by inserting a different commitment into the tree at each step. 2016-11-14 10:13:06 -07:00
zkbot 28d635c8b7 Auto merge of #1838 - bitcartel:1833_z_sendmany_error_message_formatting, r=ebfull
Closes #1833.  Format currency amounts in z_sendmany error message.

Improve coverage of possible error states from z_sendmany.
Refactor qa test for z_sendmany operations.
2016-11-13 03:05:30 +00:00
Jay Graber c246c1ea3c Replace bitcoin with zcash in rpcprotocol.cpp 2016-11-11 15:24:36 -08:00
Jay Graber 59ac34e344 s/Bitcoin/Zcash in JSONRPCError 2016-11-11 11:14:18 -08:00
Jay Graber d25e75c512 Document z_sendmany error code messages in payment-api.md 2016-11-10 21:24:43 -08:00
Simon 9384e74c50 Closes #1833. Format currency amounts in z_sendmany error message.
Improve coverage of possible error states from z_sendmany.
Refactor qa test for z_sendmany operations.
2016-11-10 16:57:36 -08:00
zkbot 3a0855e65a Auto merge of #1806 - str4d:1787-enable-tests-flag, r=ebfull
Add --disable-tests flag to zcutils/build.sh

Closes #1787
2016-11-09 17:33:56 +00:00
ayleph 48f9c65b55 Correct spelling error in z_sendmany error output
Change "alllowed" -> "allowed."
2016-11-08 13:13:48 -08:00
Sean Bowe 996fccf267 1.0.2 release. 2016-11-07 19:03:20 -07:00
Simon 3920292b43 Add transaction size and zaddr output limit checks to z_sendmany. 2016-11-07 09:29:56 -08:00
Jack Grigg 7a810efa08
Add --disable-tests flag to zcutils/build.sh
Closes #1787
2016-11-06 12:35:55 -08:00
zkbot fbc69d3d33 Auto merge of #1790 - bitcartel:1779_send_multiple_zaddrs_logic_error, r=bitcartel
Fixes #1779 so that sending to multiple zaddrs no longer fails.

Closes #1779

Commit 2eeb6b randomized the order of input and output notes,
but this is now known to prevent the chaining of multiple joinsplits
in a single transaction.  The root cause has yet to be determined.

This patch is a temporary fix and disables the shuffling of input
and output notes.  It also adds a chained joinsplit test to the
python qa test suite.
2016-11-06 05:20:45 +00:00
zkbot 2648902a11 Auto merge of #1778 - bitcartel:1762_segfault_miner, r=str4d
Fixes #1762 segfault when miner is interrupted.

Closes #1762
2016-11-05 22:22:22 +00:00
Simon 38276c6ba2 Add GenIdentity, an identity function for MappedShuffle.
We use this function in z_sendmany as part of the fix for #1779.
2016-11-05 14:17:19 -07:00
Sean Bowe 5f0a73ce11 Improve accuracy of constraint system violation diagnostics. 2016-11-05 11:27:23 -06:00
Sean Bowe b55744e1ad Regression test for constraint system violation. 2016-11-05 11:15:16 -06:00
Simon 7c463780cf Fixes #1779 so that sending to multiple zaddrs no longer fails.
Commit 2eeb6b randomized the order of input and output notes,
but this is now known to prevent the chaining of multiple joinsplits
in a single transaction.  The root cause has yet to be determined.

This patch is a temporary fix and disables the shuffling of input
and output notes.  It also adds a chained joinsplit test to the
python qa test suite.
2016-11-04 23:23:48 -07:00
zkbot ce71cd0984 Auto merge of #1765 - ITH4Coinomia:patch-2, r=ebfull
Update init.cpp

Reformatted Text
2016-11-04 18:19:54 +00:00
zkbot 3b8f74abb2 Auto merge of #1763 - ITH4Coinomia:patch-1, r=ebfull
Update security-warnings.md

Linked Bitcoin URL
2016-11-04 17:40:09 +00:00
zkbot c73122db7b Auto merge of #1399 - ebfull:write-r1cs, r=ebfull
Write R1CS output to file in GenerateParams.

Not urgent. This is how the constraint system is communicated to the MPC.
2016-11-04 16:57:43 +00:00
S. Matthew English de9ca8e9a4 enforcing consistency 'tor' to 'Tor'
There was only one instance of 'tor', changed it to 'Tor' to better reflect all other references
2016-11-04 13:11:33 +01:00
Simon 5e9b555fed Fixes #1762 segfault when miner is interrupted.
Running ./zcash-cli setgenerate false would result in a segfault.
The miner thread's boost::signals2::connection was not disconnected
when the miner thread was interrupted and shutdown.  Subsequently, when
a new block arrived, the UpdateTip callback would still be invoked on
a now invalid object, resulting in a segfault.
2016-11-03 21:53:56 -07:00
Sean Bowe eb2e2b7043 1.0.1 release. 2016-11-03 22:26:15 -06:00
zkbot 9752e57739 Auto merge of #1772 - str4d:temporary-gtest-bug-workaround, r=ebfull
Temporary gtest bug workaround

Replaces the previous partial fix from #1771 with a temporary workaround that prevents all issues.
2016-11-03 23:19:51 +00:00
Jack Grigg b7f3640dda
Change execution order of gtests to avoid bug
This is only a workaround; we still need to isolate and fix the root cause.
2016-11-03 18:09:34 -05:00
Jack Grigg d873bd1d58
Revert "Initialise walletdb system in a temp dir for all gtests"
This reverts commit 74372eaa4c.
2016-11-03 18:04:28 -05:00
zkbot 231d2ccaf9 Auto merge of #1759 - ageis:more-fetch-params-stuff, r=ebfull
Improves usability of fetch-params.sh

Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.
2016-11-03 21:44:23 +00:00
Jack Grigg 74372eaa4c
Initialise walletdb system in a temp dir for all gtests 2016-11-03 15:42:44 -05:00
zkbot a2d8669f84 Auto merge of #1758 - str4d:1728-install-and-dist-scripts, r=str4d
Add build scripts and fetch-params.sh to "make install" and "make dist"

Closes #1728
2016-11-03 17:07:33 +00:00
zkbot 11c9be9eff Auto merge of #1735 - str4d:metrics-screen-improvements, r=str4d
Metrics screen improvements

Closes #1656, #1685, #1688 and #1716
2016-11-03 14:55:04 +00:00
ITH4Coinomia df22af008d Update init.cpp
Reformatted Text
2016-11-03 18:34:12 +05:30
ITH4Coinomia c6ad4f2245 Update security-warnings.md
Linked Bitcoin URL
2016-11-03 16:51:41 +05:30
zkbot 9eb852edd0 Auto merge of #1718 - ebfull:valid-fee-selection, r=nathan-at-least
Properly account for JoinSplit value when deciding if a transaction should be placed in a mined block.

Closes #1705.

The transaction selection logic in miner.cpp was not updated to account for JoinSplit value. This caused issues that include, but are not limited to, miners not including pure JoinSplit transactions in their blocks.
2016-11-03 04:38:54 +00:00
Jack Grigg 6b820113e9
Fix whitespace in Makefile.gtest.include 2016-11-02 17:43:37 -05:00
Jack Grigg e80490f5ff
Fix gtest issue introduced into master 2016-11-02 16:45:38 -05:00
Sean Bowe 52676958d1 Test that a pure joinsplit will mine if other transactions are in the mempool. 2016-11-02 14:25:07 -06:00
Jack Grigg 3bddaf632e
Use uint64_t for AtomicCounter 2016-11-02 14:50:00 -05:00
zkbot 51a5737950 Auto merge of #1754 - str4d:1753-genesis-block-coinbase-height-exception, r=str4d
Adjust consensus rule to accept genesis block without height in coinbase

Closes #1753
2016-11-02 18:15:39 +00:00
Kevin Gallagher 4bc627b6a3 Improves usability of fetch-params.sh
Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.
2016-11-02 11:06:55 -07:00
zkbot 624b5f390a Auto merge of #1752 - ebfull:diagnostics-of-constraint-system-violations, r=ebfull
Throw more descriptive exceptions when the constraint system is violated

Closes #1668.
2016-11-02 17:30:31 +00:00
Jack Grigg 33efd816ec
Add build scripts and fetch-params.sh to "make install" and "make dist"
Closes #1728
2016-11-02 12:13:47 -05:00
Jack Grigg 73a439185d
Ensure that no tracked blocks are skipped during orphan detection 2016-11-02 09:20:35 -05:00
Jack Grigg 22ee0efe25
Fix previous commit 2016-11-01 20:37:59 -05:00
Jack Grigg 548bbd95f0
Adjust consensus rule to accept genesis block without height in coinbase
Closes #1753
2016-11-01 19:58:56 -05:00
zkbot 77dcb00d0e Auto merge of #1748 - bitcartel:master_1746_add_z_validateaddress, r=ebfull
Add rpc call z_validateaddress to validate zaddrs.

Closes #1746.
2016-11-01 20:56:26 +00:00
Sean Bowe c4643bd949 Throw more descriptive exceptions when the constraint system is violated. 2016-11-01 14:52:03 -06:00
zkbot ae3e69c6b2 Auto merge of #1750 - ebfull:add-checkpoint, r=ebfull
Add checkpoint at block 2500.
2016-11-01 20:01:07 +00:00
Jack Grigg cb7098317d
Improve locking in metrics 2016-11-01 11:59:40 -05:00
Sean Bowe 73363c3d9a Add checkpoint at block 2500. 2016-11-01 09:16:51 -06:00