Commit Graph

14243 Commits

Author SHA1 Message Date
Dimitris Apostolou c84ae00cbf
Remove Bitcoin release notes 2020-10-03 22:58:39 +03:00
Dimitris Apostolou 1fa5d4670a
Remove deprecated init.md 2020-10-03 22:43:45 +03:00
Homu b667bfaa14 Auto merge of #4760 - rex4539:fix-zeromq-warning, r=daira
Fix zeromq warning

Fixes https://github.com/zcash/zcash/issues/4759.
2020-10-03 17:04:31 +00:00
Dimitris Apostolou 95a5c30339
Fix zeromq warning 2020-10-03 09:13:35 +03:00
Homu ce44f60c26 Auto merge of #4758 - str4d:depends-updates, r=str4d
Update dependencies
2020-10-01 16:34:04 +00:00
Homu eb4c9ea0a3 Auto merge of #4484 - defuse:fix-undefined-behavior-in-bitcoin-test, r=str4d
Fix undefined behavior in the test_bitcoin tests
2020-10-01 15:19:39 +00:00
Taylor Hornby 3693b96ed4 Fix undefined behavior in the test_bitcoin tests 2020-10-01 13:59:47 +01:00
Homu a983344931 Auto merge of #4752 - str4d:small-httpserver-backports, r=daira
Small httpserver.cpp backports

Also includes a change to the `uiInterface.NotifyBlockTip` signal API.
These remove merge conflicts from subsequent backports for `sync.h`.

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6859
- bitcoin/bitcoin#7112
  - Only the non-QT changes.
- bitcoin/bitcoin#7966
- bitcoin/bitcoin#8421
  - We already backported the second commit in zcash/zcash#2555
2020-10-01 12:48:58 +00:00
str4d 2fbc111efb
httpserver: Code style cleanups
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-10-01 13:46:21 +01:00
Jack Grigg e15eaf0343 QA: Fix backporting bugs in httpbasics.py 2020-10-01 13:44:21 +01:00
Homu 939c5dfce6 Auto merge of #4756 - str4d:4755-exorcise-openssl, r=str4d
build: Remove a stray -lcrypto

zcash/zcash#4740 removed OpenSSL from our depends system, so we were
not satisfying this linker flag intentionally. Configurations where a
target OpenSSL could not be found by the linker, such as cross-compiles
and native macOS builds, were therefore failing. However, OpenSSL is
likely available in the system for all the "supported builders" (which
are all Linux-based), so the linker was likely being satisfied by that
library, enabling the previous PR to be merged.
2020-10-01 10:40:15 +00:00
Jack Grigg 0d4a7b032f depends: Use correct HOST for download-linux target
By using the old HOST with -unknown, `make -C depends download` was
interpreting the download-linux step as a cross-compile, and attempting
to download a Rust stdlib for Linux that we weren't pinning (because we
don't support cross-compiling to x86_64 Linux - just build it native).

Follow-up to https://github.com/zcash/zcash/pull/4749.
2020-10-01 11:22:27 +01:00
Jack Grigg 076c1af55c depends: utfcpp 3.1.2 2020-10-01 11:10:33 +01:00
Jack Grigg 78a7230f50 depends: googletest 1.8.1 2020-10-01 10:57:57 +01:00
Jack Grigg 7725f66051 depends: ccache 3.7.11 2020-10-01 10:57:26 +01:00
Jack Grigg 96da9c2c00 depends: libevent 2.1.12
This includes https://github.com/libevent/libevent/pull/637 which fixes
a problem we encounter during cross-compilation with clang.
2020-10-01 10:56:42 +01:00
Jack Grigg be7876adbb build: Remove a stray -lcrypto
zcash/zcash#4740 removed OpenSSL from our depends system, so we were
not satisfying this linker flag intentionally. Configurations where a
target OpenSSL could not be found by the linker, such as cross-compiles
and native macOS builds, were therefore failing. However, OpenSSL is
likely available in the system for all the "supported builders" (which
are all Linux-based), so the linker was likely being satisfied by that
library, enabling the previous PR to be merged.
2020-10-01 09:59:02 +01:00
Homu b5fa52b701 Auto merge of #4740 - str4d:remove-openssl, r=daira
Remove OpenSSL

Includes changes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7095
- bitcoin/bitcoin#11024
- bitcoin/bitcoin#17165
  - Only the commit removing SSL lib detection (we have long since removed the rest).
- bitcoin/bitcoin#17265
  - We had already migrated away from OpenSSL for randomness.
- bitcoin/bitcoin#17515
  - Only the second commit.

Closes #145.
2020-10-01 00:34:47 +00:00
Daira Hopwood ce0654e13a Cosmetics in CScriptNum code and tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-01 00:34:31 +01:00
Daira Hopwood 932d627753 It's unnecessary to pass int64_t by const reference.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-01 00:34:31 +01:00
Daira Hopwood f432fe5ebf Add assertions for CScriptNum[10] +/- int64_t to avoid the possibility of UB.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-01 00:34:31 +01:00
Daira Hopwood 9ba10a8071 Avoid undefined behaviour in scriptnum tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-01 00:34:31 +01:00
Cory Fields 860e6e600c httpserver: replace boost threads with std
along with mutex/condvar/bind/etc.

httpserver handles its own interruption, so there's no reason not to use std
threading.

While we're at it, may as well kill the BOOST_FOREACH's as well.
2020-09-30 12:48:35 +01:00
Cory Fields 97194f2abc httpserver: use a future rather than relying on boost's try_join_for 2020-09-30 12:48:35 +01:00
Wladimir J. van der Laan 26efd3aaf9 http: use std::move to move HTTPRequest into HTTPWorkItem
Thanks to Cory Fields for the idea.
2020-09-30 12:48:35 +01:00
Wladimir J. van der Laan a500df5561 http: Change boost::scoped_ptr to std::unique_ptr in HTTPRequest
No need for boost here.
2020-09-30 12:48:35 +01:00
Wladimir J. van der Laan 1f106fa803 http: Add log message when work queue is full
More useful error reporting.
2020-09-30 12:48:35 +01:00
Wladimir J. van der Laan fc9ce9e766 http: Do a pending c++11 simplification
Use std::unique_ptr for handling work items.

This makes the code more RAII and, as mentioned in the comment, is what
I planned when I wrote the code in the first place.
2020-09-30 12:48:35 +01:00
Daira Hopwood b165ead16a Minor additional OpenSSL scouring.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-09-30 10:44:42 +01:00
Jack Grigg bab853748e QA: Remove OpenSSL from updatecheck.py 2020-09-30 00:40:12 +01:00
Jack Grigg ab35a260d5 Remove remaining OpenSSL references 2020-09-30 00:40:12 +01:00
Jack Grigg ce1b5491db util: Remove OpenSSL multithreading infrastructure 2020-09-30 00:40:12 +01:00
Wladimir J. van der Laan fe49dc5282 build: remove libcrypto as internal dependency in libbitcoinconsensus.pc 2020-09-30 00:40:12 +01:00
fanquake 4526ecf9b2 doc: remove OpenSSL from build instructions and licensing info 2020-09-30 00:40:12 +01:00
fanquake f477932d38 depends: remove OpenSSL package 2020-09-30 00:40:12 +01:00
fanquake 0ad49bca44 build: remove OpenSSL detection and libs 2020-09-30 00:40:12 +01:00
fanquake 8993f1f708 build: remove SSL lib detection 2020-09-30 00:40:12 +01:00
practicalswift c28c9b96a1 tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt 2020-09-30 00:40:12 +01:00
Wladimir J. van der Laan 7b3cb48232 Replace scriptnum_test's normative ScriptNum implementation
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes #7086.
2020-09-30 00:40:12 +01:00
Jonas Schnelli 220e166e47 Move uiInterface.NotifyBlockTip signal above the core/wallet signal
- This will keep getbestblockhash more in sync with blocknotify callbacks
2020-09-30 00:35:32 +01:00
Jonas Schnelli 66515b0628 NotifyBlockTip signal: switch from hash (uint256) to CBlockIndex*
- also adds a boolean for indication if the tip update was happening during initial sync
- emit notification also during initial sync
2020-09-30 00:35:32 +01:00
Wladimir J. van der Laan 23556e690e http: Restrict maximum size of request line + headers
Prevent memory exhaustion by sending lots of data.
Also add a test to `httpbasics.py`.

Closes #6425
2020-09-30 00:35:32 +01:00
Homu 7d94064616 Auto merge of #4643 - str4d:locked-memory-manager, r=str4d
Locked memory manager

Add a pool for locked memory chunks, replacing `LockedPageManager`.

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#8321
- bitcoin/bitcoin#8753
- bitcoin/bitcoin#9063
- bitcoin/bitcoin#9070
- bitcoin/bitcoin#11385
- bitcoin/bitcoin#12048
  - Excludes change to benchmark.
- bitcoin/bitcoin#15117
- bitcoin/bitcoin#16161
  - Excludes Travis CI changes.
  - Includes change from bitcoin/bitcoin#13163
- bitcoin/bitcoin#15600
- bitcoin/bitcoin#18443
- Assorted small changes from:
  - bitcoin/bitcoin#9233
  - bitcoin/bitcoin#10483
  - bitcoin/bitcoin#10645
  - bitcoin/bitcoin#10969
  - bitcoin/bitcoin#11351
- bitcoin/bitcoin#19111
  - Excludes change to `src/rpc/server.cpp`
- bitcoin/bitcoin#9804
  - Only the commit for `src/key.cpp`
- bitcoin/bitcoin#9598
2020-09-29 22:18:48 +00:00
Homu 9245388bbc Auto merge of #4749 - str4d:update-config-guess-and-sub, r=str4d
depends: Update to latest config.guess & config.sub
2020-09-29 02:17:39 +00:00
Homu 94cf4a4946 Auto merge of #4558 - linuxion:master, r=str4d
[RPC] Add transaction size to JSON output

Cherry-picked from upstream PR https://github.com/bitcoin/bitcoin/pull/7072.
2020-09-28 22:40:09 +00:00
Nick abcce56fe1 [RPC] Add transaction size to JSON output
This may be useful for blockchain explorers.
2020-09-28 23:12:21 +01:00
Jack Grigg f43e3833f3 gitian: Switch from x86_64-unknown-linux-gnu to x86_64-linux-gnu
This will work regardless of how config.sub behaves, and matches what
upstream currently uses.
2020-09-28 21:36:46 +01:00
Jack Grigg bd87bcf1b4 build: Switch to x86_64-pc-linux-gnu for codecov filtering 2020-09-28 21:36:02 +01:00
Jack Grigg f52793d0d0 QA: Switch to x86_64-pc-linux-gnu for hard-coded Linux HOST
The change to config.guess for x86_64:Linux was made here:
    http://git.savannah.gnu.org/cgit/config.git/commit/?id=ca9bfb8cc75a2be1819d89c664a867785c96c9ba
2020-09-28 21:28:43 +01:00
Jack Grigg 9384b78c0f depends: Update map of GCC canonical hosts to Rust targets
The updated files now output x86_64-pc-linux-gnu on some platforms where
they previously output x86_64-unknown-linux-gnu.
2020-09-28 18:20:47 +01:00