a5be52a675
make-release.py: Updated manpages for 5.3.3.
2023-02-20 19:47:26 -07:00
6fe1b5e595
make-release.py: Versioning changes for 5.3.3.
2023-02-20 19:43:45 -07:00
700d785046
Postpone dependency updates.
2023-02-20 19:43:03 -07:00
1478dc1e7f
Update release notes for v5.3.3 hotfix
2023-02-20 19:37:38 -07:00
2c85dd9598
Merge remote-tracking branch '22387-backport' into hotfix-5.3.3
2023-02-20 19:33:18 -07:00
169e890f1e
Merge remote-tracking branch 'trim-cnode' into hotfix-5.3.3
2023-02-20 19:30:48 -07:00
f30c3c97b7
Merge remote-tracking branch 'remove-mapRequest' into hotfix-5.3.3
2023-02-20 19:30:25 -07:00
074e633798
Improve the encapsulation of `CNode::filterInventoryKnown`.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-02-20 23:39:20 +00:00
c5b8807ce7
Ensure that CNode::{addrKnown, filterInventoryKnown} immediately take
...
little memory when we disconnect the node.
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Jack Grigg <str4d@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-02-20 20:14:55 +00:00
0a39cc6727
Enable a CRollingBloomFilter to be reset to a state where it takes little memory.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-02-20 18:32:46 +00:00
9555b5e8a4
p2p, rpc, test: address rate-limiting follow-ups
...
(cherry picked from commit bitcoin/bitcoin@d930c7f5b0 )
2023-02-17 17:54:39 -07:00
1dddc1337c
Add logging and addr rate limiting statistics
...
Includes logging improvements by Vasil Dimov and John Newbery.
(cherry picked from commit bitcoin/bitcoin@f424d601e1 )
2023-02-17 16:47:47 -07:00
c8cdfcffd0
Randomize the order of addr processing
...
(cherry picked from commit bitcoin/bitcoin@5648138f59 )
2023-02-17 16:47:37 -07:00
2c48eddfa5
Remove `ResetRequestCount`
...
There is no longer any `mapRequestCount` to reset.
This also removes the `BlockFound` signal, as its only purpose was to call
`ResetRequestCount`.
2023-02-17 15:45:29 -07:00
7c739e2b20
Rate limit the processing of incoming addr messages
...
While limitations on the influence of attackers on addrman already
exist (affected buckets are restricted to a subset based on incoming
IP / network group), there is no reason to permit them to let them
feed us addresses at more than a multiple of the normal network
rate.
This commit introduces a "token bucket" rate limiter for the
processing of addresses in incoming ADDR and ADDRV2 messages.
Every connection gets an associated token bucket. Processing an
address in an ADDR or ADDRV2 message from non-whitelisted peers
consumes a token from the bucket. If the bucket is empty, the
address is ignored (it is not forwarded or processed). The token
counter increases at a rate of 0.1 tokens per second, and will
accrue up to a maximum of 1000 tokens (the maximum we accept in a
single ADDR or ADDRV2). When a GETADDR is sent to a peer, it
immediately gets 1000 additional tokens, as we actively desire many
addresses from such peers (this may temporarily cause the token
count to exceed 1000).
The rate limit of 0.1 addr/s was chosen based on observation of
honest nodes on the network. Activity in general from most nodes
is either 0, or up to a maximum around 0.025 addr/s for recent
Bitcoin Core nodes. A few (self-identified, through subver) crawler
nodes occasionally exceed 0.1 addr/s.
(cherry-picked from commit bitcoin/bitcoin@0d64b8f709 )
2023-02-17 14:36:25 -07:00
aa88e23f6b
Remove useless mapRequest tracking that just effects Qt display.
...
I thought we had removed this a long time ago, TBH, its really
confusing feedback to users that we display whether a tx was
broadcast to immediate neighbor nodes, given that has little
indication of whether the tx propagated very far.
2023-02-17 14:04:37 -07:00
ed0089d876
make-release.py: Updated release notes and changelog for 5.3.2.
2022-12-03 19:58:44 +00:00
dd47391112
make-release.py: Updated manpages for 5.3.2.
2022-12-03 19:58:44 +00:00
f7697dbdf3
make-release.py: Versioning changes for 5.3.2.
2022-12-03 19:49:32 +00:00
72cef60175
Postpone updates.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-03 19:47:30 +00:00
e1b5bd26ea
Merge pull request #6276 from zcash/revert-6231-headers-first-rebirth
...
Revert "Headers-first fix" to avoid a memory usage regression on IBD
2022-12-03 12:30:44 -07:00
35700b9d65
Add release notes for the IBD memory spike issue.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-03 17:52:12 +00:00
08f86a4db8
Revert "Headers-first fix"
2022-12-03 17:52:12 +00:00
0972ffd785
make-release.py: Updated release notes and changelog for 5.3.1.
2022-12-02 02:46:42 +00:00
4d5f4bc60b
make-release.py: Updated manpages for 5.3.1.
2022-12-02 02:46:42 +00:00
5e3e4d49d0
make-release.py: Versioning changes for 5.3.1.
2022-12-02 02:42:08 +00:00
3a5a016a11
Merge branch 'master' into version-5.3.1
2022-12-02 02:41:23 +00:00
b2c88861ee
Bump timestamps and add libcxx/native_clang 15.0.6 in `postponed-updates.txt`.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-02 02:15:22 +00:00
1ef5372859
Update release notes: z_getnotescount already had the minconf parameter
...
Co-authored-by: Greg Pfeil <greg@technomadic.org>
2022-11-28 14:08:55 -07:00
1dd4be5474
Add release notes for #6122 (`asOfHeight` RPC parameters).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-28 14:08:47 -07:00
60a43b96c3
Merge pull request #6266 from daira/asofheight-release-notes
...
Add release notes for #6122 (`asOfHeight` RPC parameters)
2022-11-25 14:39:31 +00:00
a528b63097
Update release notes: z_getnotescount already had the minconf parameter
...
Co-authored-by: Greg Pfeil <greg@technomadic.org>
2022-11-24 20:11:53 +00:00
f4a722eff5
Add release notes for #6122 (`asOfHeight` RPC parameters).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-24 16:35:31 +00:00
32df2e6b7b
Merge pull request #6263 from sellout/release-v5.3.1-rc1
...
Release v5.3.1-rc1
2022-11-24 12:27:34 +00:00
761b764b51
make-release.py: Updated release notes and changelog for 5.3.1-rc1.
2022-11-23 22:18:55 -07:00
4ec715c6db
make-release.py: Updated manpages for 5.3.1-rc1.
2022-11-23 22:18:54 -07:00
0647a9ba24
make-release.py: Versioning changes for 5.3.1-rc1.
2022-11-23 22:09:24 -07:00
3de2348987
Postpone dependency updates for v5.3.1
2022-11-23 22:05:45 -07:00
f6a4f68115
Merge pull request #6122 from nuttycom/wallet/listunspent_as_of
...
Add `asOfHeight` argument across the RPC API
2022-11-23 21:20:20 -07:00
583fbb2218
Simplify filtering AvailableCoins by destination
2022-11-23 11:51:22 -07:00
2eb29c2a66
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-23 11:00:10 -07:00
368d04245d
Change asOfHeight to preserve Bitcoin compat
2022-11-22 22:06:51 -07:00
4b2203a1fd
Change asOfHeight to use -1 as default
2022-11-22 16:47:40 -07:00
6421f47ef7
Revert getinfo support of asOfHeight
...
This operation is practically deprecated, so don’t change it.
2022-11-22 16:47:40 -07:00
7792228bab
Revert change to getbalance minconf
...
It was the docs that were wrong. In this case, the default `minconf` _should_ be
0 (to match upstream).
2022-11-22 16:47:40 -07:00
d444f8b586
Fix small error in code review suggestions
2022-11-22 16:47:40 -07:00
f290b9a7b4
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-22 15:59:07 -07:00
6284f3f8b0
Merge pull request #6231 from miodragpop/headers-first-rebirth
...
Headers-first fix
2022-11-22 19:27:03 +00:00
5ea600a102
Update src/rpc/server.cpp
...
Co-authored-by: Kris Nuttycombe <kris.nuttycombe@gmail.com>
2022-11-22 10:38:21 -07:00
4f85307186
Add FIXMEs to repair comments after #6262 is fixed
2022-11-22 10:36:34 -07:00
Kris Nuttycombe
Daira Hopwood
Jon Atack
Pieter Wuille
Greg Pfeil
Matt Corallo
Greg Pfeil
str4d
Greg Pfeil