Commit Graph

8621 Commits

Author SHA1 Message Date
Sean Bowe 4180589f02
Set mainnet activation of Blossom 2019-11-01 09:31:55 -06:00
Alfredo Garcia 6650aed46b add next upgrade info to metrics console 2019-10-30 15:19:22 -03:00
Alfredo Garcia 12dd81614c add version to thank you string 2019-10-29 14:44:27 -03:00
Taylor Hornby bfa8da3852 Have make clean delete fuzz.cpp 2019-10-28 11:54:19 -06:00
Taylor Hornby b25a14f433 Separate AFL build, run fuzz stages, and add afl argument pass-through 2019-10-28 11:54:13 -06:00
Alfredo Garcia cbf1a85013 remove z_mergetoaddress from experimental 2019-10-26 12:52:36 -03:00
Larry Ruane 07f2edc91c #4175 z_sendmany coinbase to zaddr with change: report error status 2019-10-24 22:47:31 -06:00
Alfredo Garcia b3594b5273 limit blockchain progress to a max of 1.000000 2019-10-24 15:51:00 -03:00
Taylor Hornby f968506039 Add all-in-one script for starting AFL fuzzing 2019-10-23 11:15:09 -06:00
Eirik Ogilvie-Wigley bdfed7e178 make-release.py: Versioning changes for 2.1.0-rc1. 2019-10-22 14:35:07 -06:00
Alfredo Garcia a913574b0e change some wallet functions from bool to void 2019-10-22 17:23:53 -03:00
Eirik Ogilvie-Wigley 8307a5db5a Use same type when calling max 2019-10-22 11:29:55 -06:00
Alfredo Garcia 0eec096843 Consensus: Decouple pow.cpp from util.h 2019-10-22 14:16:53 -03:00
Homu fffd5da201 Auto merge of #4145 - Eirik0:limit-mempool, r=Eirik0
DoS protection: Weighted random drop of txs if mempool full
2019-10-21 12:40:50 -07:00
Alfredo Garcia f4106c65a5 remove duplicated prefix in errors and warnings 2019-10-21 13:13:59 -03:00
Eirik Ogilvie-Wigley 40a7156026 Remove dots and underscores from parameter names 2019-10-21 09:20:17 -06:00
Jack Grigg f270979acb
Migrate to librustzcash 0.2.0 API 2019-10-20 19:11:02 +13:00
Eirik Ogilvie-Wigley e744cece52 Fix test cases: default mempool limiters 2019-10-18 13:36:12 -06:00
Eirik Ogilvie-Wigley 64fc25ed6e Update parameter names to match ZIP 2019-10-17 16:39:32 -06:00
Eirik Ogilvie-Wigley e7aed48e7a Wording and grammatical fixes 2019-10-17 15:16:51 -06:00
Eirik Ogilvie-Wigley 78592da52a Add explanatory comments 2019-10-17 14:18:20 -06:00
Eirik Ogilvie-Wigley 1edeba61ac Add test 2019-10-17 12:32:33 -06:00
zebambam 7e8b18e480 Added basic fuzzing to the monolith, see ticket #4155 2019-10-15 00:00:21 +00:00
Larry Ruane ffb8e6747b access array element using at() 2019-10-12 19:06:51 -06:00
Larry Ruane a3eb2b8708 update unit tests to compute empty roots 2019-10-12 18:03:36 -06:00
Larry Ruane 7ec8c5d309 precompute empty merkle roots 2019-10-12 18:03:36 -06:00
Eirik Ogilvie-Wigley c4931a9a44 Rename files 2019-10-09 15:22:49 -06:00
Eirik Ogilvie-Wigley b4c4134956 Represent recently evicted list as a deque 2019-10-09 15:12:32 -06:00
Eirik Ogilvie-Wigley ca883c8517 Log rather than return error if a transaction is recently evicted 2019-10-09 14:43:35 -06:00
Eirik Ogilvie-Wigley 9b2a04bd95 Use tx cost rather than evictionWeight when checking mempool capacity 2019-10-09 13:42:46 -06:00
Eirik Ogilvie-Wigley 2d9becbeb8 Rename variables for consistency 2019-10-09 13:36:20 -06:00
Eirik Ogilvie-Wigley 1556ec6722 Fix comments 2019-10-09 13:19:09 -06:00
Eirik Ogilvie-Wigley bf044cc0c3 Represent tx costs as signed integers 2019-10-09 13:14:35 -06:00
Eirik Ogilvie-Wigley 61b7dfb6f0 Move duplicate macro to reusable location 2019-10-09 12:25:56 -06:00
Eirik Ogilvie-Wigley 69a5ffe5d4 Prevent adding duplicate transactions 2019-10-09 12:13:01 -06:00
Eirik Ogilvie-Wigley 2365ba7b97 Put size increment and decrement on their own lines 2019-10-09 12:06:03 -06:00
Eirik Ogilvie-Wigley 30be750644 Fix recently evicted list size 2019-10-09 11:59:14 -06:00
Homu 4eaad3f77b Auto merge of #4154 - zebambam:remove_stale_seeder, r=Eirik0
Removed stale seeder, fixing #4153

Removed old seeder.
2019-10-07 15:06:20 -07:00
Eirik Ogilvie-Wigley 9e97833952 Fix naming conventions 2019-10-07 14:23:42 -06:00
Eirik Ogilvie-Wigley 1a06727c0c Performance: Store weighted transactions in a tree 2019-10-07 14:23:42 -06:00
Eirik Ogilvie-Wigley 6fdd8f5298 Help message cleanup and add lock 2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley 1407fd10a1 Remove transactions when ensuring size limit 2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley 0b2c5cfcc2 Grammatical fixes
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley a48b1ba7e2 Rebuild weighted list on removal and fix size calculation 2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley ae9ecf09e8 DoS protection: Weighted random drop of txs if mempool full 2019-10-07 14:23:41 -06:00
zebambam 3b9237b883 Removed stale seeder, fixing #4153 2019-10-07 13:17:21 -07:00
Homu fafc479fcf Auto merge of #3765 - jeff-liang:addnetworkindicator, r=daira
Display which network the node is running on. Resolves #3760.

Resolves #3760
2019-10-02 08:41:32 -07:00
Daira Hopwood 3e37152bf5 Fix setting an expiry height of 0. fixes #4132
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-26 20:43:52 +01:00
Homu 961c0d58ec Auto merge of #4060 - str4d:remove-libsnark, r=daira
Remove libsnark

Closes #167. Closes #416. Closes #418. Closes #437.
Closes #521. Closes #743. Closes #750. Closes #894.
Closes #903. Closes #1125. Closes #1136. Closes #1240.
Closes #1264. Closes #1516. Closes #1517. Closes #1651.
Closes #2064. Closes #2158. Closes #3478. Closes #3652.
Closes #3744.
2019-09-26 11:21:40 -07:00
Homu 62dc5f0821 Auto merge of #4144 - zcash:hotfix-v2.0.7-3, r=str4d
Release v2.0.7-3
2019-09-24 16:02:35 -07:00
Daira Hopwood 1e11ffb6bb make-release.py: Versioning changes for 2.0.7-3. 2019-09-24 20:58:26 +01:00
Daira Hopwood 921f326132
Merge pull request #18 from zcash/mempool-txnotify-thread
Move mempool SyncWithWallets call into its own thread
2019-09-24 19:22:08 +01:00
Daira Hopwood f5832a9549
Merge pull request #17 from zcash/exception-handling
Ignore exceptions when deserializing note plaintexts
2019-09-24 19:21:34 +01:00
Jack Grigg 9d8322a341
Enable RPC tests to wait on mempool notifications 2019-09-20 21:41:49 +01:00
Jack Grigg 3ff68c5052
Move mempool SyncWithWallets call into its own thread 2019-09-20 21:00:42 +01:00
Jack Grigg c1fbf8ab5d
Ignore exceptions when deserializing note plaintexts 2019-09-19 22:29:24 +01:00
Jack Grigg 7c8111f304
Remove cs_main lock requirement from CWallet::SyncTransaction
SetMerkleBranch was the only call underneath SyncTransaction that
required the cs_main lock.
2019-09-19 20:59:05 +01:00
Jack Grigg d917c11572
SetMerkleBranch: remove unused code, remove cs_main lock requirement
Includes equivalent changes to bitcoin/bitcoin#9446
2019-09-19 20:57:39 +01:00
Jack Grigg 5ae7b70ae6
Disable -shrinkdebugfile command 2019-09-19 18:05:56 +01:00
Jack Grigg c8c43c4210
Add block hashes for Overwinter, Sapling, and testnet Blossom
Also updates nMinimumChainWork for testnet (using block 585000).
2019-09-19 16:10:35 +01:00
Jack Grigg 150e330310
Abort node if NU activations have unexpected hashes 2019-09-19 15:00:04 +01:00
Jack Grigg 10b9d6306b
Move AbortNode to the top of main.cpp
It is in an anonymous namespace, so it needs to be above all code in the
file that uses it.
2019-09-19 14:52:55 +01:00
Eirik Ogilvie-Wigley c8715f7fb3 Wrap metrics message in strprintf 2019-09-18 12:16:11 -06:00
jeff-liang 188f3254fc Display which network the node is running on.
Co-authored-by: Jeff Liang
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-18 12:11:17 -06:00
Jack Grigg fe3cb8ec93
Remove makeGrothProof argument from JoinSplit::prove 2019-09-16 13:10:54 +01:00
Homu 06507722ac Auto merge of #4088 - LarryRuane:3708-insightexplorer-formatting, r=Eirik0
insightexplorer: formatting, pyflakes cleanups

These changes were too late (post-review) for the Insight Explorer PRs, see #3708. No functional differences.
2019-09-04 10:57:56 -07:00
Eirik Ogilvie-Wigley 72d2ab918d make-release.py: Versioning changes for 2.0.7-2. 2019-08-30 17:38:50 -06:00
Eirik Ogilvie-Wigley c05652b8d9 make-release.py: Versioning changes for 2.0.7-1. 2019-08-29 12:58:35 -06:00
Homu 424d8b1af5 Auto merge of #4115 - LarryRuane:4114-spent-index-debug, r=Eirik0
#4114 Don't call GetSpentIndex() when converting txs to JSON if spent index is disabled

Closes #4114.
2019-08-28 21:09:19 -07:00
Larry Ruane e83168b8c8 better fix: make GetSpentIndex() consistent with others...
but don't call it if insight explorer isn't enabled
2019-08-27 08:37:42 -06:00
Daira Hopwood 7d5de93518 Add intended rewind for Blossom on testnet.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-26 21:37:44 +01:00
Larry Ruane 210c46c21d #4114 don't call error() from GetSpentIndex() 2019-08-24 19:05:10 -06:00
Jack Grigg 9cbd2889be
rpc: Use Sapling transactions in zc_raw_joinsplit 2019-08-22 17:27:18 +01:00
Jack Grigg 9ce0caf205
Remove libsnark 2019-08-22 15:42:52 +01:00
Jack Grigg 6a4b8b7751
Remove libsnark from build system 2019-08-22 15:42:51 +01:00
Jack Grigg 7bd700b100
Revert "Check if OpenMP is available before using it"
This reverts commit daad2c2736.
2019-08-22 15:42:50 +01:00
Jack Grigg 9a0e257526
Revert "configure: Guess -march for libsnark OPTFLAGS instead of hard-coding"
This reverts commit 98cfe4228c.
2019-08-22 15:42:49 +01:00
Jack Grigg 8a638d5fd8
Remove pre-Sapling Sprout circuit 2019-08-22 15:42:48 +01:00
Jack Grigg 5f84491d82
Remove libsnark code for pre-Sapling Sprout proofs 2019-08-22 15:42:47 +01:00
Jack Grigg 93dae1db7d
Revert "Allow user to ask server to save the Sprout R1CS out during startup."
This reverts commit 685c0ab07f.
2019-08-22 15:42:46 +01:00
Jack Grigg e573765641
Use Sapling JSDescriptions in gtests 2019-08-22 15:42:45 +01:00
Jack Grigg c4b695e7b3
Migrate test utilities to generate Sapling-type Sprout proofs 2019-08-22 15:42:44 +01:00
Jack Grigg 79a7c072f6
Remove non-Groth16 Sprout proofs from joinsplit gtests 2019-08-22 15:42:43 +01:00
Jack Grigg 1b4cf1337c
Use Sapling JSDescriptions in Boost tests 2019-08-22 15:42:42 +01:00
Jack Grigg 1e812cd694
Remove ability to create non-Groth16 Sprout JSDescriptions 2019-08-22 15:42:41 +01:00
Jack Grigg 34297c3dec
Always skip verification for old Sprout proofs 2019-08-22 15:42:40 +01:00
Eirik Ogilvie-Wigley 63dac4b08a Update nMinimumChainWork 2019-08-19 15:16:12 -06:00
Eirik Ogilvie-Wigley 93a03a1a20 make-release.py: Versioning changes for 2.0.7. 2019-08-19 14:36:31 -06:00
Eirik Ogilvie-Wigley 1288fb1dd8 Set testnet Blossom activation height 2019-08-16 13:21:33 -06:00
Eirik Ogilvie-Wigley 0b83bf493a make-release.py: Versioning changes for 2.0.7-rc1. 2019-08-09 16:52:27 -06:00
Larry Ruane 7c5a791b73 insightexplorer: formatting, pyflakes cleanups 2019-08-09 15:27:52 -06:00
Homu 5fd1f5afc0 Auto merge of #3972 - LarryRuane:3708-getblockhashesrpc, r=str4d
3708 getblockhashesrpc

Part of #3708
2019-08-09 08:00:17 -07:00
Homu 2528af69ff Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
Implement ZIP 208: Shorter Block Target Spacing

Closes #3690.
2019-08-09 02:35:30 -07:00
Larry Ruane 70bda8416a insightexplorer fix LogPrintf 2019-08-08 14:54:47 -06:00
Larry Ruane 6e7e50be4d insightexplorer minor bug fixes 2019-08-08 14:45:30 -06:00
Larry Ruane 5bba8493d5 fix getblockdeltas documentation formatting 2019-08-08 14:38:45 -06:00
Larry Ruane 2e505df351 add timestampindex related RPC getblockhashes 2019-08-08 14:35:07 -06:00
Larry Ruane 86b23f37ad add spentindex RPC for bitcore block explorer 2019-08-07 14:23:42 -06:00
Eirik Ogilvie-Wigley b99003c1ec Rename method and use int64_t 2019-08-07 10:05:01 -06:00
Eirik Ogilvie-Wigley d9ef43dc25 Do not estimate height if there is no best header 2019-08-07 10:04:30 -06:00
Eirik Ogilvie-Wigley cdb6757095 NPE defense in metrics screen 2019-08-06 09:45:17 -06:00
Eirik Ogilvie-Wigley 2f00729061 Add copyright info 2019-08-05 19:05:11 -06:00
Eirik Ogilvie-Wigley 42a21ef004 Test clean up and fixes 2019-08-05 14:52:34 -06:00
Eirik Ogilvie-Wigley 5a93638981 Distinguish between height and current header height on metrics screen 2019-08-05 14:20:25 -06:00
Eirik Ogilvie-Wigley f97b9c5d9f Algebraic improvements related to halving 2019-08-05 14:02:31 -06:00
Eirik Ogilvie-Wigley 8f0a54c142 Remove DefaultExpiryDelta method 2019-08-05 13:40:06 -06:00
Eirik Ogilvie-Wigley 832134f4cd Update PoW related assertions 2019-08-05 13:16:13 -06:00
Eirik Ogilvie-Wigley 609bb38ad8 Clarify documentation 2019-08-05 13:01:01 -06:00
Eirik Ogilvie-Wigley 0f0512128c Make sure that expiry height is not less than height 2019-08-05 12:57:10 -06:00
Eirik Ogilvie-Wigley 7ddcf427c0 Fix/update comments 2019-08-05 12:41:31 -06:00
Eirik Ogilvie-Wigley 9f70b74692 Do not add expiring soon threshold to expiry height of txs near NU activation 2019-08-05 11:50:05 -06:00
Eirik Ogilvie-Wigley 82c291b6df Fix parsing txexpirydelta argument 2019-08-05 11:32:12 -06:00
Eirik Ogilvie-Wigley 2c35e162a6 Make sure to deactivate blossom in test case 2019-08-05 11:32:12 -06:00
Eirik Ogilvie-Wigley 8068491d2c Fix check transaction tests 2019-08-04 14:35:47 -06:00
Eirik Ogilvie-Wigley bde2e4807c Improve EstimateNetHeight calculation 2019-08-02 22:51:21 -06:00
Eirik Ogilvie-Wigley 2972521323 Add comments and fix typos 2019-08-02 21:43:17 -06:00
Eirik Ogilvie-Wigley f9d6b3e7ef Extract Halvings method and add tests 2019-08-02 21:37:48 -06:00
Eirik Ogilvie-Wigley 93452c97bf Make founders reward tests pass before and after Blossom activation height is set 2019-08-02 20:54:52 -06:00
Eirik Ogilvie-Wigley 3eb90d4040 Use pre-Blossom max FR height when calculating address change interval 2019-08-02 20:53:41 -06:00
Eirik Ogilvie-Wigley 797713284c Update main_tests for shorter block times 2019-08-02 19:37:02 -06:00
Eirik Ogilvie-Wigley 27ee4d64f2 Fix integer truncation in Blossom halving calculation 2019-08-02 19:35:53 -06:00
Eirik Ogilvie-Wigley e6c0f743aa Do not send migration transactions that would expire after a network upgrade 2019-08-02 16:12:42 -06:00
Eirik Ogilvie-Wigley 65df6225a6 Do not create transactions that will expire after the next epoch 2019-08-02 16:01:20 -06:00
Homu c68511b876 Auto merge of #3926 - LarryRuane:3708-getaddressrpcs, r=str4d
add addressindex RPC for bitcore block explorer

Addresses #3708
2019-08-01 05:43:29 -07:00
Homu 2300b911f8 Auto merge of #4035 - Eirik0:use-committransaction, r=str4d
Use CommitTransaction

This enables `-walletbroadcast` to correctly control transactions created with `z_*` APIs. It also addresses some TODOs in the code and consolidates some repeated logic.

Closes #4077 (because `CommitTransaction` calls `KeepKey` on the transparent change address).
2019-08-01 03:04:06 -07:00
Eirik Ogilvie-Wigley 6c1df957ba Update metrics block height estimation for shorter block times 2019-07-31 15:16:25 -06:00
Eirik Ogilvie-Wigley ecfcb817ae Add test for Blossom default tx expiry delta 2019-07-31 14:34:48 -06:00
Eirik Ogilvie-Wigley e358e89db9 PartitionCheck tests for shorter block times 2019-07-31 12:20:15 -06:00
Larry Ruane 68e174e22b add addressindex related RPCs 2019-07-31 10:31:16 -06:00
Jack Grigg 19bd2d0e7c
Use reserve key for transparent change when sending to Sprout 2019-07-31 12:15:09 +01:00
Eirik Ogilvie-Wigley 1188c9adf7 Fix zip208 founders reward calculation and update test 2019-07-30 17:41:33 -06:00
Eirik Ogilvie-Wigley 8865f4b6f6 Update expiry height for shorter block times 2019-07-30 01:16:37 -06:00
Eirik Ogilvie-Wigley c5ac4321f9 Add message to static_assert 2019-07-29 23:25:08 -06:00
Eirik Ogilvie-Wigley 0bb79ea191 pow test cleanup 2019-07-29 19:07:56 -06:00
Eirik Ogilvie-Wigley 68e9d2164c Add missing new line at end of file 2019-07-29 19:07:27 -06:00
Eirik Ogilvie-Wigley e6b63d1f78 Use static_assert 2019-07-29 19:05:41 -06:00
Eirik Ogilvie-Wigley c0d27cb3f2 Simplify PartitionCheck 2019-07-29 18:29:39 -06:00
Eirik Ogilvie-Wigley 2c6c55261d Make NetworkUpgradeAvailable a method of Params 2019-07-29 14:47:06 -06:00
Eirik Ogilvie-Wigley 102dafdf89 Update block subsidy halving for zip208 2019-07-29 13:44:53 -06:00
Homu 0ba07d5842 Auto merge of #4056 - rex4539:fix-rpc-undefined-behavior, r=ebfull
Fix RPC undefined behavior

Closes https://github.com/zcash/zcash/issues/3792
2019-07-26 15:19:07 -07:00
Eirik Ogilvie-Wigley ff0820df5e Update test_pow for shorter block times 2019-07-26 10:48:16 -06:00
Eirik Ogilvie-Wigley c192e3a75d Update pow_tests for shorter block times 2019-07-26 10:34:23 -06:00
Dimitris Apostolou ff40531607 Fix RPC undefined behavior.
Co-Authored-By: Dimitris Apostolou <dimitris.apostolou@icloud.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-23 21:36:53 +01:00
Eirik Ogilvie-Wigley 7421272712 Make nextHeight required in CalculateNextWorkRequired 2019-07-18 14:57:13 -06:00
Daira Hopwood bc909a7a7f Replace http with https: in links to the MIT license.
Also change MIT/X11 to just MIT, since no distinction was intended.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
Daira Hopwood f63731261c Update copyright information for Zcash, leveldb, and libsnark.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 13:59:30 +01:00
Daira Hopwood 6db54c9861 Add MIT license to Makefiles
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 13:59:30 +01:00
Homu d2a5526202 Auto merge of #4053 - rex4539:shielded-funds, r=Eirik0
Fix naming inconsistency

Closes https://github.com/zcash/zcash/issues/3486
2019-07-17 12:36:37 -07:00
Simon d7ebbeb2aa Modify PartitionCheck to be aware of pre & post Blossom target spacing. 2019-07-11 14:17:58 -06:00
Simon 3a8fd5ea33 Replace nPoWTargetSpacing -> PoWTargetSpacing() in tests 2019-07-11 13:46:29 -06:00