Wladimir J. van der Laan
5901596548
json: fail read_string if string contains trailing garbage
...
Change `read_string` to fail when not the entire input has been
consumed. This avoids unexpected, even dangerous behavior (fixes #6223 ).
The new JSON parser adapted in #6121 also solves this problem so in
master this is a temporary fix, but should be backported to older releases.
Also adds tests for the new behavior.
Github-Pull: #6226
Rebased-From: 4e157fc60dae5ca69933ea4c1585a2a078b4d957
2015-06-03 15:16:37 +02:00
Jonas Schnelli
6145fdf47e
OSX: use "Bitcoin Core" as Bundle Display Name
...
Github-Pull: #6214
Rebased-From: 0a32a9347e12a8d1d4a46bf9a1d5b3ae13bbe501
2015-06-03 15:10:36 +02:00
Jonas Schnelli
4d435d1c9a
[OSX] revert renaming of Bitcoin-Qt.app
...
Github-Pull: #6214
Rebased-From: a2241eabfdbdadd2f96c0a538b9901257831b642
2015-06-03 15:10:00 +02:00
Cory Fields
7d4b5cbee3
gitian: Bump cache dir for 0.11
2015-06-02 10:47:07 -04:00
Luke Dashjr
c00ae64f77
Remove P2SH coinbase flag, no longer interesting
...
Github-Pull: #6203
Rebased-From: d449772cf69c01932fc5d72c46054815d6300b3c
2015-06-02 09:13:03 +02:00
Wladimir J. van der Laan
dfdb6dd052
build: disable optional use of gmp in internal secp256k1 build
...
Until secp256k1 is used for verification there is no reason for Bitcoin
Core's secp256k1 to link against gmp, even if available. Pass a flag to
configure to override the bignum implementation.
This fixes a crash at runtime on ppc64 reported by @gmaxwell.
Github-Pull: #6210
Rebased-From: 7fd5b801ff16d748b5ca13ded09ed5da8eacf7e7
2015-06-02 08:41:25 +02:00
Suhas Daftuar
b4bbad18ef
Ignore getheaders requests when not synced.
...
Rebased-From: a1ba0778dd3c784046dea334e5d39f37eca264f7
Github-Pull: #6172
2015-06-02 07:57:04 +02:00
Peter Todd
75a4d512cf
Fix off-by-one error w/ nLockTime in the wallet
...
Previously due to an off-by-one error the wallet ignored
nLockTime-by-height transactions that would be valid in the next block
even though they are accepted into the mempool. The transactions
wouldn't show up until confirmed, nor would they be included in the
unconfirmed balance. Similar to the mempool behavior fix in 665bdd3b
,
the wallet code was calling IsFinalTx() directly without taking into
account the fact that doing so tells you if the transaction could have
been mined in the *current* block, rather than the next block.
To fix this we strip IsFinalTx() of non-consensus-critical
functionality, removing the default arguments, and add CheckFinalTx() to
check if a transaction will be final in the next block.
Github-Pull: #6183
Rebased-From: 28bf06236d3b385e95fe26a7a742395b30efd6ee
2015-06-01 12:35:49 +02:00
Wladimir J. van der Laan
2be094eeba
qt: Periodic translation update
2015-06-01 12:35:05 +02:00
Wladimir J. van der Laan
8e15efa76c
Bump version to 0.11
2015-06-01 10:25:26 +02:00
Wladimir J. van der Laan
e9d0d252fc
Merge pull request #6208
...
d6922aa
[net, trivial] remove using namespace std pollution in netbase.cpp (Philip Kaufmann)
49b2292
[net, trivial] explicitly use std::string for FindNode (Philip Kaufmann)
2015-06-01 09:53:45 +02:00
Wladimir J. van der Laan
42746b0476
Merge pull request #6193
...
6e71efa
[REST] remove json input for getutxos, limit to query max. 15 outpoints (Jonas Schnelli)
64b8027
rest.cpp: strip whitespace (Jonas Schnelli)
2015-06-01 09:48:17 +02:00
Wladimir J. van der Laan
921ea89bc3
Merge pull request #6195
...
8273793
Eliminate compiler warning due to unused variable (Suhas Daftuar)
2015-06-01 08:49:47 +02:00
Philip Kaufmann
d6922aad2c
[net, trivial] remove using namespace std pollution in netbase.cpp
2015-05-31 15:48:23 +02:00
Philip Kaufmann
49b22928ee
[net, trivial] explicitly use std::string for FindNode
...
- in OpenNetworkConnection we have a FindNode call, which gets a const
char*, wheras we only have defined a FindNode for std::string
2015-05-31 15:44:22 +02:00
Wladimir J. van der Laan
b679a6b403
doc: Add to 0.11 release notes
...
Add information about further notable changes:
- Big endian support
- Memory usage optimization
- Disable wallet transaction broadcast
- Stream isolation for Tor
2015-05-29 17:32:31 +02:00
Wladimir J. van der Laan
fb061c3391
Merge pull request #6194
...
ee9a2e4
Fix walletbackup.py after directory restructuring (Suhas Daftuar)
2015-05-29 08:22:34 +02:00
Jonas Schnelli
6e71efa9f0
[REST] remove json input for getutxos, limit to query max. 15 outpoints
...
Remove possibility to send json encoded parameters to `/rest/getutxos/` to avoid possible DoS scenarios.
The JSON output option is untouched.
2015-05-27 20:10:02 +02:00
Suhas Daftuar
8273793350
Eliminate compiler warning due to unused variable
2015-05-27 13:04:59 -04:00
Wladimir J. van der Laan
ce56f5621a
Merge pull request #6173
...
e697343
Chainparams: Explicit CMessageHeader::MessageStartChars to functions in main: (Jorge Timón)
2015-05-27 16:20:55 +02:00
Jorge Timón
e69734309c
Chainparams: Explicit CMessageHeader::MessageStartChars to functions in main:
...
-UndoWriteToDisk
-WriteBlockToDisk
2015-05-27 16:01:07 +02:00
Suhas Daftuar
ee9a2e4271
Fix walletbackup.py after directory restructuring
...
Also add walletbackup.py to rpc-tests.sh
2015-05-27 10:00:15 -04:00
Wladimir J. van der Laan
c7c9af381c
Merge pull request #5669
...
da29ecb
Consensus: MOVEONLY: Move CValidationState from main consensus/validation (jtimon)
27afcd8
Consensus: Refactor: Decouple CValidationState from main::AbortNode() (Cory Fields)
2015-05-27 15:00:02 +02:00
Wladimir J. van der Laan
2b2d5b92b9
Merge pull request #6189
...
44e1aad
Autoprune release notes included (mrbandrews)
2015-05-27 13:26:39 +02:00
Wladimir J. van der Laan
c608b6daf9
Merge pull request #6097
...
7b7f258
rpc-tests: remove python-bitcoinrpc directory (Jonas Schnelli)
a85b2e2
pull-tester/rpc-tests.sh: disable script_test.py test (Jonas Schnelli)
3e875b1
pull-tester/rpc-tests.sh: allow passing throug of arguments (Jonas Schnelli)
00706a5
update rpc-tests readme.md (Jonas Schnelli)
344e08e
extend rpc-tests.sh control script with non-travis tests (Jonas Schnelli)
64937fe
[QA] restructure rpc tests directory (Jonas Schnelli)
2015-05-27 13:20:53 +02:00
Wladimir J. van der Laan
68aff60e4a
Merge pull request #6190
...
1fe4c4f
gitian-downloader: Update luke-jr's key (Luke Dashjr)
2015-05-27 11:51:00 +02:00
Jonas Schnelli
64b8027c5c
rest.cpp: strip whitespace
2015-05-27 09:41:14 +02:00
Wladimir J. van der Laan
0bcf04f046
Merge pull request #6153
...
8c35b6f
Parameter interaction: disable upnp if -proxy set (Wladimir J. van der Laan)
2015-05-27 09:33:01 +02:00
Wladimir J. van der Laan
df992b9c18
Merge pull request #6174
...
213f257
doc: add translation strings policy (Wladimir J. van der Laan)
2015-05-27 09:31:26 +02:00
Wladimir J. van der Laan
182686cdbd
Merge pull request #6186
...
b45c50c
Fix two problems in CSubNet parsing (Wladimir J. van der Laan)
19e8d7b
Simplify code for CSubnet (Wladimir J. van der Laan)
2015-05-27 09:08:39 +02:00
Luke Dashjr
1fe4c4fcff
gitian-downloader: Update luke-jr's key
2015-05-26 20:47:31 +00:00
mrbandrews
44e1aad500
Autoprune release notes included
2015-05-26 15:56:17 -04:00
Wladimir J. van der Laan
165e323d85
qt: Periodic translation update
2015-05-26 14:36:47 +02:00
Wladimir J. van der Laan
e3ed6a9785
doc: Add preliminary changelog for 0.11 to release notes
2015-05-26 14:35:48 +02:00
Wladimir J. van der Laan
9f7809f6c3
Merge pull request #5976
...
8ba7f84
Reduce download timeouts as blocks arrive (Suhas Daftuar)
2015-05-26 13:02:40 +02:00
Wladimir J. van der Laan
847be04449
Merge pull request #6187
...
8697ff3
Remove duplicate chainparams.h include from alert_tests (Michael Ford)
2015-05-26 12:02:36 +02:00
Michael Ford
8697ff33ed
Remove duplicate chainparams.h include from alert_tests
2015-05-26 17:16:21 +08:00
Wladimir J. van der Laan
e9af4e65b5
Merge pull request #5947
...
36cba8f
Alert if it is very likely we are getting a bad chain (Gavin Andresen)
2015-05-26 10:41:17 +02:00
Wladimir J. van der Laan
b45c50ce51
Fix two problems in CSubNet parsing
...
Fix two CSubNet constructor problems:
- The use of `/x` where 8 does not divide x was broken, due to a
bit-order issue
- The use of e.g. `1.2.3.4/24` where the netmasked bits in the network
are not 0 was broken. Fix this by explicitly normalizing the netwok
according to the bitmask.
Also add tests for these cases.
Fixes #6179 . Thanks to @jonasschnelli for reporting and initial fix.
2015-05-26 08:59:59 +02:00
Wladimir J. van der Laan
19e8d7be42
Simplify code for CSubnet
...
Simplify the code by using CAddress.ip directly, instead of the reversed
GetByte() semantics.
2015-05-26 08:59:13 +02:00
Wladimir J. van der Laan
e1412d3e96
Merge pull request #6159
...
ffdda4e
Catch errors on datadir lock and pidfile delete (Adam Weiss)
2015-05-24 10:57:22 +02:00
Wladimir J. van der Laan
2d84241d26
doc: Add historical release notes 0.9.5
2015-05-24 09:49:18 +02:00
Wladimir J. van der Laan
213f257a03
doc: add translation strings policy
2015-05-23 11:30:27 +02:00
Adam Weiss
ffdda4e8a7
Catch errors on datadir lock and pidfile delete
...
Prevents bad permissions (or other fs related problems) from resulting
in hard crashes with cryptic messages on startup and shutdown.
2015-05-22 14:15:22 -04:00
Wladimir J. van der Laan
7708fcde36
Merge pull request #6098
...
cc24610
Update Windows resource files (and add one for bitcoin-tx) (Luke Dashjr)
2015-05-22 08:35:38 +02:00
Wladimir J. van der Laan
b3024f077b
Merge pull request #6168
...
7f68c7d
contrib/linearize: Support linearization of testnet blocks (Jeff Garzik)
2015-05-22 08:17:08 +02:00
Luke Dashjr
cc24610fdb
Update Windows resource files (and add one for bitcoin-tx)
2015-05-22 02:56:55 +00:00
Wladimir J. van der Laan
4bf83b27b2
Merge pull request #6171
...
bdcf5de
Fix intermittent hang issue in scheduler_tests (Wladimir J. van der Laan)
2015-05-21 22:00:07 +02:00
Jonas Schnelli
7b7f258396
rpc-tests: remove python-bitcoinrpc directory
...
place authproxy.py at same level as other utility classes
2015-05-21 21:22:22 +02:00
Wladimir J. van der Laan
bdcf5dea7c
Fix intermittent hang issue in scheduler_tests
...
Don't clear `stopRequested` and `stopWhenEmpty` at the top of
`serviceQueue`, as this results in a race condition: on systems under
heavy load, some of the threads only get scheduled on the CPU when the
other threads have already finished their work. This causes the flags to
be cleared post-hoc and thus those threads to wait forever.
The potential drawback of this change is that the scheduler cannot be
restarted after being stopped (an explicit reset would be needed), but
we don't use this functionality anyway.
2015-05-21 19:07:10 +02:00