Sean Bowe
faca79eb2f
Initialize ThreadNotifyWallets before additional blocks are imported.
...
Co-authored-by: Daira Hopwood <daira@electriccoin.co>
2020-02-26 11:20:12 -07:00
Gregory Maxwell
9f4ad7e1c6
Move GetWarnings() into its own file.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-02-21 01:31:16 +00:00
Homu
a2d719b9ff
Auto merge of #4324 - zancas:4323_replace_boost_fn_w_std_fn, r=str4d
...
Replace boost::function with std::function
Fixes : #4323
This logic is cherry-picked from the relevant commit, as referenced here:
https://github.com/bitcoin/bitcoin/pull/10395
2020-02-07 20:49:18 +00:00
Daira Hopwood
eb5e328073
Add -maxtimeadjustment with default of 0 instead of the 4200 seconds used in Bitcoin Core.
...
Based on 40061b05dc
Co-authored-by: mruddy <mruddy@users.noreply.github.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-02-05 17:00:09 +00:00
practicalswift
b841318ce8
Replace boost::function with std::function (C++11)
2020-02-04 19:54:25 -07:00
Homu
fa341bcff0
Auto merge of #4270 - str4d:2074-wallet-2, r=str4d
...
Bitcoin wallet PRs 2
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7576
- bitcoin/bitcoin#7577
- bitcoin/bitcoin#7608
- bitcoin/bitcoin#7691
- bitcoin/bitcoin#7905
2019-12-18 23:53:21 +00:00
Jonas Schnelli
6c1b6c8ccc
[Wallet] refactor wallet/init interaction
2019-12-18 16:50:29 -06:00
Jonas Schnelli
5b376b5125
[Wallet] optimize return value of InitLoadWallet()
2019-12-18 16:50:29 -06:00
Jonas Schnelli
c3ca0163a8
[Wallet] move "load wallet phase" to CWallet
...
Zcash: Modified to move our modifications to "load wallet phase".
2019-12-18 16:50:29 -06:00
Jonas Schnelli
8dacb764bc
[Wallet] move wallet help string creation to CWallet
2019-12-18 16:50:29 -06:00
Homu
0a31c163c6
Auto merge of #4252 - str4d:wallet-interface-refactor, r=str4d
...
Wallet interface refactor
This refactors the logic introduced in #4144 to improve the separation between the node and wallet. The notifier thread now lives next in `src/validationinterface.cpp` directly next to the existing `CMainSignals` node-wallet interface.
Part of #3877 .
2019-12-18 22:48:26 +00:00
Jack Grigg
2c8dff00cc
ThreadNotifyRecentlyAdded -> ThreadNotifyWallets
2019-12-18 15:06:54 -06:00
Luke Dashjr
996d6c3f54
Common argument defaults for NODE_BLOOM stuff and -wallet
2019-12-17 12:18:50 -06:00
MarcoFalke
386245e164
mempool: Replace maxFeeRate of 10000*minRelayTxFee with maxTxFee
2019-12-17 12:18:50 -06:00
MarcoFalke
2187f93703
HelpMessage: Don't hide -mintxfee behind showDebug
2019-12-17 12:18:50 -06:00
MarcoFalke
4db07b29c8
[trivial] init: Use defaults MIN_RELAY_TX_FEE & TRANSACTION_MAXFEE
2019-12-17 12:18:50 -06:00
MarcoFalke
f4b9c3283d
translations: Don't translate markdown or force English grammar
2019-12-17 12:18:50 -06:00
MarcoFalke
ab77f894b7
Clarify what minrelaytxfee does
2019-12-17 12:18:50 -06:00
MarcoFalke
e3bdf82dc2
Init: Use DEFAULT_TRANSACTION_MINFEE in help message
2019-12-17 12:18:50 -06:00
MarcoFalke
3de455e138
[trivial] init cleanup
2019-12-17 12:18:50 -06:00
Homu
63c3d1ec94
Auto merge of #4227 - str4d:2074-scripts-1, r=str4d
...
Bitcoin script PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6335
- bitcoin/bitcoin#6424
- bitcoin/bitcoin#11058
- bitcoin/bitcoin#12460
- bitcoin/bitcoin#13194
Part of #2074 .
2019-12-17 17:05:58 +00:00
Homu
5db5bd749c
Auto merge of #4245 - oxarbitrage:issue4012, r=daira
...
Remove dead code
Closes https://github.com/zcash/zcash/issues/4012
Equivalent to bitcoin/bitcoin/pull/9822
2019-12-10 22:10:10 +00:00
Alfredo Garcia
c0d5b87277
readd create_directories
2019-12-09 18:04:06 -03:00
Jorge Timón
dd0c036538
Policy: MOVEONLY: Create policy/policy.h with some constants
...
Zcash: Adjusted to be move-only after our changes to the constants.
2019-12-04 20:34:11 +00:00
Homu
868c63f92d
Auto merge of #2390 - str4d:2132-mapargs-prep, r=str4d
...
Misc upstream PRs
Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6077
- Second commit only (first was already applied to 0.11.X and then reverted)
- https://github.com/bitcoin/bitcoin/pull/6284
- https://github.com/bitcoin/bitcoin/pull/6489
- https://github.com/bitcoin/bitcoin/pull/6235
- https://github.com/bitcoin/bitcoin/pull/6905
- https://github.com/bitcoin/bitcoin/pull/6780
- Excluding second commit (QT) and third commit (requires https://github.com/bitcoin/bitcoin/pull/6993 )
- https://github.com/bitcoin/bitcoin/pull/6961
- Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to.
- https://github.com/bitcoin/bitcoin/pull/7044
- https://github.com/bitcoin/bitcoin/pull/8856
- https://github.com/bitcoin/bitcoin/pull/9002
Part of #2074 and #2132 .
2019-12-04 19:20:44 +00:00
Jack Grigg
5fd97dcdf9
Wrap long line
2019-12-04 17:21:55 +00:00
Jack Grigg
784a481070
cleanup: Comments
2019-12-04 17:21:54 +00:00
Gregory Maxwell
9fee2baebf
Make connect=0 disable automatic outbound connections.
...
Otherwise it just responds to this obvious bit of configuration by
trying to connect to "0" in a loop.
2019-12-04 17:18:45 +00:00
Jorge Timón
71068892d2
Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs
2019-12-04 17:18:44 +00:00
Gregory Sanders
f4d9e06a90
Added additional config option for multiple RPC users.
2019-12-04 17:18:43 +00:00
MarcoFalke
e11e1ea58e
[trivial] Reuse translation and cleanup DEFAULT_* values
...
* DEFAULT_DISABLE_SAFEMODE = false
* Use DEFAULT_* constants for extern bools
2019-12-04 17:18:41 +00:00
Luke Dashjr
9bc915b02a
Bugfix: Omit wallet-related options from -help when wallet is not supported
2019-12-04 17:18:40 +00:00
Luke Dashjr
2e02bb21f7
Constrain constant values to a single location in code
2019-12-04 17:18:39 +00:00
Jack Grigg
363c945325
Initialize experimental mode in a separate function
2019-12-04 17:18:38 +00:00
Jonas Schnelli
a425ac9706
Initialize logging before we do parameter interaction
2019-12-04 17:18:37 +00:00
Jonas Schnelli
ef6b9b0fb2
Refactor parameter interaction, call it before AppInit2()
2019-12-04 17:18:36 +00:00
Luke Dashjr
5bedad9580
Bugfix: Omit wallet-related options from -help when wallet is disabled
2019-12-04 17:18:35 +00:00
Luke Dashjr
a624c49219
Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo
2019-12-04 17:18:34 +00:00
Luke Dashjr
3779bea091
Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool)
2019-12-04 17:18:33 +00:00
Luke Dashjr
b90ea483dd
Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method
2019-12-04 17:18:32 +00:00
Jorge Timón
bd87de60ed
Chainparams: Translations: DRY: options and error strings
...
Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine
2019-12-04 17:18:31 +00:00
Casey Rodarmor
aa1d014b40
Give a better error message if system clock is bad
...
Fixes #2007
This checks to see if the system clock appears to be bad and gives a
helpful error message. If the user's clock is set incorrectly, hopefully
they'll abort, fix it, and then save themselves a fruitless resync.
2019-12-04 17:18:29 +00:00
Homu
2383d1b1de
Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id
...
Remove option mempooltxinputlimit
This option is no longer used after Overwinter. Fixes #4209 .
2019-12-03 20:07:20 +00:00
str4d
6d57fcff13
Apply suggestions from code review
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-12-02 21:10:35 +00:00
Alfredo Garcia
afbf1a7082
remove dead code in init
2019-11-28 14:55:32 -03:00
Dagur Valberg Johannsson
fe1ff82a7d
Remove option mempooltxinputlimit
...
This option is no longer used after Overwinter. Fixes #4209 .
2019-11-19 10:35:39 +01:00
Jonas Schnelli
ea4ee8a222
[squashme] improve/corrects prune mode detection test for required wallet rescans
2019-11-14 13:56:19 +00:00
Jonas Schnelli
d510fb4aa4
[autoprune] allow wallet in pruned mode
2019-11-14 13:56:17 +00:00
Homu
fd8444d0b7
Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
...
Remove z_mergetoaddress from experimental state
Closes #3731 .
2019-11-11 01:57:21 -08:00
Homu
cb0a94cd21
Auto merge of #4161 - oxarbitrage:issue3621, r=Eirik0
...
remove duplicated prefix in errors and warnings
Fixes #3621
2019-11-05 09:55:54 -08:00