Alfredo Garcia
3fb8af512c
change regex
2020-01-21 21:24:21 -03:00
Alfredo Garcia
7cb45243fe
change convention
2020-01-20 12:23:52 -03:00
Alfredo Garcia
fce6000f76
allow negative index to getblockhash
2019-12-31 09:35:37 -03:00
Alfredo Garcia
3ac6dd5f5d
add negative height to getblock
2019-12-31 09:16:29 -03:00
Taylor Hornby
d7108d36b1
Update list of dependencies to check
2019-12-19 14:33:51 -07:00
Taylor Hornby
49f94dbe3d
Add GitHub API credential
2019-12-19 14:33:41 -07:00
Taylor Hornby
d83e8a6a44
Add Python script for checking if dependencies have updates.
2019-12-19 13:58:36 -07:00
Homu
0a31c163c6
Auto merge of #4252 - str4d:wallet-interface-refactor, r=str4d
...
Wallet interface refactor
This refactors the logic introduced in #4144 to improve the separation between the node and wallet. The notifier thread now lives next in `src/validationinterface.cpp` directly next to the existing `CMainSignals` node-wallet interface.
Part of #3877 .
2019-12-18 22:48:26 +00:00
Jack Grigg
f93db1219b
test: Update wallet RPC test with change to "absurdly high fee" limit
2019-12-18 15:40:50 -06:00
Jack Grigg
e77e8660e3
test: Add missing sync_all point
...
This file was renamed in master, so it was missed in the first commit.
2019-12-18 15:06:54 -06:00
Jack Grigg
4f6b477fb6
test: Reverse hashtx and hashblock ordering at start of ZMQ RPC test
...
The "hashtx" message was previously triggered synchronously inside
ConnectBlock, while the "hashblock" message is triggered in ConnectTip
immediately after ConnectBlock returns. Thus ZMQ would see a "hashtx"
for every relevant transaction, followed by a "hashblock".
Now, "hashtx" is triggered asynchronously once the cs_main lock is
dropped, which does not occur until after ConnectTip returns. Thus ZMQ
will see a "hashblock" immediately after the block is connected, and
then a "hashtx" for relevant transactions at some point afterwards.
2019-12-18 15:06:54 -06:00
Jack Grigg
d57af95802
test: Remove genesis-block Sapling activation from shorter_block_times
...
Sapling can't be activated in the genesis block without recomputing it,
and we already activate Sapling by default in block 1, which is fine for
this RPC test.
2019-12-18 15:06:54 -06:00
Jack Grigg
f7eaf921bc
test: Add sync_all points after block generation to RPC tests
...
Previously we only required synchronization points where blocks were
sent between nodes; now we need them between action and query operations
on the same node, because wallet notification of mined blocks no longer
occurs in real-time.
2019-12-18 15:06:54 -06:00
Jack Grigg
03db5c8ca3
Tie sync_blocks in RPC tests to notifier thread
2019-12-18 15:06:54 -06:00
MarcoFalke
6d2629dd64
[doc] Fix markdown
2019-12-17 12:18:50 -06:00
Alfredo Garcia
910ff448d6
remove SignatureHash from python rpc tests
2019-12-11 14:46:56 -03:00
Dimitris Apostolou
f0003239f8
Change "protect" terminology to "shield"
2019-12-04 23:17:06 +02:00
Homu
868c63f92d
Auto merge of #2390 - str4d:2132-mapargs-prep, r=str4d
...
Misc upstream PRs
Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6077
- Second commit only (first was already applied to 0.11.X and then reverted)
- https://github.com/bitcoin/bitcoin/pull/6284
- https://github.com/bitcoin/bitcoin/pull/6489
- https://github.com/bitcoin/bitcoin/pull/6235
- https://github.com/bitcoin/bitcoin/pull/6905
- https://github.com/bitcoin/bitcoin/pull/6780
- Excluding second commit (QT) and third commit (requires https://github.com/bitcoin/bitcoin/pull/6993 )
- https://github.com/bitcoin/bitcoin/pull/6961
- Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to.
- https://github.com/bitcoin/bitcoin/pull/7044
- https://github.com/bitcoin/bitcoin/pull/8856
- https://github.com/bitcoin/bitcoin/pull/9002
Part of #2074 and #2132 .
2019-12-04 19:20:44 +00:00
Jack Grigg
1088866455
pyflakes fixes
2019-12-04 19:16:20 +00:00
Gregory Sanders
f4d9e06a90
Added additional config option for multiple RPC users.
2019-12-04 17:18:43 +00:00
Homu
9a06ea5ab8
Auto merge of #4221 - rex4539:typo, r=mdr0id
...
Fix typo
2019-12-03 22:12:39 +00:00
Homu
2383d1b1de
Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id
...
Remove option mempooltxinputlimit
This option is no longer used after Overwinter. Fixes #4209 .
2019-12-03 20:07:20 +00:00
Alfredo Garcia
7e946d7ccb
add blockheight, blockindex and blocktime to z_listreceivedbyaddress
2019-12-03 11:24:30 -03:00
Homu
5e26d48a39
Auto merge of #4226 - str4d:2074-wallet-1, r=mdr0id
...
Bitcoin 0.12 wallet PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6057
- bitcoin/bitcoin#6415
Part of #2074 . Closes #3700 .
2019-12-03 06:53:27 +00:00
Homu
cc807987c9
Auto merge of #4244 - charlieok:add_check_depends_build_step, r=mdr0id
...
Add check-depends step to STAGE_COMMANDS list
Added to the beginning of the list of stage commands
2019-12-03 03:11:32 +00:00
Marshall Gaucher
017682f993
Update to stop random race error from assert
2019-12-02 17:39:00 -08:00
Marshall Gaucher
acea0f7715
Update z_sendmany calls passing int 0, instead of Decimal('0')
2019-12-02 15:37:10 -08:00
Marshall Gaucher
62f5bdfbdc
Update `import *` to unblock pyflakes from failing
2019-12-02 11:38:33 -08:00
Alfredo Garcia
de47393848
fix rpc testcase
2019-11-29 18:27:41 -03:00
Charlie O'Keefe
d4f70e5536
Add check-depends step to STAGE_COMMANDS list
2019-11-27 14:12:18 -08:00
Wladimir J. van der Laan
e427f70a8c
make proxy_test work on servers without ipv6
2019-11-27 10:38:14 -08:00
Dagur Valberg Johannsson
fe1ff82a7d
Remove option mempooltxinputlimit
...
This option is no longer used after Overwinter. Fixes #4209 .
2019-11-19 10:35:39 +01:00
Matt Corallo
60dc0a9e8e
Implement watchonly support in fundrawtransaction
...
Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524 ).
2019-11-14 15:46:07 +00:00
Matt Corallo
a0d211537c
Add p2sh option to importaddress to import redeemScripts
2019-11-14 14:48:21 +00:00
Dimitris Apostolou
40609b95ff
Fix typo
2019-11-12 12:51:45 +02:00
Homu
fd8444d0b7
Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
...
Remove z_mergetoaddress from experimental state
Closes #3731 .
2019-11-11 01:57:21 -08:00
Alfredo Garcia
01998bdc9e
remove zmergetoaddress from experimental state in rpc-tests
2019-11-06 10:57:10 -03:00
Eirik Ogilvie-Wigley
1ddc9ff231
Show time elapsed when running RPC tests
2019-10-23 15:04:14 -06:00
Eirik Ogilvie-Wigley
40a7156026
Remove dots and underscores from parameter names
2019-10-21 09:20:17 -06:00
Eirik Ogilvie-Wigley
64fc25ed6e
Update parameter names to match ZIP
2019-10-17 16:39:32 -06:00
Eirik Ogilvie-Wigley
2033395e51
minor rpc test clean up
2019-10-17 12:37:05 -06:00
Eirik Ogilvie-Wigley
b680185f48
mempool_limit rpc test cleanup
2019-10-09 12:50:00 -06:00
Eirik Ogilvie-Wigley
a515b0057a
No need to activate Overwinter/Sapling in rpc test
2019-10-07 14:43:44 -06:00
Eirik Ogilvie-Wigley
1a06727c0c
Performance: Store weighted transactions in a tree
2019-10-07 14:23:42 -06:00
Eirik Ogilvie-Wigley
0b2c5cfcc2
Grammatical fixes
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley
a48b1ba7e2
Rebuild weighted list on removal and fix size calculation
2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley
ae9ecf09e8
DoS protection: Weighted random drop of txs if mempool full
2019-10-07 14:23:41 -06:00
Daira Hopwood
7167dc9b2c
Test setting an expiry height of 0.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-26 20:43:52 +01:00
Homu
961c0d58ec
Auto merge of #4060 - str4d:remove-libsnark, r=daira
...
Remove libsnark
Closes #167 . Closes #416 . Closes #418 . Closes #437 .
Closes #521 . Closes #743 . Closes #750 . Closes #894 .
Closes #903 . Closes #1125 . Closes #1136 . Closes #1240 .
Closes #1264 . Closes #1516 . Closes #1517 . Closes #1651 .
Closes #2064 . Closes #2158 . Closes #3478 . Closes #3652 .
Closes #3744 .
2019-09-26 11:21:40 -07:00
Homu
62dc5f0821
Auto merge of #4144 - zcash:hotfix-v2.0.7-3, r=str4d
...
Release v2.0.7-3
2019-09-24 16:02:35 -07:00
Jack Grigg
9d8322a341
Enable RPC tests to wait on mempool notifications
2019-09-20 21:41:49 +01:00
Jack Grigg
982e924e98
tests: Clean up use of repr() in mininode
2019-09-16 12:23:46 +01:00
Homu
06507722ac
Auto merge of #4088 - LarryRuane:3708-insightexplorer-formatting, r=Eirik0
...
insightexplorer: formatting, pyflakes cleanups
These changes were too late (post-review) for the Insight Explorer PRs, see #3708 . No functional differences.
2019-09-04 10:57:56 -07:00
Jack Grigg
8669cb692d
test: Update RPC tests to use a minimum of Sapling
...
The p2p_nu_peer_management and rewind_index RPC tests still start from
Sprout, because they are explicitly (and only) testing network behaviour
across network upgrades.
The mempool_tx_input_limit test is removed because the flag has been
ignored since Sapling activation, and will be removed at some point in
the near future.
2019-08-22 17:26:54 +01:00
Jack Grigg
d7d4dd8a0f
test: Add hashFinalSaplingProxy to create_block
2019-08-22 15:44:18 +01:00
Jack Grigg
0097df5c7a
test: Add Sapling v4 transactions to mininode framework
2019-08-22 15:44:16 +01:00
Jack Grigg
3019c0be14
test: Require minimum of Sapling for all RPC tests
2019-08-22 15:42:54 +01:00
Jack Grigg
1f38ad2536
Remove libsnark unit tests from full test suite
2019-08-22 15:42:54 +01:00
Eirik Ogilvie-Wigley
b54725fbed
Remove constant
...
Co-Authored-By: str4d <thestr4d@gmail.com>
2019-08-19 12:30:24 -06:00
zebambam
5ac48d8ebc
Updated location to new download server, fixing #4100
2019-08-18 14:38:49 +01:00
Eirik Ogilvie-Wigley
94f642c80a
Enable shorter block times rpc test
2019-08-16 13:21:33 -06:00
Daira Hopwood
f58bc7b638
Add RPC test and test framework constants for Sapling->Blossom activation.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-16 20:19:18 +01:00
Jack Grigg
cfdf040332
test: Fix AuthServiceProxy closed conn detection
2019-08-16 20:19:18 +01:00
zebambam
929b302e40
Updated location to new download server
2019-08-14 11:42:31 -07:00
Larry Ruane
7c5a791b73
insightexplorer: formatting, pyflakes cleanups
2019-08-09 15:27:52 -06:00
Homu
5fd1f5afc0
Auto merge of #3972 - LarryRuane:3708-getblockhashesrpc, r=str4d
...
3708 getblockhashesrpc
Part of #3708
2019-08-09 08:00:17 -07:00
Homu
2528af69ff
Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
...
Implement ZIP 208: Shorter Block Target Spacing
Closes #3690 .
2019-08-09 02:35:30 -07:00
Larry Ruane
2e505df351
add timestampindex related RPC getblockhashes
2019-08-08 14:35:07 -06:00
Larry Ruane
86b23f37ad
add spentindex RPC for bitcore block explorer
2019-08-07 14:23:42 -06:00
Eirik Ogilvie-Wigley
2f00729061
Add copyright info
2019-08-05 19:05:11 -06:00
Eirik Ogilvie-Wigley
42a21ef004
Test clean up and fixes
2019-08-05 14:52:34 -06:00
Eirik Ogilvie-Wigley
65df6225a6
Do not create transactions that will expire after the next epoch
2019-08-02 16:01:20 -06:00
Homu
c68511b876
Auto merge of #3926 - LarryRuane:3708-getaddressrpcs, r=str4d
...
add addressindex RPC for bitcore block explorer
Addresses #3708
2019-08-01 05:43:29 -07:00
Homu
2300b911f8
Auto merge of #4035 - Eirik0:use-committransaction, r=str4d
...
Use CommitTransaction
This enables `-walletbroadcast` to correctly control transactions created with `z_*` APIs. It also addresses some TODOs in the code and consolidates some repeated logic.
Closes #4077 (because `CommitTransaction` calls `KeepKey` on the transparent change address).
2019-08-01 03:04:06 -07:00
Jack Grigg
907554be3a
test: Fix pyflakes warnings
2019-08-01 10:43:03 +01:00
Jack Grigg
8e48ca1fb2
test: Fix permissions on wallet_changeaddresses RPC test
2019-08-01 10:21:27 +01:00
Larry Ruane
68e174e22b
add addressindex related RPCs
2019-07-31 10:31:16 -06:00
Jack Grigg
6bc69c39cb
test: Check for change t-addr reuse in z_sendmany
2019-07-31 12:11:14 +01:00
Eirik Ogilvie-Wigley
07851670b4
Temporarily disable test
2019-07-29 15:04:34 -06:00
Eirik Ogilvie-Wigley
102dafdf89
Update block subsidy halving for zip208
2019-07-29 13:44:53 -06:00
Homu
5306121e5c
Auto merge of #4075 - Eirik0:4059-fix-migration-test, r=Eirik0
...
Fix nondeterministic failure in sapling migration test
Fixes #4059
2019-07-26 01:06:55 -07:00
Eirik Ogilvie-Wigley
a63ec6e717
Shorter block times rpc test
2019-07-25 12:49:15 -06:00
Eirik Ogilvie-Wigley
5fc227c7dd
Apply suggestions from code review
...
Show migration status in assertion failures
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-07-25 12:35:10 -06:00
Eirik Ogilvie-Wigley
6a3f9d8260
Clean up and fix typo
2019-07-24 15:43:08 -06:00
Homu
6da42887f1
Auto merge of #3944 - daira:update-license-info, r=daira
...
Update license info
Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes.
Fixes #2827 .
2019-07-24 04:07:03 -07:00
Eirik Ogilvie-Wigley
ded45b90d7
Fix nondeterministic failure in sapling migration test
2019-07-20 14:36:08 -06:00
Daira Hopwood
2fe59a5681
qa/zcash/checksec.sh is under a BSD license, with a specialized non-endorsement clause.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:31:39 +01:00
Daira Hopwood
bc909a7a7f
Replace http with https: in links to the MIT license.
...
Also change MIT/X11 to just MIT, since no distinction was intended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
Homu
1c899f5a83
Auto merge of #4044 - Eirik0:fix-mergetoaddress-test-comment, r=Eirik0
...
Fix comment in mergetoaddress RPC test
2019-07-18 06:12:22 -07:00
Dimitris Apostolou
f57f76d789
Rename vjoinsplit to vJoinSplit
2019-06-16 19:13:49 +03:00
Eirik0
c9d14272af
Fix comment in mergetoaddress RPC test
2019-06-11 14:32:57 -06:00
Larry Ruane
f381d4e085
add spentindex to getrawtransaction RPC results
2019-06-11 10:29:51 -06:00
Eirik0
a8055cfe10
Fix z_mergetoaddress sending from ANY_SPROUT/ANY_SAPLING when the wallet contains both note types
2019-06-10 13:21:25 -06:00
Eirik0
bb0a3e1cb5
Remove old mergetoaddress RPC test
2019-05-22 16:01:50 -06:00
Eirik0
23d9826ef9
Fix LogPrint statements
2019-05-10 17:25:30 -06:00
Eirik0
7470ae8885
Do not automatically remove async migration operations and return txids
2019-05-10 17:19:56 -06:00
Daira Hopwood
e7529049fb
Test the expiry height of migration transactions.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Eirik0
7cf4749d0d
Correctly account for migration transactions in the mempool
...
Co-authored-by: LarryRuane <larry@z.cash>
2019-05-05 12:59:43 -06:00
Eirik0
345177cfc1
Do not look at vin/vout when determining migration txs and other cleanup
2019-04-30 09:52:53 -06:00
Eirik0
e9530f40f2
use -valueBalance rather than vpub_new to calculate migrated amount
2019-04-29 17:00:26 -06:00
Eirik0
108e587c14
Fix typos and update documentation
2019-04-29 15:29:29 -06:00
Eirik0
2276133bb3
Test migration using both the parameter and the default Sapling address
2019-04-29 15:29:29 -06:00
Eirik0
6e82d72852
Add rpc to get Sprout to Sapling migration status
2019-04-29 15:28:35 -06:00
Eirik0
6acb37bcee
Check for full failure message in test case
2019-04-26 19:01:23 -06:00
Eirik0
5519d16997
Set min depth when selecting notes to migrate
2019-04-25 13:43:23 -06:00
Eirik0
d2a584e35a
Refactor wait_and_assert_operationid_status to allow returning the result
2019-04-24 11:31:14 -06:00
Eirik0
699288b4b4
Documentation cleanup
2019-04-24 11:31:14 -06:00
Eirik0
81a45d6984
Add rpc to enable and disable Sprout to Sapling migration
2019-04-24 11:31:14 -06:00
Simon
d6b47948bf
Add qa test for experimental feature: -developersetpoolsizezero
2019-04-23 15:05:15 -07:00
Jack Grigg
3cb20f26a1
test: Make expected_utxos optional in get_coinbase_address()
2019-03-06 09:03:55 +13:00
Jack Grigg
b0f1d643aa
test: Fetch coinbase address from coinbase UTXOs
...
After upstream PR bitcoin/bitcoin#5994 , the first call to getnewaddress after
startup does not return the address being used by the miner.
2019-03-06 09:03:51 +13:00
Homu
48b7dea5a8
Auto merge of #3639 - leto:size_on_disk, r=bitcartel
...
Port getblockchaininfo.size_on_disk from BTC master
Closes #3630 .
2019-02-25 10:08:44 -08:00
Jack Grigg
ecde950bac
Add Sapling benchmarks to benchmark runner
2019-02-16 18:44:16 +00:00
Eirik Ogilvie-Wigley
a482e4c9fa
Strategically sync to prevent intermittent failures
2019-01-17 15:00:57 -07:00
Eirik Ogilvie-Wigley
32212cbad7
Extract helper methods
2019-01-17 15:00:57 -07:00
Eirik Ogilvie-Wigley
5e654035a6
fail test if pong is not received
2019-01-17 15:00:57 -07:00
Eirik Ogilvie-Wigley
3dab742638
Check entire contents of mempool
2019-01-17 15:00:52 -07:00
Eirik Ogilvie-Wigley
57dcc9e6bf
Make variables local
2019-01-17 14:58:50 -07:00
Eirik Ogilvie-Wigley
73859fd218
Move common code to helper
2019-01-17 14:58:46 -07:00
Eirik Ogilvie-Wigley
23b329d912
flake8 cleanup
2019-01-14 14:00:24 -07:00
mdr0id
4ca5def62f
Make pythonisms consistent
2018-12-18 12:16:23 -08:00
Simon
067b6f9373
For ZEC-013. Update qa tests broken by expiring soon threshold.
2018-11-17 09:02:10 -08:00
Simon
4484c76202
For ZEC-013. RPC createrawtransaction returns error if tx expiring soon.
2018-11-17 09:02:10 -08:00
Simon
cc1ab2db55
For ZEC-013. Don't propagate txs which are expiring soon in p2p messages.
...
When responding to "mempool" message, do not include the txid of an
expiring soon transaction in the "inv" message reply.
When responding to "getdata" message, do not reply with a "tx" message
for a transaction which is expiring soon.
2018-11-17 09:02:00 -08:00
Simon
f8cd79c2de
For ZEC-013. Mitigate potential tx expiry height related DoS vector.
...
Don't accept transactions which are about to expire (next 3 blocks).
Don't set a ban score if a peer does propragate these transactions.
See ZEC-013 for more detail.
2018-11-17 09:01:49 -08:00
Simon
43040e9384
Add support for "notfound" message to mininode.
2018-11-17 08:27:41 -08:00
Homu
a47e1fda73
Auto merge of #3684 - str4d:load-sapling-chain-value, r=bitcartel
...
Load sapling chain value into memory
`CBlockIndex::nSaplingValue` has been correctly set and written to disk since before Sapling activated, meaning that all nodes now are correctly tracking the Sapling shielded pool value on-disk. However, on restart the per-block values are not being read into memory, and so the in-memory pool value appears to be zero on every restart. Setting `nSaplingValue` in-memory during block index loading fixes the problem.
2018-11-16 21:07:46 -08:00
Eirik Ogilvie-Wigley
e0b89f59f9
Adjust z_mergetoaddress assertions in Sapling rpc test
2018-11-16 18:14:58 -07:00
Eirik Ogilvie-Wigley
0adb77d32e
Add locking for Sapling notes
2018-11-16 18:14:58 -07:00
Eirik Ogilvie-Wigley
487c9020bd
Add Sapling support to z_mergetoaddress
2018-11-16 18:14:58 -07:00
Eirik Ogilvie-Wigley
e0c491c073
Extend Sprout mergetoaddress rpc test to also work for Sapling
2018-11-16 18:14:57 -07:00
Eirik Ogilvie-Wigley
fe393e8a2f
Add fail method to rpc test utils
2018-11-16 18:00:05 -07:00
Simon
12a1267a4a
Update qa tests for new "sapling" default for z_getnewaddress.
2018-11-16 14:22:23 -08:00
Jack Grigg
4e117579c5
Test Sapling value pool accounting
2018-11-16 16:14:52 +00:00
Jonathan "Duke" Leto
6c1bf4e7ed
Add size_on_disk test
...
Co-authored-by: Simon <simon@bitcartel.com>
2018-11-14 15:04:05 -08:00
Homu
97fccdbac5
Auto merge of #3605 - LarryRuane:3604-memo-zeros, r=daira
...
3604 fix sapling default memo - 0xF6 plus zeros
Closes #3604 . For Sapling outputs, set the default memo to `no_memo` instead of all zeros. (See section 5.5 of the Sapling protocol specification.)
2018-10-28 03:15:07 -07:00
Eirik Ogilvie-Wigley
882a4f577f
Fix potentially misleading test failures
2018-10-24 13:53:25 -06:00
Larry Ruane
245db9c8a6
update bug in wallet_listreceived.py, now it highlights the fix
2018-10-24 08:13:56 -06:00
Homu
d810703431
Auto merge of #3588 - bitcartel:hash_final_sapling_root_verification, r=bitcartel
...
Add test to verify final sapling root in block header is updated.
2018-10-18 17:52:11 -07:00
Simon
61caa46619
For #3359 . Return error if Sapling addresses passed to RPC z_mergetoaddress.
...
RPC z_mergetoaddress does not support Sapling yet but the existing error
reporting was not clear to users.
2018-10-13 08:10:10 -07:00
Simon
de1b86a429
For #3359 . RPCs transferring funds return error if Sapling addresses are used before Sapling activation.
2018-10-12 23:14:06 -07:00
Homu
527b7feef5
Auto merge of #3592 - Eirik0:z-sendmany-better-error, r=bitcartel
...
Better error message when sending to both sprout and sapling
When trying to send to both Sprout and Sapling (not currently supported with z_sendmany) we were getting the following error in our operation result: `general exception: boost::bad_get: failed value get using boost::get`.
This PR changes this to fail with a better error message before the async operation begins:
```
error code: -8
error message:
Cannot send to both Sprout and Sapling addresses using z_sendmany
```
2018-10-12 15:30:34 -07:00
Eirik Ogilvie-Wigley
0917c84d9a
Better error message when sending to both sprout and sapling
...
Co-authored-by mdr0id <marshall@z.cash>
2018-10-12 14:12:21 -06:00
Simon
01918e8742
Update test to verify Sapling nullifiers and witnesses persist correctly.
2018-10-11 21:52:56 -07:00
arielgabizon
eb0bf23751
add test for sapling spend with transparent recipient
2018-10-11 15:22:20 +02:00
Simon
56765e24cb
Add test to verify final sapling root in block header is updated.
2018-10-10 17:30:58 -07:00
Eirik Ogilvie-Wigley
3f824a908b
Fix HDSeed comment
2018-10-10 16:00:59 -06:00
Homu
732e167043
Auto merge of #3450 - leto:rpctest-readme, r=str4d
...
Fix some typos in rpc-tests readme
2018-10-09 13:18:07 -07:00
Homu
c2bb0ec67f
Auto merge of #3517 - mdr0id:3388_persist_wallet, r=str4d
...
Sapling support for persisting wallet to disk
Closes #3388 . Closes #3061 .
2018-10-08 09:53:34 -07:00
Simon
01282e4fa6
Update wallet_persistence test to verify spending notes after restart.
2018-10-07 16:22:33 -07:00
Simon
08f1baaaca
Update wallet_persistence test to verify wallet txs are persisted across restarts.
2018-10-06 22:53:24 -07:00
Simon
5537bf5cdb
Fix file permissions of QA test wallet_persistence.py
2018-10-06 21:05:30 -07:00
mdr0id
2fcf06077f
Persist Sapling key material in the wallet to disk
2018-10-06 00:01:14 +01:00
mdr0id
87ae893d75
Revert "wallet: Comment out HDSeed and CHDChain persistence to disk"
...
This reverts commit b7f9a7ae02
.
2018-10-05 17:46:43 +01:00
Homu
625797a037
Auto merge of #3518 - str4d:3216-z_shieldcoinbase, r=str4d
...
Add Sapling support to z_shieldcoinbase
Part of #3216 .
2018-10-05 03:33:16 -07:00
Jack Grigg
089ec92e7b
Fix pyflakes warnings
2018-10-05 11:32:22 +01:00
Homu
967bbbc486
Auto merge of #3561 - bitcartel:3560_update_sapling_note_data, r=bitcartel
...
Closes #3560 . Update Sapling note data correctly when importing a key.
2018-10-04 15:37:34 -07:00
Jack Grigg
f09aae037c
Update wallet_listreceived test for now-correct empty Sapling memos
2018-10-04 22:46:15 +01:00
Homu
4ba35551d4
Auto merge of #3510 - arcalinea:3378_z_listunspent, r=bitcartel
...
Sapling support for z_listunspent
Closes #3378 .
2018-10-04 11:39:14 -07:00
Simon
f0dcfceb81
Closes #3560 . Update Sapling note data correctly when importing a key.
2018-10-03 15:40:50 -07:00
Jack Grigg
5f91a95641
Add Sapling support to z_shieldcoinbase
...
Part of #3216 .
2018-10-03 12:16:18 +01:00
Homu
bcdb4344f0
Auto merge of #3548 - Eirik0:3546-sapling-coin-priority, r=bitcartel
...
Use max priority for all shielded transactions
Addresses https://github.com/zcash/zcash/issues/3546#issuecomment-425184034
2018-10-01 10:13:15 -07:00
Simon
b7549f2aec
Add test that Sapling shielded transactions have MAX_PRIORITY
2018-09-30 17:23:53 -07:00
Simon
5f57babd08
Cleanup to address review comments.
2018-09-28 22:11:05 -07:00
Larry Ruane
d7d6480ce3
z_listunspent rpc unit test: add testing for Sapling
2018-09-28 15:23:24 -07:00
Jay Graber
011f9a02ef
Add rpc test for sprout txs z_listunspent
2018-09-28 15:19:10 -07:00
Larry Ruane
e4f0d6a8de
Sapling support for z_listreceivedbyaddress
2018-09-27 16:59:29 -06:00
Simon
4c4e1718b1
Update qa test as offline regtest nodes need branch id passed in.
2018-09-21 17:16:44 -07:00
Simon
18f8abb62d
Closes #3534 . Do not use APPROX_RELEASE_HEIGHT to get consensus branch
...
id when in regtest mode.
Co-authored-by: Larry Ruane <larryruane@gmail.com>
2018-09-21 11:10:15 -07:00
Homu
36243f41f1
Auto merge of #3520 - Eirik0:3327-sign-offline, r=bitcartel
...
Fix signing raw transactions with unsynced offline nodes
This PR address the issue in two different ways:
- In `signrawtransaction` we determine the consensus branch ID (which we then later use to construct the transaction) using the chain height. We now also consider the `APPROX_RELEASE_HEIGHT` as this is a better estimation than 0 for the height of the chain if we are unsynced. (This in and of itself solves the Overwinter signing issue).
- We have added an additional parameter to `signrawtransaction` to allow manually overriding the consensus branch ID that zcashd determines we are on. This allows users to work around corner cases where the first strategy is still insufficient.
Closes #3327 .
2018-09-19 15:02:52 -07:00
Eirik Ogilvie-Wigley
c10249f3de
Remove unused import
2018-09-19 14:41:02 -06:00
Homu
25c3f903c1
Auto merge of #3491 - Eirik0:3218-sapling-import-export-wallet, r=str4d
...
Add Sapling support to z_importwallet and z_exportwallet
Includes code adapted from upstream PR https://github.com/bitcoin/bitcoin/pull/8323
Closes #3218 .
2018-09-19 12:15:48 -07:00
Homu
379c7439a0
Auto merge of #3479 - Eirik0:rpc-test-cleanup, r=bitcartel
...
Rpc test cleanup
The main purpose of this PR was to inline the method 'wait_for_async_operation_id' from util.py in tests where we were doing this manually. To make it work in all cases, I had to change the method to return the result in the case where the call failed. I also did a bit of general clean up (removing semicolons) in the files which I changed.
2018-09-18 20:05:39 -07:00
Homu
e95bdeabbf
Auto merge of #3521 - bitcartel:sapling_json_data, r=str4d
...
Add Sapling fields to JSON RPC output using TxToJSON.
Related to #3063 to add Sapling support to wallet RPCs.
2018-09-18 12:13:14 -07:00
Simon
3501519bc8
Update qa test to check for Sapling related JSON fields.
2018-09-17 10:01:50 -07:00
Eirik Ogilvie-Wigley
40b9527301
Incorporate APPROX_RELEASE_HEIGHT when determining what consensus branch to sign with
2018-09-17 10:27:39 -06:00
Eirik Ogilvie-Wigley
19697025c6
Add test for signing raw transactions offline
2018-09-17 10:27:37 -06:00
Eirik Ogilvie-Wigley
5602e1f1a6
Allow passing timeout parameter to wait_and_assert_operationid_status
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
e39f0e16c2
Remove unused imports
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
4d89d020a6
Remove unneeded semicolons
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
f081d9cb02
Use utility method to wait for async operations
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
611f93244b
Allow more information to be returned when an async rpc fails
2018-09-14 18:41:14 -06:00
Eirik Ogilvie-Wigley
b37dc4e22f
Don't export empty zip32 metadata
2018-09-14 18:36:24 -06:00
Eirik Ogilvie-Wigley
2fe39561ec
Export zip32 metadata with sapling keys
2018-09-14 17:27:20 -06:00
Eirik Ogilvie-Wigley
ae807af413
Export comment on HDSeed and fingerprint with wallet
2018-09-14 17:26:02 -06:00
Eirik Ogilvie-Wigley
9bcf90e2de
Add sapling support to z_importwallet
2018-09-14 16:16:03 -06:00
Eirik Ogilvie-Wigley
5e360fb29f
Add sapling spending keys to z_exportwallet
2018-09-14 15:07:15 -06:00
Jack Grigg
8e057ad9ee
qa: Test both Overwinter and Sapling peer management
2018-09-12 12:15:37 +01:00
Jack Grigg
b7f9a7ae02
wallet: Comment out HDSeed and CHDChain persistence to disk
...
Sapling keys generated from the seed are not yet persisted, so we don't
want to persist the seed or chain state either, otherwise the wallet
could end up in an inconsistent state.
Some tests are temporarily disabled because commenting out HDSeed
persistence breaks invariants inside CCryptoKeyStore.
Revert this commit during the PR for #3388 .
2018-09-03 10:45:37 +01:00
Jack Grigg
af04224522
Fix file permissions of wallet_sapling RPC test
2018-09-03 08:27:33 +01:00
Jack Grigg
0f436a0a26
Fix RPC test that checks exact wording of cleaned-up error message
2018-09-03 08:23:09 +01:00
Jack Grigg
e54c4d2ca1
rpcwallet: Add Sapling support to z_sendmany
2018-08-27 11:36:14 +01:00
Homu
622751da12
Auto merge of #3444 - LarryRuane:2982-mininode-version, r=str4d
...
generalize mininode.py protocol versioning
Fixes #2982 -- replace `overwintered` boolean argument to NodeConn constructor with a protocol version integer, so that adding Sapling (and beyond) will be easier.
2018-08-20 09:48:51 -07:00
Eirik Ogilvie-Wigley
4e1e91512d
Fix assertion and comment
2018-08-06 09:58:40 -06:00
Eirik Ogilvie-Wigley
7929851626
Only include the change field if we have a spending key
2018-08-06 09:58:40 -06:00
Jonathan "Duke" Leto
41ecade012
Fix some typos in rpc-tests readme
2018-08-05 21:51:35 -07:00
Larry Ruane
c0aa34a4b2
generalize mininode.py protocol versioning
2018-08-02 20:30:20 -06:00
Homu
066cc9c6c7
Auto merge of #3429 - str4d:3217-sapling-address-creation, r=str4d
...
Add Sapling support to z_getnewaddress and z_listaddresses
Closes #3217 .
2018-08-01 12:01:39 -07:00
Jack Grigg
4aabeebc1f
test: Fix permissions of wallet_addresses
2018-08-01 19:56:01 +01:00
Jack Grigg
d75e69da5a
test: Deduplicate logic in wallet_addresses RPC test
2018-08-01 09:44:31 +01:00
Simon
f01c11bd0f
Add tests for expiryheight parameter of RPC createrawtransaction.
2018-07-30 10:24:10 -07:00
Jack Grigg
eec85c4388
Add Sapling support to z_getnewaddress and z_listaddresses
2018-07-30 16:24:20 +01:00
Larry Ruane
cb3a815b29
Add call to sync_all() after (z_sendmany, wait)
2018-07-20 12:00:41 -06:00
Daniel Cousens
4b184205e3
rpc: update inline comments to refer to new file paths
2018-07-18 11:07:17 -06:00
Homu
b9bd5ab42c
Auto merge of #3354 - leto:absurd_fee_bug, r=bitcartel
...
Fix absurd fee bug reported in #3281 , with tests
This was ported from the Hush `absurd_fee_bug` PR: https://github.com/MyHush/hush/pull/136
Tests executed with `./qa/pull-tester/rpc-tests.sh wallet` and pass on Ubuntu 16.04. Some tests were added for previously untested behavior as well.
Closes #3281 .
2018-07-17 15:03:08 -07:00
Simon
0b6eeac330
Update and fix per review comments, the test for absurd fee.
2018-07-17 13:00:42 -07:00
Homu
13b41a6760
Auto merge of #3156 - Eirik0:2935-change-indicator, r=bitcartel
...
Add change indicator
This adds to the json returned when calling z_listreceivedbyaddress and z_listuspent an additional field entitiled 'change' which will be either true or false depending on whether or not the note was change from another transaction.
2018-07-17 11:41:03 -07:00
Eirik Ogilvie-Wigley
62d707d1fd
Fix test broken by change indicator
2018-07-16 14:50:06 -06:00
Eirik Ogilvie-Wigley
0646f749f9
Add change indicator for notes
2018-07-16 14:49:29 -06:00
Homu
f649bb36c5
Auto merge of #3303 - LarryRuane:2807-rpc-test-round-fees, r=bitcartel
...
(rpc-test) accurately account for fee without rounding error
Fix for #2807 , this test compares balances after doing key exports and imports, and expects these balances to be equal. But they are not exactly equal due to transaction fees, so the test makes them "equal" by rounding a value that has had fees taken out up to the nearest hundredth of a unit (which is much more than the default fee). This obviously is somewhat sloppy. It also converts a balance to float, which really should never be used due to loss of precision (use Decimal instead).
This change makes the test accurately account for the fee using precise comparisons, and removes the use of float. This test doesn't depend on the default fee (0.0001) but instead sets the fee (to that value). This way, if the default fee changes in the future, this test will continue to run. While testing these changes, I set the fee to various values (up to the max, 0.0190), and the test still passes.
2018-06-22 14:01:48 -07:00
Simon
a4ff089b2a
Fix pyflakes error in test zkey_import_export.
2018-06-22 11:34:21 -07:00
Duke Leto
e5aa9f617b
Fix absurd fee bug reported in #3281 , with tests
2018-06-22 05:20:45 +00:00
Homu
4e3ff06507
Auto merge of #3320 - str4d:macos-tests, r=bitcartel
...
Fix MacOS tests
Includes code cherry-picked from upstream PR bitcoin/bitcoin#8270 .
2018-06-18 19:00:56 -07:00
Jack Grigg
341a22ad90
Skip ELF-only sec-hard checks on non-ELF binaries
2018-06-07 18:49:15 +12:00
Jack Grigg
c7e64754dc
Add MacOS support to no-dot-so test
2018-06-05 22:32:13 +12:00
Eirik Ogilvie-Wigley
25c13ef702
Add hashFinalSaplingRoot to getblocktemplate
2018-06-01 15:47:30 -06:00
Larry Ruane
fff031688e
(rpc-test) accurately account for fee without rounding error
2018-05-24 11:29:14 -04:00
Homu
386a9b35c0
Auto merge of #3238 - str4d:3199-mempool-sapling-activation, r=str4d
...
Update mempool_nu_activation RPC test to exercise both Overwinter and Sapling
Closes #3199 .
2018-05-16 13:52:40 -07:00
Eirik Ogilvie-Wigley
a81b36d267
Add more options when asserting in RPC tests
2018-05-04 09:38:36 -06:00
Jack Grigg
11aa594440
Remove obsolete CreateJoinSplit and GenerateParams binaries
2018-05-03 13:18:03 +01:00
Jack Grigg
2c34c1cbff
Update mempool_nu_activation RPC test to exercise both Overwinter and Sapling
...
Closes #3199 .
2018-05-03 01:07:41 +01:00
Simon
9bd8f092c6
Closes #3178 by adding verbosity level improvements to getblock RPC.
...
This is a follow-up commit for d0a1d833520d120bb5a2ac4cf4192047af6afe24
found in PR #3095 in order to fix nits and add a test.
2018-04-30 11:51:59 -07:00
Homu
68cf6f3c2d
Auto merge of #3074 - arcalinea:2983_tx_expiry_test_dependent, r=str4d
...
Add test for dependent txs to mempool_tx_expiry.py
Closes #2983
Also replaced absolute blockheight check with a relative height check.
2018-04-23 15:50:16 -07:00
Jay Graber
7dc0f84788
Add test for dependent txs to mempool_tx_expiry.py
2018-04-18 06:34:09 -07:00
mruddy
690d38f0f8
Resolve issue bitcoin/bitcoin#3166 .
...
These changes decode valid SIGHASH types on signatures in assembly (asm) representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from jtimon, laanwj, and sipa.
2018-04-16 07:38:36 -06:00
Jonas Schnelli
216e94fb24
[RPC] createrawtransaction: add option to set the sequence number per input
2018-04-12 18:10:04 -06:00
Jack Grigg
3fe2f3d143
Update -enforcenodebloom RPC test with filterclear vs filteradd
2018-04-05 01:30:38 +01:00
Jack Grigg
b77e46fe01
Add RPC test for -enforcenodebloom
2018-04-05 01:30:38 +01:00
Jack Grigg
10e97b8f00
test: Add missing Overwinter fields to mininode's CTransaction
2018-04-04 22:49:49 +01:00
Daira Hopwood
473a113241
Don't increase banscore if the transaction only just expired.
...
Author: Jack Grigg <str4d@z.cash>
2018-04-04 01:29:47 +01:00
Daira Hopwood
a0ea82301a
Test that receiving an expired transaction does not increase the peer's ban score.
2018-04-04 00:01:49 +01:00
Daira Hopwood
697140ede5
Add support for Overwinter v3 transactions to mininode framework.
2018-04-04 00:01:23 +01:00
Jack Grigg
26cdb83add
Update blockchain.py RPC test for Zcash
2018-04-03 20:40:54 +01:00
Pieter Wuille
f95bf4c417
Fix chainstate serialized_size computation
2018-04-03 20:40:54 +01:00
James O'Beirne
79272bfaf9
Add tests for gettxoutsetinfo, CLevelDBBatch, CLevelDBIterator
...
Thanks @dexX7.
2018-04-03 20:40:54 +01:00
Homu
3055fd5508
Auto merge of #3136 - str4d:2937-z_importviewingkey-startheight, r=daira
...
Fix z_importviewingkey startHeight parameter
Closes #2937 .
Co-authored-by: Tomas M <tomas@slax.org>
2018-04-03 09:41:09 -07:00
Homu
3a47b9bcfd
Auto merge of #3132 - str4d:2898-rewind-block-index, r=daira
...
When rewinding, remove insufficiently-validated blocks
If a block is insufficiently-validated against a particular branch ID, then we
cannot guarantee that even the block header will be valid under the actual
consensus rules the node will want to apply. Instead require that the blocks are
completely re-validated, by removing them from the block index (which is
equivalent to reducing their validity to BLOCK_VALID_UNKNOWN).
Closes #3100 .
2018-04-03 04:37:21 -07:00
Jack Grigg
fe87fd2b36
Add RPC test of RewindBlockIndex
2018-04-03 10:58:27 +01:00
Homu
ca981fd442
Auto merge of #3080 - leto:jsindex, r=bitcartel
...
Return JoinSplit and JoinSplitOutput indexes in z_listreceivedbyaddress
This implements a feature request by @nathan-at-least in https://github.com/zcash/zcash/issues/2932 and I wanted to ask for feedback about the exact form of the data returned before updating tests and docs.
2018-04-03 00:30:11 -07:00
Jack Grigg
28915c30ca
Fix z_importviewingkey startHeight parameter
...
Closes #2937 .
2018-04-03 02:43:52 +01:00
Jonathan "Duke" Leto
afdd64c6ae
Add tests for new JoinSplit keys returned by z_listreceivedbyaddress
2018-04-02 13:23:00 -07:00
Homu
347804fe73
Auto merge of #3106 - braddmiller:3046-mergetoaddress-concurrent, r=str4d
...
Add Note Locking to z_mergetoaddress
Adds note locking to `z_mergetoaddress` allowing it to be invoked multiple times before previous `z_mergetoaddress` operations have finished.
Reference issue [#3046 ](https://github.com/zcash/zcash/issues/3046 )
Co-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash>
2018-03-30 14:29:17 -07:00
Homu
72f14060bc
Auto merge of #3098 - str4d:2343-overwinter-disable-mempooltxinputlimit, r=str4d
...
Ignore -mempooltxinputlimit once Overwinter activates
Overwinter changes the SignatureHash function to solve the quadratic hashing problem, so this option will no longer be needed.
2018-03-30 08:33:58 -07:00
Brad Miller
4e6400bc00
Implement note locking for z_mergetoaddress
...
Co-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash>
2018-03-29 15:48:34 -06:00
Jack Grigg
9666cc912a
Test calling z_mergetoaddress to merge notes while a note merge is ongoing
2018-03-29 15:38:26 -06:00
Homu
5bdce01848
Auto merge of #2913 - bitcartel:2910_z_listunspent, r=bitcartel
...
Closes #2910 . Add z_listunspent RPC call.
Have tested on network. Opening up for review.
2018-03-28 10:40:49 -07:00
Simon
d72c19a662
Closes #2910 . Add z_listunspent RPC call.
2018-03-28 10:38:57 -07:00
Jack Grigg
31afbcc5c9
Ignore -mempooltxinputlimit once Overwinter activates
2018-03-28 14:25:42 +02:00
Homu
99b6f76355
Auto merge of #3111 - bitcartel:3110_high_fee_error_reporting, r=bitcartel
...
Closes #3110 . Ensure user can see error message about absurdly high fees.
2018-03-27 10:33:52 -07:00
Simon
8b15afd315
Closes #3110 . Ensure user can see error message about absurdly high fees.
2018-03-27 10:23:24 -07:00
Jack Grigg
b466c1c90c
cleanup: Ensure code is pyflakes-clean for CI
2018-03-27 02:47:57 +02:00
Homu
64de921747
Auto merge of #3091 - bitcartel:cache_invalidation_qa, r=str4d
...
Closes #1988 . Add qa test for cache invalidation bug found in v1.0.0 to v1.0.3.
2018-03-20 11:28:08 -07:00
Homu
70e2522306
Auto merge of #3090 - bitcartel:3084_log_expired_txid, r=bitcartel
...
Closes #3084 . Log txid when removing expired transactions from mempool.
2018-03-19 14:59:30 -07:00
Jack Grigg
b7caaf954b
test: Move wait_and_assert_operationid_status debug output before asserts
...
Otherwise we don't see them for failed tests :)
2018-03-19 14:00:18 +01:00
Simon
b740a99079
Remove local function wait_and_assert_operationid_status which is
...
now defined in the test framework for shared usage.
2018-03-16 17:16:22 -07:00
Simon
2f761371d2
Add qa test for cache invalidation bug found in v1.0.0 to v1.0.3.
2018-03-16 15:18:34 -07:00
Simon
a510b4752d
Enable mempool logging in tx expiry QA test.
2018-03-16 11:45:45 -07:00
Daira Hopwood
b4353db5d6
pyflakes cleanups to RPC tests after Overwinter PRs.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-03-12 14:15:25 +00:00
Jonathan "Duke" Leto
4db8717431
Fix outdated comment about starting balance of nodes
2018-02-28 14:29:05 -08:00
Jonathan "Duke" Leto
48cecf2ad9
Regtest mining does have a founders reward, a single address t2FwcEhFdNXuFMv1tcYwaBJtYVtMj8b1uTg
2018-02-28 14:28:22 -08:00
Jonathan "Duke" Leto
62fee1296f
Update awkward wording about blocks as per @daira
2018-02-28 14:17:28 -08:00
Jonathan "Duke" Leto
d8399efc03
This library seems to not be used at all and all comments mentioning it are ghosts
2018-02-28 14:13:07 -08:00
Jonathan "Duke" Leto
427e5fae3f
Fix references to Bitcoin in RPC tests readme
2018-02-26 10:47:59 -08:00
Homu
a418756ef4
Auto merge of #2874 - arcalinea:tx_block_expiry, r=arcalinea
...
Transaction expiry height
Implements ZIP 203.
- Only applies after Overwinter blockheight.
Closes #754 .
2018-02-23 18:37:48 -08:00
Simon
b6e5cc7d27
Add python qa test overwinter_peer_management.
2018-02-23 14:22:43 -08:00
Jay Graber
5943f227da
Add mempool_tx_expiry.py test
2018-02-23 00:12:10 -08:00
Homu
c5904fb2a4
Auto merge of #2797 - str4d:2493-active-merging, r=bitcartel
...
Implement z_mergetoaddress for combining UTXOs and notes
Closes #2493 .
2018-02-22 20:59:51 -08:00
Jack Grigg
15ced9b153
wallet_mergetoaddress: Add additional syncs to prevent race conditions
2018-02-23 04:28:04 +00:00
Simon
e6cd2a8356
Closes #2964 . z_sendmany once again makes v1 tx for taddr to taddr.
...
In accordance with the Zcash protocol spec.
2018-02-22 15:43:42 +00:00
Jack Grigg
4c3d2b3bbe
Check upgrade status in wallet_overwintertx RPC test
2018-02-22 13:44:40 +00:00
Jack Grigg
553a5c1ab2
Gate z_mergetoaddress as an experimental feature
2018-02-22 13:23:25 +00:00
Jack Grigg
6e9c7629af
Implement z_mergetoaddress for combining UTXOs and notes
...
Closes #2493 .
2018-02-22 13:23:18 +00:00
Jack Grigg
ed9aa2b62a
Add branch IDs for current and next block to getblockchaininfo
...
Closes #2974 .
2018-02-21 21:18:03 +00:00
Homu
d4d2844829
Auto merge of #2463 - str4d:713-rollback-limit, r=str4d
...
Implement roll-back limit for reorganisation
Part of #2905 . Closes #713 .
2018-02-20 15:17:22 -08:00
Jack Grigg
818b94f94f
Make number of inputs configurable in validatelargetx test
2018-02-20 04:22:22 +00:00
Homu
49274558c6
Auto merge of #2940 - str4d:nu-activation-mempool-expiry, r=str4d
...
Mempool improvements, branch ID awareness
Whenever the local chain tip is updated, transactions in the mempool which commit to an
unmineable branch ID (for example, just before a network upgrade activates, where the
next block will have a different branch ID) will be removed.
Includes commits cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6654
- Only the mempool index change.
- bitcoin/bitcoin#6776
- bitcoin/bitcoin#7020
- bitcoin/bitcoin#6915
Part of #2074 .
2018-02-19 19:00:30 -08:00
Jack Grigg
34a64fe0a2
Remove mempool transactions which commit to an unmineable branch ID
2018-02-20 02:57:44 +00:00
Matt Corallo
b0f8c83f95
Add failing test checking timelocked-txn removal during reorg
2018-02-20 02:57:40 +00:00
Jack Grigg
57e6ecda5a
Implement roll-back limit for reorganisation
...
Closes #713 .
2018-02-19 16:32:42 +00:00
Simon
072099d788
Implementation of Overwinter transaction format ZIP 202.
2018-02-16 10:10:15 -08:00
Jack Grigg
9e8f1d09ca
zkey_import_export: Synchronize mempools before mining
...
Resolves a race condition that caused the RPC test to intermittently fail.
Closes #2892 .
2018-01-22 21:10:57 +00:00
Jack Grigg
44e5b42751
Check chainValueZat when checking value pool monitoring
2018-01-03 23:41:53 +01:00
Jack Grigg
5d9cf8ae23
Fix pyflakes warnings in zkey_import_export RPC test
2017-12-21 18:19:42 +00:00
Homu
1683c2d5bf
Auto merge of #2143 - str4d:1997-viewing-keys, r=str4d
...
Implement incoming viewing keys
Closes #1997 .
2017-12-20 14:11:05 -08:00
Jack Grigg
44e37656bf
Add watch-only support to Zcash RPC methods
...
Balance totals do not include spends linked to viewing key addresses, as
nullifiers cannot be calculated and therefore spends cannot be detected.
2017-12-20 00:46:37 +00:00
Homu
c1b0db70e5
Auto merge of #2779 - arcalinea:2515_test_zimportkey, r=str4d
...
Add RPC test that exercises z_importkey
Part of #2515 .
2017-12-18 08:32:28 -08:00
Homu
efda4bafef
Auto merge of #2796 - per-gron:less-verbose-tests, r=daira
...
Less verbose tests
Fixes #2453 and deduplicates some related code.
2017-12-17 00:22:38 -08:00
Per Grön
d4ab94a6d9
Print result of RPC call in test only when PYTHON_DEBUG is set
2017-12-16 19:24:25 +01:00
Per Grön
8993edfb77
Deduplicate test utility method wait_and_assert_operationid_status
...
Strictly speaking this is not a true deduplication; the test output will be
slightly different (due to inconsistent print statements) but I think this is
close enough.
2017-12-16 19:24:25 +01:00
Homu
7888624f74
Auto merge of #2795 - str4d:2351-sprout-circuit-value, r=str4d
...
Track net value entering and exiting the Sprout circuit
Delta values will be stored for new blocks; old blocks can be filled in by
re-indexing. The net value currently in the Sprout circuit is only calculated
when delta values for all previous blocks are present.
Part of #2351 .
2017-12-16 02:09:40 -08:00
Homu
f44a4cea42
Auto merge of #2790 - bitcartel:2746_payment_disclosure_prefix, r=str4d
...
Closes #2746 . Payment disclosure blobs now use 'zpd:' prefix.
2017-12-15 10:31:58 -08:00
Jay Graber
73b220cb0f
Add rpc test that exercises z_importkey
2017-12-15 10:15:50 -08:00
Jack Grigg
e319633435
Add Sprout value pool to getblock and getblockchaininfo
2017-12-14 22:06:15 +00:00
syd
31436e4372
Add assert_raises_message to the python test framework.
2017-12-12 20:04:13 -05:00
Simon
61345ae703
Closes #2746 . Payment disclosure blobs now use 'zpd:' prefix.
2017-12-07 10:11:43 -08:00
Homu
019c4bddc8
Auto merge of #2741 - bitcartel:stop_dumpwallet_overwriting, r=str4d
...
Prevent RPC calls dumpwallet and z_exportwallet from overwriting an existing file
Closes #2740
2017-12-04 09:41:52 -08:00
Simon
159aa37fc0
Closes #2759 . Fixes broken pipe error with QA test wallet.py.
2017-11-22 00:02:52 -08:00
Simon
ba1dbb3040
RPC dumpwallet and z_exportwallet updated to no longer allow
...
overwriting an existing file.
2017-11-16 22:29:37 -08:00
Simon
45232b1961
Add payment disclosure as experimental feature.
2017-11-14 13:29:05 -08:00
Simon
337bca8125
Fix an issue where qa test wallet_shieldcoinbase could hang.
...
The mempool was not synced so a block could be generated and not
clear out the mempool. This would then cause subsequent code
which expected the mempool of all nodes to be empty to hang.
2017-11-03 00:39:23 -07:00
Homu
3775ac5250
Auto merge of #2692 - bitcartel:2639_enable_z_shieldcoinbase, r=str4d
...
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
This reverts commit 5023af7bd5
.
2017-11-02 00:18:40 -07:00
Simon
c5dabd2b66
Closes #2639 . Adds optional limit parameter with a default value of 50.
...
The new parameter is to satisfy the principle of least astonishment
by providing a sensible default for the maximum number of transparent
inputs to shield. If users do not configure -mempooltxinputlimit
it is possible for them to create transactions with hundreds of
inputs which suffer from mining delay, due to the current state of
the network where some miners have configured -mempooltxinputlimit
as a way to deal with the problem of quadratic hashing.
2017-11-01 10:40:24 -07:00
Simon
cf72e8e06e
Closes #2263 fixing broken pipe error.
2017-10-30 11:58:37 -07:00
Simon
c2d3bafeaa
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
...
This reverts commit 5023af7bd5
.
2017-10-26 11:29:36 -07:00
Duke Leto
a20b975a52
Update performance-measurements.sh
...
Fix error message, as per @daira
2017-10-24 14:50:26 -07:00
Homu
6b58fd2c99
Auto merge of #2665 - leto:perf_fix, r=str4d
...
Fix bug where performance-measurements.sh fails hards when given no args
Better than "$1: unbound variable", we ran into this when testing this script in the Hush repo, so we are pushing this fix upstream.
2017-10-23 18:37:05 -07:00
Jack Grigg
692bf7a6df
Add --list-stages argument to full_test_suite.py
2017-10-18 00:56:32 -07:00
Jack Grigg
91dd425b4a
Add libsnark tests to full_test_suite.py
2017-10-18 00:55:52 -07:00
Homu
4c9b77d8fb
Auto merge of #2654 - str4d:429-test-driver-script, r=str4d
...
[Test] New merge test suite driver script
Running the script with no arguments will run all test stages in succession.
Passing one or more stages as arguments will run just those stages.
Closes #429 .
2017-10-16 21:51:21 -07:00
Jack Grigg
6e98511cf1
Add stdout notice if any stage fails
2017-10-16 16:16:14 -04:00
Jack Grigg
88fbdc4868
Add bitcoin-util-test.py to full_test_suite.py
...
Not moved, because upstream makes improvements to this script, and the need to
set environment variables makes it simpler to just use the given script.
2017-10-16 16:15:10 -04:00
Homu
a2dc9be5c5
Auto merge of #2533 - str4d:2530-mininode, r=str4d
...
Migrate MiniNode to Zcash
This enables various RPC tests that use it (most of them in the extended test suite) to properly test Zcash code.
The PR also fixes bugs in the BIP65 and BIP66 tests that were both masking and masked by the un-migrated MiniNode.
The Python module `pyblake2` is now a requirement for the RPC tests.
Part of #2530 .
2017-10-16 08:43:58 -07:00
Jonathan "Duke" Leto
147fffb7ec
Fix bug where performance-measurements.sh fails hards when given no args
...
Better than "$1: unbound variable", we ran into this when testing this
script in the Hush repo, so we are pushing this fix upstream.
2017-10-16 08:39:59 -07:00
Homu
af549fe6ed
Auto merge of #2650 - str4d:2645-listunspent-benchmark, r=str4d
...
Add benchmark for listunspent
Closes #2645 .
2017-10-12 15:24:53 -07:00
Jack Grigg
94790c5d8f
Add memory benchmark for validatelargetx
2017-10-09 22:18:28 +01:00
Jack Grigg
c6af0aa453
Move check-security-hardening.sh into full_test_suite.py
2017-10-06 11:17:45 +01:00
Jack Grigg
105b2b6248
Move ensure-no-dot-so-in-depends.py into full_test_suite.py
2017-10-06 11:17:45 +01:00
Jack Grigg
aadf3aa159
Replace full-test-suite.sh with a new test suite driver script
...
This will be the canonical location for the entire Zcash merge test suite.
2017-10-06 11:17:11 +01:00
Jack Grigg
f8ef223ce3
Un-indent RPC test output in test runner
...
The indentation caused the test stdout to be buffered and only printed at the
end of the test, which makes it harder to diagnose hanging tests.
2017-10-05 15:18:58 +01:00
Jack Grigg
5455ca0d0e
Fix BIP65 and BIP66 tests
...
Blocks were being created that didn't satisfy the regtest consensus rules.
2017-10-05 15:18:54 +01:00
Jack Grigg
c10c40779d
[Test] MiniNode: Implement Zcash coinbase
2017-10-05 15:18:53 +01:00
Jack Grigg
7596a4922d
[Test] MiniNode: Coerce OP_PUSHDATA bytearrays to bytes
...
If a bytearray is passed in as part of an iterable, the CScript constructor
fails because b''.join() cannot be used to join a bytearray to a bytes or str in
Python 2.
2017-10-05 15:18:31 +01:00
Jack Grigg
643235859a
[Test] MiniNode: Fix coinbase creation
...
CScriptNum is only used for heights > 16.
2017-10-05 15:18:27 +01:00
Jack Grigg
e68c3ec188
[Test] MiniNode: Use Zcash PoW
...
Equihash solver code extracted from https://github.com/str4d/zcash-pow
RPC tests now require pyblake2 to be installed
2017-10-05 15:15:10 +01:00
Jack Grigg
0de9a481ab
[Test] MiniNode: Update protocol version and network magics
2017-10-05 15:15:10 +01:00
Jack Grigg
31bc3d2581
[Test] MiniNode: Implement Zcash block parsing
2017-10-05 15:15:10 +01:00
Jack Grigg
c47dc872a7
[Test] MiniNode: Implement v2 CTransaction parsing
2017-10-05 15:15:10 +01:00
Jack Grigg
13ca1e8011
[Test] MiniNode: Implement JSDescription parsing
2017-10-05 15:15:06 +01:00
Jack Grigg
99dd50c30c
Add benchmark for listunspent
...
Closes #2645 .
2017-10-04 12:48:50 +01:00
Jack Grigg
243b6a9d4b
Add connections in BIP65 and BIP66 tests to the test manager
...
Fixes a bug in the tests causing them to silently pass instead of correctly
reporting other errors. Introduced in 4a785b0a5b
during the test rewrites.
2017-10-03 17:41:37 +01:00
Homu
e806f9c603
Auto merge of #2638 - bitcartel:2637_experimental_feature_z_shieldcoinbase, r=str4d
...
Closes #2637 . Make z_shieldcoinbase an experimental feature.
Can be enabled with: `zcashd -experimentalfeatures -zshieldcoinbase`
2017-09-27 16:09:54 -07:00
Jack Grigg
091c089d03
Fix incorrect failure in memory benchmark
2017-09-27 19:42:39 +01:00
Jack Grigg
72b4f0b3e6
Individualise performance-measurements.sh errors for debugging
2017-09-27 19:41:54 +01:00
Simon
5023af7bd5
Closes #2637 . Make z_shieldcoinbase an experimental feature where it
...
can be enabled with: zcashd -experimentalfeatures -zshieldcoinbase.
2017-09-27 10:43:54 -07:00
Jack Grigg
f897e075c2
Fix pyflakes warnings in RPC tests
2017-09-27 17:24:19 +01:00
Homu
f34c60de37
Auto merge of #2615 - bitcartel:2448_shield_coinbase, r=bitcartel
...
Add RPC command shield_coinbase #2448 .
Shield transparent coinbase funds by sending to a shielded z address. Closes #2448 .
2017-09-22 12:04:31 -07:00
Simon
06c19063bb
Implement RPC shield_coinbase #2448 .
2017-09-21 15:04:12 -07:00
Homu
8f16b27304
Auto merge of #2616 - nathan-at-least:importprivkey-shows-address.4, r=str4d
...
Importprivkey shows address
Scratching an itch: make `importprivkey` output the corresponding address.
Without this PR, `importprivkey` shows no output. Because we're moving towards an "address-based" RPC interface, rather than "account-based", there's a gap when using `importprivkey` because there's no way to assign it to a specific account, but also no easy way to determine the address. This change fixes that wart.
2017-09-21 14:29:03 -07:00
Jack Grigg
109fed51ff
Additional test cases for importprivkey RPC test
2017-09-21 22:21:44 +01:00
Homu
60b4a79000
Auto merge of #2620 - bitcartel:2583_watch_only_fspendable, r=str4d
...
Closes #2583 . Exclude watch-only utxos from coin selection.
2017-09-20 04:49:48 -07:00
Simon
5a0721f0fe
Set up a clean chain.
...
Delete redundant method wait_until_miner_sees() via use of sync_all().
2017-09-19 20:42:53 -07:00
Simon
b17e1b4080
Closes #2583 . Exclude watch-only utxos from z_sendmany coin selection.
2017-09-19 19:42:48 -07:00
Ariel Gabizon
2e8aefdce1
add load-wallet benchmark
2017-09-18 21:54:53 +02:00
Nathan Wilcox
3e92c028ce
Add a new requirement that `importprivkey` API is idempotent.
2017-09-18 15:30:42 +09:00
Nathan Wilcox
63cdea4233
Add a new rpc-test-specified requirement: `importprivkey` outputs the associated address. (Test fails.)
2017-09-18 15:30:42 +09:00
Nathan Wilcox
d29b6b042f
key_import_export rpc-test: verify that UTXO view co-evolves for nodes sharing a key.
2017-09-18 15:30:42 +09:00
Jack Grigg
e719bf75d4
Adjust instructions for UTXO dataset creation
...
--nocleanup is sufficient to leave the data directories behind. --noshutdown is
only useful if you want to inspect the nodes afterwards, and you'd need to
manually shut down both nodes before copying the data directories.
2017-09-11 21:53:35 +01:00
Jack Grigg
d669871e8b
Fix bug in benchmark data generation script
2017-09-06 19:52:35 +01:00
Jack Grigg
a76174b76b
Benchmark time to call sendtoaddress with many UTXOs
2017-08-31 02:15:06 +01:00
Homu
1738e6957f
Auto merge of #2458 - daira:2450.pyflakes-cleanup, r=str4d
...
pyflakes cleanup
Make the RPC tests pyflakes-clean. fixes #2450
Includes a fix that upstream had in https://github.com/bitcoin/bitcoin/pull/7802
2017-07-14 18:03:03 -07:00
Simon
d77a0ac4a0
Closes #2446 by adding generated field to listunspent.
...
If generated is true, the unspent transaction output is from a
coinbase transaction and can only be sent to a shielded address.
2017-07-11 10:44:36 -07:00
Daira Hopwood
ff0f305497
Cosmetics (trailing whitespace, comment conventions, etc.)
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
811b36ba80
For unused variables reported by pyflakes, either remove the variable,
...
suppress the warning, or fix a bug (if the wrong variable was used).
refs #2450
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
aff0bf7fa1
Clean up imports to be pyflakes-checkable. fixes #2450
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:04 +01:00
Homu
59de56eeca
Auto merge of #2342 - bitcartel:1081__mempoolpatch, r=str4d
...
Add ability for node to reject tx from mempool by number of tx inputs
Implement short-term solution described in #2343 so that users can respond promptly to critical short-term problems caused by quadratic validation scaling, such as the getblocktemplate latency, block propagation latency, and mempool size inflation issues described in #2333 .
2017-06-21 14:42:13 -07:00
Jack Grigg
6ea58d1531
Use sendfrom for both t-addr calls
2017-06-22 09:34:10 +12:00
Simon
99f6d5da6c
Fix #b1eb4f2 so test checks sendfrom as originally intended.
...
Also reduce number of z_sendmany calls made so test runs quicker.
2017-06-20 22:49:47 +00:00
Daira Hopwood
193b3e8b28
Delete test that is redundant and inapplicable to Zcash.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-20 10:03:17 +01:00
Jack Grigg
b1eb4f251a
Fix comment
2017-06-20 19:54:11 +12:00
Jack Grigg
4ef014151d
Additional testing of -mempooltxinputlimit
2017-06-20 15:58:46 +12:00
Daira Hopwood
4a785b0a5b
Repair tests for strict DER signatures.
...
While we're at it, repair a similar test for CLTV, and make the repaired RPC tests run by default.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:32:15 +01:00
Nathan Wilcox
5a027a4a6e
Do not use `-rpcwait` on all `zcash_rpc` invocations, only block when starting zcashd.
2017-05-22 17:51:23 -07:00
Nathan Wilcox
4e47698633
Reuse zcash_rpc.
2017-05-22 17:47:36 -07:00
Nathan Wilcox
453c74743c
Fix a variable name typo.
2017-05-22 17:46:26 -07:00
Nathan Wilcox
0cfc9d65fa
Enable set -u mode.
2017-05-22 17:46:13 -07:00
Jack Grigg
08dc7889d2
Remove additional sources of determinism from benchmark archive
...
The archive has also been moved from .tar.gz to .tar.xz for a
33% reduction in size.
Closes #2388 .
2017-05-20 11:59:16 +12:00
Homu
8214ebc61c
Auto merge of #2372 - str4d:2355-connectblock-bench, r=nathan-at-least
...
Benchmark for calling ConnectBlock on a block with many inputs
Requires placing `block-107134.tar.gz` (containing the block, and a fake CoinsDB containing its inputs) into the base directory of the repository.
To facilitate generation of the fake CoinsDB, an additional field `valuesZat` has been added to `getrawtransaction` containing the integer number of zatoshis instead of a decimal number of ZEC.
Closes #2355 .
2017-05-18 20:13:26 -07:00
Jack Grigg
c66c731adf
Add a benchmark for calling ConnectBlock on a block with many inputs
...
Requires placing block-107134.tar.gz (containing the block, and a fake CoinsDB
containing its inputs) into the base directory of the repository. This can be
generated using qa/zcash/create_benchmark_archive.py (see the script for usage
details).
To facilitate generation of the fake CoinsDB, an additional field 'valueZat' has
been added to 'getrawtransaction' containing the integer number of zatoshis
instead of a decimal number of ZEC.
Closes #2355 .
2017-05-18 11:03:46 +12:00
Homu
73676ce6d6
Auto merge of #2200 - str4d:1884-tx-priority-test, r=nathan-at-least
...
Fix prioritisetransaction RPC test
Part of #1884 .
2017-05-16 11:54:49 -07:00
zkbot
ab3c2fe7b0
Auto merge of #2265 - daira:2263.fix-rpc-error-reporting, r=daira
...
Fix an error reporting bug due to BrokenPipeError and ConnectionResetError not existing in Python 2
refs #2263
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-04-16 16:56:16 +00:00
zkbot
f7f764e0b2
Auto merge of #2189 - bitcartel:1.0.7_with_apache_qpid, r=bitcartel
...
Add AMQP 1.0 support via Apache Qpid Proton C++ API 0.17.0
Closes #2188
2017-04-16 15:09:19 +00:00
Jay Graber
0a56135336
Poll on getblocktemplate result rather than use bare sleep to avoid race condition.
2017-04-14 17:31:35 -07:00
Daira Hopwood
80cbdbc749
Fix an error reporting bug due to BrokenPipeError and ConnectionResetError not existing in Python 2.
...
refs #2263
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-04-14 21:40:30 +01:00
Jack Grigg
338ff45787
Use a larger -rpcclienttimeout for slow performance measurements
...
Closes #2238 .
2017-04-07 15:03:25 +12:00
Simon
99eb947a98
Add AMQP 1.0 support via Apache Qpid Proton C++ API 0.17.0
2017-03-25 08:51:40 -07:00
Wladimir J. van der Laan
f3e1770cfb
tests: Disable Tor interaction
...
This is unnecessary during the current tests (any test for Tor
interaction can explicitly enable it) and interferes with the proxy
test.
2017-03-25 20:25:38 +13:00
zkbot
f9f48667be
Auto merge of #2176 - str4d:1593-libevent, r=bitcartel
...
libevent-based http server
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#5677
- bitcoin/bitcoin#6695
- bitcoin/bitcoin#6899
- bitcoin/bitcoin#7016
- bitcoin/bitcoin#7964
- bitcoin/bitcoin#8722
- bitcoin/bitcoin#8730
- bitcoin/bitcoin#9073
- bitcoin/bitcoin#9265
- bitcoin/bitcoin#9387
- bitcoin/bitcoin#9471
- bitcoin/bitcoin#9647
- bitcoin/bitcoin#9903
- bitcoin/bitcoin#6640
- bitcoin/bitcoin#8139
- bitcoin/bitcoin#8839
Closes #1593 and #1856 .
2017-03-25 04:52:16 +00:00
Jack Grigg
47855b599d
Revert "Revert "rpc-tests: re-enable rpc-tests for Windows""
...
This reverts commit 7fd5d4e30e
.
We need to un-revert this before pulling in
https://github.com/bitcoin/bitcoin/pull/6616
2017-03-25 17:37:18 +13:00
Wladimir J. van der Laan
e93a3e1945
test: Avoid ConnectionResetErrors during RPC tests
...
This is necessary on FreeBSD and MacOSX, at least.
See https://github.com/bitcoin/bitcoin/pull/8834#issuecomment-250450213
2017-03-24 18:43:40 +13:00
Pieter Wuille
2edad86b2d
Fix interrupted HTTP RPC connection workaround for Python 3.5+
2017-03-24 18:43:21 +13:00
zkbot
6344719817
Auto merge of #2052 - str4d:2032-z_importkey-partial-rescan, r=bitcartel
...
Usability improvements for z_importkey
- Add height parameter to z_importkey to reduce rescan range
- Change semantics of rescan parameter, so users can explicitly force a rescan
for existing keys.
Closes #2032
2017-03-24 03:47:11 +00:00
Jack Grigg
53c96bfa6c
Test boolean fallback in z_importkey
2017-03-24 09:23:11 +13:00
Wladimir J. van der Laan
7b41e725d0
Make RPC tests cope with server-side timeout between requests
...
Python's httplib does not graciously handle disconnections from the http server, resulting in BadStatusLine errors.
See https://bugs.python.org/issue3566 "httplib persistent connections violate MUST in RFC2616 sec 8.1.4."
This was fixed in Python 3.5.
Work around it for now.
2017-03-24 09:03:59 +13:00
Wladimir J. van der Laan
7fd5d4e30e
Revert "rpc-tests: re-enable rpc-tests for Windows"
...
This reverts commit bd30c3dced21fca869a14c75081f15195762afe1.
Disable windows RPC tests for now. These should be re-enabled once a
suitable Wine version is used on Travis.
2017-03-24 09:03:59 +13:00
Wladimir J. van der Laan
cc14ac45f4
tests: GET requests cannot have request body, use POST in rest.py
...
Sending a request body with GET request is not valid in HTTP spec, and
not compatible with evhttpd.
2017-03-24 09:03:59 +13:00
Wladimir J. van der Laan
14dcc6ab96
qa: Remove -rpckeepalive tests from httpbasics
...
This option was a temporary workaround, and is no longer necessary
with the new web server.
2017-03-24 09:03:59 +13:00
Jack Grigg
bec25c91cb
Revert "Closes #1680 , temporary fix for rpc deadlock inherited from upstream."
...
This reverts commit f4404d7b5b
.
2017-03-24 09:03:59 +13:00
Jack Grigg
dec148f498
Fix prioritisetransaction RPC test
...
Part of #1884 .
2017-03-23 18:57:46 +13:00
Jack Grigg
b7e5b7d5ee
Simplify z_importkey by making rescan a string
...
Transparently handles older boolean values as well.
2017-03-23 15:57:11 +13:00
Jack Grigg
a31ba7a0cb
Usability improvements for z_importkey
...
- Add height parameter to z_importkey to reduce rescan range
- Change semantics of rescan parameter, so users can explicitly force a rescan
for existing keys.
Closes #2032
2017-03-16 19:34:41 +13:00
Jack Grigg
542a7a40f1
Add tests for getmempoolinfo
2017-03-16 14:30:16 +13:00
Pavel Janík
30c163d99d
Implement REST mempool API, add test and documentation.
2017-03-14 13:52:06 +13:00
zkbot
a7cf698873
Auto merge of #2100 - str4d:2074-rpc, r=arcalinea
...
Bitcoin 0.12 RPC PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6266
- bitcoin/bitcoin#6257
- bitcoin/bitcoin#6271
- bitcoin/bitcoin#6158
- bitcoin/bitcoin#6307
- bitcoin/bitcoin#6290
- bitcoin/bitcoin#6262
- bitcoin/bitcoin#6088
- bitcoin/bitcoin#6339
- bitcoin/bitcoin#6299 (partial, remainder in #2099 )
- bitcoin/bitcoin#6350
- bitcoin/bitcoin#6247
- bitcoin/bitcoin#6362
- bitcoin/bitcoin#5486
- bitcoin/bitcoin#6417
- bitcoin/bitcoin#6398 (partial, remainder was included in #1950 )
- bitcoin/bitcoin#6444
- bitcoin/bitcoin#6456 (partial, remainder was included in #2082 )
- bitcoin/bitcoin#6380
- bitcoin/bitcoin#6970
Part of #2074 .
2017-03-04 02:57:46 +00:00
zkbot
dadb1ab74c
Auto merge of #2101 - str4d:2074-tests, r=arcalinea
...
Bitcoin 0.12 test PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6337
- bitcoin/bitcoin#6390
- bitcoin/bitcoin#5515
- bitcoin/bitcoin#6287 (partial, remainder included in bitcoin/bitcoin#6703)
- bitcoin/bitcoin#6465
Part of #2074 .
2017-03-03 21:25:03 +00:00
Casey Rodarmor
df8f8095b6
Don't share objects between TestInstances
2017-03-03 11:47:12 -08:00
Wladimir J. van der Laan
7cc6648341
tests: Extend RPC proxy tests
...
Also test -noonion
2017-03-03 10:57:13 -08:00
Jack Grigg
25b8f796ff
Re-encode t-addrs in disablewallet.py with Zcash prefixes
2017-03-02 13:26:34 -08:00
Jack Grigg
5329495fe4
Adjust fundrawtransaction RPC test for Zcash
...
- Enable wallet encryption
- Correct block reward
2017-03-02 13:26:34 -08:00
Wladimir J. van der Laan
56215c77d8
Fix crash in validateaddress with -disablewallet
...
Fix a null pointer dereference in validateaddress with -disablewallet. Also add a regression testcase.
2017-03-02 13:26:34 -08:00
Jonas Schnelli
c2616abb3c
[QA] add testcases for parsing strings as values
2017-03-02 13:26:34 -08:00
Wladimir J. van der Laan
d101d7b8e6
univalue: Avoid unnecessary roundtrip through double for numbers
...
JSON makes no distinction between numbers and reals, and our code
doesn't need to do so either.
This removes VREAL, as well as its specific post-processing in
`UniValue::write`. Non-monetary amounts do not need to be forcibly
formatted with 8 decimals, so the extra roundtrip was unnecessary
(and potentially loses precision).
Zcash: cherry-picked from commit 7650449a6777710cf818d41862626164da0cd412
Left over from 2aee461930
2017-03-02 13:26:34 -08:00
zathras-crypto
a11c4bbd26
Exempt unspendable transaction outputs from dust checks
...
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them.
This primarily targets transaction outputs with `OP_RETURN`.
---
Initially based on:
commit 9cf0ae26350033d43d5dd3c95054c0d1b1641eda
Author: zathras-crypto <zathrasc@gmail.com>
Date: Wed Mar 25 02:04:02 2015 -0700
Changes:
- cherry-picked on top of bitcoin:master
- added RPC test for fundrawtransaction
2017-03-02 13:26:34 -08:00
Jonas Schnelli
5bfd954fc6
[QA] remove rawtransactions.py from the extended test list
...
rawtransactions.py is already in the standard test list
2017-03-02 13:23:03 -08:00
Jonas Schnelli
897a370c39
[QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction.py RPC test
...
- added missing mempool sync between block generations
2017-03-02 13:23:03 -08:00
Jonas Schnelli
81eb80d841
[REST] add JSON support for /rest/headers/
2017-03-02 13:23:03 -08:00
mruddy
81ae51c883
add tests for the decodescript rpc. add mention of the rpc regression tests to the testing seciton of the main readme.
2017-03-02 13:23:03 -08:00
Wladimir J. van der Laan
bf890b6518
test: Move reindex test to standard tests
...
This test finishes very quickly, so it should be part of the default set
of tests in rpc-tests.
2017-03-02 13:23:03 -08:00
Jonas Schnelli
788d8e6a6f
fundrawtransaction tests
2017-03-02 13:23:03 -08:00
Jonas Schnelli
2ab237a088
add RPC tests for setban & disconnectnode
2017-03-02 13:23:03 -08:00
Jonas Schnelli
e521939942
[RPC] extend setban to allow subnets
2017-03-02 13:23:03 -08:00
Jonas Schnelli
962ec4b5e4
[QA] add setban/listbanned/clearbanned tests
2017-03-02 13:23:03 -08:00
Stephen
6699b42518
Add paytxfee to getwalletinfo, warnings to getnetworkinfo
2017-03-02 13:23:03 -08:00
zkbot
6ee75b3b7b
Auto merge of #2014 - arcalinea:test-prioritisetransaction, r=arcalinea
...
Test prioritisetransaction
After talking with @str4d about #1884 , I wrote a test for prioritisetransaction. It uses small blocks (11kb), and checks whether a transaction makes it into the next block after being prioritized by that node.
Should this be improved with a larger number of txs in the mempool, or by testing over multiple runs?
As for getblocktemplate(), it seems to return the prioritized transaction within the block size set by the node (about 50 txs fit in an 11kb block), but the block "sizelimit" it displays is set at 2 MB in `rpcmining.cpp` line 690:
```
result.push_back(Pair("sizelimit", (int64_t)MAX_BLOCK_SIZE));
```
This was quite confusing, I didn't think the `-blockmaxsize` parameter I was setting was working for awhile.
2017-03-02 06:47:04 +00:00
Simon
85c9ecb846
Part of #1969 . Update tests to avoid error 'absurdly high fee' from change in min fee calc.
2017-02-28 11:44:51 -08:00
Simon
ebe750a882
Part of #1969 . Changing min fee calculation also changes the dust threshold.
2017-02-28 11:44:07 -08:00
Jay Graber
8d2dac6e3f
Inc num of txs in test mempool
2017-02-27 14:11:09 -08:00
Jay Graber
cc64e2ccc8
Add rpc test for prioritisetransaction
2017-02-12 11:01:45 -08:00
Simon
238fec642d
Update test to check for updated error messages in AmountFromValue().
2017-02-09 23:32:15 -08:00
zkbot
7d4ced95ed
Auto merge of #2056 - str4d:2035-experimental-mode, r=bitcartel
...
Add a flag for enabling experimental features
Closes #2035 .
2017-02-09 23:39:02 +00:00
zkbot
d32511c72c
Auto merge of #2054 - str4d:2030-decoderawtransaction-joinsplit-fields, r=bitcartel
...
Show all JoinSplit components in getrawtransaction and decoderawtransaction
Closes #2030 .
2017-02-09 22:56:01 +00:00
Simon
91270dcfbc
Update test to check for more joinsplit related fields in getrawtransaction
2017-02-09 14:48:58 -08:00
Jack Grigg
b8eb37757b
Require -experimentalmode for wallet encryption
2017-02-09 22:10:58 +00:00
zkbot
253c610783
Auto merge of #2050 - str4d:2020-zmq, r=bitcartel
...
Add ZeroMQ notifications
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6103
- bitcoin/bitcoin#6684
- bitcoin/bitcoin#6686
- bitcoin/bitcoin#6736
- bitcoin/bitcoin#6739
- bitcoin/bitcoin#6743
- bitcoin/bitcoin#6768
- bitcoin/bitcoin#6779
- bitcoin/bitcoin#6810
- bitcoin/bitcoin#6927
- bitcoin/bitcoin#6980 (only upgrading zeromq)
- bitcoin/bitcoin#6680
- bitcoin/bitcoin#7058
- bitcoin/bitcoin#7621
- bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7762
- bitcoin/bitcoin#7993 (only upgrading zeromq)
- bitcoin/bitcoin#8238
- bitcoin/bitcoin#8701
- bitcoin/bitcoin#6685
Closes #2020 .
2017-02-09 20:08:15 +00:00
zkbot
b2e2dccc64
Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel
...
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-09 18:56:44 +00:00
Jack Grigg
8db0dd93e4
Add test to check for presence of vpub_old & vpub_new in getrawtransaction
2017-02-09 16:38:01 +00:00
Jonas Schnelli
9bbc220641
fix rpc-tests.sh
...
`${testScripts[@]}` now does split up `testscript --agument` in two elements pushed to the array (`testscript` and `--agument`).
2017-02-09 11:53:51 +00:00
Simon
75bb764bb8
Add test for z_sendmany with fee of 0
2017-02-08 15:26:33 -08:00
Jonas Schnelli
3ba2e19e2b
[ZMQ] append a message sequence number to every ZMQ notification
2017-02-08 22:11:53 +00:00
Jack Grigg
c7cb3c13ea
[qa] py2: Unfiddle strings into bytes explicitly in ZMQ RPC test
...
Extracted from bitcoin/bitcoin#7853
commit faa41ee204124da19dcf1e5b8a3aef1e216bf5e6
2017-02-08 22:11:53 +00:00
Jack Grigg
a9445db62f
Fix python syntax in ZMQ RPC test
...
Extracted from bitcoin/bitcoin#7335
commit 7777994846cdb9b9cf69e391a33eeed30393bbcf
2017-02-08 22:11:53 +00:00
Cory Fields
5088de4bb8
travis: install a recent libzmq and pyzmq for tests
2017-02-08 22:10:42 +00:00
Jonas Schnelli
5c7f84cf26
[travis] add zmq python module
2017-02-08 22:10:42 +00:00
Jonas Schnelli
da0e7aa1d7
QA: Add ZeroMQ RPC test
2017-02-08 22:10:42 +00:00
Cory Fields
cce7754eb8
Depends: Add ZeroMQ package
2017-02-08 22:10:42 +00:00
Simon
aa0ab69a15
Closes #2024 by documenting and testing method field in z_getoperationstatus
2017-02-06 14:53:56 -08:00
Simon
a45d2ec79c
Update test to verify order of zrpcunsafe log messages
2017-02-01 14:41:35 -08:00
Simon
a1477f6fac
Add test to verify z_sendmany logging
2017-02-01 11:02:03 -08:00
zkbot
0edb3c0f16
Auto merge of #1978 - str4d:1941-scan-whole-chain-on-zkey-import, r=ebfull
...
Scan the whole chain whenever a z-key is imported
Closes #1941 .
2017-01-20 00:02:12 +00:00
Sean Bowe
620c0e2845
Add test for z_importkey rescanning from beginning of chain.
2017-01-19 16:59:29 -07:00
zkbot
78674ca79e
Auto merge of #2007 - bitcartel:1097_copyright_notice_and_date, r=bitcartel
...
Closes #1097 so that zcash-cli displays license info like zcashd.
LicenseInfo is refactored from init.cpp to util.cpp so that the
bitcoin-cli makefile target does not need to be modified.
2017-01-19 00:56:47 +00:00
Simon
774489569a
Increase timeout for z_sendmany transaction in wallet.py qa test
2017-01-18 16:54:39 -08:00
zkbot
63e0e895a5
Auto merge of #2006 - bitcartel:1497_destination_path_validation_when_exporting, r=bitcartel
...
Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames
2017-01-18 18:19:50 +00:00
Simon
bab89e35c7
Update walletbackup.py qa test to use -exportdir option
2017-01-18 10:05:49 -08:00
Jack Grigg
9847bc870d
Create empty zcash.conf during coverage checks
...
Fixes regression caused by #2013 .
2017-01-18 12:11:50 +01:00
zkbot
ee2f1ebb9d
Auto merge of #1942 - str4d:1940-threaded-createjoinsplit, r=ebfull
...
Extend createjoinsplit to benchmark parallel JoinSplits
Closes #1940
2017-01-18 01:04:05 +00:00
zkbot
4169cddd64
Auto merge of #1991 - bitcartel:1960_z_getoperation_include_call_details, r=ebfull
...
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-17 19:24:07 +00:00
Jack Grigg
336fa63020
Create empty zcash.conf during performance measurements
2017-01-17 13:19:49 +01:00
Simon
8aa7937d44
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-16 16:45:27 -08:00
Jack Grigg
4082dcb10f
Extend createjoinsplit to benchmark parallel JoinSplits
...
Closes #1940
2016-12-14 15:28:00 +13:00
zkbot
02bb4df58d
Auto merge of #1918 - bitcartel:timeout_cpu_throttling, r=str4d
...
Increase timeout as laptops on battery power have cpu throttling.
Merge this last as other PRs also update the test file `wallet_protectcoinbase.py`.
2016-12-09 09:03:37 +00:00