Greg Pfeil
4946316537
Appease ShellCheck
...
ShellCheck has started failing in CI. My guess is that the ubuntu-latest runner
now uses a `/bin/sh` that is actually Bash.
- excludes checksec.sh, as it’s not our code
- fixes lints in other files
2022-12-06 10:46:43 -07:00
Ben Woosley
dd84f66600
doc: Correct spelling errors in comments
...
And ci script output.
Identified via test/lint/lint-spelling
(cherry picked from commit bitcoin/bitcoin@9b0e16226e )
Zcash: Only the change to `test/lint/lint-shell.sh`
2022-08-20 03:15:12 +00:00
Hennadii Stepanov
c23889a150
script: Enable SC2001 rule for Gitian scripts
...
(cherry picked from commit bitcoin/bitcoin@17f81e9648 )
2022-08-20 03:15:12 +00:00
Hennadii Stepanov
f620206f03
script: Enable SC2155 rule for Gitian scripts
...
Also pwd command is replaced with $PWD variable everywhere for
consistency.
(cherry picked from commit bitcoin/bitcoin@61bb21b418 )
2022-08-20 03:15:12 +00:00
Hennadii Stepanov
fa3abe8819
script: Enable SC2006 rule for Gitian scripts
...
(cherry picked from commit bitcoin/bitcoin@577682d9e8 )
2022-08-20 03:15:12 +00:00
Jack Grigg
0f84499556
lint: Disable some ShellChecks on Gitian descriptors
...
These trigger because our Gitian descriptors are out-of-sync with
upstream.
2022-08-20 03:15:12 +00:00
Hennadii Stepanov
3cf26a1c4f
script: Lint Gitian descriptors with ShellCheck
...
(cherry picked from commit bitcoin/bitcoin@14aded46df )
Zcash: Applies CI change to GitHub Actions workflow.
2022-08-20 03:15:12 +00:00
Hennadii Stepanov
8294e51681
Enable ShellCheck rules
...
Enabled ShellCheck rules:
SC1087
SC2001
SC2004
SC2005
SC2006
SC2016
SC2028
SC2048
SC2066 (note that IFS already contains only a line feed)
SC2116
SC2166
SC2181
SC2206
SC2207
SC2230
SC2236
(cherry picked from commit bitcoin/bitcoin@1ac454a384 )
Zcash: Applies more of this commit. It was partially backported in
zcash/zcash#4827 , and is also partially backported here for the scripts
we actually have.
2022-08-20 03:13:52 +00:00
Kris Nuttycombe
15d1bb6ce9
scripted-diff: Add 2020-2022 copyright headers for files added/modified in 2020
...
-BEGIN VERIFY SCRIPT-
grep -l "Copyright" $(grep -L "The Zcash developers" $(git diff --name-only --diff-filter=ACM 6a08c225674df23f1c7f214bcb94732dba688d39..a960e896dd4c0b6d96db3d5ebbb1caa6c92a9f39 -- src/ test/ zcutil/ qa/)) | xargs -I {} sed -i"" -e "s#\(\(.*\)Copyright (c) .* The Bitcoin Core developers\)#\1\n\2Copyright (c) 2020-2022 The Zcash developers#" {}
-END VERIFY SCRIPT-
2022-05-11 17:32:39 -06:00
Dimitris Apostolou
f459e43dc9
Update links
2020-12-13 11:24:44 +02:00
str4d
1e6d1837a0
lint: Remove some subtrees from exclusion
...
Either they don't violate the lints, or can be easily fixed.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 20:06:45 +00:00
practicalswift
1be9fa9aeb
Remove no longer needed shellcheck suppressions
2020-10-27 23:05:19 +00:00
practicalswift
8ed37f5f40
Remove repeated suppression. Fix indentation.
2020-10-27 23:05:19 +00:00
Vidar Holen
37604a1990
refactor/lint: Add ignored suggestions to an array
...
This avoids duplicating the codes between command and comments.
2020-10-27 23:05:19 +00:00
João Barbosa
653f6dc7e7
qa: Ignore shellcheck warning SC2236
...
With shellcheck 0.6.0 the warning `SC2236 - Use -n instead of ! -z` is raised.
This change adds that warning to the ignored list.
2020-10-27 23:05:19 +00:00
practicalswift
5b11b94d27
macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew
2020-10-27 23:05:19 +00:00
Julian Fleischer
b90433afd3
fix locale for lint-shell
2020-10-27 23:05:19 +00:00
DesWurstes
be186b8112
Obsolete #!/bin/bash shebang
2020-10-27 23:05:18 +00:00
practicalswift
745ac0ae6d
Add "export LC_ALL=C" to all shell scripts
...
Zcash: Only for lint-* scripts we have backported from upstream.
2020-10-27 23:05:02 +00:00
MarcoFalke
c2848070b4
test: Move linters to test/lint, add readme
...
Zcash: Only the lint-* scripts we have backported.
2020-10-27 23:05:02 +00:00