4db07b29c8
[trivial] init: Use defaults MIN_RELAY_TX_FEE & TRANSACTION_MAXFEE
2019-12-17 12:18:50 -06:00
f4b9c3283d
translations: Don't translate markdown or force English grammar
2019-12-17 12:18:50 -06:00
ab77f894b7
Clarify what minrelaytxfee does
2019-12-17 12:18:50 -06:00
e3bdf82dc2
Init: Use DEFAULT_TRANSACTION_MINFEE in help message
2019-12-17 12:18:50 -06:00
3de455e138
[trivial] init cleanup
2019-12-17 12:18:50 -06:00
63c3d1ec94
Auto merge of #4227 - str4d:2074-scripts-1, r=str4d
...
Bitcoin script PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6335
- bitcoin/bitcoin#6424
- bitcoin/bitcoin#11058
- bitcoin/bitcoin#12460
- bitcoin/bitcoin#13194
Part of #2074 .
2019-12-17 17:05:58 +00:00
5db5bd749c
Auto merge of #4245 - oxarbitrage:issue4012, r=daira
...
Remove dead code
Closes https://github.com/zcash/zcash/issues/4012
Equivalent to bitcoin/bitcoin/pull/9822
2019-12-10 22:10:10 +00:00
c0d5b87277
readd create_directories
2019-12-09 18:04:06 -03:00
dd0c036538
Policy: MOVEONLY: Create policy/policy.h with some constants
...
Zcash: Adjusted to be move-only after our changes to the constants.
2019-12-04 20:34:11 +00:00
868c63f92d
Auto merge of #2390 - str4d:2132-mapargs-prep, r=str4d
...
Misc upstream PRs
Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6077
- Second commit only (first was already applied to 0.11.X and then reverted)
- https://github.com/bitcoin/bitcoin/pull/6284
- https://github.com/bitcoin/bitcoin/pull/6489
- https://github.com/bitcoin/bitcoin/pull/6235
- https://github.com/bitcoin/bitcoin/pull/6905
- https://github.com/bitcoin/bitcoin/pull/6780
- Excluding second commit (QT) and third commit (requires https://github.com/bitcoin/bitcoin/pull/6993 )
- https://github.com/bitcoin/bitcoin/pull/6961
- Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to.
- https://github.com/bitcoin/bitcoin/pull/7044
- https://github.com/bitcoin/bitcoin/pull/8856
- https://github.com/bitcoin/bitcoin/pull/9002
Part of #2074 and #2132 .
2019-12-04 19:20:44 +00:00
5fd97dcdf9
Wrap long line
2019-12-04 17:21:55 +00:00
784a481070
cleanup: Comments
2019-12-04 17:21:54 +00:00
9fee2baebf
Make connect=0 disable automatic outbound connections.
...
Otherwise it just responds to this obvious bit of configuration by
trying to connect to "0" in a loop.
2019-12-04 17:18:45 +00:00
71068892d2
Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs
2019-12-04 17:18:44 +00:00
f4d9e06a90
Added additional config option for multiple RPC users.
2019-12-04 17:18:43 +00:00
e11e1ea58e
[trivial] Reuse translation and cleanup DEFAULT_* values
...
* DEFAULT_DISABLE_SAFEMODE = false
* Use DEFAULT_* constants for extern bools
2019-12-04 17:18:41 +00:00
9bc915b02a
Bugfix: Omit wallet-related options from -help when wallet is not supported
2019-12-04 17:18:40 +00:00
2e02bb21f7
Constrain constant values to a single location in code
2019-12-04 17:18:39 +00:00
363c945325
Initialize experimental mode in a separate function
2019-12-04 17:18:38 +00:00
a425ac9706
Initialize logging before we do parameter interaction
2019-12-04 17:18:37 +00:00
ef6b9b0fb2
Refactor parameter interaction, call it before AppInit2()
2019-12-04 17:18:36 +00:00
5bedad9580
Bugfix: Omit wallet-related options from -help when wallet is disabled
2019-12-04 17:18:35 +00:00
a624c49219
Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo
2019-12-04 17:18:34 +00:00
3779bea091
Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool)
2019-12-04 17:18:33 +00:00
b90ea483dd
Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method
2019-12-04 17:18:32 +00:00
bd87de60ed
Chainparams: Translations: DRY: options and error strings
...
Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine
2019-12-04 17:18:31 +00:00
aa1d014b40
Give a better error message if system clock is bad
...
Fixes #2007
This checks to see if the system clock appears to be bad and gives a
helpful error message. If the user's clock is set incorrectly, hopefully
they'll abort, fix it, and then save themselves a fruitless resync.
2019-12-04 17:18:29 +00:00
2383d1b1de
Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id
...
Remove option mempooltxinputlimit
This option is no longer used after Overwinter. Fixes #4209 .
2019-12-03 20:07:20 +00:00
6d57fcff13
Apply suggestions from code review
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-12-02 21:10:35 +00:00
afbf1a7082
remove dead code in init
2019-11-28 14:55:32 -03:00
fe1ff82a7d
Remove option mempooltxinputlimit
...
This option is no longer used after Overwinter. Fixes #4209 .
2019-11-19 10:35:39 +01:00
ea4ee8a222
[squashme] improve/corrects prune mode detection test for required wallet rescans
2019-11-14 13:56:19 +00:00
d510fb4aa4
[autoprune] allow wallet in pruned mode
2019-11-14 13:56:17 +00:00
fd8444d0b7
Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
...
Remove z_mergetoaddress from experimental state
Closes #3731 .
2019-11-11 01:57:21 -08:00
cb0a94cd21
Auto merge of #4161 - oxarbitrage:issue3621, r=Eirik0
...
remove duplicated prefix in errors and warnings
Fixes #3621
2019-11-05 09:55:54 -08:00
cbf1a85013
remove z_mergetoaddress from experimental
2019-10-26 12:52:36 -03:00
f4106c65a5
remove duplicated prefix in errors and warnings
2019-10-21 13:13:59 -03:00
40a7156026
Remove dots and underscores from parameter names
2019-10-21 09:20:17 -06:00
64fc25ed6e
Update parameter names to match ZIP
2019-10-17 16:39:32 -06:00
c4931a9a44
Rename files
2019-10-09 15:22:49 -06:00
2d9becbeb8
Rename variables for consistency
2019-10-09 13:36:20 -06:00
9e97833952
Fix naming conventions
2019-10-07 14:23:42 -06:00
1a06727c0c
Performance: Store weighted transactions in a tree
2019-10-07 14:23:42 -06:00
6fdd8f5298
Help message cleanup and add lock
2019-10-07 14:23:41 -06:00
0b2c5cfcc2
Grammatical fixes
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-10-07 14:23:41 -06:00
ae9ecf09e8
DoS protection: Weighted random drop of txs if mempool full
2019-10-07 14:23:41 -06:00
961c0d58ec
Auto merge of #4060 - str4d:remove-libsnark, r=daira
...
Remove libsnark
Closes #167 . Closes #416 . Closes #418 . Closes #437 .
Closes #521 . Closes #743 . Closes #750 . Closes #894 .
Closes #903 . Closes #1125 . Closes #1136 . Closes #1240 .
Closes #1264 . Closes #1516 . Closes #1517 . Closes #1651 .
Closes #2064 . Closes #2158 . Closes #3478 . Closes #3652 .
Closes #3744 .
2019-09-26 11:21:40 -07:00
921f326132
Merge pull request #18 from zcash/mempool-txnotify-thread
...
Move mempool SyncWithWallets call into its own thread
2019-09-24 19:22:08 +01:00
3ff68c5052
Move mempool SyncWithWallets call into its own thread
2019-09-20 21:00:42 +01:00
5ae7b70ae6
Disable -shrinkdebugfile command
2019-09-19 18:05:56 +01:00
5f84491d82
Remove libsnark code for pre-Sapling Sprout proofs
2019-08-22 15:42:47 +01:00
93dae1db7d
Revert "Allow user to ask server to save the Sprout R1CS out during startup."
...
This reverts commit 685c0ab07f
2019-08-22 15:42:46 +01:00
2528af69ff
Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
...
Implement ZIP 208: Shorter Block Target Spacing
Closes #3690 .
2019-08-09 02:35:30 -07:00
82c291b6df
Fix parsing txexpirydelta argument
2019-08-05 11:32:12 -06:00
8865f4b6f6
Update expiry height for shorter block times
2019-07-30 01:16:37 -06:00
c0d27cb3f2
Simplify PartitionCheck
2019-07-29 18:29:39 -06:00
bc909a7a7f
Replace http with https: in links to the MIT license.
...
Also change MIT/X11 to just MIT, since no distinction was intended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
d7ebbeb2aa
Modify PartitionCheck to be aware of pre & post Blossom target spacing.
2019-07-11 14:17:58 -06:00
44b2d060ef
Globals: Remove a bunch of Params() calls from main.cpp:
...
1) Chainparams: Explicit CChainParams arg for main:
-AcceptBlock
-AcceptBlockHeader
-ActivateBestChain
-ConnectTip
-InitBlockIndex
-LoadExternalBlockFile
-VerifyDB parametric constructor
2) Also pickup more Params()\. in main.cpp
3) Pass nPruneAfterHeight explicitly to new FindFilesToPrune() in main.cpp
2019-05-23 17:48:18 +01:00
793a72e31f
Chainparams: Explicit CChainParams arg for miner:
...
-BitcoinMiner
-CreateNewBlock
-GenerateBitcoins
-ProcessBlockFound
2019-05-23 17:48:17 +01:00
5969bd8f55
Fix help message
2019-04-29 15:29:27 -06:00
b9c7f274a4
remove extra hyphen
...
Co-Authored-By: Eirik0 <eirik@z.cash>
2019-04-29 09:55:07 -06:00
8ffd63af2d
Add migration options to conf file
...
Co-authored-by: Simon <simon@bitcartel.com>
2019-04-29 09:36:26 -06:00
1fefed9eb5
Auto merge of #3940 - str4d:3607-init-encrypted-wallet-without-hd-seed, r=bitcartel
...
init: Fix new HD seed generation for previously-encrypted wallets
Closes #3607 .
How to verify (with `zcashd` flags `-testnet -wallet=wallet.3607.dat -experimentalfeatures -developerencryptwallet`):
- Start `zcashd` 2.0.0, encrypt the wallet, and stop the node.
- Start `zcashd` 2.0.1+ (before this branch), and see that it crashes during startup.
- Start `zcashd` built from this branch, and see that it does not crash during startup. Unlock the wallet, then stop.
- Start `zcashd` 2.0.1+ (before this branch), and see that it no longer crashes during startup.
2019-04-25 13:15:51 -07:00
4c1a8884f4
Add testnet and regtest experimental feature: -developersetpoolsizezero
2019-04-22 14:24:40 -07:00
1f561f323f
init: Fix new HD seed generation for previously-encrypted wallets
...
Closes #3607 .
2019-04-04 18:27:46 +01:00
6cf0e50b56
add -addressindex changes for bitcore insight block explorer
2019-03-28 12:03:48 -06:00
c233f6fd31
Add comments
2019-03-06 09:03:55 +13:00
b2993bc5d4
detach wallet from miner
2019-03-06 09:02:50 +13:00
abd55f27f2
Auto merge of #3691 - ebfull:printsproutr1cs, r=daira
...
Allow user to ask server to save the Sprout R1CS to a file during startup.
This adds an experimental feature `-savesproutr1cs` which can be used to save the file `r1cs` containing the constraint system used in the original launch of Zcash. The file is written to the parameters directory. This can be used to recover this file for verification of the Sprout MPC transcript and parameters.
2018-12-18 23:28:06 -08:00
9cd74866c7
Auto merge of #3262 - str4d:2074-perf-1, r=str4d
...
Bitcoin 0.12 performance improvements
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6918
- bitcoin/bitcoin#6932
Part of #2074 .
2018-11-30 15:25:33 -08:00
685c0ab07f
Allow user to ask server to save the Sprout R1CS out during startup.
2018-11-17 17:10:58 -07:00
f8cd79c2de
For ZEC-013. Mitigate potential tx expiry height related DoS vector.
...
Don't accept transactions which are about to expire (next 3 blocks).
Don't set a ban score if a peer does propragate these transactions.
See ZEC-013 for more detail.
2018-11-17 09:01:49 -08:00
ee3fa7020e
Pass parameter paths as native strings to librustzcash
2018-10-27 19:19:02 +13:00
3a78872137
Make sigcache faster and more efficient
2018-10-24 19:28:39 +08:00
c58dae6cda
init: Generate a new HD seed on startup
2018-09-03 10:45:37 +01:00
40f320e0ee
Auto merge of #3443 - daira:testnet-rollback, r=str4d
...
Support testnet rollback.
Part of #1302 . Closes #2905 .
2018-08-08 05:28:08 -07:00
198dfd3c36
Switch to use the official Sapling parameters.
2018-08-04 16:28:39 -06:00
66856b2b3c
Support testnet rollback.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-08-02 23:10:30 +01:00
d9ef8f622e
Check the hash of the (Sapling+) zk-SNARK parameters during initialization.
2018-08-02 12:18:13 -06:00
a9496b08b6
rpc: Register calls where they are defined
...
Split out methods to every module, apart from 'help' and 'stop' which
are implemented in rpcserver.cpp itself.
- This makes it easier to add or remove RPC commands - no longer everything that includes
rpcserver.h has to be rebuilt when there's a change there.
- Cleans up `rpc/server.h` by getting rid of the huge cluttered list of function definitions.
- Removes most of the bitcoin-specific code from rpcserver.cpp and .h.
Continues #7307 for the non-wallet.
2018-07-18 11:07:18 -06:00
4519a766b6
move rpc* to rpc/
2018-07-18 11:07:16 -06:00
34aca1b03c
[RPC, Wallet] Move RPC dispatch table registration to wallet/ code
...
Allow extending the rpc dispatch table by appending commands when server is not running.
2018-07-18 11:07:15 -06:00
3835cbb57f
Auto merge of #3263 - str4d:ibd-upstream-changes, r=bitcartel
...
InitialBlockDownload upstream changes
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7208
- bitcoin/bitcoin#8007
- bitcoin/bitcoin#9053
- Excluding second commit (requires bitcoin/bitcoin#8865 )
- bitcoin/bitcoin#10388
2018-07-17 13:17:27 -07:00
c74ab3356a
Remove config option -disabledeprecation
...
Closes #2943 .
2018-06-11 10:38:12 -07:00
29aaf13b0a
Make max tip age an option instead of chainparam
...
After discussion in #7164 I think this is better.
Max tip age was introduced in #5987 to make it possible to run
testnet-in-a-box. But associating this behavior with the testnet chain
is wrong conceptually, as it is not needed in normal usage.
Should aim to make testnet test the software as-is.
Replace it with a (debug) option `-maxtipage`, which can be
specified only in the specific case.
2018-05-15 21:24:58 +12:00
93bd00a0d5
Add key_io includes to Zcash-specific code
2018-05-08 21:39:56 +01:00
b6be3e88bb
Use CBitcoinAddress wrappers in Zcash-specific code
2018-05-03 01:13:04 +01:00
23f8b30c88
Auto merge of #3193 - str4d:b9856-badalloc-terminate, r=bitcartel
...
Terminate immediately when allocation fails
Backport of bitcoin/bitcoin#9856
Closes #1498 .
2018-05-01 02:09:51 -07:00
b300118002
Merge pull request #2813 from str4d/2074-uacomment
...
Implement uacomment config parameter
2018-04-30 09:12:38 -06:00
aeb089ecc7
Attempt to log before terminating if prevector allocation fails
2018-04-26 11:30:33 +01:00
3c9dbf3ed8
Improve best-effort logging before termination on OOM
...
Suggested by @kallewoof in bitcoin/bitcoin#9856
2018-04-26 11:22:07 +01:00
c10b69eb64
don't throw std::bad_alloc when out of memory. Instead, terminate immediately
2018-04-19 16:49:02 +01:00
acfcdb94b9
Load Sapling testnet parameters into memory.
2018-04-17 15:04:46 -06:00
3c1db17064
[uacomment] Sanitize per BIP-0014
...
* SanitizeString() can be requested to be more strict
* Throw error when SanitizeString() changes uacomments
* Fix tests
2018-04-13 07:41:50 -06:00
2bc62dc4e3
limit total length of user agent comments
...
Reworked-By: Wladimir J. van der Laan <laanwj@gmail.com>
2018-04-13 07:40:34 -06:00
0a284ecaf6
Fix NODE_BLOOM documentation errors
2018-04-05 01:30:38 +01:00
b976ce7cee
Document both the peerbloomfilters and enforcenodebloom options.
2018-04-05 01:30:12 +01:00
8bc4461326
Add NODE_BLOOM service bit and bump protocol version
...
Lets nodes advertise that they offer bloom filter support explicitly.
The protocol version bump allows SPV nodes to assume that NODE_BLOOM is
set if NODE_NETWORK is set for pre-170004 nodes.
Also adds an option to turn bloom filter support off for nodes which
advertise a version number >= 170004. Nodes attempting to use bloom
filters on such protocol versions are banned, and a later upgade
should drop nodes of an older version which attempt to use bloom
filters.
Much code stolen from Peter Todd.
Zcash: Implements Zcash equivalent of BIP 111; deploys with Overwinter
2018-04-05 01:30:12 +01:00
31afbcc5c9
Ignore -mempooltxinputlimit once Overwinter activates
2018-03-28 14:25:42 +02:00
MarcoFalke
Homu
Alfredo Garcia
Jorge Timón
Jack Grigg
Gregory Maxwell
Gregory Sanders
Luke Dashjr
Jonas Schnelli
Casey Rodarmor
str4d
Dagur Valberg Johannsson
Jonas Schnelli
Eirik Ogilvie-Wigley
Eirik Ogilvie-Wigley
Daira Hopwood
Simon
Larry Ruane
Sean Bowe
Pieter Wuille
Wladimir J. van der Laan
Daniel Cousens
Marshall Gaucher
Cory Fields
Pavol Rusnak
Patick Strateman
Matt Corallo