Kris Nuttycombe
abda46722b
Merge pull request #6382 from nuttycom/defer_zbalance_deprecation
...
Defer z_getbalance and z_gettotalbalance disablement.
2023-01-30 16:57:07 -07:00
Dimitris Apostolou
4464f81061
Fix typo
2023-01-31 00:26:47 +02:00
Alex Morcos
05a1c41aac
FIX: correctly measure size of priority block
...
(cherry picked from commit bitcoin/bitcoin@c2dd5a3c39 )
2023-01-30 21:59:42 +00:00
Alex Morcos
43ce65399c
FIX: Account for txs already added to block in addPriorityTxs
...
(cherry picked from commit bitcoin/bitcoin@a278764748 )
2023-01-30 21:59:42 +00:00
Alex Morcos
e6d4027888
Refactor CreateNewBlock to be a method of the BlockAssembler class
...
(cherry picked from commit bitcoin/bitcoin@4dc94d1036 )
Zcash: Adapted to include our miner changes.
2023-01-30 21:59:42 +00:00
Kris Nuttycombe
70c9725cc3
Merge pull request #6365 from str4d/6333-cxx-orchard-frontier
...
rust: Migrate `OrchardMerkleFrontier` to `cxx`
2023-01-30 14:16:34 -07:00
Daira Hopwood
145f2c31ed
Use a more recent URL format for GitHub release archives.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-01-30 20:29:04 +00:00
Kris Nuttycombe
c9d6230e88
Defer z_getbalance and z_gettotalbalance disablement.
...
These disable-by-default changes need to be deferred until we
have a better replacement that provides a single source for
summary balance information.
2023-01-30 11:00:09 -07:00
Kris Nuttycombe
f3b93f87f3
Merge pull request #6380 from zcash/release-v5.4.0-rc3
...
Release v5.4.0-rc3
2023-01-27 16:11:27 -07:00
Kris Nuttycombe
d9a60c9d1e
make-release.py: Updated release notes and changelog for 5.4.0-rc3.
2023-01-27 15:07:19 -07:00
Kris Nuttycombe
85440c7bf8
make-release.py: Updated manpages for 5.4.0-rc3.
2023-01-27 15:07:19 -07:00
Kris Nuttycombe
6e8404e9b3
make-release.py: Versioning changes for 5.4.0-rc3.
2023-01-27 15:03:29 -07:00
str4d
932475413a
Merge pull request #6379 from daira/postpone-deps-for-5.4.0
...
Postpone updates for 5.4.0.
2023-01-27 22:01:51 +00:00
Daira Hopwood
2afaa88c01
Postpone updates for 5.4.0.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-01-27 21:55:38 +00:00
Daira Hopwood
88a57f3617
Merge pull request #6368 from nuttycom/bug/slow_wallet_shutdown
...
Fetch recently conflicted transactions incrementally in ThreadNotifyWallet
2023-01-27 21:23:47 +00:00
Kris Nuttycombe
95e3447b96
Fix potential path or symlink traversal
...
Use `realpath` instead of `abspath` and remove unused `safe_extract` arguments & defaults.
Reviewed with @daira @str4d @sellout
2023-01-27 14:08:02 -07:00
TrellixVulnTeam
543df3797a
Adding tarfile member sanitization to extractall()
2023-01-27 14:08:01 -07:00
Kris Nuttycombe
149ffb9582
Merge pull request #6374 from nuttycom/bug/wallet_rescan_escape
...
Allow rescan to exit in the case that Ctrl-C is pressed.
2023-01-27 13:54:57 -07:00
Kris Nuttycombe
a4e6efa3ce
Merge pull request #6376 from sellout/fetch-params-macos
...
Support Bash 3.2 in fetch-params.sh
2023-01-27 11:32:20 -07:00
Kris Nuttycombe
29e65bf536
Tolerate missing cached conflict data in ThreadNotifyWallets
2023-01-26 16:51:23 -07:00
Greg Pfeil
81cc5b98e1
Support Bash 3.2 in fetch-params.sh
...
MacOS still ships with a 15-year-old version of Bash so this removes some usage of features that
require newer (only 10 years old) versions.
Fixes #6367 .
Co-authored-by: Mohamed AlFalasi <2569171+edubai@users.noreply.github.com>
2023-01-26 15:33:57 -07:00
Kris Nuttycombe
887b2688df
Remove unused DEFAULT_BATCHSCANNERMEMLIMIT constant.
2023-01-26 12:33:55 -07:00
Kris Nuttycombe
aab58d308f
Bound wallet batch scanner size to 1000 blocks instead of 100 MiB
...
1000 blocks was selected as a balance between limiting the likely
maximum memory usage of the batch scanner, and avoiding
artificially restricting scanning throughput of small/fast blocks
due to the second-boundary lock synchronization point.
This also removes the `zcashd.wallet.batchscanner.usage.bytes` gague
value that was previously made available when `-prometheusport` was
specified.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 12:26:31 -07:00
Kris Nuttycombe
ce694802d9
Fetch recently conflicted transactions incrementally in ThreadNotifyWallet.
...
We no longer fetch updates from the mempool unless we have fetched all
updates from the chain, as we would otherwise notify the wallet of
mempool changes for which they have not observed parent transactions
in the chain.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 12:26:31 -07:00
Kris Nuttycombe
3b17b77f3d
Allow rescan to exit in the case that Ctrl-C is pressed.
...
Wallet rescanning that happens on node startup was previously not
respecting Ctrl-C. We use an explicit check of `ShutdownRequested()`
instead of a `boost::interruption_point` because wallet startup does
not run in a separate thread.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 11:43:54 -07:00
Kris Nuttycombe
069159b8c1
Merge commit '267ddf8efe36cc799c4c31772a8883ea332ef55b' into version-5.4.0
2023-01-26 09:30:33 -07:00
str4d
cc068329d5
Merge pull request #6370 from nuttycom/bug/dumpwallet_help
...
Fixes an error in `zcash-cli help` following the removal of `dumpwallet`.
2023-01-26 00:48:52 +00:00
Kris Nuttycombe
25c62d804a
Fixes an error in `zcash-cli help` following the removal of `dumpwallet`.
2023-01-25 16:57:29 -07:00
Kris Nuttycombe
c9b63cc3e5
Merge pull request #6358 from str4d/rpc-tests-python-driver
2023-01-25 15:06:06 -07:00
Jack Grigg
817276c02f
rust: Migrate `OrchardMerkleFrontier` to `cxx`
...
Closes zcash/zcash#6333 .
2023-01-24 21:04:48 +00:00
Kris Nuttycombe
a1589ac994
Merge pull request #6364 from str4d/release-v5.4.0-rc2
...
Release v5.4.0-rc2
2023-01-23 21:22:09 -07:00
Jack Grigg
908675b5b9
rust: Add `cxx` version of `RustStream`
2023-01-24 04:15:09 +00:00
Kris Nuttycombe
6d182d7ae7
Update doc/release-notes.md
...
Minor wording correction.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-23 19:15:35 -07:00
Kris Nuttycombe
214c3007f5
Enable tests of chain supply & transparent pool balance.
2023-01-24 02:13:05 +00:00
Jack Grigg
f5b123e494
make-release.py: Updated release notes and changelog for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
Jack Grigg
ad24667c1a
make-release.py: Updated manpages for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
Jack Grigg
ae7c2c742d
make-release.py: Versioning changes for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
Jack Grigg
8f4fff4529
Update release notes with notable changes for v5.4.0
2023-01-24 02:13:05 +00:00
Jack Grigg
5b74dbfddd
metrics: Update `zcash.pool.value.zatoshis` gauge for transparent pool
2023-01-24 02:13:05 +00:00
Jack Grigg
0ff03e9693
depends: Postpone cxx update
2023-01-24 02:12:55 +00:00
str4d
d6e2fada84
Merge pull request #6362 from nuttycom/issue2921-fix-copyright-headers
...
Replace fix-copyright-headers.py with a script that creates a scripted-diff git commit.
2023-01-23 22:13:05 +00:00
str4d
0e931a9397
Merge pull request #4470 from oxarbitrage/issue4294
...
Add transparent value pool to RPC calls
2023-01-23 21:55:00 +00:00
Kris Nuttycombe
0f886c32fe
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-01-23 13:23:20 -07:00
Kris Nuttycombe
3cec519ce4
scripted-diff: Update Zcash copyrights to 2023
...
-BEGIN VERIFY SCRIPT-
for party in "The Zcash developers" "The Bitcoin Core developers" "Bitcoin Developers"; do
sed -i"" -e "s#Copyright (c) \([0-9]\{4\}\)\(-[0-9]\{4\}\)\? $party#Copyright (c) \1-2023 $party#" COPYING
sed -i"" -e "s#\(.*\)\([0-9]\{4\}\)\(-[0-9]\{4\}\)\, $party#\1\2-2023, $party#" contrib/debian/copyright
done
sed -i"" -e "s/define(_COPYRIGHT_YEAR, [0-9]\{4\})/define(_COPYRIGHT_YEAR, 2023)/" configure.ac
sed -i"" -e "s/#define COPYRIGHT_YEAR [0-9]\{4\}/#define COPYRIGHT_YEAR 2023/" src/clientversion.h
git grep "^// Copyright (c) .* The Zcash developers" \
| awk -F ':' '{print $1}' \
| xargs -I {} sed -i"" -e "s#// Copyright (c) \([0-9]\{4\}\)\(-[0-9]\{4\}\)\? The Zcash developers#// Copyright (c) \1-2023 The Zcash developers#" {}
-END VERIFY SCRIPT-
2023-01-23 11:31:54 -07:00
Kris Nuttycombe
b8fe1d2b78
Replace fix-copyright-headers.py with a script that creates a scripted-diff git commit.
...
Fixes #2921
Supersedes #4926
2023-01-23 11:31:41 -07:00
Kris Nuttycombe
57ca26867b
Remove unnecessary delta_count variable.
2023-01-22 22:21:02 -07:00
Kris Nuttycombe
193b22b754
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 11:33:23 -07:00
Kris Nuttycombe
810c191216
Add script for verifying block rewards and fees not claimed by miners.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
Kris Nuttycombe
2fd52ada51
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
Kris Nuttycombe
aa78fc0878
Verify sum of pool balances against chain total supply.
...
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-22 09:10:03 -07:00