Commit Graph

12542 Commits

Author SHA1 Message Date
Eirik0 a84125aacd Fix tree depth in comment 2019-05-10 12:58:11 -06:00
Eirik0 0e06801e12 Move reused sign and send logic 2019-05-10 12:45:14 -06:00
Eirik0 a7a52d2424 Move reused async rpc send logic to separate file 2019-05-10 12:20:52 -06:00
Eirik0 3220d99360 Use CommitTransaction() rather than sendrawtransaction() 2019-05-10 11:44:40 -06:00
Daira Hopwood 9615caa8f9 Fix cosmetic spacing issue in z_setmigration help.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 16:08:03 +01:00
Daira Hopwood e7529049fb Test the expiry height of migration transactions.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Daira Hopwood 14c0be6f27 Change expiry delta for migration transactions to 450 blocks.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Daira Hopwood 9cd34fc10a Repair calls to TransactionBuilder from tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Daira Hopwood 5eb7129d95 Generalize TransactionBuilder and CreateNewContextualCMutableTransaction to allow choosing the expiry delta.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Homu e97621acf7 Auto merge of #3995 - bitcartel:no_migration_during_block_download_phase, r=Eirik0
Don't allow Sprout-to-Sapling migration when syncing during IBD or after wake from sleep.

Prevent migration transactions from being created in response to incoming blocks when a node launches and syncs (the initial block download phase) and when a node wakes from sleep/hibernation and starts syncing old blocks rapidly.
2019-05-09 13:51:49 -07:00
Homu 785989f2f9 Auto merge of #3997 - bitcartel:transaction_builder_tiny_format_error, r=Eirik0
Remove unused specifier from format string

The extra specifier meant that a runtime error would be thrown during Sprout to Sapling migration, if `zrpcunsafe` logging was enabled, preventing migration transactions from being created.
2019-05-09 11:26:33 -07:00
Simon 6921c81b9d Don't allow migration when node is syncing at launch or after waking up. 2019-05-09 09:32:09 -07:00
Simon bda85eb06a Remove unused specifier from format string.
The extra specifier meant that a runtime error would be thrown
during Sprout to Sapling migration if `zrpcunsafe` logging
was enabled:
"tinyformat: Too many conversion specifiers in format string"
2019-05-08 20:51:13 -07:00
Homu 5aaef0b58c Auto merge of #3994 - Eirik0:release-v2.0.5-1, r=Eirik0
Release v2.0.5-1
2019-05-08 07:45:09 -07:00
Eirik0 dfa40412af make-release.py: Updated release notes and changelog for 2.0.5-1. 2019-05-08 06:57:28 -06:00
Eirik0 eceff9bed6 make-release.py: Updated manpages for 2.0.5-1. 2019-05-08 06:57:28 -06:00
Eirik0 f809ff997f make-release.py: Versioning changes for 2.0.5-1. 2019-05-08 06:50:57 -06:00
Homu 92702158ae Auto merge of #3990 - Eirik0:fix-migration-amount, r=Eirik0
Fix calculating amount to migrate
2019-05-07 20:57:30 -07:00
Eirik0 ea8823ce51 coinsView is required when using TransactionBuilder if there may be Sprout change 2019-05-07 18:41:35 -06:00
Eirik0 5fd7af5f85 Add the amount migrated to the operation's result 2019-05-07 08:58:23 -06:00
Eirik0 f0f7b3f012 Fix summing available funds 2019-05-07 08:55:26 -06:00
Homu 5347f6e6cb Auto merge of #3989 - Eirik0:2.0.5-1_release_notes, r=bitcartel
Notable changes for v2.0.5-1
2019-05-06 19:45:12 -07:00
Eirik0 aa23406263 Notable changes for v2.0.5-1 2019-05-06 17:22:10 -06:00
Homu cc80501ea3 Auto merge of #3987 - Eirik0:migration-null-defence, r=Eirik0
Sprout -> Sapling migration status nullptr defence
2019-05-06 12:12:06 -07:00
Eirik0 94e419f95d Rename variable and add comment 2019-05-06 11:46:16 -06:00
Eirik0 d48c3efca7 Store the migration operation id rather than the operation iteslf 2019-05-06 09:57:40 -06:00
Eirik0 7cf4749d0d Correctly account for migration transactions in the mempool
Co-authored-by: LarryRuane <larry@z.cash>
2019-05-05 12:59:43 -06:00
Homu d1d80d9548 Auto merge of #3984 - Eirik0:release-v2.0.5, r=Eirik0
Release v2.0.5
2019-05-03 20:07:44 -07:00
Eirik0 5d69949aaa make-release.py: Updated release notes and changelog for 2.0.5. 2019-05-03 16:35:30 -06:00
Eirik0 380babed98 make-release.py: Updated manpages for 2.0.5. 2019-05-03 16:35:30 -06:00
Eirik0 c1daa11d7b make-release.py: Versioning changes for 2.0.5. 2019-05-03 16:30:13 -06:00
Homu 4df60f4b33 Auto merge of #3981 - Eirik0:2.0.5_release_notes, r=Eirik0
Notable changes for v2.0.5
2019-05-03 09:14:08 -07:00
Eirik0 e152af3c7c Add missing word to release notes 2019-05-03 09:30:26 -06:00
Homu 4d6d2f05e1 Auto merge of #3982 - bitcartel:2.0.5_chainwork_update, r=Eirik0
Update chain work and checkpoint for 2.0.5 release

Update chain work and checkpoint using block 525000.
2019-05-02 21:13:13 -07:00
Eirik0 95fe7ae676 Notable changes for v2.0.5 2019-05-02 19:34:52 -06:00
Simon 68c17ffec8 Update chain work and checkpoint using block 525000. 2019-05-02 14:53:35 -07:00
Homu 8010becd4e Auto merge of #3980 - ianamunoz:fix-gitian-dependency, r=mdr0id
add curl to package list for gitian lxc container

This PR fixes the issue we are seeing in the gitian builder:
https://github.com/zcash/zcash-gitian/issues/64

The base lxc image no longer contains curl by default so it must be installed.
2019-05-02 12:08:07 -07:00
Ian Munoz 5bff723807 add curl to package list for gitian lxc container 2019-05-02 11:47:25 -04:00
Homu 910b1ea2ad Auto merge of #3979 - Eirik0:release-v2.0.5-rc1, r=mdr0id
Release v2.0.5 rc1
2019-05-01 19:33:45 -07:00
Eirik0 12a9e172e5 make-release.py: Updated release notes and changelog for 2.0.5-rc1. 2019-05-01 14:16:08 -06:00
Eirik0 cf0a5ca28d make-release.py: Updated manpages for 2.0.5-rc1. 2019-05-01 14:16:08 -06:00
Eirik0 6c47e6fe7b make-release.py: Versioning changes for 2.0.5-rc1. 2019-05-01 14:15:14 -06:00
Homu d894f7b3b2 Auto merge of #3977 - LarryRuane:3873-setmigration-cli, r=bitcartel
3873 z_setmigration cli bool enable arg conversion

Addresses #3873.
2019-05-01 09:26:20 -07:00
Larry Ruane 4cbe0a9d02 3873 z_setmigration cli bool enable arg conversion 2019-05-01 10:03:24 -06:00
Homu bf2204878f Auto merge of #3973 - Eirik0:3938-migration-status, r=mdr0id
3938 migration status

Closes #3938
2019-05-01 02:18:50 -07:00
Eirik0 3cad5f454f Do not throw an exception if HD Seed is not found when exporting wallet 2019-04-30 15:47:03 -06:00
Eirik0 e14cf96642 Calculate the number of confimations in the canonical way 2019-04-30 11:06:08 -06:00
Eirik0 345177cfc1 Do not look at vin/vout when determining migration txs and other cleanup 2019-04-30 09:52:53 -06:00
Eirik0 e9530f40f2 use -valueBalance rather than vpub_new to calculate migrated amount 2019-04-29 17:00:26 -06:00
Eirik0 108e587c14 Fix typos and update documentation 2019-04-29 15:29:29 -06:00