Simon
3bff998b38
Rename methods to avoid using prefix of _ underscore which is reserved.
...
Added logging of explicit exception rather than a catch all.
Removed redundant spending key check.
Updated user facing help message.
2016-08-24 11:55:26 -07:00
Simon
4b2e557181
Fix comments.
2016-08-24 11:19:34 -07:00
Simon
309b0ecd80
Add "zkey" to list of key types (used by the wallet to decide
...
whether or not it can be recovered if it detects bad records).
2016-08-24 11:19:34 -07:00
Simon
79d769a382
Remove one line of dead code.
2016-08-24 11:19:34 -07:00
Simon
2e0cc87acf
Fix comment.
2016-08-24 11:19:34 -07:00
Simon
badb9a9c2f
Add test coverage for RPC call z_getnewaddress.
2016-08-24 11:19:34 -07:00
Simon
60f762a549
Added wallet rpc tests to cover:
...
z_importwallet, z_exportwallet
z_importkey, z_exportkey
z_listaddresses
2016-08-24 11:19:34 -07:00
Simon
0feffd1424
Don't mark wallet as dirty if key already exists.
...
Fix incorrect method name used in error message.
2016-08-24 11:19:33 -07:00
Simon
4cea36bef3
Add gtest to cover new methods in:
...
CWallet
- GenerateNewZKey()
- AddZKey()
- LoadZKey()
- LoadZKeyMetadata()
CWalletDB
- WriteZKey()
2016-08-24 11:19:33 -07:00
Simon
e709997ff2
Implemented z_listaddresses to return all the zaddr in the wallet.
2016-08-24 11:19:33 -07:00
Simon
92444edc00
Add z_importwallet and z_exportwallet to handle keys for both
...
taddr and zaddr. Restore behaviour of dumpwallet and importwallet
to only handle taddr.
2016-08-24 11:19:33 -07:00
Simon
c1c4594371
Implemented RPC calls z_importkey, z_exportkey, z_getnewaddress.
...
Modified RPC calls dumpwallet and importwallet to include spending keys.
2016-08-24 11:19:33 -07:00
zkbot
2833fb14af
Auto merge of #1291 - daira:decrease-max-headers-results, r=daira
...
Decrease MAX_HEADERS_RESULTS to 1000. fixes #1289
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-24 05:45:53 +00:00
Daira Hopwood
b93c8139e6
Decrease MAX_HEADERS_RESULTS to 160. fixes #1289
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-24 06:14:09 +01:00
Daira Hopwood
bcf79c78c5
Change some asserts in equihash.cpp to be static.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-24 06:13:13 +01:00
Daira Hopwood
c6a7e897bc
Add mostly-static checks on consistency of Equihash parameters, MAX_HEADERS_RESULTS, and MAX_PROTOCOL_MESSAGE_LENGTH.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-24 06:13:06 +01:00
zkbot
cab581256f
Auto merge of #1292 - bitcartel:zc.v0.11.2.latest_701_rpc_docs, r=daira
...
Closes #701 by adding documentation about the Payment RPC interface.
@daira Calls which might not make it into z9 are labelled (NOT IN Z9 ALPHA).
2016-08-24 05:05:11 +00:00
zkbot
cd9d373987
Auto merge of #1260 - str4d:1175-byte-array-manipulation, r=ebfull
...
Update Equihash implementation to match the Zcash spec
Closes #1175
2016-08-24 03:01:13 +00:00
Jack Grigg
90b740fd3b
Test conversion between solution indices and minimal representation
2016-08-24 13:42:52 +12:00
bitcartel
5f3f741e47
Add note about zkey and encrypted wallets in z9 alpha.
2016-08-23 15:33:05 -07:00
Simon
73f9e32b86
Closes #701 by adding documentation about the Payment RPC interface.
2016-08-23 00:37:43 -07:00
zkbot
27bd8e4129
Auto merge of #1270 - ThisIsNotOfficialCodeItsJustForks:t1168-fix-optimization-flags, r=daira
...
Fix inconsistent -O1/-O2, fix libzcash flags, add -fwrapv -fno-strict-aliasing
Closes #1168 . In that ticket I decided the optimization flags for dependencies are out of scope, i.e. we go with whatever the upstream package maintainer chose.
2016-08-23 03:30:31 +00:00
zkbot
fed866e212
Auto merge of #1262 - ebfull:compressed-proofs, r=ebfull
...
Implement zkSNARK compression
Implement zkSNARK compression.
The serialization format of zkSNARKs has now been specified in our protocol specification. G1/G2 elements are now compressed into 33 byte and 65 byte formats, repsectively. `MONTGOMERY_OUTPUT` is enabled everywhere to make proving/verifying keys load faster and be consistent with the MPC.
Proofs are now 296 bytes. This PR also updates the proving and verifying keys.
Closes #1103 . Closes #471 .
See also https://github.com/zcash/libsnark/pull/3 and https://github.com/zcash/libsnark/pull/4
2016-08-23 02:11:30 +00:00
zkbot
07b246988b
Auto merge of #1261 - str4d:892-branch-coverage, r=daira
...
Coverage report improvements
2016-08-23 00:19:48 +00:00
Sean Bowe
393b2b7834
Update proving/verifying keys.
2016-08-22 15:48:43 -06:00
Sean Bowe
decde3864d
Enable MONTGOMERY_OUTPUT everywhere.
2016-08-22 15:48:43 -06:00
Sean Bowe
6a1653f009
Update libsnark dependency.
2016-08-22 15:48:20 -06:00
Sean Bowe
ae6b333c75
Perform curve parameter initialization at start of gtest suite.
2016-08-22 15:47:00 -06:00
Daira Hopwood
ea92aba9fe
Move bigint arithmetic implementations to libsnark.
2016-08-22 15:46:58 -06:00
Sean Bowe
f0dab51cf3
Implement zkSNARK compression.
2016-08-22 00:36:12 -06:00
zkbot
365845216b
Auto merge of #1268 - ThisIsNotOfficialCodeItsJustForks:t1130-upgrade-libsodium, r=ebfull
...
Upgrade libsodium for AVX2-detection bugfix.
Upgrades libsodium to bring in an AVX2-detection bugfix (to help with #1130 ).
2016-08-22 02:34:30 +00:00
zkbot
f4491c51e4
Auto merge of #1248 - rcseacord:rcseacord-patch-4, r=ebfull
...
Update uint256.h
Addresses load of misaligned address for type 'const uint32_t' #1246
2016-08-22 00:12:48 +00:00
Lars-Magnus Skog
8fd71a194e
changed module name from "bitcoin" to "Zcash" in FormatException()
2016-08-21 15:10:09 +02:00
Jack Grigg
e273f05d10
Remove unnecessary temporary array from Equihash hash generation
2016-08-21 06:05:48 +12:00
Jack Grigg
6e629886e5
Add another test case based on example in the spec
2016-08-21 05:57:46 +12:00
Gaurav Rana
6c7cc8ebea
update zcash-cli stop message
...
changed "Bitcoin server stopping" to "Zcash server stopping"
2016-08-20 12:27:12 +00:00
zkbot
7e556172d9
Auto merge of #1236 - tomrittervg:tomrittervg-comments-1, r=ebfull
...
Clarify comment about nonce space for Note Encryption
2016-08-18 23:38:36 +00:00
Taylor Hornby
2902ac7ce8
Use libsodium's s < L check, instead checking that libsodium checks that.
2016-08-18 16:38:20 -06:00
Tom Ritter
36d5f42948
Update NoteEncryption.hpp
2016-08-18 16:51:15 -05:00
zkbot
28a30f7801
Auto merge of #1254 - ebfull:tx-structure-changes, r=bitcartel
...
Change memo field size and relocate `ciphertexts` field of JoinSplit description
Closes #1190
Closes #1187
2016-08-18 16:49:47 +00:00
ebfull
2ee6ed64eb
Add parenthesis around macro value definition
2016-08-18 10:43:58 -06:00
zkbot
af9898eee5
Auto merge of #1258 - ThisIsNotOfficialCodeItsJustForks:t1251-upstream-anti-dos, r=daira
...
Pull in some DoS mitigations from upstream
Closes #1251 .
**WARNING: I force pushed**
2016-08-18 16:08:25 +00:00
zkbot
3d28c86c8e
Auto merge of #1205 - str4d:1199-key-management, r=str4d
...
Add support for spending keys to the basic key store
Prerequisite for #1197 and #1199 .
2016-08-18 00:27:09 +00:00
Jack Grigg
a4f4fa8fe9
ASSERT -> EXPECT in test to get more info per test run about future regressions
2016-08-18 12:25:01 +12:00
Jack Grigg
04dfc3c569
Rework test to check for failure to return a spending key
2016-08-18 12:22:30 +12:00
Taylor Hornby
f5d3d420f6
Add -fwrapv -fno-strict-aliasing; fix libzcash flags.
2016-08-17 11:57:51 -06:00
Taylor Hornby
46ad3c2758
Fix inconsistent optimization flags; single source of truth.
2016-08-17 11:38:28 -06:00
Taylor Hornby
a635d6e995
Upgrade libsodium for AVX2-detection bugfix.
2016-08-17 10:43:06 -06:00
zkbot
39af39fb85
Auto merge of #1231 - rcseacord:rcseacord-patch-3, r=str4d
...
Address incorrect use of shared_ptr in test_equihash.cpp
Closes #1228
2016-08-17 01:30:26 +00:00
zkbot
cdc01fad17
Auto merge of #1230 - rcseacord:rcseacord-patch-1, r=str4d
...
Address incorrect use of shared_ptr in equihash.cpp
Closes #1214
2016-08-17 00:35:57 +00:00