Jack Grigg
31afbcc5c9
Ignore -mempooltxinputlimit once Overwinter activates
2018-03-28 14:25:42 +02:00
Homu
99b6f76355
Auto merge of #3111 - bitcartel:3110_high_fee_error_reporting, r=bitcartel
...
Closes #3110 . Ensure user can see error message about absurdly high fees.
2018-03-27 10:33:52 -07:00
Simon
8b15afd315
Closes #3110 . Ensure user can see error message about absurdly high fees.
2018-03-27 10:23:24 -07:00
Jack Grigg
b466c1c90c
cleanup: Ensure code is pyflakes-clean for CI
2018-03-27 02:47:57 +02:00
Homu
64de921747
Auto merge of #3091 - bitcartel:cache_invalidation_qa, r=str4d
...
Closes #1988 . Add qa test for cache invalidation bug found in v1.0.0 to v1.0.3.
2018-03-20 11:28:08 -07:00
Homu
70e2522306
Auto merge of #3090 - bitcartel:3084_log_expired_txid, r=bitcartel
...
Closes #3084 . Log txid when removing expired transactions from mempool.
2018-03-19 14:59:30 -07:00
Jack Grigg
b7caaf954b
test: Move wait_and_assert_operationid_status debug output before asserts
...
Otherwise we don't see them for failed tests :)
2018-03-19 14:00:18 +01:00
Simon
b740a99079
Remove local function wait_and_assert_operationid_status which is
...
now defined in the test framework for shared usage.
2018-03-16 17:16:22 -07:00
Simon
2f761371d2
Add qa test for cache invalidation bug found in v1.0.0 to v1.0.3.
2018-03-16 15:18:34 -07:00
Simon
a510b4752d
Enable mempool logging in tx expiry QA test.
2018-03-16 11:45:45 -07:00
Daira Hopwood
b4353db5d6
pyflakes cleanups to RPC tests after Overwinter PRs.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-03-12 14:15:25 +00:00
Jonathan "Duke" Leto
4db8717431
Fix outdated comment about starting balance of nodes
2018-02-28 14:29:05 -08:00
Jonathan "Duke" Leto
48cecf2ad9
Regtest mining does have a founders reward, a single address t2FwcEhFdNXuFMv1tcYwaBJtYVtMj8b1uTg
2018-02-28 14:28:22 -08:00
Jonathan "Duke" Leto
62fee1296f
Update awkward wording about blocks as per @daira
2018-02-28 14:17:28 -08:00
Jonathan "Duke" Leto
d8399efc03
This library seems to not be used at all and all comments mentioning it are ghosts
2018-02-28 14:13:07 -08:00
Jonathan "Duke" Leto
427e5fae3f
Fix references to Bitcoin in RPC tests readme
2018-02-26 10:47:59 -08:00
Homu
a418756ef4
Auto merge of #2874 - arcalinea:tx_block_expiry, r=arcalinea
...
Transaction expiry height
Implements ZIP 203.
- Only applies after Overwinter blockheight.
Closes #754 .
2018-02-23 18:37:48 -08:00
Simon
b6e5cc7d27
Add python qa test overwinter_peer_management.
2018-02-23 14:22:43 -08:00
Jay Graber
5943f227da
Add mempool_tx_expiry.py test
2018-02-23 00:12:10 -08:00
Homu
c5904fb2a4
Auto merge of #2797 - str4d:2493-active-merging, r=bitcartel
...
Implement z_mergetoaddress for combining UTXOs and notes
Closes #2493 .
2018-02-22 20:59:51 -08:00
Jack Grigg
15ced9b153
wallet_mergetoaddress: Add additional syncs to prevent race conditions
2018-02-23 04:28:04 +00:00
Simon
e6cd2a8356
Closes #2964 . z_sendmany once again makes v1 tx for taddr to taddr.
...
In accordance with the Zcash protocol spec.
2018-02-22 15:43:42 +00:00
Jack Grigg
4c3d2b3bbe
Check upgrade status in wallet_overwintertx RPC test
2018-02-22 13:44:40 +00:00
Jack Grigg
553a5c1ab2
Gate z_mergetoaddress as an experimental feature
2018-02-22 13:23:25 +00:00
Jack Grigg
6e9c7629af
Implement z_mergetoaddress for combining UTXOs and notes
...
Closes #2493 .
2018-02-22 13:23:18 +00:00
Jack Grigg
ed9aa2b62a
Add branch IDs for current and next block to getblockchaininfo
...
Closes #2974 .
2018-02-21 21:18:03 +00:00
Homu
d4d2844829
Auto merge of #2463 - str4d:713-rollback-limit, r=str4d
...
Implement roll-back limit for reorganisation
Part of #2905 . Closes #713 .
2018-02-20 15:17:22 -08:00
Jack Grigg
818b94f94f
Make number of inputs configurable in validatelargetx test
2018-02-20 04:22:22 +00:00
Homu
49274558c6
Auto merge of #2940 - str4d:nu-activation-mempool-expiry, r=str4d
...
Mempool improvements, branch ID awareness
Whenever the local chain tip is updated, transactions in the mempool which commit to an
unmineable branch ID (for example, just before a network upgrade activates, where the
next block will have a different branch ID) will be removed.
Includes commits cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6654
- Only the mempool index change.
- bitcoin/bitcoin#6776
- bitcoin/bitcoin#7020
- bitcoin/bitcoin#6915
Part of #2074 .
2018-02-19 19:00:30 -08:00
Jack Grigg
34a64fe0a2
Remove mempool transactions which commit to an unmineable branch ID
2018-02-20 02:57:44 +00:00
Matt Corallo
b0f8c83f95
Add failing test checking timelocked-txn removal during reorg
2018-02-20 02:57:40 +00:00
Jack Grigg
57e6ecda5a
Implement roll-back limit for reorganisation
...
Closes #713 .
2018-02-19 16:32:42 +00:00
Simon
072099d788
Implementation of Overwinter transaction format ZIP 202.
2018-02-16 10:10:15 -08:00
Jack Grigg
9e8f1d09ca
zkey_import_export: Synchronize mempools before mining
...
Resolves a race condition that caused the RPC test to intermittently fail.
Closes #2892 .
2018-01-22 21:10:57 +00:00
Jack Grigg
44e5b42751
Check chainValueZat when checking value pool monitoring
2018-01-03 23:41:53 +01:00
Jack Grigg
5d9cf8ae23
Fix pyflakes warnings in zkey_import_export RPC test
2017-12-21 18:19:42 +00:00
Homu
1683c2d5bf
Auto merge of #2143 - str4d:1997-viewing-keys, r=str4d
...
Implement incoming viewing keys
Closes #1997 .
2017-12-20 14:11:05 -08:00
Jack Grigg
44e37656bf
Add watch-only support to Zcash RPC methods
...
Balance totals do not include spends linked to viewing key addresses, as
nullifiers cannot be calculated and therefore spends cannot be detected.
2017-12-20 00:46:37 +00:00
Homu
c1b0db70e5
Auto merge of #2779 - arcalinea:2515_test_zimportkey, r=str4d
...
Add RPC test that exercises z_importkey
Part of #2515 .
2017-12-18 08:32:28 -08:00
Homu
efda4bafef
Auto merge of #2796 - per-gron:less-verbose-tests, r=daira
...
Less verbose tests
Fixes #2453 and deduplicates some related code.
2017-12-17 00:22:38 -08:00
Per Grön
d4ab94a6d9
Print result of RPC call in test only when PYTHON_DEBUG is set
2017-12-16 19:24:25 +01:00
Per Grön
8993edfb77
Deduplicate test utility method wait_and_assert_operationid_status
...
Strictly speaking this is not a true deduplication; the test output will be
slightly different (due to inconsistent print statements) but I think this is
close enough.
2017-12-16 19:24:25 +01:00
Homu
7888624f74
Auto merge of #2795 - str4d:2351-sprout-circuit-value, r=str4d
...
Track net value entering and exiting the Sprout circuit
Delta values will be stored for new blocks; old blocks can be filled in by
re-indexing. The net value currently in the Sprout circuit is only calculated
when delta values for all previous blocks are present.
Part of #2351 .
2017-12-16 02:09:40 -08:00
Homu
f44a4cea42
Auto merge of #2790 - bitcartel:2746_payment_disclosure_prefix, r=str4d
...
Closes #2746 . Payment disclosure blobs now use 'zpd:' prefix.
2017-12-15 10:31:58 -08:00
Jay Graber
73b220cb0f
Add rpc test that exercises z_importkey
2017-12-15 10:15:50 -08:00
Jack Grigg
e319633435
Add Sprout value pool to getblock and getblockchaininfo
2017-12-14 22:06:15 +00:00
Simon
61345ae703
Closes #2746 . Payment disclosure blobs now use 'zpd:' prefix.
2017-12-07 10:11:43 -08:00
Homu
019c4bddc8
Auto merge of #2741 - bitcartel:stop_dumpwallet_overwriting, r=str4d
...
Prevent RPC calls dumpwallet and z_exportwallet from overwriting an existing file
Closes #2740
2017-12-04 09:41:52 -08:00
Simon
159aa37fc0
Closes #2759 . Fixes broken pipe error with QA test wallet.py.
2017-11-22 00:02:52 -08:00
Simon
ba1dbb3040
RPC dumpwallet and z_exportwallet updated to no longer allow
...
overwriting an existing file.
2017-11-16 22:29:37 -08:00
Simon
45232b1961
Add payment disclosure as experimental feature.
2017-11-14 13:29:05 -08:00
Simon
337bca8125
Fix an issue where qa test wallet_shieldcoinbase could hang.
...
The mempool was not synced so a block could be generated and not
clear out the mempool. This would then cause subsequent code
which expected the mempool of all nodes to be empty to hang.
2017-11-03 00:39:23 -07:00
Homu
3775ac5250
Auto merge of #2692 - bitcartel:2639_enable_z_shieldcoinbase, r=str4d
...
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
This reverts commit 5023af7bd5
.
2017-11-02 00:18:40 -07:00
Simon
c5dabd2b66
Closes #2639 . Adds optional limit parameter with a default value of 50.
...
The new parameter is to satisfy the principle of least astonishment
by providing a sensible default for the maximum number of transparent
inputs to shield. If users do not configure -mempooltxinputlimit
it is possible for them to create transactions with hundreds of
inputs which suffer from mining delay, due to the current state of
the network where some miners have configured -mempooltxinputlimit
as a way to deal with the problem of quadratic hashing.
2017-11-01 10:40:24 -07:00
Simon
cf72e8e06e
Closes #2263 fixing broken pipe error.
2017-10-30 11:58:37 -07:00
Simon
c2d3bafeaa
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
...
This reverts commit 5023af7bd5
.
2017-10-26 11:29:36 -07:00
Duke Leto
a20b975a52
Update performance-measurements.sh
...
Fix error message, as per @daira
2017-10-24 14:50:26 -07:00
Homu
6b58fd2c99
Auto merge of #2665 - leto:perf_fix, r=str4d
...
Fix bug where performance-measurements.sh fails hards when given no args
Better than "$1: unbound variable", we ran into this when testing this script in the Hush repo, so we are pushing this fix upstream.
2017-10-23 18:37:05 -07:00
Jack Grigg
692bf7a6df
Add --list-stages argument to full_test_suite.py
2017-10-18 00:56:32 -07:00
Jack Grigg
91dd425b4a
Add libsnark tests to full_test_suite.py
2017-10-18 00:55:52 -07:00
Homu
4c9b77d8fb
Auto merge of #2654 - str4d:429-test-driver-script, r=str4d
...
[Test] New merge test suite driver script
Running the script with no arguments will run all test stages in succession.
Passing one or more stages as arguments will run just those stages.
Closes #429 .
2017-10-16 21:51:21 -07:00
Jack Grigg
6e98511cf1
Add stdout notice if any stage fails
2017-10-16 16:16:14 -04:00
Jack Grigg
88fbdc4868
Add bitcoin-util-test.py to full_test_suite.py
...
Not moved, because upstream makes improvements to this script, and the need to
set environment variables makes it simpler to just use the given script.
2017-10-16 16:15:10 -04:00
Homu
a2dc9be5c5
Auto merge of #2533 - str4d:2530-mininode, r=str4d
...
Migrate MiniNode to Zcash
This enables various RPC tests that use it (most of them in the extended test suite) to properly test Zcash code.
The PR also fixes bugs in the BIP65 and BIP66 tests that were both masking and masked by the un-migrated MiniNode.
The Python module `pyblake2` is now a requirement for the RPC tests.
Part of #2530 .
2017-10-16 08:43:58 -07:00
Jonathan "Duke" Leto
147fffb7ec
Fix bug where performance-measurements.sh fails hards when given no args
...
Better than "$1: unbound variable", we ran into this when testing this
script in the Hush repo, so we are pushing this fix upstream.
2017-10-16 08:39:59 -07:00
Homu
af549fe6ed
Auto merge of #2650 - str4d:2645-listunspent-benchmark, r=str4d
...
Add benchmark for listunspent
Closes #2645 .
2017-10-12 15:24:53 -07:00
Jack Grigg
94790c5d8f
Add memory benchmark for validatelargetx
2017-10-09 22:18:28 +01:00
Jack Grigg
c6af0aa453
Move check-security-hardening.sh into full_test_suite.py
2017-10-06 11:17:45 +01:00
Jack Grigg
105b2b6248
Move ensure-no-dot-so-in-depends.py into full_test_suite.py
2017-10-06 11:17:45 +01:00
Jack Grigg
aadf3aa159
Replace full-test-suite.sh with a new test suite driver script
...
This will be the canonical location for the entire Zcash merge test suite.
2017-10-06 11:17:11 +01:00
Jack Grigg
f8ef223ce3
Un-indent RPC test output in test runner
...
The indentation caused the test stdout to be buffered and only printed at the
end of the test, which makes it harder to diagnose hanging tests.
2017-10-05 15:18:58 +01:00
Jack Grigg
5455ca0d0e
Fix BIP65 and BIP66 tests
...
Blocks were being created that didn't satisfy the regtest consensus rules.
2017-10-05 15:18:54 +01:00
Jack Grigg
c10c40779d
[Test] MiniNode: Implement Zcash coinbase
2017-10-05 15:18:53 +01:00
Jack Grigg
7596a4922d
[Test] MiniNode: Coerce OP_PUSHDATA bytearrays to bytes
...
If a bytearray is passed in as part of an iterable, the CScript constructor
fails because b''.join() cannot be used to join a bytearray to a bytes or str in
Python 2.
2017-10-05 15:18:31 +01:00
Jack Grigg
643235859a
[Test] MiniNode: Fix coinbase creation
...
CScriptNum is only used for heights > 16.
2017-10-05 15:18:27 +01:00
Jack Grigg
e68c3ec188
[Test] MiniNode: Use Zcash PoW
...
Equihash solver code extracted from https://github.com/str4d/zcash-pow
RPC tests now require pyblake2 to be installed
2017-10-05 15:15:10 +01:00
Jack Grigg
0de9a481ab
[Test] MiniNode: Update protocol version and network magics
2017-10-05 15:15:10 +01:00
Jack Grigg
31bc3d2581
[Test] MiniNode: Implement Zcash block parsing
2017-10-05 15:15:10 +01:00
Jack Grigg
c47dc872a7
[Test] MiniNode: Implement v2 CTransaction parsing
2017-10-05 15:15:10 +01:00
Jack Grigg
13ca1e8011
[Test] MiniNode: Implement JSDescription parsing
2017-10-05 15:15:06 +01:00
Jack Grigg
99dd50c30c
Add benchmark for listunspent
...
Closes #2645 .
2017-10-04 12:48:50 +01:00
Jack Grigg
243b6a9d4b
Add connections in BIP65 and BIP66 tests to the test manager
...
Fixes a bug in the tests causing them to silently pass instead of correctly
reporting other errors. Introduced in 4a785b0a5b
during the test rewrites.
2017-10-03 17:41:37 +01:00
Homu
e806f9c603
Auto merge of #2638 - bitcartel:2637_experimental_feature_z_shieldcoinbase, r=str4d
...
Closes #2637 . Make z_shieldcoinbase an experimental feature.
Can be enabled with: `zcashd -experimentalfeatures -zshieldcoinbase`
2017-09-27 16:09:54 -07:00
Jack Grigg
091c089d03
Fix incorrect failure in memory benchmark
2017-09-27 19:42:39 +01:00
Jack Grigg
72b4f0b3e6
Individualise performance-measurements.sh errors for debugging
2017-09-27 19:41:54 +01:00
Simon
5023af7bd5
Closes #2637 . Make z_shieldcoinbase an experimental feature where it
...
can be enabled with: zcashd -experimentalfeatures -zshieldcoinbase.
2017-09-27 10:43:54 -07:00
Jack Grigg
f897e075c2
Fix pyflakes warnings in RPC tests
2017-09-27 17:24:19 +01:00
Homu
f34c60de37
Auto merge of #2615 - bitcartel:2448_shield_coinbase, r=bitcartel
...
Add RPC command shield_coinbase #2448 .
Shield transparent coinbase funds by sending to a shielded z address. Closes #2448 .
2017-09-22 12:04:31 -07:00
Simon
06c19063bb
Implement RPC shield_coinbase #2448 .
2017-09-21 15:04:12 -07:00
Homu
8f16b27304
Auto merge of #2616 - nathan-at-least:importprivkey-shows-address.4, r=str4d
...
Importprivkey shows address
Scratching an itch: make `importprivkey` output the corresponding address.
Without this PR, `importprivkey` shows no output. Because we're moving towards an "address-based" RPC interface, rather than "account-based", there's a gap when using `importprivkey` because there's no way to assign it to a specific account, but also no easy way to determine the address. This change fixes that wart.
2017-09-21 14:29:03 -07:00
Jack Grigg
109fed51ff
Additional test cases for importprivkey RPC test
2017-09-21 22:21:44 +01:00
Homu
60b4a79000
Auto merge of #2620 - bitcartel:2583_watch_only_fspendable, r=str4d
...
Closes #2583 . Exclude watch-only utxos from coin selection.
2017-09-20 04:49:48 -07:00
Simon
5a0721f0fe
Set up a clean chain.
...
Delete redundant method wait_until_miner_sees() via use of sync_all().
2017-09-19 20:42:53 -07:00
Simon
b17e1b4080
Closes #2583 . Exclude watch-only utxos from z_sendmany coin selection.
2017-09-19 19:42:48 -07:00
Ariel Gabizon
2e8aefdce1
add load-wallet benchmark
2017-09-18 21:54:53 +02:00
Nathan Wilcox
3e92c028ce
Add a new requirement that `importprivkey` API is idempotent.
2017-09-18 15:30:42 +09:00
Nathan Wilcox
63cdea4233
Add a new rpc-test-specified requirement: `importprivkey` outputs the associated address. (Test fails.)
2017-09-18 15:30:42 +09:00
Nathan Wilcox
d29b6b042f
key_import_export rpc-test: verify that UTXO view co-evolves for nodes sharing a key.
2017-09-18 15:30:42 +09:00
Jack Grigg
e719bf75d4
Adjust instructions for UTXO dataset creation
...
--nocleanup is sufficient to leave the data directories behind. --noshutdown is
only useful if you want to inspect the nodes afterwards, and you'd need to
manually shut down both nodes before copying the data directories.
2017-09-11 21:53:35 +01:00
Jack Grigg
d669871e8b
Fix bug in benchmark data generation script
2017-09-06 19:52:35 +01:00