Commit Graph

13418 Commits

Author SHA1 Message Date
Alfredo Garcia d53d4d880a add destination wrappers 2020-02-18 13:20:43 -03:00
Jack Grigg 0f12f47f58 Patch libsodium 1.0.15 signature validation onto 1.0.18 2020-02-18 01:18:37 +00:00
Jack Grigg 4fe5969157 Patch libsodium 1.0.15 pubkey validation onto 1.0.18 2020-02-18 01:18:37 +00:00
ca333 d4644e7ed0 update libsodium to v1.0.18
according to changelogs backwards compatible and containing various optimizations:

https://github.com/jedisct1/libsodium/releases
https://fossies.org/diffs/libsodium/1.0.15_vs_1.0.16/ChangeLog-diff.html
https://fossies.org/diffs/libsodium/1.0.16_vs_1.0.17/ChangeLog-diff.html
https://fossies.org/diffs/libsodium/1.0.17_vs_1.0.18/ChangeLog-diff.html

(EDIT by str4d): The update is not in fact backwards-compatible; the
passing test cases added in the previous commit fail as of this commit.
2020-02-18 01:18:37 +00:00
Jack Grigg 7893f7b752 Add test vectors for small-order Ed25519 pubkeys
I'm not adding test vectors for non-canonical pubkeys, as that would
require grinding to find a private key corresponding to one of the 19
pubkeys that can be non-canonical.
2020-02-18 01:18:37 +00:00
Homu 5dde1a7702 Auto merge of #4328 - oxarbitrage:issue3344, r=str4d
Reduce duplication in key_io decode

Attempt to fix https://github.com/zcash/zcash/issues/3344 by adding a new `DecodeAny` template function with arguments that will handle all the cases. Then on each decoding this new function is called with the appropriate arguments resulting in reducing code duplication.

Some of the complexity(`boost::optional`) will be removed if `ViewingKey` is implemented for sapling.
2020-02-17 21:50:45 +00:00
Alfredo Garcia 0987bf349a add missing calls to DecodeAny 2020-02-17 14:54:08 -03:00
Alfredo Garcia df38c039f5 make type and size a pair in DecodeAny arguments 2020-02-17 14:27:56 -03:00
Alfredo Garcia 9ba20840e9 remove debug noise from 2 gtests 2020-02-17 13:57:49 -03:00
Alfredo Garcia a8f6b8c2e5 fix rpx_wallet_tests 2020-02-17 09:52:40 -03:00
Dimitris Apostolou daff771ca4
End diff with LF character 2020-02-16 21:14:42 +02:00
Daira Hopwood fd164f56f2 Add missing cases for Blossom in ContextualCheckBlock tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-02-16 18:38:56 +00:00
Homu a830563309 Auto merge of #4316 - str4d:worst-case-benchmarks, r=str4d
Worst-case block verification benchmarks

The micro-benchmark framework from #3858 is used to measure the time to verify various transaction components. These are leveraged by a script that simulates the verification cost of different compositions of full blocks.
2020-02-14 23:42:44 +00:00
Jack Grigg ec32287fe7 bench: "Use" result of crypto_sign_verify_detached
This fixes compilation with --enable-werror.
2020-02-14 16:48:32 +00:00
Alfredo Garcia e992825e0a add txexpirynotify 2020-02-13 21:42:25 -03:00
Jack Grigg ef5fb6a93c test: Fix pyflakes warnings 2020-02-13 20:04:33 +00:00
Jack Grigg 0d5d329312 test: Hard-code hex memo in wallet_listreceived for Python3 compatibility 2020-02-13 20:04:33 +00:00
Homu bfa54b28f4 Auto merge of #4348 - rex4539:typos, r=str4d
Fix typo
2020-02-13 15:44:38 +00:00
Dimitris Apostolou 3247e3c901
Fix typo 2020-02-13 17:14:19 +02:00
Homu c5d20b5da0 Auto merge of #4335 - rex4539:remove-libsnark-flags, r=str4d
Remove libsnark preprocessor flags

Closes https://github.com/zcash/zcash/issues/4285.
2020-02-11 23:47:52 +00:00
Homu 3011702f53 Auto merge of #4302 - oxarbitrage:issue3687, r=str4d
Add z_getnewaddress test

Supercedes #3749. Closes #3687.

It takes the commit from @dagurval where a new test case
`rpc_wallet_z_getnewaddress` is added and it adds a check for too many
arguments.

It uses `CheckRPCThrows()` to test the error message of invalid argument.
However, for too many arguments the full help message is displayed, so I
am just testing there is an runtime exception.
2020-02-11 22:43:44 +00:00
Homu 64f0291790 Auto merge of #4257 - oxarbitrage:issue4004, r=str4d
Delete SignatureHash from python script framework

Fixes https://github.com/zcash/zcash/issues/4004

Code is not used anywhere.
2020-02-11 21:39:31 +00:00
Homu db6fb09518 Auto merge of #4334 - rex4539:fix-boost, r=str4d
Fix Boost compilation on macOS

Fixes https://github.com/zcash/zcash/issues/4333
2020-02-11 14:50:48 +00:00
Dimitris Apostolou 439c3dd6d2
Remove libsnark preprocessor flags 2020-02-11 16:28:18 +02:00
Alfredo Garcia 70d5682e31
Merge branch 'master' into issue4004 2020-02-11 10:58:33 -03:00
Alfredo Garcia ebd9d0c562
remove unused imports 2020-02-11 10:56:45 -03:00
Homu e10576434d Auto merge of #4258 - oxarbitrage:issue3575, r=str4d
Changing gtest to CamelCase

This is #3583 with merge conflicts fixed.

Closes #3575.
2020-02-11 13:47:26 +00:00
Homu b5e38edfda Auto merge of #4236 - mdr0id:rpc_py2_to_py3, r=mdr0id
RPC Python2 to Python3 Update

Updates to allow RPCs to run in Python3.
2020-02-10 22:35:27 +00:00
mdr0id 1ce2e86612 Update #! env for python3 2020-02-10 13:34:29 -08:00
mdr0id 7300db81ed Updating remaining python3 conventions 2020-02-10 13:15:26 -08:00
mdr0id 4cb368a8d9 Update remaining Python3 conventions 2020-02-10 12:46:41 -08:00
mdr0id 826135d5ed Fix remaining python3 conventions 2020-02-10 12:38:46 -08:00
mdr0id fdac835b13 update comment regarding prior py2 exception 2020-02-09 12:38:01 -08:00
mdr0id 5ac9cb85f3 fix string pattern issue on byte object 2020-02-09 09:07:42 -08:00
mdr0id 9592ded3cc clean up conventions and whitespace 2020-02-09 08:44:23 -08:00
mdr0id 8f859cbf85 fix pyflakes errors 2020-02-09 08:18:00 -08:00
mdr0id 93c625397f Update py3 division 2020-02-09 08:18:00 -08:00
mdr0id c7113bd6f1 Update json to simplejson to remove unicode and str issue from py2 to py3 2020-02-09 08:18:00 -08:00
mdr0id 3eb6512b78 cleanups and fixing odd casting 2020-02-09 08:18:00 -08:00
mdr0id b2752948c0 fix url and port issue 2020-02-09 08:18:00 -08:00
mdr0id 08cfd935d6 clean up 2020-02-09 08:17:32 -08:00
mdr0id 4801c316fc clean up 2020-02-09 08:17:32 -08:00
mdr0id ff5a47acfa clean up 2020-02-09 08:17:32 -08:00
mdr0id 44834ed01c Clean up import calls 2020-02-09 08:17:32 -08:00
mdr0id 3ae42f1e75 Fix decimal 0 issues 2020-02-09 08:17:32 -08:00
mdr0id 0b1a644d54 remove u encoding 2020-02-09 08:17:32 -08:00
mdr0id f26269c512 clean up to minimize diff 2020-02-09 08:17:32 -08:00
mdr0id 2d4f4f0b13 remove debug lines from prior commits 2020-02-09 08:17:32 -08:00
mdr0id 89307b131a update type for decimal 0 2020-02-09 08:15:43 -08:00
mdr0id 8240f73c68 clean up initiliaze statements from imports 2020-02-09 08:15:43 -08:00