2021-06-03 21:40:53 -07:00
|
|
|
## Motivation
|
2020-08-28 17:36:46 -07:00
|
|
|
<!--
|
2020-10-30 14:42:04 -07:00
|
|
|
Thank you for your Pull Request.
|
2023-11-02 14:56:07 -07:00
|
|
|
Does it close any issues?
|
2021-06-03 21:40:53 -07:00
|
|
|
-->
|
2023-11-02 14:56:07 -07:00
|
|
|
_What are the most important goals of the ticket or PR?_
|
|
|
|
|
|
|
|
|
|
|
|
### PR Author Checklist
|
|
|
|
|
|
|
|
#### Check before marking the PR as ready for review:
|
|
|
|
- [ ] Will the PR name make sense to users?
|
|
|
|
- [ ] Does the PR have a priority label?
|
|
|
|
- [ ] Have you added or updated tests?
|
|
|
|
- [ ] Is the documentation up to date?
|
|
|
|
|
|
|
|
##### For significant changes:
|
|
|
|
- [ ] Is there a summary in the CHANGELOG?
|
|
|
|
- [ ] Can these changes be split into multiple PRs?
|
|
|
|
|
|
|
|
_If a checkbox isn't relevant to the PR, mark it as done._
|
2020-08-28 17:36:46 -07:00
|
|
|
|
2021-06-03 21:40:53 -07:00
|
|
|
### Specifications
|
|
|
|
|
|
|
|
<!--
|
|
|
|
If this PR changes consensus rules, quote them, and link to the Zcash spec or ZIP:
|
|
|
|
https://zips.z.cash/#nu5-zips
|
2020-08-28 17:36:46 -07:00
|
|
|
-->
|
|
|
|
|
2023-11-02 14:56:07 -07:00
|
|
|
|
2022-12-07 14:38:41 -08:00
|
|
|
### Complex Code or Requirements
|
2020-08-28 17:36:46 -07:00
|
|
|
|
|
|
|
<!--
|
2022-12-07 14:38:41 -08:00
|
|
|
Does this PR change concurrency, unsafe code, or complex consensus rules?
|
2023-11-02 14:56:07 -07:00
|
|
|
If it does, label this PR with `extra-reviews`.
|
2020-08-28 17:36:46 -07:00
|
|
|
-->
|
|
|
|
|
2023-11-02 14:56:07 -07:00
|
|
|
|
2020-08-28 17:36:46 -07:00
|
|
|
## Solution
|
|
|
|
|
|
|
|
<!--
|
2021-06-03 21:40:53 -07:00
|
|
|
Summarize the changes in this PR.
|
2020-10-30 14:42:04 -07:00
|
|
|
-->
|
|
|
|
|
2023-11-02 14:56:07 -07:00
|
|
|
|
|
|
|
### Testing
|
|
|
|
|
|
|
|
<!--
|
|
|
|
Which tests were changed or added in this PR? Were there manual tests?
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
2020-10-30 14:42:04 -07:00
|
|
|
## Review
|
|
|
|
|
|
|
|
<!--
|
|
|
|
Is this PR blocking any other work?
|
2022-12-07 14:38:41 -08:00
|
|
|
If you want specific reviewers for this PR, tag them here.
|
2020-08-28 17:36:46 -07:00
|
|
|
-->
|
2020-08-28 18:14:38 -07:00
|
|
|
|
2023-11-02 14:56:07 -07:00
|
|
|
|
2021-06-03 21:40:53 -07:00
|
|
|
### Reviewer Checklist
|
2020-10-30 14:42:04 -07:00
|
|
|
|
2023-11-02 14:56:07 -07:00
|
|
|
Check before approving the PR:
|
|
|
|
- [ ] Does the PR scope match the ticket?
|
|
|
|
- [ ] Are there enough tests to make sure it works? Do the tests cover the PR motivation?
|
|
|
|
- [ ] Are all the PR blockers dealt with?
|
|
|
|
PR blockers can be dealt with in new tickets or PRs.
|
|
|
|
|
|
|
|
_And check the PR Author checklist is complete._
|
2020-10-30 14:42:04 -07:00
|
|
|
|
|
|
|
## Follow Up Work
|
|
|
|
|
|
|
|
<!--
|
|
|
|
Is there anything missing from the solution?
|
|
|
|
-->
|