zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zebra/zebra-network/src/meta_addr.rs

20 lines
586 B
Rust
Raw Normal View History

Introduce a `MetaAddr` type replacing `NetworkAddress`. The `NetworkAddress` type was a `(Services, SocketAddr)` pair as used in the `version` handshake message, described as the `net_addr` struct in the Bitcoin wiki protocol documentation. However, all of the other uses of the `net_addr` struct are a `(Timestamp, Services, SocketAddr)` pair (where the timestamp is the last-seen time of the peer), and the timestamp is omitted only during the `version` messages, which are used only during the handshake, so it seems better to include the timestamp field and omit it during serialization of `version` packets.
2019-09-12 03:36:50 -07:00
//! An address-with-metadata type used in Bitcoin networking.
use chrono::{DateTime, Utc};
use std::net::SocketAddr;
use crate::types::Services;
/// An address with metadata on its advertised services and last-seen time.
Replace `Version` `MetaAddr` with `(Services, SocketAddr)`. (#12) * Replace Version MetaAddr by (Services, SocketAddr). The version handshake message doesn't include last-seen timestamps for the address fields, unlike other messages, so instead of modeling the message data with a `MetaAddr` (which includes a timestamp), we should just use a tuple. * Simplify try_read_version implementation. Because we no longer need to construct fake timestamps for the `MetaAddr` fields, we don't need to use any of the parsed fields while parsing later fields, and we can neatly wrap up the entire parsing logic into a single expression. * fmt I didn't have the toolchain-specified `rustfmt` because I was mostly offline and couldn't download it.
2019-09-19 09:38:02 -07:00
///
Introduce a `MetaAddr` type replacing `NetworkAddress`. The `NetworkAddress` type was a `(Services, SocketAddr)` pair as used in the `version` handshake message, described as the `net_addr` struct in the Bitcoin wiki protocol documentation. However, all of the other uses of the `net_addr` struct are a `(Timestamp, Services, SocketAddr)` pair (where the timestamp is the last-seen time of the peer), and the timestamp is omitted only during the `version` messages, which are used only during the handshake, so it seems better to include the timestamp field and omit it during serialization of `version` packets.
2019-09-12 03:36:50 -07:00
/// [Bitcoin reference](https://en.bitcoin.it/wiki/Protocol_documentation#Network_address)
Add missing derives to newtypes.
2019-09-15 12:11:07 -07:00
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
Introduce a `MetaAddr` type replacing `NetworkAddress`. The `NetworkAddress` type was a `(Services, SocketAddr)` pair as used in the `version` handshake message, described as the `net_addr` struct in the Bitcoin wiki protocol documentation. However, all of the other uses of the `net_addr` struct are a `(Timestamp, Services, SocketAddr)` pair (where the timestamp is the last-seen time of the peer), and the timestamp is omitted only during the `version` messages, which are used only during the handshake, so it seems better to include the timestamp field and omit it during serialization of `version` packets.
2019-09-12 03:36:50 -07:00
pub struct MetaAddr {
/// The peer's address.
Make MetaAddr fields public.
2019-09-14 08:56:43 -07:00
pub addr: SocketAddr,
/// The services advertised by the peer.
pub services: Services,
/// When the peer was last seen.
pub last_seen: DateTime<Utc>,
Introduce a `MetaAddr` type replacing `NetworkAddress`. The `NetworkAddress` type was a `(Services, SocketAddr)` pair as used in the `version` handshake message, described as the `net_addr` struct in the Bitcoin wiki protocol documentation. However, all of the other uses of the `net_addr` struct are a `(Timestamp, Services, SocketAddr)` pair (where the timestamp is the last-seen time of the peer), and the timestamp is omitted only during the `version` messages, which are used only during the handshake, so it seems better to include the timestamp field and omit it during serialization of `version` packets.
2019-09-12 03:36:50 -07:00
}