2020-06-15 15:41:10 -07:00
|
|
|
//! `start` subcommand - entry point for starting a zebra node
|
2020-06-15 16:16:46 -07:00
|
|
|
//!
|
2021-12-21 18:07:52 -08:00
|
|
|
//! ## Application Structure
|
2020-06-15 16:16:46 -07:00
|
|
|
//!
|
2021-12-21 18:07:52 -08:00
|
|
|
//! A zebra node consists of the following services and tasks:
|
2020-06-15 16:16:46 -07:00
|
|
|
//!
|
2021-10-18 12:23:21 -07:00
|
|
|
//! Peers:
|
2020-06-15 16:16:46 -07:00
|
|
|
//! * Network Service
|
2021-10-18 12:23:21 -07:00
|
|
|
//! * primary external interface to the node
|
2020-07-05 03:58:50 -07:00
|
|
|
//! * handles all external network requests for the Zcash protocol
|
2020-06-15 17:07:55 -07:00
|
|
|
//! * via zebra_network::Message and zebra_network::Response
|
2020-06-15 16:16:46 -07:00
|
|
|
//! * provides an interface to the rest of the network for other services and
|
2021-01-29 04:19:06 -08:00
|
|
|
//! tasks running within this node
|
2020-06-15 17:07:55 -07:00
|
|
|
//! * via zebra_network::Request
|
2021-10-18 12:23:21 -07:00
|
|
|
//!
|
|
|
|
//! Blocks & Mempool Transactions:
|
2020-06-15 16:16:46 -07:00
|
|
|
//! * Consensus Service
|
|
|
|
//! * handles all validation logic for the node
|
2021-10-18 12:23:21 -07:00
|
|
|
//! * verifies blocks using zebra-chain, then stores verified blocks in zebra-state
|
|
|
|
//! * verifies mempool and block transactions using zebra-chain and zebra-script,
|
|
|
|
//! and returns verified mempool transactions for mempool storage
|
2021-11-25 08:26:32 -08:00
|
|
|
//! * Groth16 Parameters Download Task
|
|
|
|
//! * downloads the Sprout and Sapling Groth16 circuit parameter files
|
|
|
|
//! * finishes when the download is complete and the download file hashes have been checked
|
2021-10-18 12:23:21 -07:00
|
|
|
//! * Inbound Service
|
|
|
|
//! * handles requests from peers for network data, chain data, and mempool transactions
|
|
|
|
//! * spawns download and verify tasks for each gossiped block
|
|
|
|
//! * sends gossiped transactions to the mempool service
|
|
|
|
//!
|
|
|
|
//! Blocks:
|
2020-06-15 16:16:46 -07:00
|
|
|
//! * Sync Task
|
2021-01-29 04:19:06 -08:00
|
|
|
//! * runs in the background and continuously queries the network for
|
|
|
|
//! new blocks to be verified and added to the local state
|
2021-10-18 12:23:21 -07:00
|
|
|
//! * spawns download and verify tasks for each crawled block
|
|
|
|
//! * State Service
|
|
|
|
//! * contextually verifies blocks
|
|
|
|
//! * handles in-memory storage of multiple non-finalized chains
|
|
|
|
//! * handles permanent storage of the best finalized chain
|
|
|
|
//! * Block Gossip Task
|
|
|
|
//! * runs in the background and continuously queries the state for
|
|
|
|
//! newly committed blocks to be gossiped to peers
|
|
|
|
//!
|
|
|
|
//! Mempool Transactions:
|
|
|
|
//! * Mempool Service
|
|
|
|
//! * activates when the syncer is near the chain tip
|
|
|
|
//! * spawns download and verify tasks for each crawled or gossiped transaction
|
|
|
|
//! * handles in-memory storage of unmined transactions
|
|
|
|
//! * Queue Checker Task
|
|
|
|
//! * runs in the background, polling the mempool to store newly verified transactions
|
|
|
|
//! * Transaction Gossip Task
|
|
|
|
//! * runs in the background and gossips newly added mempool transactions
|
|
|
|
//! to peers
|
2020-07-20 21:00:22 -07:00
|
|
|
|
2020-09-18 12:18:22 -07:00
|
|
|
use abscissa_core::{config, Command, FrameworkError, Options, Runnable};
|
|
|
|
use color_eyre::eyre::{eyre, Report};
|
2021-11-19 15:02:56 -08:00
|
|
|
use futures::FutureExt;
|
|
|
|
use tokio::{pin, select, sync::oneshot};
|
2021-10-12 10:31:54 -07:00
|
|
|
use tower::{builder::ServiceBuilder, util::BoxService};
|
2020-09-18 12:18:22 -07:00
|
|
|
|
2020-09-09 12:03:09 -07:00
|
|
|
use crate::{
|
2021-09-08 11:51:17 -07:00
|
|
|
components::{
|
2021-11-23 09:42:44 -08:00
|
|
|
inbound::InboundSetupData,
|
2021-09-08 11:51:17 -07:00
|
|
|
mempool::{self, Mempool},
|
2021-10-07 03:46:37 -07:00
|
|
|
sync,
|
2021-09-08 11:51:17 -07:00
|
|
|
tokio::{RuntimeRun, TokioComponent},
|
|
|
|
ChainSync, Inbound,
|
|
|
|
},
|
|
|
|
config::ZebradConfig,
|
2020-09-09 12:03:09 -07:00
|
|
|
prelude::*,
|
|
|
|
};
|
2020-07-20 21:00:22 -07:00
|
|
|
|
2019-08-29 14:46:54 -07:00
|
|
|
/// `start` subcommand
|
|
|
|
#[derive(Command, Debug, Options)]
|
2020-06-16 11:02:01 -07:00
|
|
|
pub struct StartCmd {
|
2021-12-09 16:19:52 -08:00
|
|
|
/// Filter strings which override the config file and defaults
|
|
|
|
#[options(free, help = "tracing filters which override the zebrad.toml config")]
|
2019-09-09 13:05:42 -07:00
|
|
|
filters: Vec<String>,
|
2019-08-29 14:46:54 -07:00
|
|
|
}
|
|
|
|
|
2020-06-16 11:02:01 -07:00
|
|
|
impl StartCmd {
|
2020-06-15 17:07:55 -07:00
|
|
|
async fn start(&self) -> Result<(), Report> {
|
2020-09-18 12:18:22 -07:00
|
|
|
let config = app_config().clone();
|
|
|
|
info!(?config);
|
2020-06-15 17:07:55 -07:00
|
|
|
|
2020-09-18 12:18:22 -07:00
|
|
|
info!("initializing node state");
|
2021-09-21 10:06:52 -07:00
|
|
|
let (state_service, latest_chain_tip, chain_tip_change) =
|
Reject connections from outdated peers (#2519)
* Simplify state service initialization in test
Use the test helper function to remove redundant code.
* Create `BestTipHeight` helper type
This type abstracts away the calculation of the best tip height based on
the finalized block height and the best non-finalized chain's tip.
* Add `best_tip_height` field to `StateService`
The receiver endpoint is currently ignored.
* Return receiver endpoint from service constructor
Make it available so that the best tip height can be watched.
* Update finalized height after finalizing blocks
After blocks from the queue are finalized and committed to disk, update
the finalized block height.
* Update best non-finalized height after validation
Update the value of the best non-finalized chain tip block height after
a new block is committed to the non-finalized state.
* Update finalized height after loading from disk
When `FinalizedState` is first created, it loads the state from
persistent storage, and the finalized tip height is updated. Therefore,
the `best_tip_height` must be notified of the initial value.
* Update the finalized height on checkpoint commit
When a checkpointed block is commited, it bypasses the non-finalized
state, so there's an extra place where the finalized height has to be
updated.
* Add `best_tip_height` to `Handshake` service
It can be configured using the `Builder::with_best_tip_height`. It's
currently not used, but it will be used to determine if a connection to
a remote peer should be rejected or not based on that peer's protocol
version.
* Require best tip height to init. `zebra_network`
Without it the handshake service can't properly enforce the minimum
network protocol version from peers. Zebrad obtains the best tip height
endpoint from `zebra_state`, and the test vectors simply use a dummy
endpoint that's fixed at the genesis height.
* Pass `best_tip_height` to proto. ver. negotiation
The protocol version negotiation code will reject connections to peers
if they are using an old protocol version. An old version is determined
based on the current known best chain tip height.
* Handle an optional height in `Version`
Fallback to the genesis height in `None` is specified.
* Reject connections to peers on old proto. versions
Avoid connecting to peers that are on protocol versions that don't
recognize a network update.
* Document why peers on old versions are rejected
Describe why it's a security issue above the check.
* Test if `BestTipHeight` starts with `None`
Check if initially there is no best tip height.
* Test if best tip height is max. of latest values
After applying a list of random updates where each one either sets the
finalized height or the non-finalized height, check that the best tip
height is the maximum of the most recently set finalized height and the
most recently set non-finalized height.
* Add `queue_and_commit_finalized` method
A small refactor to make testing easier. The handling of requests for
committing non-finalized and finalized blocks is now more consistent.
* Add `assert_block_can_be_validated` helper
Refactor to move into a separate method some assertions that are done
before a block is validated. This is to allow moving these assertions
more easily to simplify testing.
* Remove redundant PoW block assertion
It's also checked in
`zebra_state::service::check::block_is_contextually_valid`, and it was
getting in the way of tests that received a gossiped block before
finalizing enough blocks.
* Create a test strategy for test vector chain
Splits a chain loaded from the test vectors in two parts, containing the
blocks to finalize and the blocks to keep in the non-finalized state.
* Test committing blocks update best tip height
Create a mock blockchain state, with a chain of finalized blocks and a
chain of non-finalized blocks. Commit all the blocks appropriately, and
verify that the best tip height is updated.
Co-authored-by: teor <teor@riseup.net>
2021-08-08 16:52:52 -07:00
|
|
|
zebra_state::init(config.state.clone(), config.network.network);
|
|
|
|
let state = ServiceBuilder::new().buffer(20).service(state_service);
|
2020-09-18 12:18:22 -07:00
|
|
|
|
|
|
|
info!("initializing network");
|
2020-09-18 12:37:01 -07:00
|
|
|
// The service that our node uses to respond to requests by peers. The
|
|
|
|
// load_shed middleware ensures that we reduce the size of the peer set
|
|
|
|
// in response to excess load.
|
2020-09-18 12:18:22 -07:00
|
|
|
let (setup_tx, setup_rx) = oneshot::channel();
|
|
|
|
let inbound = ServiceBuilder::new()
|
|
|
|
.load_shed()
|
|
|
|
.buffer(20)
|
2021-11-23 09:42:44 -08:00
|
|
|
.service(Inbound::new(setup_rx));
|
2020-09-18 12:18:22 -07:00
|
|
|
|
Reject connections from outdated peers (#2519)
* Simplify state service initialization in test
Use the test helper function to remove redundant code.
* Create `BestTipHeight` helper type
This type abstracts away the calculation of the best tip height based on
the finalized block height and the best non-finalized chain's tip.
* Add `best_tip_height` field to `StateService`
The receiver endpoint is currently ignored.
* Return receiver endpoint from service constructor
Make it available so that the best tip height can be watched.
* Update finalized height after finalizing blocks
After blocks from the queue are finalized and committed to disk, update
the finalized block height.
* Update best non-finalized height after validation
Update the value of the best non-finalized chain tip block height after
a new block is committed to the non-finalized state.
* Update finalized height after loading from disk
When `FinalizedState` is first created, it loads the state from
persistent storage, and the finalized tip height is updated. Therefore,
the `best_tip_height` must be notified of the initial value.
* Update the finalized height on checkpoint commit
When a checkpointed block is commited, it bypasses the non-finalized
state, so there's an extra place where the finalized height has to be
updated.
* Add `best_tip_height` to `Handshake` service
It can be configured using the `Builder::with_best_tip_height`. It's
currently not used, but it will be used to determine if a connection to
a remote peer should be rejected or not based on that peer's protocol
version.
* Require best tip height to init. `zebra_network`
Without it the handshake service can't properly enforce the minimum
network protocol version from peers. Zebrad obtains the best tip height
endpoint from `zebra_state`, and the test vectors simply use a dummy
endpoint that's fixed at the genesis height.
* Pass `best_tip_height` to proto. ver. negotiation
The protocol version negotiation code will reject connections to peers
if they are using an old protocol version. An old version is determined
based on the current known best chain tip height.
* Handle an optional height in `Version`
Fallback to the genesis height in `None` is specified.
* Reject connections to peers on old proto. versions
Avoid connecting to peers that are on protocol versions that don't
recognize a network update.
* Document why peers on old versions are rejected
Describe why it's a security issue above the check.
* Test if `BestTipHeight` starts with `None`
Check if initially there is no best tip height.
* Test if best tip height is max. of latest values
After applying a list of random updates where each one either sets the
finalized height or the non-finalized height, check that the best tip
height is the maximum of the most recently set finalized height and the
most recently set non-finalized height.
* Add `queue_and_commit_finalized` method
A small refactor to make testing easier. The handling of requests for
committing non-finalized and finalized blocks is now more consistent.
* Add `assert_block_can_be_validated` helper
Refactor to move into a separate method some assertions that are done
before a block is validated. This is to allow moving these assertions
more easily to simplify testing.
* Remove redundant PoW block assertion
It's also checked in
`zebra_state::service::check::block_is_contextually_valid`, and it was
getting in the way of tests that received a gossiped block before
finalizing enough blocks.
* Create a test strategy for test vector chain
Splits a chain loaded from the test vectors in two parts, containing the
blocks to finalize and the blocks to keep in the non-finalized state.
* Test committing blocks update best tip height
Create a mock blockchain state, with a chain of finalized blocks and a
chain of non-finalized blocks. Commit all the blocks appropriately, and
verify that the best tip height is updated.
Co-authored-by: teor <teor@riseup.net>
2021-08-08 16:52:52 -07:00
|
|
|
let (peer_set, address_book) =
|
2021-09-29 09:52:44 -07:00
|
|
|
zebra_network::init(config.network.clone(), inbound, latest_chain_tip.clone()).await;
|
2021-09-13 13:28:07 -07:00
|
|
|
|
2021-11-23 09:42:44 -08:00
|
|
|
info!("initializing verifiers");
|
|
|
|
let (chain_verifier, tx_verifier, mut groth16_download_handle) =
|
|
|
|
zebra_consensus::chain::init(
|
|
|
|
config.consensus.clone(),
|
|
|
|
config.network.network,
|
|
|
|
state.clone(),
|
2021-12-14 13:43:07 -08:00
|
|
|
config.consensus.debug_skip_parameter_preload,
|
2021-11-23 09:42:44 -08:00
|
|
|
)
|
|
|
|
.await;
|
|
|
|
|
2021-09-15 15:13:29 -07:00
|
|
|
info!("initializing syncer");
|
2021-11-23 09:42:44 -08:00
|
|
|
let (syncer, sync_status) = ChainSync::new(
|
|
|
|
&config,
|
|
|
|
peer_set.clone(),
|
|
|
|
chain_verifier.clone(),
|
2021-12-17 08:31:51 -08:00
|
|
|
state.clone(),
|
|
|
|
latest_chain_tip.clone(),
|
2021-11-23 09:42:44 -08:00
|
|
|
);
|
2021-09-15 15:13:29 -07:00
|
|
|
|
2021-09-13 13:28:07 -07:00
|
|
|
info!("initializing mempool");
|
2021-10-12 10:31:54 -07:00
|
|
|
let (mempool, mempool_transaction_receiver) = Mempool::new(
|
|
|
|
&config.mempool,
|
2021-09-13 13:28:07 -07:00
|
|
|
peer_set.clone(),
|
2021-11-23 09:42:44 -08:00
|
|
|
state.clone(),
|
2021-09-13 13:28:07 -07:00
|
|
|
tx_verifier,
|
2021-09-15 15:13:29 -07:00
|
|
|
sync_status.clone(),
|
2021-12-17 08:31:51 -08:00
|
|
|
latest_chain_tip.clone(),
|
2021-09-21 10:06:52 -07:00
|
|
|
chain_tip_change.clone(),
|
2021-10-12 10:31:54 -07:00
|
|
|
);
|
|
|
|
let mempool = BoxService::new(mempool);
|
|
|
|
let mempool = ServiceBuilder::new().buffer(20).service(mempool);
|
2021-09-13 13:28:07 -07:00
|
|
|
|
2021-11-23 09:42:44 -08:00
|
|
|
let setup_data = InboundSetupData {
|
|
|
|
address_book,
|
|
|
|
block_download_peer_set: peer_set.clone(),
|
|
|
|
block_verifier: chain_verifier,
|
|
|
|
mempool: mempool.clone(),
|
|
|
|
state,
|
2021-12-17 08:31:51 -08:00
|
|
|
latest_chain_tip,
|
2021-11-23 09:42:44 -08:00
|
|
|
};
|
2020-09-18 12:18:22 -07:00
|
|
|
setup_tx
|
2021-11-23 09:42:44 -08:00
|
|
|
.send(setup_data)
|
2020-09-18 12:18:22 -07:00
|
|
|
.map_err(|_| eyre!("could not send setup data to inbound service"))?;
|
2020-06-15 17:07:55 -07:00
|
|
|
|
2022-01-11 09:11:35 -08:00
|
|
|
let syncer_task_handle = tokio::spawn(syncer.sync());
|
2021-10-07 03:46:37 -07:00
|
|
|
|
2022-01-11 09:11:35 -08:00
|
|
|
let mut block_gossip_task_handle = tokio::spawn(sync::gossip_best_tip_block_hashes(
|
2021-10-07 03:46:37 -07:00
|
|
|
sync_status.clone(),
|
2021-10-13 08:04:49 -07:00
|
|
|
chain_tip_change.clone(),
|
2021-10-07 03:46:37 -07:00
|
|
|
peer_set.clone(),
|
|
|
|
));
|
|
|
|
|
2021-10-13 08:04:49 -07:00
|
|
|
let mempool_crawler_task_handle = mempool::Crawler::spawn(
|
|
|
|
&config.mempool,
|
|
|
|
peer_set.clone(),
|
2021-10-18 12:23:21 -07:00
|
|
|
mempool.clone(),
|
2021-10-13 08:04:49 -07:00
|
|
|
sync_status,
|
|
|
|
chain_tip_change,
|
|
|
|
);
|
2021-10-08 04:59:46 -07:00
|
|
|
|
2021-10-18 12:23:21 -07:00
|
|
|
let mempool_queue_checker_task_handle = mempool::QueueChecker::spawn(mempool);
|
|
|
|
|
2021-10-08 04:59:46 -07:00
|
|
|
let tx_gossip_task_handle = tokio::spawn(mempool::gossip_mempool_transaction_id(
|
|
|
|
mempool_transaction_receiver,
|
|
|
|
peer_set,
|
|
|
|
));
|
2021-10-07 03:46:37 -07:00
|
|
|
|
2021-11-30 13:04:32 -08:00
|
|
|
info!("spawned initial Zebra tasks");
|
2021-10-07 03:46:37 -07:00
|
|
|
|
2022-01-11 09:11:35 -08:00
|
|
|
// TODO: put tasks into an ongoing FuturesUnordered and a startup FuturesUnordered?
|
2021-10-07 03:46:37 -07:00
|
|
|
|
2022-01-11 09:11:35 -08:00
|
|
|
// ongoing tasks
|
|
|
|
pin!(syncer_task_handle);
|
2021-11-19 15:02:56 -08:00
|
|
|
pin!(mempool_crawler_task_handle);
|
|
|
|
pin!(mempool_queue_checker_task_handle);
|
|
|
|
pin!(tx_gossip_task_handle);
|
2021-10-08 04:59:46 -07:00
|
|
|
|
2021-11-19 15:02:56 -08:00
|
|
|
// startup tasks
|
|
|
|
let groth16_download_handle_fused = (&mut groth16_download_handle).fuse();
|
|
|
|
pin!(groth16_download_handle_fused);
|
2021-10-18 12:23:21 -07:00
|
|
|
|
2021-11-19 15:02:56 -08:00
|
|
|
// Wait for tasks to finish
|
|
|
|
let exit_status = loop {
|
|
|
|
let mut exit_when_task_finishes = true;
|
|
|
|
|
|
|
|
let result = select! {
|
2022-01-11 09:11:35 -08:00
|
|
|
sync_result = &mut syncer_task_handle => sync_result
|
|
|
|
.expect("unexpected panic in the syncer task")
|
2021-11-19 15:02:56 -08:00
|
|
|
.map(|_| info!("syncer task exited")),
|
|
|
|
|
2022-01-11 09:11:35 -08:00
|
|
|
block_gossip_result = &mut block_gossip_task_handle => block_gossip_result
|
2021-11-19 15:02:56 -08:00
|
|
|
.expect("unexpected panic in the chain tip block gossip task")
|
|
|
|
.map(|_| info!("chain tip block gossip task exited"))
|
|
|
|
.map_err(|e| eyre!(e)),
|
|
|
|
|
|
|
|
mempool_crawl_result = &mut mempool_crawler_task_handle => mempool_crawl_result
|
|
|
|
.expect("unexpected panic in the mempool crawler")
|
|
|
|
.map(|_| info!("mempool crawler task exited"))
|
|
|
|
.map_err(|e| eyre!(e)),
|
|
|
|
|
|
|
|
mempool_queue_result = &mut mempool_queue_checker_task_handle => mempool_queue_result
|
|
|
|
.expect("unexpected panic in the mempool queue checker")
|
|
|
|
.map(|_| info!("mempool queue checker task exited"))
|
|
|
|
.map_err(|e| eyre!(e)),
|
|
|
|
|
|
|
|
tx_gossip_result = &mut tx_gossip_task_handle => tx_gossip_result
|
|
|
|
.expect("unexpected panic in the transaction gossip task")
|
|
|
|
.map(|_| info!("transaction gossip task exited"))
|
|
|
|
.map_err(|e| eyre!(e)),
|
|
|
|
|
|
|
|
// Unlike other tasks, we expect the download task to finish while Zebra is running.
|
|
|
|
groth16_download_result = &mut groth16_download_handle_fused => {
|
|
|
|
groth16_download_result
|
|
|
|
.unwrap_or_else(|_| panic!(
|
|
|
|
"unexpected panic in the Groth16 pre-download and check task. {}",
|
|
|
|
zebra_consensus::groth16::Groth16Parameters::failure_hint())
|
|
|
|
);
|
|
|
|
|
|
|
|
exit_when_task_finishes = false;
|
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
// Stop Zebra if a task finished and returned an error,
|
|
|
|
// or if an ongoing task exited.
|
|
|
|
if let Err(err) = result {
|
|
|
|
break Err(err);
|
|
|
|
}
|
|
|
|
|
|
|
|
if exit_when_task_finishes {
|
|
|
|
break Ok(());
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
info!("exiting Zebra because an ongoing task exited: stopping other tasks");
|
|
|
|
|
|
|
|
// ongoing tasks
|
2022-01-11 09:11:35 -08:00
|
|
|
syncer_task_handle.abort();
|
|
|
|
block_gossip_task_handle.abort();
|
2021-11-19 15:02:56 -08:00
|
|
|
mempool_crawler_task_handle.abort();
|
|
|
|
mempool_queue_checker_task_handle.abort();
|
|
|
|
tx_gossip_task_handle.abort();
|
|
|
|
|
|
|
|
// startup tasks
|
|
|
|
groth16_download_handle.abort();
|
|
|
|
|
|
|
|
exit_status
|
2020-06-15 17:07:55 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-16 11:02:01 -07:00
|
|
|
impl Runnable for StartCmd {
|
2019-08-29 14:46:54 -07:00
|
|
|
/// Start the application.
|
|
|
|
fn run(&self) {
|
2020-07-31 23:15:26 -07:00
|
|
|
info!("Starting zebrad");
|
2020-01-13 09:54:27 -08:00
|
|
|
let rt = app_writer()
|
2019-12-13 14:25:14 -08:00
|
|
|
.state_mut()
|
2019-09-09 13:05:42 -07:00
|
|
|
.components
|
2019-12-13 14:25:14 -08:00
|
|
|
.get_downcast_mut::<TokioComponent>()
|
2019-09-09 13:05:42 -07:00
|
|
|
.expect("TokioComponent should be available")
|
|
|
|
.rt
|
2020-01-13 09:54:27 -08:00
|
|
|
.take();
|
|
|
|
|
2020-08-05 16:35:56 -07:00
|
|
|
rt.expect("runtime should not already be taken")
|
|
|
|
.run(self.start());
|
2021-12-21 18:07:52 -08:00
|
|
|
|
|
|
|
info!("stopping zebrad");
|
2019-08-29 14:46:54 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-16 11:02:01 -07:00
|
|
|
impl config::Override<ZebradConfig> for StartCmd {
|
2019-08-29 14:46:54 -07:00
|
|
|
// Process the given command line options, overriding settings from
|
|
|
|
// a configuration file using explicit flags taken from command-line
|
|
|
|
// arguments.
|
2019-09-09 13:05:42 -07:00
|
|
|
fn override_config(&self, mut config: ZebradConfig) -> Result<ZebradConfig, FrameworkError> {
|
|
|
|
if !self.filters.is_empty() {
|
2020-06-04 19:34:06 -07:00
|
|
|
config.tracing.filter = Some(self.filters.join(","));
|
2019-08-29 14:46:54 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
Ok(config)
|
|
|
|
}
|
|
|
|
}
|